schemas: introduce assigned-clock-sscs (PR #154)
Hi Stephen and Michael,
Just FYI, below is a foward of pull request for dtschema for bindings adding spread spectrum to clocks. As Clock framework maintainers this might be relevant to you.
-------- Forwarded Message --------
Subject: [devicetree-org/dt-schema] schemas: introduce assigned-clock-sscs (PR #154)
Date: Fri, 24 Jan 2025 04:31:30 -0800
From: Peng Fan <[email protected]>
Reply-To: devicetree-org/dt-schema <reply+ACPRLI5YLXX27TFZX2P7NVOFT5USFEVBNHHKO4ZXHM@reply.github.com>
To: devicetree-org/dt-schema <[email protected]>
CC: Subscribed <[email protected]>
To support spread spectrum clock, introduce assigned-clock-sscs, it is an uint32-matrix with format multiple elements of below <modfreq spreadpercentage modmethod>, <...>
You can view, comment on, or merge this pull request online at:
https://github.com/devicetree-org/dt-schema/pull/154
-- Commit Summary --
* schemas: introduce assigned-clock-sscs
-- File Changes --
M dtschema/fixups.py (1)
M dtschema/meta-schemas/clocks.yaml (3)
M dtschema/schemas/clock/clock.yaml (10)
-- Patch Links --
https://github.com/devicetree-org/dt-schema/pull/154.patch
https://github.com/devicetree-org/dt-schema/pull/154.diff
Signature · 5 lines
Reply to this email directly or view it on GitHub: https://github.com/devicetree-org/dt-schema/pull/154 You are receiving this because you are subscribed to this thread. Message ID: <devicetree-org/dt-schema/pull/[email protected]>
CC devicetree
Quoted 25 lines · Krzysztof Kozlowski
Just FYI, below is a foward of pull request for dtschema for bindings adding spread spectrum to clocks. As Clock framework maintainers this might be relevant to you.
-------- Forwarded Message --------
Subject: [devicetree-org/dt-schema] schemas: introduce assigned-clock-sscs (PR #154)
Date: Fri, 24 Jan 2025 04:31:30 -0800
From: Peng Fan <[email protected]>
Reply-To: devicetree-org/dt-schema <reply+ACPRLI5YLXX27TFZX2P7NVOFT5USFEVBNHHKO4ZXHM@reply.github.com>
To: devicetree-org/dt-schema <[email protected]>
CC: Subscribed <[email protected]>To support spread spectrum clock, introduce assigned-clock-sscs, it is an uint32-matrix with format multiple elements of below <modfreq spreadpercentage modmethod>, <...>
You can view, comment on, or merge this pull request online at:https://github.com/devicetree-org/dt-schema/pull/154
-- Commit Summary --
* schemas: introduce assigned-clock-sscs
Quoted 7 lines
assigned-clock-sscs:
$ref: /schemas/types.yaml#/definitions/uint32-matrix items:
items:
- description: The modulation frequency
- description: The modulation depth in permyriad
- description: The modulation method, down(2), up(1), center(0)
Is there a way to explicitly disable it, if it was enabled by the firmware? See also my comment in "Re: [PATCH v2 1/4] clk: Introduce clk_hw_set_spread_spectrum".
Quoted 2 lines
minimum: 0
maximum: 2
What's the meaning of these limits?
[1] https://lore.kernel.or/CAMuHMdWn+sKiC1B4MF1vHwS2ArFYQXGzpYi2EcsyERPSCc9bvQ@mail.gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
Quoted 36 lines · Geert Uytterhoeven
CC devicetree
Quoted 25 lines · Krzysztof Kozlowski
Just FYI, below is a foward of pull request for dtschema for bindings adding spread spectrum to clocks. As Clock framework maintainers this might be relevant to you.
-------- Forwarded Message --------
Subject: [devicetree-org/dt-schema] schemas: introduce assigned-clock-sscs (PR #154)
Date: Fri, 24 Jan 2025 04:31:30 -0800
From: Peng Fan <[email protected]>
Reply-To: devicetree-org/dt-schema <reply+ACPRLI5YLXX27TFZX2P7NVOFT5USFEVBNHHKO4ZXHM@reply.github.com>
To: devicetree-org/dt-schema <[email protected]>
CC: Subscribed <[email protected]>To support spread spectrum clock, introduce assigned-clock-sscs, it is an uint32-matrix with format multiple elements of below <modfreq spreadpercentage modmethod>, <...>
You can view, comment on, or merge this pull request online at:https://github.com/devicetree-org/dt-schema/pull/154
-- Commit Summary --
* schemas: introduce assigned-clock-sscs
Quoted 7 lines
assigned-clock-sscs:
$ref: /schemas/types.yaml#/definitions/uint32-matrix items:
items:
- description: The modulation frequency
- description: The modulation depth in permyriad
- description: The modulation method, down(2), up(1), center(0)
Quoted 2 lines
Is there a way to explicitly disable it, if it was enabled by the firmware? See also my comment in "Re: [PATCH v2 1/4] clk: Introduce
The binding here is just to describe the parameter to configure spread spectrum of a clk.
To disable spread spectrum, the clk_hw_set_spread_spectrum could be used with enable as false or as you suggested using CLK_SSC_NONE_SPREAD?
Quoted 6 lines
clk_hw_set_spread_spectrum".Quoted 2 lines
minimum: 0
maximum: 2What's the meaning of these limits?
Modulation has three methods:
Down-spread modulation
Up-spread modulation
Center-spread modulation.
I use 2 for down, 1 for up, 0 for center here. So the limits:
min: 0, max: 2.
Thanks,
Peng
Quoted 15 lines
[1] https://lore.kernel.org/CAMuHMdWn+sKiC1B4MF1vHwS2ArFYQXGzpYi2EcsyERPSCc9bvQ@mail.gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Peng,
Quoted 35 lines · Peng Fan
Quoted 34 lines · Geert Uytterhoeven
Quoted 32 lines · Krzysztof Kozlowski
Just FYI, below is a foward of pull request for dtschema for bindings adding spread spectrum to clocks. As Clock framework maintainers this might be relevant to you.
-------- Forwarded Message --------
Subject: [devicetree-org/dt-schema] schemas: introduce assigned-clock-sscs (PR #154)
Date: Fri, 24 Jan 2025 04:31:30 -0800
From: Peng Fan <[email protected]>
Reply-To: devicetree-org/dt-schema <reply+ACPRLI5YLXX27TFZX2P7NVOFT5USFEVBNHHKO4ZXHM@reply.github.com>
To: devicetree-org/dt-schema <[email protected]>
CC: Subscribed <[email protected]>To support spread spectrum clock, introduce assigned-clock-sscs, it is an uint32-matrix with format multiple elements of below <modfreq spreadpercentage modmethod>, <...>
You can view, comment on, or merge this pull request online at:https://github.com/devicetree-org/dt-schema/pull/154
-- Commit Summary --
* schemas: introduce assigned-clock-sscs
assigned-clock-sscs:
$ref: /schemas/types.yaml#/definitions/uint32-matrix items:
items:
- description: The modulation frequency
- description: The modulation depth in permyriad
- description: The modulation method, down(2), up(1), center(0)
Quoted 8 lines
Quoted 2 lines
Is there a way to explicitly disable it, if it was enabled by the firmware? See also my comment in "Re: [PATCH v2 1/4] clk: Introduce
The binding here is just to describe the parameter to configure spread spectrum of a clk.
To disable spread spectrum, the
clk_hw_set_spread_spectrumcould be used with enable as false or as you suggested usingCLK_SSC_NONE_SPREAD?
But the bindings don't have an enable flag...
Quoted 7 lines
Quoted 6 lines
clk_hw_set_spread_spectrum".Quoted 2 lines
minimum: 0
maximum: 2What's the meaning of these limits?
Quoted 7 lines
Modulation has three methods:
Down-spread modulation
Up-spread modulation
Center-spread modulation.I use 2 for down, 1 for up, 0 for center here. So the limits:
min: 0, max: 2.
Silly me, they apply to the last description...
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 41 lines · Geert Uytterhoeven
Hi Peng,
Quoted 38 lines · Peng Fan
Quoted 36 lines · Geert Uytterhoeven
Quoted 25 lines · Krzysztof Kozlowski
Just FYI, below is a foward of pull request for dtschema for bindings adding spread spectrum to clocks. As Clock framework maintainers this might be relevant to you.
-------- Forwarded Message --------
Subject: [devicetree-org/dt-schema] schemas: introduce assigned-clock-sscs (PR #154)
Date: Fri, 24 Jan 2025 04:31:30 -0800
From: Peng Fan <[email protected]>
Reply-To: devicetree-org/dt-schema <reply+ACPRLI5YLXX27TFZX2P7NVOFT5USFEVBNHHKO4ZXHM@reply.github.com>
To: devicetree-org/dt-schema <[email protected]>
CC: Subscribed <[email protected]>To support spread spectrum clock, introduce assigned-clock-sscs, it is an uint32-matrix with format multiple elements of below <modfreq spreadpercentage modmethod>, <...>
You can view, comment on, or merge this pull request online at:https://github.com/devicetree-org/dt-schema/pull/154
-- Commit Summary --
* schemas: introduce assigned-clock-sscs
Quoted 7 lines
assigned-clock-sscs:
$ref: /schemas/types.yaml#/definitions/uint32-matrix items:
items:
- description: The modulation frequency
- description: The modulation depth in permyriad
- description: The modulation method, down(2), up(1), center(0)Is there a way to explicitly disable it, if it was enabled by the firmware? See also my comment in "Re: [PATCH v2 1/4] clk: Introduce
Quoted 7 lines
Quoted 5 lines
The binding here is just to describe the parameter to configure spread spectrum of a clk.
To disable spread spectrum, the
clk_hw_set_spread_spectrumcould be used with enable as false or as you suggested usingCLK_SSC_NONE_SPREAD?But the bindings don't have an enable flag...
The modulation method maybe updated to
down(3), up(2), center(1), no modulation(0).
Then no need a separate entry for enable.
Thanks,
Peng.
Quoted 29 lines
Quoted 8 lines
Quoted 7 lines
clk_hw_set_spread_spectrum".Quoted 2 lines
minimum: 0
maximum: 2What's the meaning of these limits?
Quoted 7 lines
Modulation has three methods:
Down-spread modulation
Up-spread modulation
Center-spread modulation.I use 2 for down, 1 for up, 0 for center here. So the limits:
min: 0, max: 2.Silly me, they apply to the last description...
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds