Skip to contentSkip to conversation

drm/nouveau: add the missed kfree() for nouveau_bo_alloc()

PATCH Markus Elfring 1 participant 1 message Jul 15, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 1 line

… to fix it.

I suggest to replace this wording by the tag “Fixes”.

…

Review nouveau_bo_alloc(struct nouveau_cli *cli, u64 *size, int *align, u32 flags, · line 282

Quoted 10 lines

+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c

(quoted diff) +3 -1
@@ -276,8 +276,10 @@  nouveau_bo_alloc(struct nouveau_cli *cli, u64 *size, int *align, u32 flags,
 			break;
 	}
 
-	if (WARN_ON(pi < 0))
+	if (WARN_ON(pi < 0)) {
+		kfree(nvbo);
 		return ERR_PTR(-EINVAL);
+	}

I propose to move such common exception handling to the end of this function implementation so that a bit of duplicate code will be avoided.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e9919e11e219eaa5e8041b7b1a196839143e9125#n481

Regards,
Markus