Skip to contentSkip to conversation

netfs: Remove duplicate check in netfs_cache_read_terminated()

PATCH New Dan Carpenter 1 participant 1 message Nov 15, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfs: Remove duplicate check in netfs_cache_read_terminated()

There are two checks for "if (transferred_or_error > 0)". Delete the second check.

---
 fs/netfs/read_collect.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
fs/netfs/read_collect.c +2 -4
index 7f3a3c056c6e..431166d4f103 100644
@@ -597,10 +597,8 @@ void netfs_cache_read_terminated(void *priv, ssize_t transferred_or_error, bool
 
 	if (transferred_or_error > 0) {
 		subreq->error = 0;
-		if (transferred_or_error > 0) {
-			subreq->transferred += transferred_or_error;
-			__set_bit(NETFS_SREQ_MADE_PROGRESS, &subreq->flags);
-		}
+		subreq->transferred += transferred_or_error;
+		__set_bit(NETFS_SREQ_MADE_PROGRESS, &subreq->flags);
 	} else {
 		subreq->error = transferred_or_error;
 	}
Signature · 1 line
2.45.2