Skip to contentSkip to conversation

genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe()

PATCH Thomas Gleixner 1 participant 1 message Jul 21, 2025 1 message not in the archive

Subsystems (7)
lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 8 lines · Thomas Gleixner
Quoted 7 lines · On Wed, Jul 09 2025 at 17:13, [email protected] wrote:

Hi tglx and Miquèl, Just a gentle ping on this patchset. I understand you're likely busy with many other tasks, but any feedback or guidance on how to proceed would be greatly appreciated. As discussed in the previous thread, there was some uncertainty about whether we should directly integrate dev_err_probe() into devm_request_threaded_irq(), or if it's better to create a wrapper function. Thanks for your time! Thanks, Panchuang

For simplicity sake just rename the existing functions devm_request_threaded_irq() and devm_request_any_context_irq() to __devm_request_threaded_irq() and __devm_request_any_context_irq().

Then create new functions for the API, which

- invoke the underscore variants
- and on error invoke dev_err_probe() similar to what I suggested in my reply in this thread.

In the rare case of failure, this will print error messages for the affected drivers both in the core and at the callsite, but that's not the end of the world.

Then go and remove the random printks from the drivers, once the core change has hit upstream.

Thanks,

tglx