Freeze on resume from S3 (bisected)

Just to confirm - I should apply [1], and no other patches, during the bisection, right?

[1] https://lore.kernel.org/linux-wireless/[email protected]/

Right. Only apply [1] in every bisection step.

Thanks for the exp #1 and #2. The results are in expectation. Then the new bisection will find out another problem.

Patch fails on 57f22c8dab6b266ae. Could you send a version that succeeds?

Bisection log so far:

git bisect start
# status: waiting for both good and bad commits
# bad: [5bbd9b249880dba032bffa002dd9cd12cd5af09c] Merge tag 'v6.10-p4' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
git bisect bad 5bbd9b249880dba032bffa002dd9cd12cd5af09c
# status: waiting for good commit(s), bad commit known
# good: [bcbefbd032df6bfe925e6afeca82eb9d2cc0cb23] wifi: rtw89: add wait/completion for abort scan
git bisect good bcbefbd032df6bfe925e6afeca82eb9d2cc0cb23
# bad: [480e035fc4c714fb5536e64ab9db04fedc89e910] Merge tag 'drm-next-2024-03-13' of https://gitlab.freedesktop.org/drm/kernel
git bisect bad 480e035fc4c714fb5536e64ab9db04fedc89e910

The commit date of culprit bcbefbd032d ("wifi: rtw89: add wait/completion for abort scan") is

     CommitDate: Tue Jan 23 13:38:15 2024 +0200

But, you want to apply to the top of 57f22c8dab6b whose date is

     CommitDate: Fri Jan 19 13:49:16 2024 -0800

and doesn't contain commit bcbefbd032d, so no need to apply [1] at this point.

Ah, I get it. So, from here on, I'll be applying the patch only if this command returns exit status 0:
git merge-base --is-ancestor bcbefbd032d <commit-to-test>

Bisection log so far:
git bisect start
# status: waiting for both good and bad commits
# bad: [5bbd9b249880dba032bffa002dd9cd12cd5af09c] Merge tag 'v6.10-p4' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
git bisect bad 5bbd9b249880dba032bffa002dd9cd12cd5af09c
# status: waiting for good commit(s), bad commit known
# good: [bcbefbd032df6bfe925e6afeca82eb9d2cc0cb23] wifi: rtw89: add wait/completion for abort scan
git bisect good bcbefbd032df6bfe925e6afeca82eb9d2cc0cb23
# bad: [480e035fc4c714fb5536e64ab9db04fedc89e910] Merge tag 'drm-next-2024-03-13' of https://gitlab.freedesktop.org/drm/kernel
git bisect bad 480e035fc4c714fb5536e64ab9db04fedc89e910
# good: [57f22c8dab6b266ae36b89b073a4a33dea71e762] Merge tag 'strlcpy-removal-v6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
git bisect good 57f22c8dab6b266ae36b89b073a4a33dea71e762
# good: [43a7548e28a6df12a6170421d9d016c576010baa] Merge tag 'for-6.9-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
git bisect good 43a7548e28a6df12a6170421d9d016c576010baa
# bad: [8c9c2f851b5a58195ed7ebd67d7c59683d1a02bc] Merge tag 'iommu-updates-v6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
git bisect bad 8c9c2f851b5a58195ed7ebd67d7c59683d1a02bc

Here are the bisection results:

git bisect start
# status: waiting for both good and bad commits
# bad: [5bbd9b249880dba032bffa002dd9cd12cd5af09c] Merge tag 'v6.10-p4' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
git bisect bad 5bbd9b249880dba032bffa002dd9cd12cd5af09c
# good: [bcbefbd032df6bfe925e6afeca82eb9d2cc0cb23] wifi: rtw89: add wait/completion for abort scan
git bisect good bcbefbd032df6bfe925e6afeca82eb9d2cc0cb23
# bad: [480e035fc4c714fb5536e64ab9db04fedc89e910] Merge tag 'drm-next-2024-03-13' of https://gitlab.freedesktop.org/drm/kernel
git bisect bad 480e035fc4c714fb5536e64ab9db04fedc89e910
# good: [57f22c8dab6b266ae36b89b073a4a33dea71e762] Merge tag 'strlcpy-removal-v6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
git bisect good 57f22c8dab6b266ae36b89b073a4a33dea71e762
# good: [43a7548e28a6df12a6170421d9d016c576010baa] Merge tag 'for-6.9-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
git bisect good 43a7548e28a6df12a6170421d9d016c576010baa
# bad: [8c9c2f851b5a58195ed7ebd67d7c59683d1a02bc] Merge tag 'iommu-updates-v6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
git bisect bad 8c9c2f851b5a58195ed7ebd67d7c59683d1a02bc
# good: [b38061fe9cfa90a781e9e59fc761191fc8b469a1] net: phy: simplify genphy_c45_ethtool_set_eee
git bisect good b38061fe9cfa90a781e9e59fc761191fc8b469a1
# bad: [75c2946db360e625f1447a37f47dbbb38b1dd478] Merge tag 'wireless-next-2024-03-08' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next
git bisect bad 75c2946db360e625f1447a37f47dbbb38b1dd478
# good: [d35c9659e56edd9e629b54da8ceca062517d3d6c] Merge branch 'net-gro-cleanups-and-fast-path-refinement'
git bisect good d35c9659e56edd9e629b54da8ceca062517d3d6c
# good: [e8bb2ccff7216d520a7bc33c22484dafebe8147e] Merge branch 'net-group-together-hot-data'
git bisect good e8bb2ccff7216d520a7bc33c22484dafebe8147e
# bad: [85977fc0aa489420709779cbc859966db94be68f] wifi: mac80211: remove TDLS peers only on affected link
git bisect bad 85977fc0aa489420709779cbc859966db94be68f
# good: [c2b22e26755c77299e1dffa2e17374cd28f7f3a7] wifi: mt76: mt7921: fix the unfinished command of regd_notifier before suspend git bisect good c2b22e26755c77299e1dffa2e17374cd28f7f3a7
# good: [9ad7974856926129f190ffbe3beea78460b3b7cc] wifi: cfg80211: check A-MSDU format more carefully
git bisect good 9ad7974856926129f190ffbe3beea78460b3b7cc
# bad: [68f6c6afbcebdc3acdc6084abfe453f4cba6b9dc] wifi: mac80211: add ieee80211_vif_link_active() helper
git bisect bad 68f6c6afbcebdc3acdc6084abfe453f4cba6b9dc
# bad: [b2edc721716f44e2a7e46eb592321960a1227c7b] wifi: cfg80211: print flags in tracing in hex
git bisect bad b2edc721716f44e2a7e46eb592321960a1227c7b
# bad: [5fcc7c51f9e72d1e62991f8b32be4a5adf44d556] wifi: mac80211: handle netif carrier up/down with link AP during MLO
git bisect bad 5fcc7c51f9e72d1e62991f8b32be4a5adf44d556
# bad: [1c0d21c4b33a41be9090e73f8225813d72ac88d9] wifi: mac80211: remove only link keys during stopping link AP
git bisect bad 1c0d21c4b33a41be9090e73f8225813d72ac88d9

# first bad commit: [1c0d21c4b33a41be9090e73f8225813d72ac88d9] wifi: mac80211: remove only link keys during stopping link AP

And here are crash logs for all the bad commits:

+ Johannes, Rameshkumar and Aditya

Hi Johannes, Rameshkumar and Aditya,

Mathew helped to do bisection and found the cause is
commit 1c0d21c4b33a ("wifi: mac80211: remove only link keys during stopping link AP").

The use case is as description [1] using RTL8852BE. The STA and AP mode vifs operate on the same channels (SCC).

Please give us guide to dig this problem. Thanks.

[1] https://lore.kernel.org/linux-wireless/[email protected]/