drm/arcpgu: Use devm_platform_get_and_ioremap_resource() in arcpgu_load()
Subsystems (4)
PATCH 1/1 drm/arcpgu: Use devm_platform_get_and_ioremap_resource() in arcpgu_load()
From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 11:16:27 +0100
A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.
This issue was detected by using the Coccinelle software.
--- drivers/gpu/drm/tiny/arcpgu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/tiny/arcpgu.c +1 -2
@@ -268,8 +268,7 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu) drm->mode_config.max_height =1080 ; drm->mode_config.funcs = &arcpgu_drm_modecfg_funcs; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - arcpgu->regs =devm_ioremap_resource (&pdev->dev, res); + arcpgu->regs =devm_platform_get_and_ioremap_resource (pdev,0 , &res);if (IS_ERR (arcpgu->regs))return PTR_ERR (arcpgu->regs);
--
2.43.0
PATCH v2 1/1 drm/arcpgu: Use devm_platform_ioremap_resource() in arcpgu_load()
From: Markus Elfring <[email protected]>
Date: Tue, 6 Feb 2024 20:43:10 +0100
A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()").
* Thus reuse existing functionality instead of keeping duplicate source code.
* Delete a local variable which became unnecessary with this refactoring.
This issue was transformed by using the Coccinelle software.
---
v2:
The transformation pattern was adjusted based on advices by known contributors.
Examples:
* Douglas Anderson
* Geert Uytterhoeven
* Robin Murphy
drivers/gpu/drm/tiny/arcpgu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/tiny/arcpgu.c +1 -3
@@ -251,7 +251,6 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu)struct device_node *encoder_node =NULL , *endpoint_node =NULL ;struct drm_connector *connector =NULL ;struct drm_device *drm = &arcpgu->drm; -struct resource *res;int ret; arcpgu->clk =devm_clk_get (drm->dev,"pxlclk" );
@@ -268,8 +267,7 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu) drm->mode_config.max_height =1080 ; drm->mode_config.funcs = &arcpgu_drm_modecfg_funcs; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); - arcpgu->regs =devm_ioremap_resource (&pdev->dev, res); + arcpgu->regs =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (arcpgu->regs))return PTR_ERR (arcpgu->regs);
--
2.43.0