proc/fd: Remove the initialization of variables in seq_show()
Subsystems (2)
Quoted 1 line
The variables{files, file} will definitely be assigned,
I find an other specification nicer for these identifiers.
Quoted 1 line
so we don't need to initialize them.
I suggest to recheck programming concerns around the handling of the null pointer for the variable “file”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/proc/fd.c?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n20
https://elixir.bootlin.com/linux/v5.7-rc6/source/fs/proc/fd.c#L20
Will another imperative wording be preferred for the change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n151
Regards,
Markus
Quoted 11 lines
Quoted 1 line
The variables{files, file} will definitely be assigned,
I find an other specification nicer for these identifiers.
Quoted 1 line
so we don't need to initialize them.
I suggest to recheck programming concerns around the handling of the null pointer for the variable “file”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/proc/fd.c?id=caffb99b6929f41a69edbb5aef3a359bf45f3315#n20
https://elixir.bootlin.com/linux/v5.7-rc6/source/fs/proc/fd.c#L20
We don't need to initialize the variable “file”.
On line 34, if (files) is true,
{file = fcheck_files(files, fd)} will be executed on line 38.
On line 34, if (files) is flse,
{return ret;} will be executed on line 54, and seq_show() will exit directly. I don't find the programming concerns around the handling of the null pointer for the variable “file”.
If you have other suggestions, please elaborate on the details.
--
Yours,
Kaitao Cheng
Quoted 6 lines
Quoted 6 lines
Quoted 1 line
The variables{files, file} will definitely be assigned,
I find an other specification nicer for these identifiers.
Quoted 1 line
so we don't need to initialize them.
…
Quoted 1 line
We don't need to initialize the variable “file”.
I can agree to this interpretation of the software situation because there is a precondition involved for the variable “ret”.
https://elixir.bootlin.com/linux/v5.7-rc7/source/fs/proc/fd.c#L20
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/proc/fd.c?id=b0c3ba31be3e45a130e13b278cf3b90f69bda6f6#n20
Quoted 2 lines
I don't find the programming concerns around the handling of the null pointer for the variable “file”.
I find the initial change description too terse and therefore incomplete.
Quoted 1 line
If you have other suggestions, please elaborate on the details.
I propose to extend the patch.
How do you think about to convert initialisations for the variables “f_flags” and “ret” also into later assignments?
Regards,
Markus