Skip to contentSkip to conversation

drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle()

PATCH In review Markus Elfring 2 participants 2 messages Mar 25 – Jul 17

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau: Omit a redundant pm_runtime_mark_last_busy() call in nouveau_pmops_runtime_idle()

From: Markus Elfring <[email protected]>
Date: Wed, 25 Mar 2026 14:55:01 +0100

The device's last busy timestamp was set in a wrapper function since the commit 08071e64cb642ae19ebd6ffeb13b4f3d130b5860 ("PM: runtime:
Mark last busy stamp in pm_runtime_autosuspend()").
Thus delete a pm_runtime_mark_last_busy() call before
a pm_runtime_autosuspend() call.

The source code was transformed by using the Coccinelle software.

---
 drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_drm.c +0 -1
index 5d8475e4895e..62ac9593230f 100644
@@ -1209,7 +1209,6 @@ nouveau_pmops_runtime_idle(struct device *dev)
 		return -EBUSY;
 	}
 
-	pm_runtime_mark_last_busy(dev);
 	pm_runtime_autosuspend(dev);
 	/* we don't want the main rpm_idle to call suspend - we want to autosuspend */
 	return 1;
Signature · 1 line
2.53.0
maintainer Reviewed-by on v1 1/1
#1 lore raw

Will push to drm-misc-next in just a moment

Quoted 30 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Wed, 25 Mar 2026 14:55:01 +0100

The device's last busy timestamp was set in a wrapper function since the commit 08071e64cb642ae19ebd6ffeb13b4f3d130b5860 ("PM: runtime:
Mark last busy stamp in pm_runtime_autosuspend()").
Thus delete a pm_runtime_mark_last_busy() call before
a pm_runtime_autosuspend() call.

The source code was transformed by using the Coccinelle software.

---
 drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -

 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_drm.c +0 -0
index 5d8475e4895e..62ac9593230f 100644
@@ -1209,7 +1209,6 @@ nouveau_pmops_runtime_idle(struct device *dev)
  		return -EBUSY;
  	}

drivers/gpu/drm/nouveau/nouveau_drm.c +0 -1
-	pm_runtime_mark_last_busy(dev);

  pm_runtime_autosuspend(dev);
  /* we don't want the main rpm_idle to call suspend - we want to autosuspend */
  return 1;