Skip to contentSkip to conversation

memstick: rtsx_usb_ms: possible uninitialized-variable access in rtsx_usb_ms_issue_cmd()

BUG Li Tuo 1 participant 1 message Jul 31, 2021 MMC, SD and SDIO

lore
Share & tools
lore

Li Tuo

author
#0 lore raw

Hello,

Our static analysis tool finds a possible uninitialized-variable access in the memstick driver in Linux 5.14.0-rc3:

At the beginning of the function rtsx_usb_ms_issue_cmd(), the variable int_reg is not initialized. If the following condition is true, it remains uninitialized.
469:    if (req->long_data)

However, it is accessed in some statements such as:
491:    if (int_reg & MS_INT_CMDNK)

I am not quite sure whether this possible uninitialized-variable access is real and how to fix it if it is real. Any feedback would be appreciated, thanks!

Best wishes,
Tuo Li