x86: aid debug info generation in assembly files
cover x86: aid debug info generation in assembly files
While not immediately useful - a new binutils release would first need cutting - I thought I'd post early the patches utilizing new functionality there. The changes made are largely benign with gas 2.38 or older.
1: improve .debug_line contents for assembly sources 2: annotate entry points with type and size
Jan
PATCH 1/2 x86: improve .debug_line contents for assembly sources
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical) STT_FILE entries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].
xen/arch/x86/include/asm/spec_ctrl_asm.h +8 -0
@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__ +/* * Saving and restoring MSR_SPEC_CTRL state is a little tricky. *
@@ -89,6 +91,7 @@*/ .macro DO_OVERWRITE_RSB tmp=rax +FILE_AND_LINE /* * Requires nothing * Clobbers \tmp (%rax by default), %rcx
@@ -137,6 +140,7 @@ .endm .macro DO_SPEC_CTRL_ENTRY maybexen:req +FILE_AND_LINE /* * Requires %rsp=regs (also cpuinfo if !maybexen) * Requires %r14=stack_end (if maybexen)
@@ -171,6 +175,7 @@ .endm .macro DO_SPEC_CTRL_EXIT_TO_XEN +FILE_AND_LINE /* * Requires %rbx=stack_end * Clobbers %rax, %rcx, %rdx
@@ -192,6 +197,7 @@ .endm .macro DO_SPEC_CTRL_EXIT_TO_GUEST +FILE_AND_LINE /* * Requires %eax=spec_ctrl, %rsp=regs/cpuinfo * Clobbers %rcx, %rdx
@@ -241,6 +247,7 @@* been reloaded. */ .macro SPEC_CTRL_ENTRY_FROM_INTR_IST +FILE_AND_LINE /* * Requires %rsp=regs, %r14=stack_end * Clobbers %rax, %rcx, %rdx
@@ -288,6 +295,7 @@ UNLIKELY_DISPATCH_LABEL(\@_serialise):/* Use when exiting to Xen in IST context. */ .macro SPEC_CTRL_EXIT_TO_XEN_IST +FILE_AND_LINE /* * Requires %rbx=stack_end * Clobbers %rax, %rcx, %rdx
xen/arch/x86/indirect-thunk.S +1 -0
@@ -12,6 +12,7 @@ #include <asm/asm_defns.h> .macro IND_THUNK_RETPOLINE reg:req + .line __LINE__ call 2f 1: lfence
PATCH 2/2 x86: annotate entry points with type and size
In reply to Jan BeulichFuture gas versions will generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. "Borrow" Arm's END() and ENDPROC() to avoid open-coding (and perhaps typo-ing) the respective directives.
xen/arch/x86/include/asm/config.h +5 -0
@@ -53,6 +53,11 @@#define GLOBAL (name) \ .globl name; \ name: +#define END (name) \ + .size name, . - name +#define ENDPROC (name) \ + .type name, @function; \ + END(name)#endif #define NR_hypercalls 64
xen/arch/x86/x86_64/compat/entry.S +8 -0
@@ -27,6 +27,7 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +ENDPROC(entry_int82) /* %rbx: struct vcpu */ ENTRY(compat_test_all_events)
@@ -116,6 +117,7 @@ compat_process_trap: leaq VCPU_trap_bounce(%rbx),%rdx call compat_create_bounce_frame jmp compat_test_all_events +ENDPROC(compat_test_all_events) /* %rbx: struct vcpu, interrupts disabled */ ENTRY(compat_restore_all_guest)
@@ -161,6 +163,7 @@ ENTRY(compat_restore_all_guest) RESTORE_ALL adj=8 compat=1 .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +ENDPROC(compat_restore_all_guest) /* This mustn't modify registers other than %rax. */ ENTRY(cr4_pv32_restore)
@@ -193,6 +196,7 @@ ENTRY(cr4_pv32_restore) pop %rdx xor %eax, %eax ret +ENDPROC(cr4_pv32_restore) ENTRY(compat_syscall) /* Fix up reported %cs/%ss for compat domains. */
@@ -222,6 +226,7 @@ UNLIKELY_END(compat_syscall_gpf) movw %si,TRAPBOUNCE_cs(%rdx) movb %cl,TRAPBOUNCE_flags(%rdx) jmp .Lcompat_bounce_exception +ENDPROC(compat_syscall) ENTRY(compat_sysenter) CR4_PV32_RESTORE
@@ -236,11 +241,13 @@ ENTRY(compat_sysenter) movw %ax,TRAPBOUNCE_cs(%rdx) call compat_create_bounce_frame jmp compat_test_all_events +ENDPROC(compat_sysenter) ENTRY(compat_int80_direct_trap) CR4_PV32_RESTORE call compat_create_bounce_frame jmp compat_test_all_events +ENDPROC(compat_int80_direct_trap) /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK: */ /* {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]} */
@@ -352,3 +359,4 @@ compat_crash_page_fault: jmp .Lft14 .previous _ASM_EXTABLE(.Lft14, .Lfx14) +ENDPROC(compat_create_bounce_frame)
xen/arch/x86/x86_64/entry.S +34 -1
@@ -139,6 +139,7 @@ process_trap: leaq VCPU_trap_bounce(%rbx), %rdx call create_bounce_frame jmp test_all_events +ENDPROC(switch_to_kernel) .section .text.entry, "ax", @progbits
@@ -230,6 +231,7 @@ iret_exit_to_guest: addq $8,%rsp .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +ENDPROC(restore_all_guest) /* * When entering SYSCALL from kernel mode:
@@ -281,6 +283,7 @@ ENTRY(lstar_enter) mov %rsp, %rdi call pv_hypercall jmp test_all_events +ENDPROC(lstar_enter) /* See lstar_enter for entry register state. */ ENTRY(cstar_enter)
@@ -320,6 +323,7 @@ ENTRY(cstar_enter) jne compat_syscall #endif jmp switch_to_kernel +ENDPROC(cstar_enter) ENTRY(sysenter_entry) ENDBR64
@@ -384,6 +388,7 @@ UNLIKELY_END(sysenter_gpf) jne compat_sysenter #endif jmp .Lbounce_exception +ENDPROC(sysenter_entry) ENTRY(int80_direct_trap) ENDBR64
@@ -473,6 +478,7 @@ int80_slow_path: */ GET_STACK_END(14) jmp handle_exception_saved +ENDPROC(int80_direct_trap) /* create_bounce_frame & helpers don't need to be in .text.entry */ .text
@@ -617,6 +623,7 @@ ENTRY(dom_crash_sync_extable) xorl %edi,%edi jmp asm_domain_crash_synchronous /* Does not return */ .popsection +ENDPROC(create_bounce_frame) #endif /* CONFIG_PV */ /* --- CODE BELOW THIS LINE (MOSTLY) NOT GUEST RELATED --- */
@@ -640,10 +647,12 @@ ret_from_intr: #else jmp test_all_events #endif +ENDPROC(continue_pv_domain) #else ret_from_intr: ASSERT_CONTEXT_IS_XEN jmp restore_all_xen +ENDPROC(ret_from_intr) #endif .section .text.entry, "ax", @progbits
@@ -667,6 +676,7 @@ UNLIKELY_END(exit_cr3) RESTORE_ALL adj=8 iretq +ENDPROC(restore_all_xen) ENTRY(common_interrupt) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP
@@ -697,10 +707,12 @@ ENTRY(common_interrupt) mov %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14) mov %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14) jmp ret_from_intr +ENDPROC(common_interrupt) ENTRY(page_fault) ENDBR64 movl $TRAP_page_fault,4(%rsp) +ENDPROC(page_fault) /* No special register assumptions. */ GLOBAL(handle_exception) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP
@@ -872,12 +884,14 @@ FATAL_exception_with_ints_disabled: movq %rsp,%rdi call fatal_trap BUG /* fatal_trap() shouldn't return. */ +ENDPROC(handle_exception) ENTRY(divide_error) ENDBR64 pushq $0 movl $TRAP_divide_error,4(%rsp) jmp handle_exception +ENDPROC(divide_error) ENTRY(coprocessor_error) ENDBR64
@@ -890,72 +904,85 @@ ENTRY(simd_coprocessor_error) pushq $0 movl $TRAP_simd_error,4(%rsp) jmp handle_exception +ENDPROC(coprocessor_error) ENTRY(device_not_available) ENDBR64 pushq $0 movl $TRAP_no_device,4(%rsp) jmp handle_exception +ENDPROC(device_not_available) ENTRY(debug) ENDBR64 pushq $0 movl $TRAP_debug,4(%rsp) jmp handle_ist_exception +ENDPROC(debug) ENTRY(int3) ENDBR64 pushq $0 movl $TRAP_int3,4(%rsp) jmp handle_exception +ENDPROC(int3) ENTRY(overflow) ENDBR64 pushq $0 movl $TRAP_overflow,4(%rsp) jmp handle_exception +ENDPROC(overflow) ENTRY(bounds) ENDBR64 pushq $0 movl $TRAP_bounds,4(%rsp) jmp handle_exception +ENDPROC(bounds) ENTRY(invalid_op) ENDBR64 pushq $0 movl $TRAP_invalid_op,4(%rsp) jmp handle_exception +ENDPROC(invalid_op) ENTRY(invalid_TSS) ENDBR64 movl $TRAP_invalid_tss,4(%rsp) jmp handle_exception +ENDPROC(invalid_TSS) ENTRY(segment_not_present) ENDBR64 movl $TRAP_no_segment,4(%rsp) jmp handle_exception +ENDPROC(segment_not_present) ENTRY(stack_segment) ENDBR64 movl $TRAP_stack_error,4(%rsp) jmp handle_exception +ENDPROC(stack_segment) ENTRY(general_protection) ENDBR64 movl $TRAP_gp_fault,4(%rsp) jmp handle_exception +ENDPROC(general_protection) ENTRY(alignment_check) ENDBR64 movl $TRAP_alignment_check,4(%rsp) jmp handle_exception +ENDPROC(alignment_check) ENTRY(entry_CP) ENDBR64 movl $X86_EXC_CP, 4(%rsp) jmp handle_exception +ENDPROC(entry_CP) ENTRY(double_fault) ENDBR64
@@ -981,6 +1008,7 @@ ENTRY(double_fault) movq %rsp,%rdi call do_double_fault BUG /* do_double_fault() shouldn't return. */ +ENDPROC(double_fault) .pushsection .init.text, "ax", @progbits ENTRY(early_page_fault)
@@ -990,6 +1018,7 @@ ENTRY(early_page_fault) movq %rsp,%rdi call do_early_page_fault jmp restore_all_xen +ENDPROC(early_page_fault) .popsection ENTRY(nmi)
@@ -1120,17 +1149,20 @@ handle_ist_exception: ASSERT_CONTEXT_IS_XEN jmp restore_all_xen #endif +ENDPROC(nmi) ENTRY(machine_check) ENDBR64 pushq $0 movl $TRAP_machine_check,4(%rsp) jmp handle_ist_exception +ENDPROC(machine_check) /* No op trap handler. Required for kexec crash path. */ GLOBAL(trap_nop) ENDBR64 iretq +ENDPROC(trap_nop) /* Table of automatically generated entry points. One per vector. */ .pushsection .init.rodata, "a", @progbits
@@ -1187,6 +1219,7 @@ autogen_stubs: /* Automatically generate vec = vec + 1 .endr +ENDPROC(autogen_stubs) .section .init.rodata, "a", @progbits - .size autogen_entrypoints, . - autogen_entrypoints + END(autogen_entrypoints)
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
In reply to Jan BeulichQuoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].
xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__
Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
#define DECLARE_MACRO(n, ...) \
.macro n __VA_ARGS__ \
.file __FILE__; .line __LINE__Thanks, Roger.
Re: [PATCH 2/2] x86: annotate entry points with type and size
In reply to Jan BeulichQuoted 8 lines · Jan Beulich
Future gas versions will generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. "Borrow" Arm's
END()andENDPROC()to avoid open-coding (and perhaps typo-ing) the respective directives.Signed-off-by Jan Beulich <[email protected]>
I'm conflicted by this change.
You've clearly changed your mind since you rejected my patch introducing this infrastructure and starting to use it.
Given that it is a reoccurring bug with livepatching which has been in need of fixing since 2018, I'd organised some work to port Linux's linkage.h as something more likely to have been acceptable.
~Andrew
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
In reply to Roger Pau MonnéQuoted 36 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
Quoted 3 lines
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and DECLARE_MACRO().
Jan
Re: [PATCH 2/2] x86: annotate entry points with type and size
In reply to Andrew CooperQuoted 6 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich
Future gas versions will generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. "Borrow" Arm's
END()andENDPROC()to avoid open-coding (and perhaps typo-ing) the respective directives.
Quoted 8 lines
Quoted 3 lines
Signed-off-by Jan Beulich <[email protected]>I'm conflicted by this change.
You've clearly changed your mind since you rejected my patch introducing this infrastructure and starting to use it.
Hmm, to be honest I don't recall me rejecting such work of yours. In fact I have always been in favor of properly typing symbols, where sensible and possible. I would therefore assume it was more the "how" than the "that" which I wasn't happy with. If you have a reference to the old thread to hand, I'd be interested in looking up what made me oppose back at the time.
Quoted 3 lines
Given that it is a reoccurring bug with livepatching which has been in need of fixing since 2018, I'd organised some work to port Linux's
linkage.has something more likely to have been acceptable.
Taking what they've got would likely be fine as well. At least in a suitably stripped down manner (looking at their header they may have gone a little overboard with this).
Jan
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
In reply to Jan BeulichQuoted 41 lines · Jan Beulich
Quoted 36 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
Quoted 3 lines
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__
Quoted 5 lines
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and
DECLARE_MACRO().
I think it's a dummy question, but why would we want to add this to some macros?
Isn't it better to always have the file and line reference where the macro gets used?
Thanks, Roger.
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
Quoted 42 lines · Roger Pau Monné
Quoted 41 lines · Jan Beulich
Quoted 39 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__
Quoted 7 lines
Quoted 5 lines
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and
DECLARE_MACRO().I think it's a dummy question, but why would we want to add this to
^n't
Sorry.
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
In reply to Roger Pau MonnéQuoted 48 lines · Roger Pau Monné
Quoted 41 lines · Jan Beulich
Quoted 36 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
Quoted 3 lines
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__Quoted 5 lines
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and
DECLARE_MACRO().
Quoted 5 lines
I think it's a dummy question, but why would we want to add this to some macros?
Isn't it better to always have the file and line reference where the macro gets used?
Like said in the description, a macro simply invoking another macro, or a macro simply wrapping a single insn, is likely better to have its generated code associated with the original line number. Complex macros, otoh, are imo often better to have line numbers associated with actual macro contents. IOW to some degree I support the cited workaround in binutils (which has been there for many years).
Jan
Roger Pau Monné
Acked-byRe: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
Quoted 55 lines · Jan Beulich
Quoted 48 lines · Roger Pau Monné
Quoted 41 lines · Jan Beulich
Quoted 36 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
Quoted 3 lines
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__Quoted 5 lines
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and
DECLARE_MACRO().Quoted 5 lines
I think it's a dummy question, but why would we want to add this to some macros?
Isn't it better to always have the file and line reference where the macro gets used?
Quoted 6 lines
Like said in the description, a macro simply invoking another macro, or a macro simply wrapping a single insn, is likely better to have its generated code associated with the original line number. Complex macros, otoh, are imo often better to have line numbers associated with actual macro contents. IOW to some degree I support the cited workaround in binutils (which has been there for many years).
Seems a bit ad-hoc policy, but it's you and Andrew that mostly deal with this stuff, so if you are fine with it.
Thanks, Roger.
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
Quoted 63 lines · Roger Pau Monné
Quoted 55 lines · Jan Beulich
Quoted 48 lines · Roger Pau Monné
Quoted 41 lines · Jan Beulich
Quoted 36 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
Quoted 3 lines
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__Quoted 5 lines
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and
DECLARE_MACRO().Quoted 5 lines
I think it's a dummy question, but why would we want to add this to some macros?
Isn't it better to always have the file and line reference where the macro gets used?
Quoted 6 lines
Like said in the description, a macro simply invoking another macro, or a macro simply wrapping a single insn, is likely better to have its generated code associated with the original line number. Complex macros, otoh, are imo often better to have line numbers associated with actual macro contents. IOW to some degree I support the cited workaround in binutils (which has been there for many years).
Quoted 2 lines
Seems a bit ad-hoc policy, but it's you and Andrew that mostly deal with this stuff, so if you are fine with it.
What other rule of thumb would you suggest? I'd be happy to take suggestions rather than force in something which looks to be not entirely uncontroversial.
Quoted 1 line
Acked-by roger Pau Monné <[email protected]>
Thanks. Given the above, I guess I'll apply this only provisionally.
Jan
Re: [PATCH 1/2] x86: improve .debug_line contents for assembly sources
In reply to Roger Pau MonnéQuoted 63 lines · Roger Pau Monné
Quoted 55 lines · Jan Beulich
Quoted 48 lines · Roger Pau Monné
Quoted 41 lines · Jan Beulich
Quoted 36 lines · Roger Pau Monné
Quoted 26 lines · Jan Beulich
While future gas versions will allow line number information to be generated for all instances of .irp and alike [1][2], the same isn't true (nor immediately intended) for .macro [3]. Hence macros, when they do more than just invoke another macro or issue an individual insn, want to have .line directives (in header files also .file ones) in place.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=7992631e8c0b0e711fbaba991348ef6f6e583725
[2] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=2ee1792bec225ea19c71095cee5a3a9ae6df7c59
[3] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=6d1ace6861e999361b30d1bc27459ab8094e0d4a
---
Using .file has the perhaps undesirable side effect of generating a fair
amount of (all identical)STT_FILEentries in the symbol table. We also
can't use the supposedly assembler-internal (and hence undocumented)
.appfile anymore, as it was removed [4]. Note that .linefile (also internal/undocumented) as well as the "# <line> <file>" constructs the
compiler emits, leading to .linefile insertion by the assembler, aren't
of use anyway as these are processed and purged when processing .macro
[3].xen/arch/x86/include/asm/spec_ctrl_asm.h line 27
Quoted 4 lines
xen/arch/x86/include/asm/spec_ctrl_asm.h +1
-0@@ -24,6 +24,8 @@#include <asm/msr-index.h> #include <asm/spec_ctrl.h> +#define FILE_AND_LINE .file __FILE__; .line __LINE__Seeing as this seems to get added to all macros below, I guess you did consider (and discarded) introducing a preprocessor macro do to the asm macro definitons:
Quoted 3 lines
#define
DECLARE_MACRO(n, ...)\.macro n __VA_ARGS__ \ .file __FILE__; .line __LINE__Quoted 5 lines
No, I didn't even consider that. I view such as too obfuscating - there's then e.g. no visual match with the .endm. Furthermore, as outlined in the description, I don't think this wants applying uniformly. There are macros which better don't have this added. Yet I also would prefer to not end up with a mix of .macro and
DECLARE_MACRO().Quoted 5 lines
I think it's a dummy question, but why would we want to add this to some macros?
Isn't it better to always have the file and line reference where the macro gets used?
Quoted 6 lines
Like said in the description, a macro simply invoking another macro, or a macro simply wrapping a single insn, is likely better to have its generated code associated with the original line number. Complex macros, otoh, are imo often better to have line numbers associated with actual macro contents. IOW to some degree I support the cited workaround in binutils (which has been there for many years).
Quoted 2 lines
Seems a bit ad-hoc policy, but it's you and Andrew that mostly deal with this stuff, so if you are fine with it.
Actually I think I'll withdraw this patch. After quite a bit of further consideration, it should really be the assembler to get this right, and once properly working there the directives added here may actually get in the way.
Jan
Re: [PATCH 2/2] x86: annotate entry points with type and size
In reply to Jan BeulichQuoted 23 lines · Jan Beulich
Quoted 6 lines · Andrew Cooper
Quoted 5 lines · Jan Beulich
Future gas versions will generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. "Borrow" Arm's
END()andENDPROC()to avoid open-coding (and perhaps typo-ing) the respective directives.Quoted 8 lines
Quoted 3 lines
Signed-off-by Jan Beulich <[email protected]>I'm conflicted by this change.
You've clearly changed your mind since you rejected my patch introducing this infrastructure and starting to use it.
Hmm, to be honest I don't recall me rejecting such work of yours. In fact I have always been in favor of properly typing symbols, where sensible and possible. I would therefore assume it was more the "how" than the "that" which I wasn't happy with. If you have a reference to the old thread to hand, I'd be interested in looking up what made me oppose back at the time.
Quoted 7 lines
Quoted 3 lines
Given that it is a reoccurring bug with livepatching which has been in need of fixing since 2018, I'd organised some work to port Linux's
linkage.has something more likely to have been acceptable.Taking what they've got would likely be fine as well. At least in a suitably stripped down manner (looking at their header they may have gone a little overboard with this).
Over two months have passed. I wonder whether I had misunderstood your
reply: I took it to mean an alternative patch or series would be posted. In the absence of that and considering that you say that you did want such annotations anyway, I wonder what it is that stands in the way of these two patches making it in.
Jan
v2 cover x86: annotate entry points with type and size
In reply to Jan BeulichThe model introduced in patch 1 is in principle arch-agnostic, hence why I'm including Arm and RISC-V reviewers here as well.
1: annotate entry points with type and size
2: also mark assembler globals hidden
Jan
PATCH v2 1/2 x86: annotate entry points with type and size
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es.
For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for.
Except for the added alignment padding (including their knock-on effects) no change in generated code/data.
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v2: Full rework.
---
Only two of the assembly files are being converted for now. More could
be done right here or as follow-on in separate patches.
In principle the framework should be possible to use by other architectures as well. If we want this, the main questions are going to be:
- What header file name? (I don't really like Linux'es linkage.h, so I'd prefer e.g. asm-defns.h or asm_defns.h as we already have in x86.)
- How much per-arch customization do we want to permit up front (i.e. without knowing how much of it is going to be needed)? Initially I'd expect only the default function alignment (and padding) to require per-arch definitions.
Note that the FB-label in autogen_stubs() cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid setting STT_NOTYPE explicitly (that's the type labels get by default anyway).
Note that we can't use ALIGN() (in place of SYM_ALIGN()) as long as we still have ALIGN.
xen/arch/x86/include/asm/asm_defns.h +39 -0
@@ -81,6 +81,45 @@ register unsigned long current_stack_poi#ifdef __ASSEMBLY__ +#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) + +#define LAST__ (nr) ARG ## nr ## _ +#define LAST_ (nr) LAST__(nr) +#define LAST(x, y...) LAST_(count_args(x, ## y))(x, ## y) + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LAST(16, ## algn), 0x90) +#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LAST(16, ## algn), 0x90) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LAST(0, ## algn), 0xff) + +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LAST(16, ## algn), 0x90) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LAST(16, ## algn), 0x90) +#define DATA_LOCAL(name, algn...) \ + SYM(name, DATA, LOCAL, LAST(0, ## algn), 0xff) +#ifdef HAVE_AS_QUOTED_SYM #define SUBSECTION_LBL (tag) \ .ifndef .L.tag; \
xen/arch/x86/x86_64/compat/entry.S +21 -16
@@ -8,10 +8,11 @@ #include <asm/page.h> #include <asm/processor.h> #include <asm/desc.h> +#include <xen/lib.h> #include <public/xen.h> #include <irq_vectors.h> -ENTRY(entry_int82) +FUNC(entry_int82) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0
@@ -27,9 +28,10 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +END(entry_int82) /* %rbx: struct vcpu */ -ENTRY(compat_test_all_events) +FUNC(compat_test_all_events) ASSERT_NOT_IN_ATOMIC cli # tests must not race interrupts /*compat_test_softirqs:*/
@@ -66,24 +68,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs) sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce) sti .Lcompat_bounce_exception: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_mce: +LABEL_LOCAL(compat_process_mce) testb $1 << VCPU_TRAP_MCE,VCPU_async_exception_mask(%rbx) jnz .Lcompat_test_guest_nmi sti
@@ -97,9 +96,8 @@ compat_process_mce: movb %dl,VCPU_async_exception_mask(%rbx) jmp compat_process_trap - ALIGN /* %rbx: struct vcpu */ -compat_process_nmi: +LABEL_LOCAL(compat_process_nmi) testb $1 << VCPU_TRAP_NMI,VCPU_async_exception_mask(%rbx) jnz compat_test_guest_events sti
@@ -116,9 +114,10 @@ compat_process_trap: leaq VCPU_trap_bounce(%rbx),%rdx call compat_create_bounce_frame jmp compat_test_all_events +END(compat_test_all_events) /* %rbx: struct vcpu, interrupts disabled */ -ENTRY(compat_restore_all_guest) +FUNC(compat_restore_all_guest) ASSERT_INTERRUPTS_DISABLED mov $~(X86_EFLAGS_IOPL | X86_EFLAGS_VM), %r11d and UREGS_eflags(%rsp),%r11d
@@ -161,9 +160,10 @@ ENTRY(compat_restore_all_guest) RESTORE_ALL adj=8 compat=1 .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +END(compat_restore_all_guest) /* This mustn't modify registers other than %rax. */ -ENTRY(cr4_pv32_restore) +FUNC(cr4_pv32_restore) push %rdx GET_CPUINFO_FIELD(cr4, dx) mov (%rdx), %rax
@@ -193,8 +193,9 @@ ENTRY(cr4_pv32_restore) pop %rdx xor %eax, %eax ret +END(cr4_pv32_restore) -ENTRY(compat_syscall) +FUNC(compat_syscall) /* Fix up reported %cs/%ss for compat domains. */ movl $FLAT_COMPAT_USER_SS, UREGS_ss(%rsp) movl $FLAT_COMPAT_USER_CS, UREGS_cs(%rsp)
@@ -222,8 +223,9 @@ UNLIKELY_END(compat_syscall_gpf) movw %si,TRAPBOUNCE_cs(%rdx) movb %cl,TRAPBOUNCE_flags(%rdx) jmp .Lcompat_bounce_exception +END(compat_syscall) -ENTRY(compat_sysenter) +FUNC(compat_sysenter) CR4_PV32_RESTORE movq VCPU_trap_ctxt(%rbx),%rcx cmpb $X86_EXC_GP, UREGS_entry_vector(%rsp)
@@ -236,17 +238,19 @@ ENTRY(compat_sysenter) movw %ax,TRAPBOUNCE_cs(%rdx) call compat_create_bounce_frame jmp compat_test_all_events +END(compat_sysenter) -ENTRY(compat_int80_direct_trap) +FUNC(compat_int80_direct_trap) CR4_PV32_RESTORE call compat_create_bounce_frame jmp compat_test_all_events +END(compat_int80_direct_trap) /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK: */ /* {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]} */ /* %rdx: trap_bounce, %rbx: struct vcpu */ /* On return only %rbx and %rdx are guaranteed non-clobbered. */ -compat_create_bounce_frame: +FUNC_LOCAL(compat_create_bounce_frame) ASSERT_INTERRUPTS_ENABLED mov %fs,%edi ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP
@@ -352,3 +356,4 @@ compat_crash_page_fault: jmp .Lft14 .previous _ASM_EXTABLE(.Lft14, .Lfx14) +END(compat_create_bounce_frame)
xen/arch/x86/x86_64/entry.S +77 -48
393 lines not on this page · raw message
PATCH v2 2/2 x86: also mark assembler globals hidden
In reply to Jan BeulichLet's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case.
---
v2: New.
xen/arch/x86/include/asm/asm_defns.h +1 -1
@@ -83,7 +83,7 @@ register unsigned long current_stack_poi #define SYM_ALIGN(algn...) .balign algn -#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
xen/arch/x86/include/asm/config.h +2 -2
@@ -45,11 +45,11 @@#ifdef __ASSEMBLY__#define ALIGN .align 16,0x90#define ENTRY (name) \ - .globl name; \ ALIGN; \ - name: + GLOBAL(name)#define GLOBAL (name) \ .globl name; \ + .hidden name; \ name:#endif
Re: [PATCH v2 1/2] x86: annotate entry points with type and size
In reply to Jan BeulichQuoted 33 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es.For
switch_to_kernel()andrestore_all_guest()so far implicit alignment (from being first in their respective sections) is being made explicit (as in: usingFUNC()without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for.Except for the added alignment padding (including their knock-on effects) no change in generated code/data.
Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v2: Full rework.
---
Only two of the assembly files are being converted for now. More could
be done right here or as follow-on in separate patches.In principle the framework should be possible to use by other architectures as well. If we want this, the main questions are going to be:
- What header file name? (I don't really like Linux'eslinkage.h, so I'd prefer e.g.asm-defns.horasm_defns.has we already have in x86.)
- How much per-arch customization do we want to permit up front (i.e. without knowing how much of it is going to be needed)? Initially I'd expect only the default function alignment (and padding) to require per-arch definitions.
Quoted 7 lines
Note that the FB-label in
autogen_stubs()cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid settingSTT_NOTYPEexplicitly (that's the type labels get by default anyway).Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.
FWIW, as I'm looking into using the newly added macros in order to add annotations suitable for live-patching, I would need to switch some of the LABEL usages into it's own functions, as it's not possible to livepatch a function that has labels jumped into from code paths outside of the function.
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 87
Quoted 10 lines
xen/arch/x86/include/asm/asm_defns.h +4
-0@@ -81,6 +81,45 @@ register unsigned long current_stack_poi#ifdef __ASSEMBLY__ +#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name
Won't this better be added when required? I can't spot any weak symbols in assembly ATM, and you don't introduce any _WEAK macro variants below.
Quoted 10 lines
xen/arch/x86/include/asm/asm_defns.h +10
-0+#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 107
Quoted 10 lines
xen/arch/x86/include/asm/asm_defns.h +10
-0+ name: + +#define END (name) .size name, . - name + +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) + +#define LAST__ (nr) ARG ## nr ## _ +#define LAST_ (nr) LAST__(nr) +#define LAST(x, y...) LAST_(count_args(x, ## y))(x, ## y)
I find LAST not very descriptive, won't it better be named OPTIONAL() or similar? (and maybe placed in lib.h?)
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 110
Quoted 3 lines
xen/arch/x86/include/asm/asm_defns.h +3
-0+ +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LAST(16, ## algn), 0x90)
A rant, should the alignment of functions use a different padding? (ie: ret or ud2?) In order to prevent stray jumps falling in the padding and fall trough into the next function. That would also prevent the implicit fall trough used in some places.
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 119
Quoted 9 lines
xen/arch/x86/include/asm/asm_defns.h +9
-0+#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LAST(16, ## algn), 0x90) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LAST(0, ## algn), 0xff) + +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LAST(16, ## algn), 0x90) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LAST(16, ## algn), 0x90)
Is there much value in adding local labels to the symbol table?
AFAICT the main purpose of this macro is to be used to declare aligned labels, and here avoid the ALIGN + label name pair, but could likely drop the .type directive?
xen/arch/x86/x86_64/compat/entry.S line 11
Quoted 13 lines
xen/arch/x86/include/asm/asm_defns.h +3
-0+#define DATA_LOCAL(name, algn...) \ + SYM(name, DATA, LOCAL, LAST(0, ## algn), 0xff) +#ifdef HAVE_AS_QUOTED_SYM #define SUBSECTION_LBL (tag) \ .ifndef .L.tag; \xen/arch/x86/x86_64/compat/entry.S +1
-0@@ -8,10 +8,11 @@ #include <asm/page.h> #include <asm/processor.h> #include <asm/desc.h> +#include <xen/lib.h>
Shouldn't the inclusion of lib.h be in asm_defs.h, as that's where the usage of count_args() resides? (I assume that's why lib.h is added here).
Quoted 21 lines
xen/arch/x86/x86_64/compat/entry.S +3
-2#include <public/xen.h> #include <irq_vectors.h> -ENTRY(entry_int82) +FUNC(entry_int82) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0@@ -27,9 +28,10 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +END(entry_int82) /* %rbx: struct vcpu */ -ENTRY(compat_test_all_events) +FUNC(compat_test_all_events) ASSERT_NOT_IN_ATOMIC cli # tests must not race interrupts /*compat_test_softirqs:*/
xen/arch/x86/x86_64/compat/entry.S compat_test_guest_events: · line 72
Quoted 7 lines
xen/arch/x86/x86_64/compat/entry.S +1
-2@@ -66,24 +68,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs)
Shouldn't this be a local function rather than a local label? It's fully isolated. I guess it would create issues with compat_process_trap, as we would then require a jump from the preceding compat_process_nmi.
xen/arch/x86/x86_64/compat/entry.S compat_test_guest_events: · line 78
Quoted 8 lines
xen/arch/x86/x86_64/compat/entry.S +1
-2sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce)
It's my understanding that here the '.L' prefix is pointless, since LABEL_LOCAL() will forcefully create a symbol for the label due to the usage of .type?
Thanks, Roger.
Re: [PATCH v2 2/2] x86: also mark assembler globals hidden
In reply to Jan BeulichQuoted 6 lines · Jan Beulich
Let's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case.
Signed-off-by Jan Beulich <[email protected]>
Thanks, Roger.
Re: [PATCH v2 1/2] x86: annotate entry points with type and size
In reply to Roger Pau MonnéQuoted 6 lines · Roger Pau Monné
Quoted 5 lines · Jan Beulich
Note that the FB-label in
autogen_stubs()cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid settingSTT_NOTYPEexplicitly (that's the type labels get by default anyway).
Quoted 8 lines
Quoted 2 lines
Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.FWIW, as I'm looking into using the newly added macros in order to add annotations suitable for live-patching, I would need to switch some of the LABEL usages into it's own functions, as it's not possible to livepatch a function that has labels jumped into from code paths outside of the function.
Hmm, I'm not sure what the best way is to overcome that restriction. I'm not convinced we want to arbitrarily name things "functions".
Quoted 6 lines
Quoted 6 lines
xen/arch/x86/include/asm/asm_defns.h +0
-0@@ -81,6 +81,45 @@ register unsigned long current_stack_poi#ifdef __ASSEMBLY__
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 87
Quoted 4 lines
xen/arch/x86/include/asm/asm_defns.h +4
-0+#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak nameWon't this better be added when required? I can't spot any weak symbols in assembly ATM, and you don't introduce any
_WEAKmacro variants below.
Well, Andrew specifically mentioned to desire to also have Linux'es support for weak symbols. Hence I decided to add it here despite (for now) being unused). I can certainly drop that again, but in particular if we wanted to use the scheme globally, I think we may want to make it "complete".
Quoted 15 lines
Quoted 15 lines
xen/arch/x86/include/asm/asm_defns.h +15
-0+#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define ARG1_(x, y...) (x)
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 107
Quoted 5 lines
xen/arch/x86/include/asm/asm_defns.h +5
-0+#define ARG2_(x, y...) ARG1_(y) + +#define LAST__ (nr) ARG ## nr ## _ +#define LAST_ (nr) LAST__(nr) +#define LAST(x, y...) LAST_(count_args(x, ## y))(x, ## y)I find LAST not very descriptive, won't it better be named
OPTIONAL()or similar? (and maybe placed inlib.h?)
I don't think OPTIONAL describes the purpose. I truly mean "last" here. As to placing in lib.h - perhaps, but then we may want to have forms with more than 2 arguments right away (and it would be a little unclear how far up to go).
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 110
Quoted 3 lines
xen/arch/x86/include/asm/asm_defns.h +3
-0+ +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LAST(16, ## algn), 0x90)A rant, should the alignment of functions use a different padding? (ie: ret or ud2?) In order to prevent stray jumps falling in the padding and fall trough into the next function. That would also prevent the implicit fall trough used in some places.
Yes, but that's a separate topic (for which iirc patches are pending as well, just of course not integrated with the work here. There's the slight risk of overlooking some "fall-through" case ...
Quoted 12 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 119
Quoted 9 lines
xen/arch/x86/include/asm/asm_defns.h +9
-0+#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LAST(16, ## algn), 0x90) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LAST(0, ## algn), 0xff) + +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LAST(16, ## algn), 0x90) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LAST(16, ## algn), 0x90)Is there much value in adding local labels to the symbol table?
Quoted 3 lines
AFAICT the main purpose of this macro is to be used to declare aligned labels, and here avoid the ALIGN + label name pair, but could likely drop the .type directive?
Right, .type ... NOTYPE is kind of redundant, but it fits the model better here.
Quoted 11 lines
xen/arch/x86/x86_64/compat/entry.S line 11
Quoted 7 lines
xen/arch/x86/x86_64/compat/entry.S +1
-0@@ -8,10 +8,11 @@ #include <asm/page.h> #include <asm/processor.h> #include <asm/desc.h> +#include <xen/lib.h>Shouldn't the inclusion of
lib.hbe inasm_defs.h, as that's where the usage ofcount_args()resides? (I assume that's whylib.his added here).
When the uses are in macros I'm always largely undecided, and I slightly tend towards the (in general, perhaps not overly relevant here) "less dependencies" solution. As in: Source files not using the macros which use count_args() also don't need libs.h then.
Quoted 4 lines
Quoted 4 lines
xen/arch/x86/x86_64/compat/entry.S +0
-0@@ -66,24 +68,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events
Quoted 9 lines
xen/arch/x86/x86_64/compat/entry.S compat_test_guest_events: · line 72
Quoted 4 lines
xen/arch/x86/x86_64/compat/entry.S +1
-2- ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs)Shouldn't this be a local function rather than a local label? It's fully isolated. I guess it would create issues with
compat_process_trap, as we would then require a jump from the precedingcompat_process_nmi.
Alternatives are possible, but right now I consider this an inner label of compat_test_all_events.
Quoted 4 lines
Quoted 4 lines
xen/arch/x86/x86_64/compat/entry.S +0
-0sti call do_softirq jmp compat_test_all_events
Quoted 8 lines
xen/arch/x86/x86_64/compat/entry.S compat_test_guest_events: · line 78
Quoted 4 lines
xen/arch/x86/x86_64/compat/entry.S +1
-2- ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce)It's my understanding that here the '.L' prefix is pointless, since
LABEL_LOCAL()will forcefully create a symbol for the label due to the usage of .type?
I don't think .type has this effect. There's certainly no such label in the symbol table of the object file I have as a result.
Jan
Re: [PATCH v2 1/2] x86: annotate entry points with type and size
Quoted 10 lines · Jan Beulich
Quoted 9 lines · Roger Pau Monné
Quoted 7 lines · Jan Beulich
Note that the FB-label in
autogen_stubs()cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid settingSTT_NOTYPEexplicitly (that's the type labels get by default anyway).Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.
Quoted 8 lines
Quoted 5 lines
FWIW, as I'm looking into using the newly added macros in order to add annotations suitable for live-patching, I would need to switch some of the LABEL usages into it's own functions, as it's not possible to livepatch a function that has labels jumped into from code paths outside of the function.
Hmm, I'm not sure what the best way is to overcome that restriction. I'm not convinced we want to arbitrarily name things "functions".
Any external entry point in the middle of a function-like block will prevent it from being live patched.
If you want I can try to do a pass on top of your patch and see how that would end up looking. I'm attempting to think about other solutions, but every other solution seems quite horrible.
Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
xen/arch/x86/include/asm/asm_defns.h +0
-0@@ -81,6 +81,45 @@ register unsigned long current_stack_poi#ifdef __ASSEMBLY__Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 87
Quoted 4 lines
xen/arch/x86/include/asm/asm_defns.h +4
-0+#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak nameWon't this better be added when required? I can't spot any weak symbols in assembly ATM, and you don't introduce any
_WEAKmacro variants below.
Quoted 5 lines
Well, Andrew specifically mentioned to desire to also have Linux'es support for weak symbols. Hence I decided to add it here despite (for now) being unused). I can certainly drop that again, but in particular if we wanted to use the scheme globally, I think we may want to make it "complete".
OK, as long as we know it's unused.
Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
xen/arch/x86/include/asm/asm_defns.h +15
-0+#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define ARG1_(x, y...) (x)Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 107
Quoted 5 lines
xen/arch/x86/include/asm/asm_defns.h +5
-0+#define ARG2_(x, y...) ARG1_(y) + +#define LAST__ (nr) ARG ## nr ## _ +#define LAST_ (nr) LAST__(nr) +#define LAST(x, y...) LAST_(count_args(x, ## y))(x, ## y)I find LAST not very descriptive, won't it better be named
OPTIONAL()or similar? (and maybe placed inlib.h?)
Quoted 4 lines
I don't think OPTIONAL describes the purpose. I truly mean "last" here. As to placing in
lib.h- perhaps, but then we may want to have forms with more than 2 arguments right away (and it would be a little unclear how far up to go).
Hm, I would be fine with adding that version with just 2 arguments, as it's better to have the helper in a generic place IMO.
Quoted 9 lines
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 110
Quoted 3 lines
xen/arch/x86/include/asm/asm_defns.h +3
-0+ +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LAST(16, ## algn), 0x90)A rant, should the alignment of functions use a different padding? (ie: ret or ud2?) In order to prevent stray jumps falling in the padding and fall trough into the next function. That would also prevent the implicit fall trough used in some places.
Quoted 3 lines
Yes, but that's a separate topic (for which iirc patches are pending as well, just of course not integrated with the work here. There's the slight risk of overlooking some "fall-through" case ...
Oh, OK, wasn't aware patches are floating for this already, just came across it while reviewing.
Quoted 12 lines
Quoted 11 lines
xen/arch/x86/x86_64/compat/entry.S line 11
Quoted 7 lines
xen/arch/x86/x86_64/compat/entry.S +1
-0@@ -8,10 +8,11 @@ #include <asm/page.h> #include <asm/processor.h> #include <asm/desc.h> +#include <xen/lib.h>Shouldn't the inclusion of
lib.hbe inasm_defs.h, as that's where the usage ofcount_args()resides? (I assume that's whylib.his added here).
Quoted 4 lines
When the uses are in macros I'm always largely undecided, and I slightly tend towards the (in general, perhaps not overly relevant here) "less dependencies" solution. As in: Source files not using the macros which use
count_args()also don't needlibs.hthen.
I tend to prefer headers to be self contained, as it overall leads to a clearer set of includes in source files. It's not obvious why entry.S needs lib.h unless the asm_macros.h usage is taken into account.
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
xen/arch/x86/x86_64/compat/entry.S +1
-2sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce)
Quoted 6 lines
Quoted 3 lines
It's my understanding that here the '.L' prefix is pointless, since
LABEL_LOCAL()will forcefully create a symbol for the label due to the usage of .type?I don't think .type has this effect. There's certainly no such label in the symbol table of the object file I have as a result.
I was expecting .type to force the creation of a symbol, so the '.L' prefix does prevent the symbol from being created even if .type is specified.
Shouldn't the assembler complain that we are attempting to set a type for a not present symbol?
Thanks, Roger.
Re: [PATCH v2 1/2] x86: annotate entry points with type and size
Quoted 17 lines · Roger Pau Monné
Quoted 16 lines · Jan Beulich
Quoted 14 lines · Roger Pau Monné
Quoted 7 lines · Jan Beulich
Note that the FB-label in
autogen_stubs()cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid settingSTT_NOTYPEexplicitly (that's the type labels get by default anyway).Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.FWIW, as I'm looking into using the newly added macros in order to add annotations suitable for live-patching, I would need to switch some of the LABEL usages into it's own functions, as it's not possible to livepatch a function that has labels jumped into from code paths outside of the function.
Quoted 5 lines
Quoted 2 lines
Hmm, I'm not sure what the best way is to overcome that restriction. I'm not convinced we want to arbitrarily name things "functions".
Any external entry point in the middle of a function-like block will prevent it from being live patched.
Is there actually any particular reason for this restriction? As long as old and new code has the same external entry points, redirecting all old ones to their new counterparts would seem feasible.
Quoted 3 lines
If you want I can try to do a pass on top of your patch and see how that would end up looking. I'm attempting to think about other solutions, but every other solution seems quite horrible.
Right, but splitting functions into piecemeal fragments isn't going to be very nice either.
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 87
Quoted 10 lines
xen/arch/x86/include/asm/asm_defns.h +4
-0@@ -81,6 +81,45 @@ register unsigned long current_stack_poi#ifdef __ASSEMBLY__ +#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak nameWon't this better be added when required? I can't spot any weak symbols in assembly ATM, and you don't introduce any
_WEAKmacro variants below.
Quoted 7 lines
Quoted 5 lines
Well, Andrew specifically mentioned to desire to also have Linux'es support for weak symbols. Hence I decided to add it here despite (for now) being unused). I can certainly drop that again, but in particular if we wanted to use the scheme globally, I think we may want to make it "complete".
OK, as long as we know it's unused.
I've added a sentence to this effect to the description.
Quoted 24 lines
Quoted 24 lines
Quoted 23 lines
Quoted 10 lines
xen/arch/x86/include/asm/asm_defns.h +10
-0+#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 107
Quoted 10 lines
xen/arch/x86/include/asm/asm_defns.h +10
-0+ name: + +#define END (name) .size name, . - name + +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) + +#define LAST__ (nr) ARG ## nr ## _ +#define LAST_ (nr) LAST__(nr) +#define LAST(x, y...) LAST_(count_args(x, ## y))(x, ## y)I find LAST not very descriptive, won't it better be named
OPTIONAL()or similar? (and maybe placed inlib.h?)
Quoted 7 lines
Quoted 4 lines
I don't think OPTIONAL describes the purpose. I truly mean "last" here. As to placing in
lib.h- perhaps, but then we may want to have forms with more than 2 arguments right away (and it would be a little unclear how far up to go).Hm, I would be fine with adding that version with just 2 arguments, as it's better to have the helper in a generic place IMO.
I'll think about this some more.
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 110
Quoted 3 lines
xen/arch/x86/include/asm/asm_defns.h +3
-0+ +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LAST(16, ## algn), 0x90)A rant, should the alignment of functions use a different padding? (ie: ret or ud2?) In order to prevent stray jumps falling in the padding and fall trough into the next function. That would also prevent the implicit fall trough used in some places.
Quoted 6 lines
Quoted 3 lines
Yes, but that's a separate topic (for which iirc patches are pending as well, just of course not integrated with the work here. There's the slight risk of overlooking some "fall-through" case ...
Oh, OK, wasn't aware patches are floating for this already, just came across it while reviewing.
Well, those don't cover padding yet, but they deal with straight-line speculation past RET or JMP.
Quoted 16 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h +1
-2sti call do_softirq jmp compat_test_all_events -ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce)Quoted 6 lines
Quoted 3 lines
It's my understanding that here the '.L' prefix is pointless, since
LABEL_LOCAL()will forcefully create a symbol for the label due to the usage of .type?I don't think .type has this effect. There's certainly no such label in the symbol table of the object file I have as a result.
Quoted 6 lines
I was expecting .type to force the creation of a symbol, so the '.L' prefix does prevent the symbol from being created even if .type is specified.
Shouldn't the assembler complain that we are attempting to set a type for a not present symbol?
But .L symbols are still normal symbols to gas, just that it knows to not emit them to the symbol table (unless there's a need, e.g. through a use in a relocation that cannot be expressed as section-relative one). It could flag the pointless use, but then it may get this wrong if in the end the symbol does need emitting.
Jan
Re: [PATCH v2 1/2] x86: annotate entry points with type and size
Quoted 21 lines · Jan Beulich
Quoted 20 lines · Roger Pau Monné
Quoted 18 lines · Jan Beulich
Quoted 6 lines · Roger Pau Monné
Quoted 5 lines · Jan Beulich
Note that the FB-label in
autogen_stubs()cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid settingSTT_NOTYPEexplicitly (that's the type labels get by default anyway).Quoted 8 lines
Quoted 2 lines
Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.FWIW, as I'm looking into using the newly added macros in order to add annotations suitable for live-patching, I would need to switch some of the LABEL usages into it's own functions, as it's not possible to livepatch a function that has labels jumped into from code paths outside of the function.
Hmm, I'm not sure what the best way is to overcome that restriction. I'm not convinced we want to arbitrarily name things "functions".
Quoted 6 lines
Quoted 2 lines
Any external entry point in the middle of a function-like block will prevent it from being live patched.
Is there actually any particular reason for this restriction? As long as old and new code has the same external entry points, redirecting all old ones to their new counterparts would seem feasible.
Yes, that was another option, we could force asm patching to always be done with a jump (instead of in-place) and then add jumps at the old entry point addresses in order to redirect to the new addresses.
Or assert that the addresses of any symbols inside the function is not changed in order to do in-place replacement of code.
Quoted 6 lines
Quoted 3 lines
If you want I can try to do a pass on top of your patch and see how that would end up looking. I'm attempting to think about other solutions, but every other solution seems quite horrible.
Right, but splitting functions into piecemeal fragments isn't going to be very nice either.
I'm not sure how much splitting would be required TBH.
Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
Quoted 8 lines
xen/arch/x86/include/asm/asm_defns.h register unsigned long current_stack_poi · line 110
Quoted 3 lines
xen/arch/x86/include/asm/asm_defns.h +3
-0+ +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LAST(16, ## algn), 0x90)A rant, should the alignment of functions use a different padding? (ie: ret or ud2?) In order to prevent stray jumps falling in the padding and fall trough into the next function. That would also prevent the implicit fall trough used in some places.
Yes, but that's a separate topic (for which iirc patches are pending as well, just of course not integrated with the work here. There's the slight risk of overlooking some "fall-through" case ...
Quoted 5 lines
Quoted 2 lines
Oh, OK, wasn't aware patches are floating for this already, just came across it while reviewing.
Well, those don't cover padding yet, but they deal with straight-line speculation past RET or JMP.
Introducing the helpers does make it easy to convert the padding for all the existing users at least.
Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
sti
calldo_softirq
jmpcompat_test_all_eventsxen/arch/x86/x86_64/compat/entry.S +1
-2- ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce)Quoted 6 lines
Quoted 3 lines
It's my understanding that here the '.L' prefix is pointless, since
LABEL_LOCAL()will forcefully create a symbol for the label due to the usage of .type?I don't think .type has this effect. There's certainly no such label in the symbol table of the object file I have as a result.
I was expecting .type to force the creation of a symbol, so the '.L' prefix does prevent the symbol from being created even if .type is specified.
Quoted 8 lines
Quoted 2 lines
Shouldn't the assembler complain that we are attempting to set a type for a not present symbol?
But .L symbols are still normal symbols to gas, just that it knows to not emit them to the symbol table (unless there's a need, e.g. through a use in a relocation that cannot be expressed as section-relative one). It could flag the pointless use, but then it may get this wrong if in the end the symbol does need emitting.
Thanks for the explanation.
Roger.
v3 cover annotate entry points with type and size
In reply to Jan BeulichThe model introduced in patch 2 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like).
1: common: move a few macros out of xen/lib.h 2: common: assembly entry point type/size annotations 3: x86: annotate entry points with type and size 4: x86: also mark assembler globals hidden
5: Arm: annotate entry points with type and size 6: RISC-V: annotate entry points with type and size 7: PPC: switch entry point annotations to common model 8: tools/binfile: switch to common annotations model
Jan
PATCH v3 1/8 common: move a few macros out of xen/lib.h
Introduce xen/macros.h for this purpose. For now xen/lib.h simply includes xen/macro.h, until consumers can be suitable cleaned up.
---
v3: New.
xen/include/xen/lib.h +1 -20
@@ -1,26 +1,7 @@#ifndef __LIB_H__#define __LIB_H__ -#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) - -#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) - -#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) -#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) - -#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) -#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) - -#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x -#define count_args(args...) \ - count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) - -/* Indirect macros required for expanded argument pasting. */ -#define PASTE_ (a, b) a ## b -#define PASTE (a, b) PASTE_(a, b) - -#define __STR (...) #__VA_ARGS__ -#define STR (...) __STR(__VA_ARGS__) +#include <xen/macros.h> #ifndef __ASSEMBLY__
xen/include/xen/macros.h new file +34 -0
@@ -0,0 +1,34 @@ +#ifndef __MACROS_H__ +#define __MACROS_H__ + +#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) + +#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) + +#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) +#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) + +#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) +#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) + +#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x +#define count_args(args...) \ + count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) + +/* Indirect macros required for expanded argument pasting. */ +#define PASTE_ (a, b) a ## b +#define PASTE (a, b) PASTE_(a, b) + +#define __STR (...) #__VA_ARGS__ +#define STR (...) __STR(__VA_ARGS__) + +#endif /* __MACROS_H__ */ + +/* +* Local variables: +* mode: C +* c-file-style: "BSD" +* c-basic-offset: 4 +* indent-tabs-mode: nil +* End: +*/
PATCH v3 2/8 common: assembly entry point type/size annotations
In reply to Jan BeulichRecent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v3: New, generalized from earlier x86-only version. LAST() (now
LASTARG()) moved to macros.h.
---
TBD: What to set CODE_ALIGN to by default? Or should we requires arch-es
to define that in all cases?
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch; conceivably it could mean to use some kind of arch default). We may not strictly need that, and hence we could also make these power-of -2 values (using .p2align).
Note that we can't use ALIGN() (in place of SYM_ALIGN()) as long as we still have ALIGN.
Note further that FUNC()'s etc "algn" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +56 -0
@@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif + +#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) + +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA_LOCAL(name, algn...) \ + SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) + +#endif /* __ASSEMBLY__ */ + +#endif /* __LINKAGE_H__ */
xen/include/xen/macros.h +9 -0
@@ -15,6 +15,15 @@ #define count_args(args...) \ count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) +#define ARG3_(x, y...) ARG2_(y) +#define ARG4_(x, y...) ARG3_(y) + +#define ARG__ (nr) ARG ## nr ## _ +#define ARG_ (nr) ARG__(nr) +#define LASTARG(x, y...) ARG_(count_args(x, ## y))(x, ## y) +/* Indirect macros required for expanded argument pasting. */ #define PASTE_ (a, b) a ## b#define PASTE (a, b) PASTE_(a, b)
PATCH v3 3/8 x86: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h.
For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for.
Except for the added/adjusted alignment padding (including their knock-on effects) no change in generated code/data. Note that the basis for support of weak definitions is added despite them not having any use right now.
Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway.
---
v3: !PV variant of ret_from_intr is local. Introduction of macros split
off to separate patch. Also adjust ASM_INT(). Re-base.
v2: Full rework.
---
Only two of the assembly files are being converted for now. More could be done right here or as follow-on in separate patches.
Note that the FB-label in autogen_stubs() cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid setting STT_NOTYPE explicitly (that's the type labels get by default anyway).
The ASM_INT() redundancy of .global will be eliminated by a subsequent patch.
I didn't think that I should make CODE_FILL evaluate to 0xCC right here; IMO that wants to be a separate patch.
xen/arch/x86/include/asm/asm_defns.h +2 -4
@@ -13,6 +13,7 @@#include <asm/alternative.h> #ifdef __ASSEMBLY__ +#include <xen/linkage.h> #include <asm/asm-defns.h> #ifndef CONFIG_INDIRECT_THUNK .equ CONFIG_INDIRECT_THUNK, 0
@@ -343,10 +344,7 @@ static always_inline void stac(void) .popsection#define ASM_INT (label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, @object + DATA(label, 4) .long (val); END(label)#define ASM_CONSTANT (name, value) \ asm ( ".equ " #name ", %P0; .global " #name \
xen/arch/x86/include/asm/config.h +3 -1
@@ -43,7 +43,9 @@/* Linkage for x86 */ #ifdef __ASSEMBLY__ -#define ALIGN .align 16,0x90 +#define CODE_ALIGN 16 +#define CODE_FILL 0x90 +#define ALIGN .align CODE_ALIGN, CODE_FILL#define ENTRY (name) \ .globl name; \ ALIGN; \
xen/arch/x86/x86_64/compat/entry.S +20 -16
@@ -11,7 +11,7 @@ #include <public/xen.h> #include <irq_vectors.h> -ENTRY(entry_int82) +FUNC(entry_int82) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0
@@ -27,9 +27,10 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +END(entry_int82) /* %rbx: struct vcpu */ -ENTRY(compat_test_all_events) +FUNC(compat_test_all_events) ASSERT_NOT_IN_ATOMIC cli # tests must not race interrupts /*compat_test_softirqs:*/
@@ -66,24 +67,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs) sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce) sti .Lcompat_bounce_exception: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_mce: +LABEL_LOCAL(compat_process_mce) testb $1 << VCPU_TRAP_MCE,VCPU_async_exception_mask(%rbx) jnz .Lcompat_test_guest_nmi sti
@@ -97,9 +95,8 @@ compat_process_mce: movb %dl,VCPU_async_exception_mask(%rbx) jmp compat_process_trap - ALIGN /* %rbx: struct vcpu */ -compat_process_nmi: +LABEL_LOCAL(compat_process_nmi) testb $1 << VCPU_TRAP_NMI,VCPU_async_exception_mask(%rbx) jnz compat_test_guest_events sti
@@ -116,9 +113,10 @@ compat_process_trap: leaq VCPU_trap_bounce(%rbx),%rdx call compat_create_bounce_frame jmp compat_test_all_events +END(compat_test_all_events) /* %rbx: struct vcpu, interrupts disabled */ -ENTRY(compat_restore_all_guest) +FUNC(compat_restore_all_guest) ASSERT_INTERRUPTS_DISABLED mov $~(X86_EFLAGS_IOPL | X86_EFLAGS_VM), %r11d and UREGS_eflags(%rsp),%r11d
@@ -161,9 +159,10 @@ ENTRY(compat_restore_all_guest) RESTORE_ALL adj=8 compat=1 .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +END(compat_restore_all_guest) /* This mustn't modify registers other than %rax. */ -ENTRY(cr4_pv32_restore) +FUNC(cr4_pv32_restore) push %rdx GET_CPUINFO_FIELD(cr4, dx) mov (%rdx), %rax
@@ -193,8 +192,9 @@ ENTRY(cr4_pv32_restore) pop %rdx xor %eax, %eax ret +END(cr4_pv32_restore) -ENTRY(compat_syscall) +FUNC(compat_syscall) /* Fix up reported %cs/%ss for compat domains. */ movl $FLAT_COMPAT_USER_SS, UREGS_ss(%rsp) movl $FLAT_COMPAT_USER_CS, UREGS_cs(%rsp)
@@ -222,8 +222,9 @@ UNLIKELY_END(compat_syscall_gpf) movw %si,TRAPBOUNCE_cs(%rdx) movb %cl,TRAPBOUNCE_flags(%rdx) jmp .Lcompat_bounce_exception +END(compat_syscall) -ENTRY(compat_sysenter) +FUNC(compat_sysenter) CR4_PV32_RESTORE movq VCPU_trap_ctxt(%rbx),%rcx cmpb $X86_EXC_GP, UREGS_entry_vector(%rsp)
@@ -236,17 +237,19 @@ ENTRY(compat_sysenter) movw %ax,TRAPBOUNCE_cs(%rdx) call compat_create_bounce_frame jmp compat_test_all_events +END(compat_sysenter) -ENTRY(compat_int80_direct_trap) +FUNC(compat_int80_direct_trap) CR4_PV32_RESTORE call compat_create_bounce_frame jmp compat_test_all_events +END(compat_int80_direct_trap) /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK: */ /* {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]} */ /* %rdx: trap_bounce, %rbx: struct vcpu */ /* On return only %rbx and %rdx are guaranteed non-clobbered. */ -compat_create_bounce_frame: +FUNC_LOCAL(compat_create_bounce_frame) ASSERT_INTERRUPTS_ENABLED mov %fs,%edi ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP
@@ -352,3 +355,4 @@ compat_crash_page_fault: jmp .Lft14 .previous _ASM_EXTABLE(.Lft14, .Lfx14) +END(compat_create_bounce_frame)
xen/arch/x86/x86_64/entry.S +76 -48
386 lines not on this page · raw message
PATCH v3 4/8 x86: also mark assembler globals hidden
In reply to Jan BeulichLet's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case.
---
v3: Re-base over generalization of the annotations.
v2: New.
xen/arch/x86/include/asm/config.h +2 -2
@@ -47,11 +47,11 @@#define CODE_FILL 0x90#define ALIGN .align CODE_ALIGN, CODE_FILL#define ENTRY (name) \ - .globl name; \ ALIGN; \ - name: + GLOBAL(name)#define GLOBAL (name) \ .globl name; \ + .hidden name; \ name:#endif
xen/include/xen/linkage.h +1 -1
@@ -21,7 +21,7 @@ #define SYM_ALIGN(algn...) .balign algn -#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
PATCH v3 5/8 Arm: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.
Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway.
---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.
The ASM_INT() redundancy of .global will be eliminated by a subsequent patch.
---
v3: New.
xen/arch/arm/arm32/lib/div64.S +2 -2
@@ -42,7 +42,7 @@ * Clobbered regs: xl, ip */ -ENTRY(__do_div64) +FUNC(__do_div64) UNWIND(.fnstart) @ Test for easy paths first.
@@ -206,4 +206,4 @@ Ldiv0_64: ldr pc, [sp], #8 UNWIND(.fnend) -ENDPROC(__do_div64) +END(__do_div64)
xen/arch/arm/arm64/lib/clear_page.S +2 -2
@@ -22,7 +22,7 @@ * Parameters: * x0 - dest */ -ENTRY(clear_page) +FUNC(clear_page) mrs x1, dczid_el0 and w1, w1, #0xf mov x2, #4
@@ -33,4 +33,4 @@ ENTRY(clear_page) tst x0, #(PAGE_SIZE - 1) b.ne 1b ret -ENDPROC(clear_page) +END(clear_page)
xen/arch/arm/include/asm/asm_defns.h +2 -4
@@ -5,6 +5,7 @@/* NB. Auto-generated from arch/.../asm-offsets.c */ #include <asm/asm-offsets.h> #endif +#include <xen/linkage.h> #include <asm/processor.h> /* Macros for generic assembly code */
@@ -28,10 +29,7 @@ label: .asciz msg; .popsection#define ASM_INT (label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, %object + DATA(label, 4) .long (val); END(label)#endif /* __ARM_ASM_DEFNS_H__ */ /*
xen/arch/arm/include/asm/config.h +2 -3
@@ -53,7 +53,8 @@/* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define CODE_ALIGN 4 +#define ALIGN .balign CODE_ALIGN#define ENTRY (name) \ .globl name; \ ALIGN; \
@@ -61,8 +62,6 @@#define GLOBAL (name) \ .globl name; \ name: -#define END (name) \ - .size name, .-name#define ENDPROC (name) \ .type name, %function; \ END(name)
PATCH v3 6/8 RISC-V: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size.
---
Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any better approach for checking whether a defined macro expands to nothing.
---
v3: New.
xen/arch/riscv/entry.S +2 -1
@@ -5,7 +5,7 @@ #include <asm/traps.h> /* WIP: only works while interrupting Xen context */ -ENTRY(handle_trap) +FUNC(handle_trap) /* Exceptions from xen */ save_to_stack:
@@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp) sret +END(handle_trap)
xen/arch/riscv/include/asm/asm.h +1 -0
@@ -7,6 +7,7 @@#define _ASM_RISCV_ASM_H#ifdef __ASSEMBLY__ +#include <xen/linkage.h> #define __ASM_STR (x) x#else #define __ASM_STR (x) #x
xen/arch/riscv/include/asm/config.h +2 -6
@@ -67,12 +67,8 @@/* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 4 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif #ifdef CONFIG_RISCV_64
xen/arch/riscv/riscv64/head.S +4 -3
@@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */ csrw CSR_SIE, zero
@@ -30,13 +30,14 @@ ENTRY(start) jal reset_stack tail start_xen +END(start) .section .text, "ax", %progbits -ENTRY(reset_stack) +FUNC(reset_stack) la sp, cpu0_boot_stack li t0, STACK_SIZE add sp, sp, t0 ret - +END(reset_stack)
xen/include/xen/linkage.h +15 -4
@@ -37,17 +37,28 @@#define END (name) .size name, . - name +/* +* CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in +* which case we also need to get rid of the comma in the .balign directive. +*/ +#define count_args_exp(args...) count_args(args) +#if count_args_exp (CODE_FILL ) +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn), CODE_FILL +#else +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn) +#endif + #define FUNC(name, algn...) \ - SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ - SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn)) #define DATA(name, algn...) \ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ - SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ - SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn)) #define DATA_LOCAL(name, algn...) \ SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
PATCH v3 7/8 PPC: switch entry point annotations to common model
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except of course the converted symbol changes to be a hidden one.
---
v3: New.
xen/arch/ppc/include/asm/config.h +1 -6
@@ -31,12 +31,7 @@/* Linkage for PPC */ #ifdef __ASSEMBLY__ -#define ALIGN .p2align 2 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 4#endif #define XEN_VIRT_START _AT(UL, 0x400000)
xen/arch/ppc/ppc64/head.S +4 -4
@@ -1,8 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <xen/linkage.h> + .section .text.header, "ax", %progbits -ENTRY(start) +FUNC(start) /* * Depending on how we were booted, the CPU could be running in either * Little Endian or Big Endian mode. The following trampoline from Linux
@@ -25,6 +27,4 @@ ENTRY(start) /* Now that the endianness is confirmed, continue */ 1: b 1b - - .size start, . - start - .type start, %function +END(start)
PATCH v3 8/8 tools/binfile: switch to common annotations model
In reply to Jan BeulichUse DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding.
---
v3: New.
xen/tools/binfile +2 -7
@@ -29,15 +29,10 @@ cat <<EOF >$target .section $section.rodata, "a", %progbits - .p2align $align - .global $varname -$varname: +DATA($varname, 1 << $align) .incbin "$binsource" .Lend: +END($varname) - .type $varname, %object - .size $varname, .Lend - $varname - - .global ${varname}_size ASM_INT(${varname}_size, .Lend - $varname) EOF
Re: [PATCH v3 6/8] RISC-V: annotate entry points with type and size
In reply to Jan BeulichQuoted 5 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size.Signed-off-by Jan Beulich <[email protected]>
I'm sorry, the Cc list was incomplete here. Adding back the remaining REST maintainers.
Jan
Quoted 115 lines
---
Probablycount_args_exp()should move tomacros.h, but I first wanted to see whether anyone can suggest any better approach for checking whether a defined macro expands to nothing.
---
v3: New.xen/arch/riscv/entry.S +2
-1@@ -5,7 +5,7 @@ #include <asm/traps.h> /* WIP: only works while interrupting Xen context */ -ENTRY(handle_trap) +FUNC(handle_trap) /* Exceptions from xen */ save_to_stack:@@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp) sret +END(handle_trap)xen/arch/riscv/include/asm/asm.h +1
-0@@ -7,6 +7,7 @@#define _ASM_RISCV_ASM_H#ifdef __ASSEMBLY__ +#include <xen/linkage.h> #define __ASM_STR (x) x#else #define __ASM_STR (x) #xxen/arch/riscv/include/asm/config.h +2
-6@@ -67,12 +67,8 @@/* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 4 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif #ifdef CONFIG_RISCV_64 xen/arch/riscv/riscv64/head.S +4
-3@@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */ csrw CSR_SIE, zero@@ -30,13 +30,14 @@ ENTRY(start) jal reset_stack tail start_xen +END(start) .section .text, "ax", %progbits -ENTRY(reset_stack) +FUNC(reset_stack) la sp, cpu0_boot_stack li t0, STACK_SIZE add sp, sp, t0 ret - +END(reset_stack)xen/include/xen/linkage.h +15
-4@@ -37,17 +37,28 @@#define END (name) .size name, . - name +/* +* CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in +* which case we also need to get rid of the comma in the .balign directive. +*/ +#define count_args_exp(args...) count_args(args) +#if count_args_exp (CODE_FILL ) +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn), CODE_FILL +#else +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn) +#endif + #define FUNC(name, algn...) \ - SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ - SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn)) #define DATA(name, algn...) \ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ - SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ - SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn)) #define DATA_LOCAL(name, algn...) \ SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
Re: [PATCH v3 2/8] common: assembly entry point type/size annotations
In reply to Jan BeulichQuoted 7 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.Signed-off-by Jan Beulich <[email protected]>
Looking over my action items from Prague I notice that I forgot one aspect here that was asked for by Andrew: To have the new framework also respect CONFIG_CC_SPLIT_SECTIONS. I'll work on that next, but perhaps better as in incremental patch on top.
Jan
[PATCH v3 9/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichLeverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
RFC: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
Note that we'd need to split DATA() in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Hence perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
xen/Makefile +3 -0
@@ -399,6 +399,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/xen.lds.S +3 -0
@@ -154,6 +154,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -106,6 +106,9 @@ SECTIONS DECL_SECTION(.init.text) { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -92,6 +92,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/xen.lds.S +6 -0
@@ -86,6 +86,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -214,6 +217,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -21,6 +21,14 @@ #define SYM_ALIGN(algn...) .balign algn +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -35,7 +43,14 @@SYM_ALIGN (algn); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -49,6 +64,7 @@#endif #define FUNC(name, algn...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn))
@@ -56,6 +72,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn))
Re: [PATCH v3 9/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Quoted 5 lines · Jan Beulich
Leverage the new infrastructure in
xen/linkage.hto also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the timeFUNC()is invoked.Signed-off-by Jan Beulich <[email protected]>
This additional change
Config.mk +1 -1
@@ -115,7 +115,7 @@ cc-option = $(shell if test -z "`echo 'v # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
is needed for ...
xen/Makefile AFLAGS += -D__ASSEMBLY__ · line 403
Quoted 8 lines
xen/Makefile +2
-0@@ -399,6 +399,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST)
... the pair of options passed in one go here to work (when old gas is in use). Of course something with the same overall effect, but less impactful might do. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). Thoughts anyone?
Jan
Re: [PATCH v3 1/8] common: move a few macros out of xen/lib.h
In reply to Jan BeulichQuoted 65 lines · Jan Beulich
Introduce
xen/macros.hfor this purpose. For nowxen/lib.hsimply includesxen/macro.h, until consumers can be suitable cleaned up.Signed-off-by Jan Beulich <[email protected]>---
v3: New.xen/include/xen/lib.h +0
-0@@ -1,26 +1,7 @@ #ifndef __LIB_H__ #define __LIB_H__xen/include/xen/lib.h +1
-20-#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) - -#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) - -#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) -#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) - -#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) -#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) - -#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x -#define count_args(args...) \ - count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) - -/* Indirect macros required for expanded argument pasting. */ -#define PASTE_ (a, b) a ## b -#define PASTE (a, b) PASTE_(a, b) - -#define __STR (...) #__VA_ARGS__ -#define STR (...) __STR(__VA_ARGS__) +#include <xen/macros.h>
#ifndef__ASSEMBLY__xen/include/xen/macros.h new file +24
-0@@ -0,0 +1,34 @@ +#ifndef __MACROS_H__ +#define __MACROS_H__ + +#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) + +#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) + +#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) +#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) + +#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) +#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) + +#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x +#define count_args(args...) \ + count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) + +/* Indirect macros required for expanded argument pasting. */ +#define PASTE_ (a, b) a ## b +#define PASTE (a, b) PASTE_(a, b) + +#define __STR (...) #__VA_ARGS__ +#define STR (...) __STR(__VA_ARGS__) +
xen/include/xen/macros.h line 34
Quoted 10 lines
xen/include/xen/macros.h new file +10
-0+#endif /* __MACROS_H__ */ + +/* +* Local variables: +* mode: C +* c-file-style: "BSD" +* c-basic-offset: 4 +* indent-tabs-mode: nil +* End: +*/
~ Oleksii
Re: [PATCH v3 1/8] common: move a few macros out of xen/lib.h
In reply to Jan Beulichxen/include/xen/macros.h
Quoted 40 lines · Jan Beulich
Introduce
xen/macros.hfor this purpose. For nowxen/lib.hsimply includesxen/macro.h, until consumers can be suitable cleaned up.Signed-off-by Jan Beulich <[email protected]>---
v3: New.xen/include/xen/lib.h +1
-20@@ -1,26 +1,7 @@#ifndef __LIB_H__#define __LIB_H__ -#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) - -#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) - -#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) -#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) - -#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) -#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) - -#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x -#define count_args(args...) \ - count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) - -/* Indirect macros required for expanded argument pasting. */ -#define PASTE_ (a, b) a ## b -#define PASTE (a, b) PASTE_(a, b) - -#define __STR (...) #__VA_ARGS__ -#define STR (...) __STR(__VA_ARGS__) +#include <xen/macros.h> #ifndef __ASSEMBLY__xen/include/xen/macros.h new file +0
-0@@ -0,0 +1,34 @@
Should there be an SPDX header here?
Quoted 24 lines
xen/include/xen/macros.h new file +24
-0+#ifndef __MACROS_H__ +#define __MACROS_H__ + +#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) + +#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) + +#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) +#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) + +#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) +#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) + +#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x +#define count_args(args...) \ + count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) + +/* Indirect macros required for expanded argument pasting. */ +#define PASTE_ (a, b) a ## b +#define PASTE (a, b) PASTE_(a, b) + +#define __STR (...) #__VA_ARGS__ +#define STR (...) __STR(__VA_ARGS__) +
xen/include/xen/macros.h line 34
Quoted 10 lines
xen/include/xen/macros.h new file +10
-0+#endif /* __MACROS_H__ */ + +/* +* Local variables: +* mode: C +* c-file-style: "BSD" +* c-basic-offset: 4 +* indent-tabs-mode: nil +* End: +*/
Re: [PATCH v3 1/8] common: move a few macros out of xen/lib.h
Quoted 6 lines · Shawn Anastasio
xen/include/xen/macros.h
Quoted 3 lines · Jan Beulich
xen/include/xen/macros.h new file +0
-0@@ -0,0 +1,34 @@Should there be an SPDX header here?
Probably, but I wouldn't know which version to use, since lib.h doesn't have one either. Not putting one there leaves things a clear or vague as they are for others without the tag (and without a full license header); putting one there would firmly state something, which then may be wrong. Therefore I think this will need sorting in (more or less) one go for all of the "license-free" source files.
Quoted 28 lines
Quoted 28 lines
xen/include/xen/macros.h new file +28
-0+#ifndef __MACROS_H__ +#define __MACROS_H__ + +#define ROUNDUP (x, a) (((x) + (a) - 1) & ~((a) - 1)) + +#define IS_ALIGNED (val, align) (!((val) & ((align) - 1))) + +#define DIV_ROUND (n, d) (((n) + (d) / 2) / (d)) +#define DIV_ROUND_UP (n, d) (((n) + (d) - 1) / (d)) + +#define MASK_EXTR (v, m) (((v) & (m)) / ((m) & -(m))) +#define MASK_INSR (v, m) (((v) * ((m) & -(m))) & (m)) + +#define count_args_ (dot, a1, a2, a3, a4, a5, a6, a7, a8, x, ...) x +#define count_args(args...) \ + count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) + +/* Indirect macros required for expanded argument pasting. */ +#define PASTE_ (a, b) a ## b +#define PASTE (a, b) PASTE_(a, b) + +#define __STR (...) #__VA_ARGS__ +#define STR (...) __STR(__VA_ARGS__) + +#endif /* __MACROS_H__ */ + +/* +* Local variables:
Quoted 8 lines
xen/include/xen/macros.h line 34
Quoted 6 lines
xen/include/xen/macros.h new file +6
-0+* mode: C +* c-file-style: "BSD" +* c-basic-offset: 4 +* indent-tabs-mode: nil +* End: +*/ Reviewed-by Shawn Anastasio <[email protected]>
Thanks.
Jan
Re: [PATCH v3 6/8] RISC-V: annotate entry points with type and size
In reply to Jan BeulichQuoted 7 lines · Jan Beulich
Quoted 6 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code
except of course the converted symbols change to be hidden ones and gain
a valid size.
Quoted 14 lines
Quoted 1 line
Signed-off-by Jan Beulich <[email protected]>I'm sorry, the Cc list was incomplete here. Adding back the remaining REST
maintainers.Jan
Quoted 6 lines
---
Probablycount_args_exp()should move tomacros.h, but I first wanted to
see whether anyone can suggest any better approach for checking whether
a defined macro expands to nothing.
What about introduction of conditional macros ?
Something similar to:
#include <stdio.h>
#define CONDITIONAL_RETURN(arg1, arg2) CONDITIONAL_RETURN_IMPL(arg1, arg2, EMPTY)
#define EMPTY(...) ""
#define CONDITIONAL_RETURN_IMPL(arg1, arg2, empty_check) \
CONDITIONAL_RETURN_##empty_check(arg1, arg2)
#define CONDITIONAL_RETURN_EMPTY(arg1, arg2) \
CONDITIONAL_RETURN_ARG1(arg1, arg2)
#define CONDITIONAL_RETURN_ARG1(arg1, arg2) arg1, arg2
#define CONDITIONAL_RETURN_ARG2(arg1, arg2) arg1
int main() {
int a = 42;
const char* b = "hello";
// Second argument is not empty, both arguments are returned
printf("Case 1: %d, %s\n", CONDITIONAL_RETURN(a, b)); // Prints:Case 1: 42, hello
// Second argument is empty, only the first argument is returned
printf("Case 2: %d, %s\n", CONDITIONAL_RETURN(a, "")); // Prints:Case 2: 42,
return 0; }
and then define DO_CODE_ALIGN using CONDITIONAL_RETURN?
~ Oleksii
Quoted 118 lines
Quoted 118 lines
---
v3: New.xen/arch/riscv/entry.S +0
-0@@ -5,7 +5,7 @@ #include <asm/traps.h>
/* WIP: only works while interrupting Xen context */xen/arch/riscv/entry.S +1
-1-ENTRY(handle_trap) +FUNC(handle_trap)
/* Exceptions from xen */
save_to_stack:xen/arch/riscv/entry.S +0
-0@@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp)
sretxen/arch/riscv/entry.S +1
-0+END(handle_trap)xen/arch/riscv/include/asm/asm.h +0
-0@@ -7,6 +7,7 @@ #define _ASM_RISCV_ASM_H
#ifdef__ASSEMBLY__
+#include <xen/linkage.h>
#define __ASM_STR(x) x
#else
#define __ASM_STR(x) #xxen/arch/riscv/include/asm/config.h +0
-0@@ -67,12 +67,8 @@
/* Linkage for RISCV */
#ifdef__ASSEMBLY__xen/arch/riscv/include/asm/config.h +2
-6-#define ALIGN .align 4 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif
#ifdefCONFIG_RISCV_64xen/arch/riscv/riscv64/head.S +1
-1@@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */csrw
CSR_SIE, zeroxen/arch/riscv/riscv64/head.S +0
-0@@ -30,13 +30,14 @@ ENTRY(start)jal
reset_stack
tailstart_xen
+END(start)
.section .text, "ax", %progbitsxen/arch/riscv/riscv64/head.S +1
-1-ENTRY(reset_stack) +FUNC(reset_stack)la sp,
cpu0_boot_stack
li t0,STACK_SIZE
add sp, sp, t0
retxen/arch/riscv/riscv64/head.S +1
-1- +END(reset_stack)xen/include/xen/linkage.h +0
-0@@ -37,17 +37,28 @@
#define END(name) .size name, . - name
+/*
+ *CODE_FILLin particular may need to expand to nothing (e.g. for RISC-V), in
+ * which case we also need to get rid of the comma in the .balign directive.
+ */xen/include/xen/linkage.h +3
-0+#define count_args_exp(args...) count_args(args) +#if count_args_exp (CODE_FILL ) +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn),
CODE_FILLxen/include/xen/linkage.h +4
-0+#else +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn) +#endif +#define
FUNC(name, algn...)\
-SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL)
+SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn))#defineLABEL(name, algn...)\
-SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL)
+SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn))#defineDATA(name, algn...)\
SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
#defineFUNC_LOCAL(name, algn...)\
-SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL)
+SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn))#defineLABEL_LOCAL(name, algn...)\
-SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL)
+SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn))#defineDATA_LOCAL(name, algn...)\
SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
Re: [PATCH v3 6/8] RISC-V: annotate entry points with type and size
Quoted 34 lines · Oleksii
Quoted 7 lines · Jan Beulich
Quoted 6 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code
except of course the converted symbols change to be hidden ones and gain
a valid size.Quoted 14 lines
Quoted 1 line
Signed-off-by Jan Beulich <[email protected]>I'm sorry, the Cc list was incomplete here. Adding back the remaining REST
maintainers.Jan
Quoted 6 lines
---
Probablycount_args_exp()should move tomacros.h, but I first wanted to
see whether anyone can suggest any better approach for checking whether
a defined macro expands to nothing.What about introduction of conditional macros ?
Something similar to:
#include <stdio.h>#define
CONDITIONAL_RETURN(arg1, arg2)CONDITIONAL_RETURN_IMPL(arg1, arg2, EMPTY)#define EMPTY(...) ""
#define
CONDITIONAL_RETURN_IMPL(arg1, arg2, empty_check)\
CONDITIONAL_RETURN_##empty_check(arg1, arg2)
Quoted 6 lines
#define
CONDITIONAL_RETURN_EMPTY(arg1, arg2)\
CONDITIONAL_RETURN_ARG1(arg1, arg2)#define
CONDITIONAL_RETURN_ARG1(arg1, arg2)arg1, arg2#define
CONDITIONAL_RETURN_ARG2(arg1, arg2)arg1
I don't see how this would be used in your scheme. It ...
Quoted 11 lines
int main() { int a = 42; const char* b = "hello"; // Second argument is not empty, both arguments are returned printf("Case 1: %d, %s\n", CONDITIONAL_RETURN(a, b)); // Prints:Case 1: 42, hello
// Second argument is empty, only the first argument is returned printf("Case 2: %d, %s\n", CONDITIONAL_RETURN(a, "")); // Prints:Case 2: 42,
... certainly isn't here, or this likely would cause at least a warning from the compiler (for there being too few arguments to printf()) and then a runtime UB for interpreting something as a pointer to a string which likely isn't.
Quoted 4 lines
return 0; }and then define
DO_CODE_ALIGNusingCONDITIONAL_RETURN?
Afaict instead of getting rid of the comma, you'd actually add "" after it. What am I missing?
Jan
Re: [PATCH v3 6/8] RISC-V: annotate entry points with type and size
Quoted 69 lines · Jan Beulich
Quoted 38 lines · Oleksii
Quoted 9 lines · Jan Beulich
Quoted 8 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated
code
except of course the converted symbols change to be hidden ones and
gain
a valid size.Quoted 15 lines
Quoted 1 line
Signed-off-by Jan Beulich <[email protected]>I'm sorry, the Cc list was incomplete here. Adding back the remaining
REST
maintainers.Jan
Quoted 6 lines
---
Probablycount_args_exp()should move tomacros.h, but I first wanted to
see whether anyone can suggest any better approach for checking whether
a defined macro expands to nothing.What about introduction of conditional macros ?
Something similar to:
#include <stdio.h>#define
CONDITIONAL_RETURN(arg1, arg2)
CONDITIONAL_RETURN_IMPL(arg1,
arg2, EMPTY)#define EMPTY(...) ""
#define
CONDITIONAL_RETURN_IMPL(arg1, arg2, empty_check)\
CONDITIONAL_RETURN_##empty_check(arg1, arg2)Quoted 6 lines
#define
CONDITIONAL_RETURN_EMPTY(arg1, arg2)\
CONDITIONAL_RETURN_ARG1(arg1, arg2)#define
CONDITIONAL_RETURN_ARG1(arg1, arg2)arg1, arg2#define
CONDITIONAL_RETURN_ARG2(arg1, arg2)arg1I don't see how this would be used in your scheme. It ...
Quoted 9 lines
int
main(){
int a = 42;
const char* b = "hello";// Second argument is not empty, both arguments are returned
printf("Case 1: %d, %s\n", CONDITIONAL_RETURN(a, b)); // Prints:
Case 1: 42, helloQuoted 5 lines
// Second argument is empty, only the first argument is returned
printf("Case 2: %d, %s\n", CONDITIONAL_RETURN(a, "")); // Prints:
Case 2: 42,... certainly isn't here, or this likely would cause at least a warning
from the compiler (for there being too few arguments toprintf()) and then a runtime UB for interpreting something as a pointer to a string which likely isn't.
Quoted 7 lines
Quoted 4 lines
return 0;
}and then define
DO_CODE_ALIGNusingCONDITIONAL_RETURN?Afaict instead of getting rid of the comma, you'd actually add "" after it. What am I missing?
You are right. I missed that actually it returns "".
~ Oleksii
v4 cover annotate entry points with type and size
In reply to Jan BeulichThe model introduced in patch 1 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like); PPC and RISC-V are still small enough to switch completely in one go.
1: common: assembly entry point type/size annotations
2: x86: annotate entry points with type and size
3: x86: also mark assembler globals hidden
4: Arm: annotate entry points with type and size
5: RISC-V: annotate entry points with type and size
6: PPC: switch entry point annotations to common model
7: tools/binfile: switch to common annotations model
8: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Jan
PATCH v4 1/8 common: assembly entry point type/size annotations
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v3: New, generalized from earlier x86-only version. LAST() (now
LASTARG()) moved to macros.h.
---
TBD: What to set CODE_ALIGN to by default? Or should we requires arch-es
to define that in all cases?
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch; conceivably it could mean to use some kind of arch default). We may not strictly need that, and hence we could also make these power-of -2 values (using .p2align).
Note that we can't use ALIGN() (in place of SYM_ALIGN()) as long as we still have ALIGN.
Note further that FUNC()'s etc "algn" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +56 -0
@@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif + +#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) + +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA_LOCAL(name, algn...) \ + SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) + +#endif /* __ASSEMBLY__ */ + +#endif /* __LINKAGE_H__ */
xen/include/xen/macros.h +9 -0
@@ -15,6 +15,15 @@ #define count_args(args...) \ count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) +#define ARG3_(x, y...) ARG2_(y) +#define ARG4_(x, y...) ARG3_(y) + +#define ARG__ (nr) ARG ## nr ## _ +#define ARG_ (nr) ARG__(nr) +#define LASTARG(x, y...) ARG_(count_args(x, ## y))(x, ## y) +/* Indirect macros required for expanded argument pasting. */ #define PASTE_ (a, b) a ## b#define PASTE (a, b) PASTE_(a, b)
PATCH v4 2/8 x86: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h.
For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for.
Except for the added/adjusted alignment padding (including their knock-on effects) no change in generated code/data. Note that the basis for support of weak definitions is added despite them not having any use right now.
Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway.
---
v4: Correct simd_coprocessor_error's (now entry_XM) END(). Re-base.
v3: !PV variant of ret_from_intr is local. Introduction of macros split
off to separate patch. Also adjust ASM_INT(). Re-base.
v2: Full rework.
---
Only two of the assembly files are being converted for now. More could be done right here or as follow-on in separate patches.
Note that the FB-label in autogen_stubs() cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid setting STT_NOTYPE explicitly (that's the type labels get by default anyway).
The ASM_INT() redundancy of .global will be eliminated by a subsequent patch.
I didn't think that I should make CODE_FILL evaluate to 0xCC right here; IMO that wants to be a separate patch.
xen/arch/x86/include/asm/asm_defns.h +2 -4
@@ -13,6 +13,7 @@#include <asm/alternative.h> #ifdef __ASSEMBLY__ +#include <xen/linkage.h> #include <asm/asm-defns.h> #ifndef CONFIG_INDIRECT_THUNK .equ CONFIG_INDIRECT_THUNK, 0
@@ -343,10 +344,7 @@ static always_inline void stac(void) .popsection#define ASM_INT (label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, @object + DATA(label, 4) .long (val); END(label)#define ASM_CONSTANT (name, value) \ asm ( ".equ " #name ", %P0; .global " #name \
xen/arch/x86/include/asm/config.h +3 -1
@@ -43,7 +43,9 @@/* Linkage for x86 */ #ifdef __ASSEMBLY__ -#define ALIGN .align 16,0x90 +#define CODE_ALIGN 16 +#define CODE_FILL 0x90 +#define ALIGN .align CODE_ALIGN, CODE_FILL#define ENTRY (name) \ .globl name; \ ALIGN; \
xen/arch/x86/x86_64/compat/entry.S +20 -16
@@ -11,7 +11,7 @@ #include <public/xen.h> #include <irq_vectors.h> -ENTRY(entry_int82) +FUNC(entry_int82) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0
@@ -27,9 +27,10 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +END(entry_int82) /* %rbx: struct vcpu */ -ENTRY(compat_test_all_events) +FUNC(compat_test_all_events) ASSERT_NOT_IN_ATOMIC cli # tests must not race interrupts /*compat_test_softirqs:*/
@@ -66,24 +67,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs) sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce) sti .Lcompat_bounce_exception: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_mce: +LABEL_LOCAL(compat_process_mce) testb $1 << VCPU_TRAP_MCE,VCPU_async_exception_mask(%rbx) jnz .Lcompat_test_guest_nmi sti
@@ -97,9 +95,8 @@ compat_process_mce: movb %dl,VCPU_async_exception_mask(%rbx) jmp compat_process_trap - ALIGN /* %rbx: struct vcpu */ -compat_process_nmi: +LABEL_LOCAL(compat_process_nmi) testb $1 << VCPU_TRAP_NMI,VCPU_async_exception_mask(%rbx) jnz compat_test_guest_events sti
@@ -116,9 +113,10 @@ compat_process_trap: leaq VCPU_trap_bounce(%rbx),%rdx call compat_create_bounce_frame jmp compat_test_all_events +END(compat_test_all_events) /* %rbx: struct vcpu, interrupts disabled */ -ENTRY(compat_restore_all_guest) +FUNC(compat_restore_all_guest) ASSERT_INTERRUPTS_DISABLED mov $~(X86_EFLAGS_IOPL | X86_EFLAGS_VM), %r11d and UREGS_eflags(%rsp),%r11d
@@ -161,9 +159,10 @@ ENTRY(compat_restore_all_guest) RESTORE_ALL adj=8 compat=1 .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +END(compat_restore_all_guest) /* This mustn't modify registers other than %rax. */ -ENTRY(cr4_pv32_restore) +FUNC(cr4_pv32_restore) push %rdx GET_CPUINFO_FIELD(cr4, dx) mov (%rdx), %rax
@@ -193,8 +192,9 @@ ENTRY(cr4_pv32_restore) pop %rdx xor %eax, %eax ret +END(cr4_pv32_restore) -ENTRY(compat_syscall) +FUNC(compat_syscall) /* Fix up reported %cs/%ss for compat domains. */ movl $FLAT_COMPAT_USER_SS, UREGS_ss(%rsp) movl $FLAT_COMPAT_USER_CS, UREGS_cs(%rsp)
@@ -222,8 +222,9 @@ UNLIKELY_END(compat_syscall_gpf) movw %si,TRAPBOUNCE_cs(%rdx) movb %cl,TRAPBOUNCE_flags(%rdx) jmp .Lcompat_bounce_exception +END(compat_syscall) -ENTRY(compat_sysenter) +FUNC(compat_sysenter) CR4_PV32_RESTORE movq VCPU_trap_ctxt(%rbx),%rcx cmpb $X86_EXC_GP, UREGS_entry_vector(%rsp)
@@ -236,17 +237,19 @@ ENTRY(compat_sysenter) movw %ax,TRAPBOUNCE_cs(%rdx) call compat_create_bounce_frame jmp compat_test_all_events +END(compat_sysenter) -ENTRY(compat_int80_direct_trap) +FUNC(compat_int80_direct_trap) CR4_PV32_RESTORE call compat_create_bounce_frame jmp compat_test_all_events +END(compat_int80_direct_trap) /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK: */ /* {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]} */ /* %rdx: trap_bounce, %rbx: struct vcpu */ /* On return only %rbx and %rdx are guaranteed non-clobbered. */ -compat_create_bounce_frame: +FUNC_LOCAL(compat_create_bounce_frame) ASSERT_INTERRUPTS_ENABLED mov %fs,%edi ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP
@@ -352,3 +355,4 @@ compat_crash_page_fault: jmp .Lft14 .previous _ASM_EXTABLE(.Lft14, .Lfx14) +END(compat_create_bounce_frame)
xen/arch/x86/x86_64/entry.S +76 -48
386 lines not on this page · raw message
PATCH v4 3/8 x86: also mark assembler globals hidden
In reply to Jan BeulichLet's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case.
---
v3: Re-base over generalization of the annotations.
v2: New.
xen/arch/x86/include/asm/config.h +2 -2
@@ -47,11 +47,11 @@#define CODE_FILL 0x90#define ALIGN .align CODE_ALIGN, CODE_FILL#define ENTRY (name) \ - .globl name; \ ALIGN; \ - name: + GLOBAL(name)#define GLOBAL (name) \ .globl name; \ + .hidden name; \ name:#endif
xen/include/xen/linkage.h +1 -1
@@ -21,7 +21,7 @@ #define SYM_ALIGN(algn...) .balign algn -#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
PATCH v4 4/8 Arm: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.
Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway.
---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.
The ASM_INT() redundancy of .global will be eliminated by a subsequent patch.
---
v3: New.
xen/arch/arm/arm32/lib/div64.S +2 -2
@@ -42,7 +42,7 @@ * Clobbered regs: xl, ip */ -ENTRY(__do_div64) +FUNC(__do_div64) UNWIND(.fnstart) @ Test for easy paths first.
@@ -206,4 +206,4 @@ Ldiv0_64: ldr pc, [sp], #8 UNWIND(.fnend) -ENDPROC(__do_div64) +END(__do_div64)
xen/arch/arm/arm64/lib/clear_page.S +2 -2
@@ -22,7 +22,7 @@ * Parameters: * x0 - dest */ -ENTRY(clear_page) +FUNC(clear_page) mrs x1, dczid_el0 and w1, w1, #0xf mov x2, #4
@@ -33,4 +33,4 @@ ENTRY(clear_page) tst x0, #(PAGE_SIZE - 1) b.ne 1b ret -ENDPROC(clear_page) +END(clear_page)
xen/arch/arm/include/asm/asm_defns.h +2 -4
@@ -5,6 +5,7 @@/* NB. Auto-generated from arch/.../asm-offsets.c */ #include <asm/asm-offsets.h> #endif +#include <xen/linkage.h> #include <asm/processor.h> /* Macros for generic assembly code */
@@ -28,10 +29,7 @@ label: .asciz msg; .popsection#define ASM_INT (label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, %object + DATA(label, 4) .long (val); END(label)#endif /* __ARM_ASM_DEFNS_H__ */ /*
xen/arch/arm/include/asm/config.h +2 -3
@@ -53,7 +53,8 @@/* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define CODE_ALIGN 4 +#define ALIGN .balign CODE_ALIGN#define ENTRY (name) \ .globl name; \ ALIGN; \
@@ -61,8 +62,6 @@#define GLOBAL (name) \ .globl name; \ name: -#define END (name) \ - .size name, .-name#define ENDPROC (name) \ .type name, %function; \ END(name)
PATCH v4 5/8 RISC-V: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size.
---
Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any better approach for checking whether a defined macro expands to nothing.
---
v4: Also drop #undef-s from linker script.
v3: New.
xen/arch/riscv/entry.S +2 -1
@@ -5,7 +5,7 @@ #include <asm/traps.h> /* WIP: only works while interrupting Xen context */ -ENTRY(handle_trap) +FUNC(handle_trap) /* Exceptions from xen */ save_to_stack:
@@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp) sret +END(handle_trap)
xen/arch/riscv/include/asm/asm.h +1 -0
@@ -7,6 +7,7 @@#define _ASM_RISCV_ASM_H#ifdef __ASSEMBLY__ +#include <xen/linkage.h> #define __ASM_STR (x) x#else #define __ASM_STR (x) #x
xen/arch/riscv/include/asm/config.h +2 -6
@@ -69,12 +69,8 @@/* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 4 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif #ifdef CONFIG_RISCV_64
xen/arch/riscv/riscv64/head.S +4 -3
@@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */ csrw CSR_SIE, zero
@@ -30,13 +30,14 @@ ENTRY(start) jal reset_stack tail start_xen +END(start) .section .text, "ax", %progbits -ENTRY(reset_stack) +FUNC(reset_stack) la sp, cpu0_boot_stack li t0, STACK_SIZE add sp, sp, t0 ret - +END(reset_stack)
xen/arch/riscv/xen.lds.S +0 -3
@@ -1,9 +1,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> -#undef ENTRY -#undef ALIGN - OUTPUT_ARCH(riscv) ENTRY(start)
xen/include/xen/linkage.h +15 -4
@@ -37,17 +37,28 @@#define END (name) .size name, . - name +/* +* CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in +* which case we also need to get rid of the comma in the .balign directive. +*/ +#define count_args_exp(args...) count_args(args) +#if count_args_exp (CODE_FILL ) +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn), CODE_FILL +#else +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn) +#endif + #define FUNC(name, algn...) \ - SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ - SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn)) #define DATA(name, algn...) \ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ - SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ - SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn)) #define DATA_LOCAL(name, algn...) \ SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
PATCH v4 5/8 PPC: switch entry point annotations to common model
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except of course the converted symbol changes to be a hidden one.
---
v4: Also drop #undef-s from linker script. Re-base.
v3: New.
xen/arch/ppc/include/asm/asm-defns.h +2 -0
@@ -2,6 +2,8 @@#ifndef _ASM_PPC_ASM_DEFNS_H#define _ASM_PPC_ASM_DEFNS_H +#include <xen/linkage.h> +/* * Load a 64-bit immediate value into the specified GPR. */
xen/arch/ppc/include/asm/config.h +1 -6
@@ -31,12 +31,7 @@/* Linkage for PPC */ #ifdef __ASSEMBLY__ -#define ALIGN .p2align 2 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 4#endif #define XEN_VIRT_START _AT(UL, 0xc000000000000000)
xen/arch/ppc/ppc64/head.S +2 -4
@@ -5,7 +5,7 @@ .section .text.header, "ax", %progbits -ENTRY(start) +FUNC(start) /* * NOTE: argument registers (r3-r9) must be preserved until the C entrypoint */
@@ -36,6 +36,4 @@ ENTRY(start) /* should never return */ trap - - .size start, . - start - .type start, %function +END(start)
xen/arch/ppc/ppc64/of-call.S +2 -4
@@ -23,7 +23,7 @@ .section .init.text, "ax", @progbits -ENTRY(enter_of) +FUNC(enter_of) mflr %r0 std %r0, 16(%r1) stdu %r1, -STACK_SWITCH_FRAME_SIZE(%r1) /* Save SP and create stack space */
@@ -78,6 +78,4 @@ ENTRY(enter_of) ld %r0, 16(%r1) mtlr %r0 blr - - .size enter_of, . - enter_of - .type enter_of, %function +END(enter_of)
xen/arch/ppc/xen.lds.S +0 -3
@@ -1,9 +1,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> -#undef ENTRY -#undef ALIGN - OUTPUT_ARCH(powerpc:common64) ENTRY(start)
PATCH v4 6/8 tools/binfile: switch to common annotations model
In reply to Jan BeulichUse DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding.
---
v3: New.
xen/tools/binfile +2 -7
@@ -29,15 +29,10 @@ cat <<EOF >$target .section $section.rodata, "a", %progbits - .p2align $align - .global $varname -$varname: +DATA($varname, 1 << $align) .incbin "$binsource" .Lend: +END($varname) - .type $varname, %object - .size $varname, .Lend - $varname - - .global ${varname}_size ASM_INT(${varname}_size, .Lend - $varname) EOF
PATCH v4 8/8 common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichLeverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3))
instead of $(firstword (3)).Note that we'd need to split DATA() in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
---
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).
Config.mk +1 -1
@@ -102,7 +102,7 @@ cc-option = $(shell if test -z "`echo 'v # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile +3 -0
@@ -407,6 +407,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/xen.lds.S +3 -0
@@ -154,6 +154,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -90,6 +90,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -89,6 +89,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/xen.lds.S +6 -0
@@ -86,6 +86,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -214,6 +217,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -21,6 +21,14 @@ #define SYM_ALIGN(algn...) .balign algn +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -35,7 +43,14 @@SYM_ALIGN (algn); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -49,6 +64,7 @@#endif #define FUNC(name, algn...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn))
@@ -56,6 +72,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn))
Re: [PATCH v4 0/8] annotate entry points with type and size
In reply to Jan BeulichQuoted 5 lines · Jan Beulich
The model introduced in patch 1 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like); PPC and RISC-V are still small enough to switch completely in one go.
Quoted 7 lines
1: common: assembly entry point type/size annotations 2: x86: annotate entry points with type and size 3: x86: also mark assembler globals hidden
4: Arm: annotate entry points with type and size 5: RISC-V: annotate entry points with type and size 6: PPC: switch entry point annotations to common model 7:tools/binfile: switch to common annotations model
I'm sorry, I notice I screwed up with the numbering of patches 6 and 7. I hope things are still clear enough.
Jan
Re: [PATCH v4 1/8] common: assembly entry point type/size annotations
In reply to Jan BeulichHi Jan,
Quoted 8 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.Signed-off-by Jan Beulich <[email protected]>
Quoted 7 lines
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v3: New, generalized from earlier x86-only version.LAST()(now
LASTARG()) moved tomacros.h.
---
TBD: What to setCODE_ALIGNto by default? Or should we requires arch-es
to define that in all cases?
The code alignment is very specific to an architecture. So I think it would be better if there are no default.
Otherwise, it will be more difficult for a developper to figure out that CODE_ALIGN may need an update.
Quoted 6 lines
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch; conceivably it could mean to use some kind of arch default). We may not strictly need that, and hence we could also make these power-of -2 values (using .p2align).
I don't have a strong opinion on this one.
Quoted 15 lines
Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.Note further that FUNC()'s etc "algn" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +3
-0@@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ +
xen/include/xen/linkage.h line 13
Quoted 10 lines
xen/include/xen/linkage.h new file +10
-0+#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif
What's the value to allow the architecture to override CODE_FILL and ...
xen/include/xen/linkage.h line 20
Quoted 7 lines
xen/include/xen/linkage.h new file +7
-0+ +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif
... DATA_FILL?
xen/include/xen/linkage.h line 22
Quoted 2 lines
xen/include/xen/linkage.h new file +2
-0+ +#define SYM_ALIGN(algn...) .balign algn
I find the name 'algn' confusing (not even referring to the missing 'i'). Why not naming it 'args'?
xen/include/xen/linkage.h line 30
Quoted 8 lines
xen/include/xen/linkage.h new file +8
-0+ +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE
SYM_* will be used only in SYM() below. So why not using STT_* directly?
Quoted 5 lines
xen/include/xen/linkage.h new file +5
-0+ +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \
xen/include/xen/linkage.h line 45
Quoted 10 lines
xen/include/xen/linkage.h new file +10
-0+ name: + +#define END (name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
I think the alignment should be explicit for DATA. Otherwise, at least on Arm, we would default to 0 which could lead to unaligned access if not careful.
xen/include/xen/linkage.h line 52
Quoted 7 lines
xen/include/xen/linkage.h new file +7
-0+ +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA_LOCAL(name, algn...) \ + SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)
Same here.
Quoted 13 lines
xen/include/xen/linkage.h new file +4
-0+ +#endif /* __ASSEMBLY__ */ + +#endif /* __LINKAGE_H__ */ xen/include/xen/macros.h +2
-0@@ -15,6 +15,15 @@ #define count_args(args...) \ count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y)
xen/include/xen/macros.h line 29
Quoted 10 lines
xen/include/xen/macros.h +7
-0+#define ARG3_(x, y...) ARG2_(y) +#define ARG4_(x, y...) ARG3_(y) + +#define ARG__ (nr) ARG ## nr ## _ +#define ARG_ (nr) ARG__(nr) +#define LASTARG(x, y...) ARG_(count_args(x, ## y))(x, ## y) +/* Indirect macros required for expanded argument pasting. */ #define PASTE_ (a, b) a ## b#define PASTE (a, b) PASTE_(a, b)
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v4 4/8] Arm: annotate entry points with type and size
In reply to Jan BeulichHi,
Quoted 9 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.Note that
ASM_INT()is switched toDATA(), notDATA_LOCAL(), as the only use site wants the symbol global anyway.Signed-off-by Jan Beulich <[email protected]>
Quoted 3 lines
---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.
I don't have a strong preference. Are you planning to do follow-up? (I am ok if it is no).
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v4 6/8] tools/binfile: switch to common annotations model
In reply to Jan BeulichHi Jan,
Quoted 5 lines · Jan Beulich
Use
DATA()/END()and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding.Signed-off-by Jan Beulich <[email protected]>
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v4 4/8] Arm: annotate entry points with type and size
In reply to Julien GrallQuoted 6 lines · Julien Grall
Quoted 5 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.
Quoted 6 lines
Quoted 4 lines
Note that
ASM_INT()is switched toDATA(), notDATA_LOCAL(), as the only use site wants the symbol global anyway.Signed-off-by Jan Beulich <[email protected]>Reviewed-by Julien Grall <[email protected]>
Thanks.
Quoted 6 lines
Quoted 3 lines
---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.I don't have a strong preference. Are you planning to do follow-up? (I am ok if it is no).
Well, I certainly can, but I wasn't expecting this series to remain pending for this long, so time's running out for 4.18.
Jan
Re: [PATCH v4 1/8] common: assembly entry point type/size annotations
In reply to Julien GrallQuoted 9 lines · Julien Grall
Quoted 2 lines · Jan Beulich
TBD: What to set
CODE_ALIGNto by default? Or should we requires arch-es
to define that in all cases?The code alignment is very specific to an architecture. So I think it would be better if there are no default.
Otherwise, it will be more difficult for a developper to figure out that
CODE_ALIGNmay need an update.
Okay, I've dropped the fallback then.
Quoted 10 lines
Quoted 10 lines
xen/include/xen/linkage.h new file +7
-0@@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> +
Quoted 8 lines
xen/include/xen/linkage.h line 13
Quoted 6 lines
xen/include/xen/linkage.h new file +6
-0+#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif What's the value to allow the architecture to override
CODE_FILLand ...
What is put between functions may be relevant to control. Without fall- through to a subsequent label, I think the intention is to use "int3" (0xcc) filler bytes, for example. (With fall-through to the subsequent label, NOPs would need using in any event.)
Quoted 9 lines
xen/include/xen/linkage.h line 20
Quoted 7 lines
xen/include/xen/linkage.h new file +7
-0+ +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif ...
DATA_FILL?
For data the need is probably less strict; still I could see one arch to prefer zero filling while another might better like all-ones-filling.
Quoted 5 lines
xen/include/xen/linkage.h line 22
Quoted 2 lines
xen/include/xen/linkage.h new file +2
-0+ +#define SYM_ALIGN(algn...) .balign algnI find the name 'algn' confusing (not even referring to the missing 'i'). Why not naming it 'args'?
I can name it "args", sure. It's just that "algn" is in line with the naming further down (where "args" isn't reasonable to use as substitution).
Quoted 9 lines
xen/include/xen/linkage.h line 30
Quoted 7 lines
xen/include/xen/linkage.h new file +7
-0+#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPESYM_* will be used only in
SYM()below. So why not using STT_* directly?
For one this is how the Linux original has it. And then to me DATA and NONE are neater to have at the use sites than the ELF-specific terms OBJECT and NOTYPE. But I'm willing to reconsider provided arguments towards the two given reasons not being overly relevant for us.
Quoted 11 lines
Quoted 11 lines
xen/include/xen/linkage.h new file +11
-0+ +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL)
Quoted 8 lines
xen/include/xen/linkage.h line 45
Quoted 4 lines
xen/include/xen/linkage.h new file +4
-0+#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)I think the alignment should be explicit for DATA. Otherwise, at least on Arm, we would default to 0 which could lead to unaligned access if not careful.
I disagree. Even for byte-granular data (like strings) it may be desirable to have some default alignment, without every use site needing to repeat that specific value.
Jan
Re: [PATCH v4 1/8] common: assembly entry point type/size annotations
Hi,
Quoted 32 lines · Jan Beulich
Quoted 9 lines · Julien Grall
Quoted 2 lines · Jan Beulich
TBD: What to set
CODE_ALIGNto by default? Or should we requires arch-es
to define that in all cases?The code alignment is very specific to an architecture. So I think it would be better if there are no default.
Otherwise, it will be more difficult for a developper to figure out that
CODE_ALIGNmay need an update.Okay, I've dropped the fallback then.
Quoted 10 lines
Quoted 10 lines
xen/include/xen/linkage.h new file +7
-0@@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> +Quoted 8 lines
xen/include/xen/linkage.h line 13
Quoted 6 lines
xen/include/xen/linkage.h new file +6
-0+#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif What's the value to allow the architecture to override
CODE_FILLand ...
Quoted 4 lines
What is put between functions may be relevant to control. Without fall- through to a subsequent label, I think the intention is to use "int3" (
0xcc) filler bytes, for example. (With fall-through to the subsequent label, NOPs would need using in any event.)
I guess for x86 it makes sense. For Arm, the filler is unlikely to be used as the instruction size is always fixed.
Quoted 11 lines
Quoted 10 lines
xen/include/xen/linkage.h line 20
Quoted 8 lines
xen/include/xen/linkage.h new file +7
-0+ +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif ...
DATA_FILL?
Quoted 2 lines
For data the need is probably less strict; still I could see one arch to prefer zero filling while another might better like all-ones-filling.
It is unclear to me why an architecture would prefer one over the other. Can you provide a bit more details?
Quoted 9 lines
Quoted 6 lines
xen/include/xen/linkage.h line 22
Quoted 3 lines
xen/include/xen/linkage.h new file +2
-0+ +#define SYM_ALIGN(algn...) .balign algnI find the name 'algn' confusing (not even referring to the missing 'i'). Why not naming it 'args'?
I can name it "args", sure. It's just that "algn" is in line with the naming further down (where "args" isn't reasonable to use as substitution).
If you want to be consistent then, I think it would be best to use 'align'. I think it should be fine as we don't seem to use '.align'.
Quoted 36 lines
Quoted 10 lines
xen/include/xen/linkage.h line 30
Quoted 8 lines
xen/include/xen/linkage.h new file +7
-0+#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPESYM_* will be used only in
SYM()below. So why not using STT_* directly?For one this is how the Linux original has it. And then to me DATA and NONE are neater to have at the use sites than the ELF-specific terms OBJECT and NOTYPE. But I'm willing to reconsider provided arguments towards the two given reasons not being overly relevant for us.
Quoted 11 lines
Quoted 11 lines
xen/include/xen/linkage.h new file +11
-0+ +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL)Quoted 8 lines
xen/include/xen/linkage.h line 45
Quoted 4 lines
xen/include/xen/linkage.h new file +4
-0+#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)I think the alignment should be explicit for DATA. Otherwise, at least on Arm, we would default to 0 which could lead to unaligned access if not careful.
Quoted 3 lines
I disagree. Even for byte-granular data (like strings) it may be desirable to have some default alignment, without every use site needing to repeat that specific value.
I understand that some cases may want to use a default alignment. But my concern is the developer may not realize that alignment is necessary. So by making it mandatory, it would at least prompt the developper to think whether this is needed.
For the string case, we could introduce a different macro.
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v4 1/8] common: assembly entry point type/size annotations
Quoted 67 lines · Julien Grall
Hi,
Quoted 32 lines · Jan Beulich
Quoted 9 lines · Julien Grall
Quoted 2 lines · Jan Beulich
TBD: What to set
CODE_ALIGNto by default? Or should we requires arch-es
to define that in all cases?The code alignment is very specific to an architecture. So I think it would be better if there are no default.
Otherwise, it will be more difficult for a developper to figure out that
CODE_ALIGNmay need an update.Okay, I've dropped the fallback then.
Quoted 10 lines
Quoted 10 lines
xen/include/xen/linkage.h new file +7
-0@@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> +Quoted 8 lines
xen/include/xen/linkage.h line 13
Quoted 6 lines
xen/include/xen/linkage.h new file +6
-0+#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif What's the value to allow the architecture to override
CODE_FILLand ...Quoted 4 lines
What is put between functions may be relevant to control. Without fall- through to a subsequent label, I think the intention is to use "int3" (
0xcc) filler bytes, for example. (With fall-through to the subsequent label, NOPs would need using in any event.)I guess for x86 it makes sense. For Arm, the filler is unlikely to be used as the instruction size is always fixed.
Quoted 11 lines
Quoted 10 lines
xen/include/xen/linkage.h line 20
Quoted 8 lines
xen/include/xen/linkage.h new file +7
-0+ +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif ...
DATA_FILL?Quoted 2 lines
For data the need is probably less strict; still I could see one arch to prefer zero filling while another might better like all-ones-filling.
It is unclear to me why an architecture would prefer one over the other. Can you provide a bit more details?
Quoted 7 lines
Quoted 6 lines
xen/include/xen/linkage.h line 22
Quoted 3 lines
xen/include/xen/linkage.h new file +2
-0+ +#define SYM_ALIGN(algn...) .balign algnI find the name 'algn' confusing (not even referring to the missing 'i'). Why not naming it 'args'?
Quoted 5 lines
Quoted 2 lines
I can name it "args", sure. It's just that "algn" is in line with the naming further down (where "args" isn't reasonable to use as substitution).
If you want to be consistent then, I think it would be best to use 'align'. I think it should be fine as we don't seem to use '.align'.
I think I had a conflict from this somewhere, but that may have been very early when I hadn't switched to .balign yet. I'll see if renaming works out.
Quoted 19 lines
Quoted 19 lines
Quoted 18 lines
Quoted 4 lines
xen/include/xen/linkage.h new file +4
-0+#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \xen/include/xen/linkage.h line 45
Quoted 10 lines
xen/include/xen/linkage.h new file +10
-0+ name: + +#define END (name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL)I think the alignment should be explicit for DATA. Otherwise, at least on Arm, we would default to 0 which could lead to unaligned access if not careful.
Quoted 8 lines
Quoted 3 lines
I disagree. Even for byte-granular data (like strings) it may be desirable to have some default alignment, without every use site needing to repeat that specific value.
I understand that some cases may want to use a default alignment. But my concern is the developer may not realize that alignment is necessary. So by making it mandatory, it would at least prompt the developper to think whether this is needed.
Forcing people to use a specific value every time, even when none would be needed. Anyway, if others think your way, then I can certainly change. But then I need to know whether others perhaps think alignment on functions (and maybe even labels) should also be explicit in all cases.
Quoted 1 line
For the string case, we could introduce a different macro.
Hmm, yet one more special thing then (for people to remember to use under certain circumstances).
Jan
v5 cover annotate entry points with type and size
In reply to Jan BeulichThe model introduced in patch 1 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like); PPC and RISC-V are still small enough to switch completely in one go.
1: common: assembly entry point type/size annotations
2: x86: annotate entry points with type and size
3: x86: also mark assembler globals hidden
4: Arm: annotate entry points with type and size
5: RISC-V: annotate entry points with type and size
6: PPC: switch entry point annotations to common model
7: tools/binfile: switch to common annotations model
8: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Jan
PATCH v5 1/8 common: assembly entry point type/size annotations
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v5: Drop CODE_ALIGN fallback. s/algn/align/g.
v3: New, generalized from earlier x86-only version. LAST() (now
LASTARG()) moved to macros.h.
---
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch;
conceivably it could mean to use some kind of arch default). We may
not strictly need that, and hence we could also make these power-
of-2 values (using .p2align).
Note that we can't use ALIGN() (in place of SYM_ALIGN()) as long as we still have ALIGN.
Note further that FUNC()'s etc "align" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +54 -0
@@ -0,0 +1,54 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +/* CODE_ALIGN needs to be specified by every architecture. */ +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif + +#define SYM_ALIGN(align...) .balign align + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, align...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(align); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, align...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define LABEL(name, align...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define DATA(name, align...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) + +#define FUNC_LOCAL(name, align...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define LABEL_LOCAL(name, align...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define DATA_LOCAL(name, align...) \ + SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) + +#endif /* __ASSEMBLY__ */ + +#endif /* __LINKAGE_H__ */
xen/include/xen/macros.h +9 -0
@@ -21,6 +21,15 @@ #define count_args(args...) \ count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) +#define ARG3_(x, y...) ARG2_(y) +#define ARG4_(x, y...) ARG3_(y) + +#define ARG__ (nr) ARG ## nr ## _ +#define ARG_ (nr) ARG__(nr) +#define LASTARG(x, y...) ARG_(count_args(x, ## y))(x, ## y) +/* Indirect macros required for expanded argument pasting. */ #define PASTE_ (a, b) a ## b#define PASTE (a, b) PASTE_(a, b)
PATCH v5 2/8 x86: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h.
For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for.
Except for the added/adjusted alignment padding (including their knock-on effects) no change in generated code/data. Note that the basis for support of weak definitions is added despite them not having any use right now.
Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway.
---
v5: Re-base.
v4: Correct simd_coprocessor_error's (now entry_XM) END(). Re-base.
v3: !PV variant of ret_from_intr is local. Introduction of macros split
off to separate patch. Also adjust ASM_INT(). Re-base.
v2: Full rework.
---
Only two of the assembly files are being converted for now. More could be done right here or as follow-on in separate patches.
Note that the FB-label in autogen_stubs() cannot be converted just yet:
Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid setting STT_NOTYPE explicitly (that's the type labels get by default anyway).
The ASM_INT() redundancy of .global will be eliminated by a subsequent patch.
I didn't think that I should make CODE_FILL evaluate to 0xCC right here; IMO that wants to be a separate patch.
xen/arch/x86/include/asm/asm_defns.h +2 -4
@@ -13,6 +13,7 @@#include <asm/alternative.h> #ifdef __ASSEMBLY__ +#include <xen/linkage.h> #include <asm/asm-defns.h> #ifndef CONFIG_INDIRECT_THUNK .equ CONFIG_INDIRECT_THUNK, 0
@@ -343,10 +344,7 @@ static always_inline void stac(void) .popsection#define ASM_INT (label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, @object + DATA(label, 4) .long (val); END(label)#define ASM_CONSTANT (name, value) \ asm ( ".equ " #name ", %P0; .global " #name \
xen/arch/x86/include/asm/config.h +3 -1
@@ -43,7 +43,9 @@/* Linkage for x86 */ #ifdef __ASSEMBLY__ -#define ALIGN .align 16,0x90 +#define CODE_ALIGN 16 +#define CODE_FILL 0x90 +#define ALIGN .align CODE_ALIGN, CODE_FILL#define ENTRY (name) \ .globl name; \ ALIGN; \
xen/arch/x86/x86_64/compat/entry.S +20 -16
@@ -11,7 +11,7 @@ #include <public/xen.h> #include <irq_vectors.h> -ENTRY(entry_int82) +FUNC(entry_int82) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0
@@ -29,9 +29,10 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +END(entry_int82) /* %rbx: struct vcpu */ -ENTRY(compat_test_all_events) +FUNC(compat_test_all_events) ASSERT_NOT_IN_ATOMIC cli # tests must not race interrupts /*compat_test_softirqs:*/
@@ -68,24 +69,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs) sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce) sti .Lcompat_bounce_exception: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_mce: +LABEL_LOCAL(compat_process_mce) testb $1 << VCPU_TRAP_MCE,VCPU_async_exception_mask(%rbx) jnz .Lcompat_test_guest_nmi sti
@@ -99,9 +97,8 @@ compat_process_mce: movb %dl,VCPU_async_exception_mask(%rbx) jmp compat_process_trap - ALIGN /* %rbx: struct vcpu */ -compat_process_nmi: +LABEL_LOCAL(compat_process_nmi) testb $1 << VCPU_TRAP_NMI,VCPU_async_exception_mask(%rbx) jnz compat_test_guest_events sti
@@ -118,9 +115,10 @@ compat_process_trap: leaq VCPU_trap_bounce(%rbx),%rdx call compat_create_bounce_frame jmp compat_test_all_events +END(compat_test_all_events) /* %rbx: struct vcpu, interrupts disabled */ -ENTRY(compat_restore_all_guest) +FUNC(compat_restore_all_guest) ASSERT_INTERRUPTS_DISABLED mov $~(X86_EFLAGS_IOPL | X86_EFLAGS_VM), %r11d and UREGS_eflags(%rsp),%r11d
@@ -163,9 +161,10 @@ ENTRY(compat_restore_all_guest) RESTORE_ALL adj=8 compat=1 .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +END(compat_restore_all_guest) /* This mustn't modify registers other than %rax. */ -ENTRY(cr4_pv32_restore) +FUNC(cr4_pv32_restore) push %rdx GET_CPUINFO_FIELD(cr4, dx) mov (%rdx), %rax
@@ -195,8 +194,9 @@ ENTRY(cr4_pv32_restore) pop %rdx xor %eax, %eax ret +END(cr4_pv32_restore) -ENTRY(compat_syscall) +FUNC(compat_syscall) /* Fix up reported %cs/%ss for compat domains. */ movl $FLAT_COMPAT_USER_SS, UREGS_ss(%rsp) movl $FLAT_COMPAT_USER_CS, UREGS_cs(%rsp)
@@ -224,8 +224,9 @@ UNLIKELY_END(compat_syscall_gpf) movw %si,TRAPBOUNCE_cs(%rdx) movb %cl,TRAPBOUNCE_flags(%rdx) jmp .Lcompat_bounce_exception +END(compat_syscall) -ENTRY(compat_sysenter) +FUNC(compat_sysenter) CR4_PV32_RESTORE movq VCPU_trap_ctxt(%rbx),%rcx cmpb $X86_EXC_GP, UREGS_entry_vector(%rsp)
@@ -238,17 +239,19 @@ ENTRY(compat_sysenter) movw %ax,TRAPBOUNCE_cs(%rdx) call compat_create_bounce_frame jmp compat_test_all_events +END(compat_sysenter) -ENTRY(compat_int80_direct_trap) +FUNC(compat_int80_direct_trap) CR4_PV32_RESTORE call compat_create_bounce_frame jmp compat_test_all_events +END(compat_int80_direct_trap) /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK: */ /* {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]} */ /* %rdx: trap_bounce, %rbx: struct vcpu */ /* On return only %rbx and %rdx are guaranteed non-clobbered. */ -compat_create_bounce_frame: +FUNC_LOCAL(compat_create_bounce_frame) ASSERT_INTERRUPTS_ENABLED mov %fs,%edi ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP
@@ -354,3 +357,4 @@ compat_crash_page_fault: jmp .Lft14 .previous _ASM_EXTABLE(.Lft14, .Lfx14) +END(compat_create_bounce_frame)
xen/arch/x86/x86_64/entry.S +76 -48
386 lines not on this page · raw message
PATCH v5 3/8 x86: also mark assembler globals hidden
In reply to Jan BeulichLet's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case.
---
v5: Re-base over changes earlier in the series.
v3: Re-base over generalization of the annotations.
v2: New.
xen/arch/x86/include/asm/config.h +2 -2
@@ -47,11 +47,11 @@#define CODE_FILL 0x90#define ALIGN .align CODE_ALIGN, CODE_FILL#define ENTRY (name) \ - .globl name; \ ALIGN; \ - name: + GLOBAL(name)#define GLOBAL (name) \ .globl name; \ + .hidden name; \ name:#endif
xen/include/xen/linkage.h +1 -1
@@ -19,7 +19,7 @@ #define SYM_ALIGN(align...) .balign align -#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
PATCH v5 4/8 Arm: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.
Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway.
---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.
The ASM_INT() redundancy of .global will be eliminated by a subsequent patch.
---
v3: New.
xen/arch/arm/arm32/lib/div64.S +2 -2
@@ -42,7 +42,7 @@ * Clobbered regs: xl, ip */ -ENTRY(__do_div64) +FUNC(__do_div64) UNWIND(.fnstart) @ Test for easy paths first.
@@ -206,4 +206,4 @@ Ldiv0_64: ldr pc, [sp], #8 UNWIND(.fnend) -ENDPROC(__do_div64) +END(__do_div64)
xen/arch/arm/arm64/lib/clear_page.S +2 -2
@@ -22,7 +22,7 @@ * Parameters: * x0 - dest */ -ENTRY(clear_page) +FUNC(clear_page) mrs x1, dczid_el0 and w1, w1, #0xf mov x2, #4
@@ -33,4 +33,4 @@ ENTRY(clear_page) tst x0, #(PAGE_SIZE - 1) b.ne 1b ret -ENDPROC(clear_page) +END(clear_page)
xen/arch/arm/include/asm/asm_defns.h +2 -4
@@ -5,6 +5,7 @@/* NB. Auto-generated from arch/.../asm-offsets.c */ #include <asm/asm-offsets.h> #endif +#include <xen/linkage.h> #include <asm/processor.h> /* Macros for generic assembly code */
@@ -30,10 +31,7 @@ label: .asciz msg;#define RODATA_STR (label, msg) RODATA_SECT(.rodata.str, label, msg)#define ASM_INT (label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, %object + DATA(label, 4) .long (val); END(label)#endif /* __ARM_ASM_DEFNS_H__ */ /*
xen/arch/arm/include/asm/config.h +2 -3
@@ -53,7 +53,8 @@/* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define CODE_ALIGN 4 +#define ALIGN .balign CODE_ALIGN#define ENTRY (name) \ .globl name; \ ALIGN; \
@@ -61,8 +62,6 @@#define GLOBAL (name) \ .globl name; \ name: -#define END (name) \ - .size name, .-name#define ENDPROC (name) \ .type name, %function; \ END(name)
PATCH v5 5/8 RISC-V: annotate entry points with type and size
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size.
---
Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any better approach for checking whether a defined macro expands to nothing.
---
v5: Re-base.
v4: Also drop #undef-s from linker script.
v3: New.
xen/arch/riscv/entry.S +2 -1
@@ -5,7 +5,7 @@ #include <asm/traps.h> /* WIP: only works while interrupting Xen context */ -ENTRY(handle_trap) +FUNC(handle_trap) /* Exceptions from xen */ save_to_stack:
@@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp) sret +END(handle_trap)
xen/arch/riscv/include/asm/asm.h +1 -0
@@ -7,6 +7,7 @@#define _ASM_RISCV_ASM_H#ifdef __ASSEMBLY__ +#include <xen/linkage.h> #define __ASM_STR (x) x#else #define __ASM_STR (x) #x
xen/arch/riscv/include/asm/config.h +2 -6
@@ -69,12 +69,8 @@/* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 4 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif #ifdef CONFIG_RISCV_64
xen/arch/riscv/riscv64/head.S +6 -3
@@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */ csrw CSR_SIE, zero
@@ -60,19 +60,21 @@ ENTRY(start) mv a1, s1 tail start_xen +END(start) .section .text, "ax", %progbits -ENTRY(reset_stack) +FUNC(reset_stack) la sp, cpu0_boot_stack li t0, STACK_SIZE add sp, sp, t0 ret +END(reset_stack) .section .text.ident, "ax", %progbits -ENTRY(turn_on_mmu) +FUNC(turn_on_mmu) sfence.vma li t0, RV_STAGE1_MODE
@@ -84,3 +86,4 @@ ENTRY(turn_on_mmu) csrw CSR_SATP, t1 jr a0 +END(turn_on_mmu)
xen/arch/riscv/xen.lds.S +0 -3
@@ -1,9 +1,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> -#undef ENTRY -#undef ALIGN - OUTPUT_ARCH(riscv) ENTRY(start)
xen/include/xen/linkage.h +15 -4
@@ -35,17 +35,28 @@#define END (name) .size name, . - name +/* +* CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in +* which case we also need to get rid of the comma in the .balign directive. +*/ +#define count_args_exp(args...) count_args(args) +#if count_args_exp (CODE_FILL ) +# define DO_CODE_ALIGN(align...) LASTARG(CODE_ALIGN, ## align), CODE_FILL +#else +# define DO_CODE_ALIGN(align...) LASTARG(CODE_ALIGN, ## align) +#endif + #define FUNC(name, align...) \ - SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) + SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align)) #define LABEL(name, align...) \ - SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) + SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align)) #define DATA(name, align...) \ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) #define FUNC_LOCAL(name, align...) \ - SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) + SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align)) #define LABEL_LOCAL(name, align...) \ - SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) + SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align)) #define DATA_LOCAL(name, align...) \ SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL)
PATCH v5 6/8 PPC: switch entry point annotations to common model
In reply to Jan BeulichUse the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones.
---
v5: Re-base.
v4: Also drop #undef-s from linker script. Re-base.
v3: New.
xen/arch/ppc/include/asm/asm-defns.h +1 -0
@@ -3,6 +3,7 @@#define _ASM_PPC_ASM_DEFNS_H#include <asm/asm-offsets.h> +#include <xen/linkage.h> /* * Load a 64-bit immediate value into the specified GPR.
xen/arch/ppc/include/asm/config.h +1 -6
@@ -32,12 +32,7 @@/* Linkage for PPC */ #ifdef __ASSEMBLY__ -#define ALIGN .p2align 2 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 4#endif #define XEN_VIRT_START _AC(0xc000000000000000, UL)
xen/arch/ppc/ppc64/exceptions-asm.S +6 -9
@@ -6,7 +6,7 @@ .section .text.exceptions, "ax", %progbits /* Helper to dump CPU state to struct cpu_user_regs pointed to by r1. */ -ENTRY(exception_common) +FUNC(exception_common) /* * Save GPRs 1-31. TODO: The value of %r1 has already been modified by the * ISR, so the value we save isn't the exact value we had on entry.
@@ -45,11 +45,10 @@ ENTRY(exception_common) stdu %r0, -STACK_FRAME_OVERHEAD(%r1) bl exception_handler - .size exception_common, . - exception_common - .type exception_common, %function + END(exception_common) /* Same as exception_common, but for exceptions that set HSRR{0,1} */ -ENTRY(h_exception_common) +FUNC(h_exception_common) /* * Save GPRs 1-31. TODO: The value of %r1 has already been modified by the * ISR, so the value we save isn't the exact value we had on entry.
@@ -89,15 +88,14 @@ ENTRY(h_exception_common) stdu %r0, -STACK_FRAME_OVERHEAD(%r1) bl exception_handler - .size h_exception_common, . - h_exception_common - .type h_exception_common, %function + END(h_exception_common) /* * Declare an ISR for the provided exception that jumps to the specified handler */ .macro ISR name, exc, handler . = (AIL_VECTOR_BASE - EXCEPTION_VECTORS_START) + \exc - ENTRY(\name) + FUNC(\name) /* TODO: switch stack */ /* Reserve space for struct cpu_user_regs */
@@ -113,8 +111,7 @@ ENTRY(h_exception_common) /* Branch to common code */ b \handler - .size \name, . - \name - .type \name, %function + END(\name) .endm /*
xen/arch/ppc/ppc64/head.S +4 -8
@@ -6,7 +6,7 @@ .section .text.header, "ax", %progbits -ENTRY(start) +FUNC(start) /* * NOTE: argument registers (r3-r9) must be preserved until the C entrypoint */
@@ -64,11 +64,9 @@ ENTRY(start) /* should never return */ trap +END(start) - .size start, . - start - .type start, %function - -ENTRY(enable_mmu) +FUNC(enable_mmu) mflr %r3 mfmsr %r4
@@ -78,6 +76,4 @@ ENTRY(enable_mmu) mtsrr0 %r3 /* return to caller after MMU enable */ mtsrr1 %r4 rfid - - .size enable_mmu, . - enable_mmu - .type enable_mmu, %function +END(enable_mmu)
xen/arch/ppc/xen.lds.S +0 -3
@@ -1,9 +1,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> -#undef ENTRY -#undef ALIGN - OUTPUT_ARCH(powerpc:common64) ENTRY(start)
PATCH v5 7/8 tools/binfile: switch to common annotations model
In reply to Jan BeulichUse DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding.
---
v3: New.
xen/tools/binfile +2 -7
@@ -29,15 +29,10 @@ cat <<EOF >$target .section $section.rodata, "a", %progbits - .p2align $align - .global $varname -$varname: +DATA($varname, 1 << $align) .incbin "$binsource" .Lend: +END($varname) - .type $varname, %object - .size $varname, .Lend - $varname - - .global ${varname}_size ASM_INT(${varname}_size, .Lend - $varname) EOF
PATCH v5 8/8 common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichLeverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3))
instead of $(firstword (3)).TBD: On top of Roger's respective patch (for livepatch), also respect
CONFIG_FUNCTION_ALIGNMENT.
Note that we'd need to split DATA() in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
---
v5: Re-base over changes earlier in the series.
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).
Config.mk +1 -1
@@ -102,7 +102,7 @@ cc-option = $(shell if $(1) $(2:-Wno-%=- # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile +3 -0
@@ -409,6 +409,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/xen.lds.S +3 -0
@@ -156,6 +156,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -104,6 +104,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -104,6 +104,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/xen.lds.S +6 -0
@@ -86,6 +86,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -214,6 +217,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -19,6 +19,14 @@ #define SYM_ALIGN(align...) .balign align +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -33,7 +41,14 @@SYM_ALIGN (align); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -47,6 +62,7 @@#endif #define FUNC(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align)) #define LABEL(name, align...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align))
@@ -54,6 +70,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) #define FUNC_LOCAL(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align)) #define LABEL_LOCAL(name, align...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align))
Re: [PATCH v5 5/8] RISC-V: annotate entry points with type and size
In reply to Jan BeulichQuoted 6 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code
except of course the converted symbols change to be hidden ones and gain
a valid size.
Quoted 8 lines
Signed-off-by Jan Beulich <[email protected]>---
Probablycount_args_exp()should move tomacros.h, but I first wanted to
see whether anyone can suggest any better approach for checking whether
a defined macro expands to nothing.
---
The current one approach looks good to me.
~ Oleksii
Quoted 144 lines
v5: Re-base.
v4: Also drop #undef-s from linker script.
v3: New.xen/arch/riscv/entry.S +0
-0@@ -5,7 +5,7 @@ #include <asm/traps.h>
/* WIP: only works while interrupting Xen context */xen/arch/riscv/entry.S +1
-1-ENTRY(handle_trap) +FUNC(handle_trap)
/* Exceptions from xen */
save_to_stack:xen/arch/riscv/entry.S +0
-0@@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp)
sretxen/arch/riscv/entry.S +1
-0+END(handle_trap)xen/arch/riscv/include/asm/asm.h +0
-0@@ -7,6 +7,7 @@ #define _ASM_RISCV_ASM_H
#ifdef__ASSEMBLY__
+#include <xen/linkage.h>
#define__ASM_STR(x)x
#else
#define__ASM_STR(x)#xxen/arch/riscv/include/asm/config.h +0
-0@@ -69,12 +69,8 @@
/* Linkage for RISCV */
#ifdef__ASSEMBLY__xen/arch/riscv/include/asm/config.h +2
-6-#define ALIGN .align 4 - -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif
#ifdefCONFIG_RISCV_64xen/arch/riscv/riscv64/head.S +1
-1@@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */csrw
CSR_SIE, zeroxen/arch/riscv/riscv64/head.S +0
-0@@ -60,19 +60,21 @@ ENTRY(start)mv a1, s1
tailstart_xen
+END(start)
.section .text, "ax", %progbitsxen/arch/riscv/riscv64/head.S +1
-1-ENTRY(reset_stack) +FUNC(reset_stack)la sp,
cpu0_boot_stack
li t0,STACK_SIZE
add sp, sp, t0
ret
+END(reset_stack)
.section .text.ident, "ax", %progbitsxen/arch/riscv/riscv64/head.S +1
-1-ENTRY(turn_on_mmu) +FUNC(turn_on_mmu)sfence.vma
li t0,RV_STAGE1_MODExen/arch/riscv/riscv64/head.S +0
-0@@ -84,3 +86,4 @@ ENTRY(turn_on_mmu)csrw
CSR_SATP, t1
jr a0xen/arch/riscv/riscv64/head.S +1
-0+END(turn_on_mmu)xen/arch/riscv/xen.lds.S +0
-0@@ -1,9 +1,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h>xen/arch/riscv/xen.lds.S +0
-3-#undef ENTRY -#undef ALIGN -OUTPUT_ARCH(riscv)
ENTRY(start)xen/include/xen/linkage.h +0
-0@@ -35,17 +35,28 @@
#define END(name) .size name, . - name
+/*
+ *CODE_FILLin particular may need to expand to nothing (e.g. for RISC-V), in
+ * which case we also need to get rid of the comma in the .balign directive.
+ */xen/include/xen/linkage.h +3
-0+#define count_args_exp(args...) count_args(args) +#if count_args_exp (CODE_FILL ) +# define DO_CODE_ALIGN(align...) LASTARG(CODE_ALIGN, ## align),
CODE_FILLxen/include/xen/linkage.h +4
-0+#else +# define DO_CODE_ALIGN(align...) LASTARG(CODE_ALIGN, ## align) +#endif +#define
FUNC(name, align...)\
-SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)
+SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align))#defineLABEL(name, align...)\
-SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)
+SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align))#defineDATA(name, align...)\
SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL)
#defineFUNC_LOCAL(name, align...)\
-SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)
+SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align))#defineLABEL_LOCAL(name, align...)\
-SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)
+SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align))#defineDATA_LOCAL(name, align...)\
SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL)
Re: [PATCH v5 1/8] common: assembly entry point type/size annotations
In reply to Jan BeulichQuoted 7 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.Signed-off-by Jan Beulich <[email protected]>
Quoted 13 lines
[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v5: DropCODE_ALIGNfallback. s/algn/align/g.
v3: New, generalized from earlier x86-only version.LAST()(now
LASTARG()) moved tomacros.h.
---
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch;
conceivably it could mean to use some kind of arch default). We may
not strictly need that, and hence we could also make these power-
of-2 values (using .p2align).
Quoted 2 lines
Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.
SYM_ALIGN seems fine for the purpose here.
Quoted 16 lines
Note further that FUNC()'s etc "align" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +7
-0@@ -0,0 +1,54 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> +
xen/include/xen/linkage.h line 17
Quoted 10 lines
xen/include/xen/linkage.h new file +10
-0+/* CODE_ALIGN needs to be specified by every architecture. */ +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0
I find the fills a bit odd, compared to what we use now (nops for x86 IIRC).
Thanks, Roger.
Re: [PATCH v5 1/8] common: assembly entry point type/size annotations
In reply to Jan BeulichQuoted 69 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v5: DropCODE_ALIGNfallback. s/algn/align/g.
v3: New, generalized from earlier x86-only version.LAST()(now
LASTARG()) moved tomacros.h.
---
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch;
conceivably it could mean to use some kind of arch default). We may
not strictly need that, and hence we could also make these power-
of-2 values (using .p2align).Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.Note further that FUNC()'s etc "align" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +38
-0@@ -0,0 +1,54 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +/* CODE_ALIGN needs to be specified by every architecture. */ +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif + +#define SYM_ALIGN(align...) .balign align + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, align...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(align); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, align...) \
xen/include/xen/linkage.h line 48
Quoted 10 lines
xen/include/xen/linkage.h new file +10
-0+ SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define LABEL(name, align...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define DATA(name, align...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) + +#define FUNC_LOCAL(name, align...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define LABEL_LOCAL(name, align...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)
One thing that I've noticed while reviewing further patches, the usage of CODE_ALIGN and CODE_FILL in LABEL_LOCAL() means that CODE_FILL must always be a nop, or else the assembler will put garbage while padding the symbol, and hence the preceding code will no longer fallthrough into the label?
Looking further, LABEL_LOCAL() is always used when there's no fallthrough, but it's IMO not obvious from the description here.
Thanks, Roger.
Re: [PATCH v5 1/8] common: assembly entry point type/size annotations
In reply to Roger Pau MonnéQuoted 10 lines · Roger Pau Monné
Quoted 7 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.Signed-off-by Jan Beulich <[email protected]>Reviewed-by Roger Pau Monné <[email protected]>
Thanks.
Quoted 15 lines
Quoted 15 lines
xen/include/xen/linkage.h new file +12
-0@@ -0,0 +1,54 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +/* CODE_ALIGN needs to be specified by every architecture. */ +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif +
Quoted 8 lines
xen/include/xen/linkage.h line 17
Quoted 5 lines
xen/include/xen/linkage.h new file +5
-0+#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0I find the fills a bit odd, compared to what we use now (nops for x86 IIRC).
Well, these are generic defaults. X86 then overrides CODE_FILL for it to remain NOP. ~0 is the best I can think of as an arch-agnostic default, considering the half dozen architectures I know at least a little.
Jan
Re: [PATCH v5 1/8] common: assembly entry point type/size annotations
In reply to Roger Pau MonnéQuoted 78 lines · Roger Pau Monné
Quoted 77 lines · Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's
END()and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use.Signed-off-by Jan Beulich <[email protected]>[1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28
---
v5: DropCODE_ALIGNfallback. s/algn/align/g.
v3: New, generalized from earlier x86-only version.LAST()(now
LASTARG()) moved tomacros.h.
---
TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be
specified (in case this has some special meaning on an arch;
conceivably it could mean to use some kind of arch default). We may
not strictly need that, and hence we could also make these power-
of-2 values (using .p2align).Note that we can't use
ALIGN()(in place ofSYM_ALIGN()) as long as we still have ALIGN.Note further that FUNC()'s etc "align" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree.
xen/include/xen/linkage.h new file +46
-0@@ -0,0 +1,54 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include <xen/macros.h> + +/* CODE_ALIGN needs to be specified by every architecture. */ +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif + +#define SYM_ALIGN(align...) .balign align + +#define SYM_L_GLOBAL (name) .globl name +#define SYM_L_WEAK (name) .weak name +#define SYM_L_LOCAL (name)/* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, align...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(align); \ + name: + +#define END (name) .size name, . - name + +#define FUNC(name, align...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define LABEL(name, align...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL) +#define DATA(name, align...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) + +#define FUNC_LOCAL(name, align...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)
Quoted 8 lines
xen/include/xen/linkage.h line 48
Quoted 2 lines
xen/include/xen/linkage.h new file +2
-0+#define LABEL_LOCAL(name, align...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## align), CODE_FILL)One thing that I've noticed while reviewing further patches, the usage of
CODE_ALIGNandCODE_FILLinLABEL_LOCAL()means thatCODE_FILLmust always be a nop, or else the assembler will put garbage while padding the symbol, and hence the preceding code will no longer fallthrough into the label?
Well, except when an arch has no such cases, it'll need to override CODE_FILL. Hence why for now Arm and PPC architectures get away without such an override. It may well be that at least Arm will need to gain one as soon as the first case of falling through is converted to this new model. See also the RISC-V change, where it becomes permissible for CODE_FILL to expand to nothing (thus using assembler built-in defaults).
Quoted 2 lines
Looking further,
LABEL_LOCAL()is always used when there's no fallthrough, but it's IMO not obvious from the description here.
Not sure what adjustment to the description you are thinking of. What's used where isn't dictated by this patch / framework.
Jan
Re: [PATCH v5 2/8] x86: annotate entry points with type and size
In reply to Jan BeulichQuoted 10 lines · Jan Beulich
xen/arch/x86/x86_64/entry.S +1
-1@@ -625,7 +627,7 @@ ENTRY(dom_crash_sync_extable) /* No special register assumptions. */ #ifdef CONFIG_PV -ENTRY(continue_pv_domain) +FUNC(continue_pv_domain) ENDBR64 call check_wakeup_from_wait ret_from_intr:
xen/arch/x86/x86_64/entry.S ret_from_intr: · line 647
Quoted 7 lines
xen/arch/x86/x86_64/entry.S +2
-1@@ -640,26 +642,28 @@ ret_from_intr: #else jmp test_all_events #endif +END(continue_pv_domain) #else -ret_from_intr: +FUNC_LOCAL(ret_from_intr, 0)
Why does this need to have an alignment of 0? There's no fallthrough of previous code AFAICT.
Quoted 40 lines
xen/arch/x86/x86_64/entry.S +6
-4ASSERT_CONTEXT_IS_XEN jmp restore_all_xen +END(ret_from_intr) #endif .section .init.text, "ax", @progbits -ENTRY(early_page_fault) +FUNC(early_page_fault) ENDBR64 movl $X86_EXC_PF, 4(%rsp) SAVE_ALL movq %rsp, %rdi call do_early_page_fault jmp restore_all_xen +END(early_page_fault) .section .text.entry, "ax", @progbits - ALIGN /* %r12=ist_exit */ -restore_all_xen: +FUNC_LOCAL(restore_all_xen) #ifdef CONFIG_DEBUG mov %rsp, %rdi@@ -683,8 +687,9 @@ UNLIKELY_END(exit_cr3) RESTORE_ALL adj=8 iretq +END(restore_all_xen) -ENTRY(common_interrupt) +FUNC(common_interrupt) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL@@ -713,12 +718,14 @@ ENTRY(common_interrupt) mov %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14) mov %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14) jmp ret_from_intr
xen/arch/x86/x86_64/entry.S ENTRY(common_interrupt) · line 728
Quoted 10 lines
xen/arch/x86/x86_64/entry.S +4
-2+END(common_interrupt) -ENTRY(entry_PF) +FUNC(entry_PF) ENDBR64 movl $X86_EXC_PF, 4(%rsp) +END(entry_PF) /* No special register assumptions. */ -GLOBAL(handle_exception) +FUNC(handle_exception, 0)
Given patch 8/8 that enables support for placing FUNC() into separate sections, the fallthrough arrangement here with entry_PF is no longer guaranteed, as the linker could re-order the sections and thus entry_PF could fallthrough into another text section?
IOW: entry_PF needs a "jmp handle_exception", and then handle_exception itself can be padded as required by the default alignment?
Quoted 146 lines
xen/arch/x86/x86_64/entry.S +35
-18ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL@@ -886,92 +893,108 @@ FATAL_exception_with_ints_disabled: xorl %esi,%esi movq %rsp,%rdi tailcall fatal_trap +END(handle_exception) -ENTRY(entry_DE) +FUNC(entry_DE) ENDBR64 pushq $0 movl $X86_EXC_DE, 4(%rsp) jmp handle_exception +END(entry_DE) -ENTRY(entry_MF) +FUNC(entry_MF) ENDBR64 pushq $0 movl $X86_EXC_MF, 4(%rsp) jmp handle_exception +END(entry_MF) -ENTRY(entry_XM) +FUNC(entry_XM) ENDBR64 pushq $0 movl $X86_EXC_XM, 4(%rsp) jmp handle_exception +END(entry_XM) -ENTRY(entry_NM) +FUNC(entry_NM) ENDBR64 pushq $0 movl $X86_EXC_NM, 4(%rsp) jmp handle_exception +END(entry_NM) -ENTRY(entry_DB) +FUNC(entry_DB) ENDBR64 pushq $0 movl $X86_EXC_DB, 4(%rsp) jmp handle_ist_exception +END(entry_DB) -ENTRY(entry_BP) +FUNC(entry_BP) ENDBR64 pushq $0 movl $X86_EXC_BP, 4(%rsp) jmp handle_exception +END(entry_BP) -ENTRY(entry_OF) +FUNC(entry_OF) ENDBR64 pushq $0 movl $X86_EXC_OF, 4(%rsp) jmp handle_exception +END(entry_OF) -ENTRY(entry_BR) +FUNC(entry_BR) ENDBR64 pushq $0 movl $X86_EXC_BR, 4(%rsp) jmp handle_exception +END(entry_BR) -ENTRY(entry_UD) +FUNC(entry_UD) ENDBR64 pushq $0 movl $X86_EXC_UD, 4(%rsp) jmp handle_exception +END(entry_UD) -ENTRY(entry_TS) +FUNC(entry_TS) ENDBR64 movl $X86_EXC_TS, 4(%rsp) jmp handle_exception +END(entry_TS) -ENTRY(entry_NP) +FUNC(entry_NP) ENDBR64 movl $X86_EXC_NP, 4(%rsp) jmp handle_exception +END(entry_NP) -ENTRY(entry_SS) +FUNC(entry_SS) ENDBR64 movl $X86_EXC_SS, 4(%rsp) jmp handle_exception +END(entry_SS) -ENTRY(entry_GP) +FUNC(entry_GP) ENDBR64 movl $X86_EXC_GP, 4(%rsp) jmp handle_exception +END(entry_GP) -ENTRY(entry_AC) +FUNC(entry_AC) ENDBR64 movl $X86_EXC_AC, 4(%rsp) jmp handle_exception +END(entry_AC) -ENTRY(entry_CP) +FUNC(entry_CP) ENDBR64 movl $X86_EXC_CP, 4(%rsp) jmp handle_exception +END(entry_CP) -ENTRY(entry_DF) +FUNC(entry_DF) ENDBR64 movl $X86_EXC_DF, 4(%rsp) /* Set AC to reduce chance of further SMAP faults */@@ -994,8 +1017,9 @@ ENTRY(entry_DF) movq %rsp,%rdi tailcall do_double_fault +END(entry_DF) -ENTRY(entry_NMI) +FUNC(entry_NMI) ENDBR64 pushq $0 movl $X86_EXC_NMI, 4(%rsp)@@ -1126,21 +1150,24 @@ handle_ist_exception: ASSERT_CONTEXT_IS_XEN jmp restore_all_xen #endif +END(entry_NMI) -ENTRY(entry_MC)
xen/arch/x86/x86_64/entry.S handle_ist_exception: · line 1163
Quoted 10 lines
xen/arch/x86/x86_64/entry.S +3
-1+FUNC(entry_MC) ENDBR64 pushq $0 movl $X86_EXC_MC, 4(%rsp) jmp handle_ist_exception +END(entry_MC) /* No op trap handler. Required for kexec crash path. */ -GLOBAL(trap_nop) +FUNC(trap_nop, 0)
Could this use the default alignment?
Quoted 12 lines
xen/arch/x86/x86_64/entry.S +2
-1ENDBR64 iretq +END(trap_nop) /* Table of automatically generated entry points. One per vector. */ .pushsection .init.rodata, "a", @progbits -GLOBAL(autogen_entrypoints) +DATA(autogen_entrypoints, 8) /* pop into the .init.rodata section and record an entry point. */ .macro entrypoint ent .pushsection .init.rodata, "a", @progbits
xen/arch/x86/x86_64/entry.S GLOBAL(autogen_entrypoints) · line 1179
Quoted 5 lines
xen/arch/x86/x86_64/entry.S +1
-1@@ -1149,7 +1176,7 @@ GLOBAL(autogen_entrypoints) .endm .popsection -autogen_stubs: /* Automatically generated stubs. */ +FUNC_LOCAL(autogen_stubs, 0) /* Automatically generated stubs. */
Won't it be good to align the stubs? As that's possible to make them faster?
Thanks, Roger.
Re: [PATCH v5 2/8] x86: annotate entry points with type and size
Quoted 13 lines · Roger Pau Monné
Quoted 12 lines · Jan Beulich
xen/arch/x86/x86_64/entry.S +1
-1@@ -625,7 +627,7 @@ ENTRY(dom_crash_sync_extable) /* No special register assumptions. */ #ifdef CONFIG_PV -ENTRY(continue_pv_domain) +FUNC(continue_pv_domain) ENDBR64 call check_wakeup_from_wait ret_from_intr:@@ -640,26 +642,28 @@ ret_from_intr: #else jmp test_all_events
Quoted 8 lines
xen/arch/x86/x86_64/entry.S ret_from_intr: · line 647
Quoted 5 lines
xen/arch/x86/x86_64/entry.S +2
-1#endif +END(continue_pv_domain) #else -ret_from_intr: +FUNC_LOCAL(ret_from_intr, 0)Why does this need to have an alignment of 0? There's no fallthrough of previous code AFAICT.
It doesn't have to, but see the description for where I thought it would make sense to newly introduce alignment; I simply didn't want to go too far with such changes leading to generated code being altered. This (and the other cases below) weren't in that group. Without ...
Quoted 1 line
Review ret_from_intr: · line 648
Quoted 1 line
(quoted diff) +0
-0ASSERT_CONTEXT_IS_XEN
... this I would be strongly inclined to switch ...
Quoted 1 line
Review ret_from_intr: · line 649
Quoted 1 line
(quoted diff) +0
-0jmp restore_all_xen
... to
#define ret_from_intr restore_all_xen
anyway. And perhaps we ought to change the "#else" above to "#elif !defined(NDEBUG)", at which point I'd say alignment isn't required here at all.
Quoted 20 lines
Quoted 4 lines
xen/arch/x86/x86_64/entry.S +0
-0@@ -713,12 +718,14 @@ ENTRY(common_interrupt) mov %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14) mov %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14) jmp ret_from_intrxen/arch/x86/x86_64/entry.S ENTRY(common_interrupt) · line 728
Quoted 10 lines
xen/arch/x86/x86_64/entry.S +4
-2+END(common_interrupt) -ENTRY(entry_PF) +FUNC(entry_PF) ENDBR64 movl $X86_EXC_PF, 4(%rsp) +END(entry_PF) /* No special register assumptions. */ -GLOBAL(handle_exception) +FUNC(handle_exception, 0)Given patch 8/8 that enables support for placing
FUNC()into separate sections, the fallthrough arrangement here withentry_PFis no longer guaranteed, as the linker could re-order the sections and thusentry_PFcould fallthrough into another text section?
Quoted 3 lines
IOW:
entry_PFneeds a "jmphandle_exception", and thenhandle_exceptionitself can be padded as required by the default alignment?
Oh, yes, very much so. Thanks for noticing. I'll do that in the later patch, though.
Quoted 9 lines
xen/arch/x86/x86_64/entry.S GLOBAL(autogen_entrypoints) · line 1179
Quoted 6 lines
xen/arch/x86/x86_64/entry.S +1
-1@@ -1149,7 +1176,7 @@ GLOBAL(autogen_entrypoints) .endm .popsection -autogen_stubs: /* Automatically generated stubs. */ +FUNC_LOCAL(autogen_stubs, 0) /* Automatically generated stubs. */Won't it be good to align the stubs? As that's possible to make them faster?
Well. If I used default alignment here, it would be the 1st stub only which gains alignment. I'd view that as simply inconsistent. You'll find there already is an ALIGN inside the .rept below. That covers only certain cases, but intentionally so, I believe: it's only entry points which shouldn't be reached anyway which get no alignment. So yes, in this case I clearly think there wants to explicitly be no alignment here.
Jan
Re: [PATCH v5 2/8] x86: annotate entry points with type and size
In reply to Jan BeulichQuoted 13 lines · Jan Beulich
Use the generic framework in
xen/linkage.h.For
switch_to_kernel()andrestore_all_guest()so far implicit alignment (from being first in their respective sections) is being made explicit (as in: usingFUNC()without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for.Except for the added/adjusted alignment padding (including their knock-on effects) no change in generated code/data. Note that the basis for support of weak definitions is added despite them not having any use right now.
Quoted 4 lines
Note that
ASM_INT()is switched toDATA(), notDATA_LOCAL(), as the only use site wants the symbol global anyway.Signed-off-by Jan Beulich <[email protected]>
Thanks, Roger.
Re: [PATCH v5 8/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichQuoted 9 lines · Jan Beulich
Leverage the new infrastructure in
xen/linkage.hto also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the timeFUNC()is invoked.Signed-off-by Jan Beulich <[email protected]>---
TBD: Since we use .subsection inUNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
Hm, I'm afraid I don't have much useful suggestions here.
Quoted 3 lines
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)).
I don't have a strong opinion re those two options My preference however (see below for reasoning) would be to put this detection in Kconfig.
Quoted 2 lines
TBD: On top of Roger's respective patch (for livepatch), also respect
CONFIG_FUNCTION_ALIGNMENT.
I think you can drop that, as the series is blocked.
Quoted 27 lines
Note that we'd need to split
DATA()in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is giveDATA()a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
---
v5: Re-base over changes earlier in the series.
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).Config.mk +1
-1@@ -102,7 +102,7 @@ cc-option = $(shell if $(1) $(2:-Wno-%=- # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile AFLAGS += -D__ASSEMBLY__ · line 413
Quoted 5 lines
xen/Makefile +2
-0@@ -409,6 +409,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST)
I guess you already know what I'm going to comment on. I think this would be clearer if it was a Kconfig option. For once because I think we should gate livapatch support on the option being available, and secondly it would avoid having to pass the extra -D around.
I think it's relevant to have a consistent set of build tool options requirements for livepatch support, so that when enabled the support is consistent across builds. With this approach livepatch could be enabled in Kconfig, but depending on the tools support the resulting binary might or might not support live patching of assembly code. Such behavior is IMO unhelpful from a user PoV, and can lead to surprises down the road.
Thanks, Roger.
Re: [PATCH v5 8/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Quoted 17 lines · Roger Pau Monné
Quoted 9 lines · Jan Beulich
Leverage the new infrastructure in
xen/linkage.hto also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the timeFUNC()is invoked.Signed-off-by Jan Beulich <[email protected]>---
TBD: Since we use .subsection inUNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.Hm, I'm afraid I don't have much useful suggestions here.
Quoted 3 lines
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)).
Quoted 8 lines
I don't have a strong opinion re those two options My preference however (see below for reasoning) would be to put this detection in
Kconfig.Quoted 2 lines
TBD: On top of Roger's respective patch (for livepatch), also respect
CONFIG_FUNCTION_ALIGNMENT.I think you can drop that, as the series is blocked.
Considering the series here has been pending for quite some time, too, I guess I'd like to keep it just in case that other functionality becomes unblocked or available by some other means, even if only to remind myself.
Quoted 14 lines
xen/Makefile AFLAGS += -D__ASSEMBLY__ · line 413
Quoted 8 lines
xen/Makefile +2
-0@@ -409,6 +409,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST)I guess you already know what I'm going to comment on. I think this would be clearer if it was a
Kconfigoption. For once because I think we should gate livapatch support on the option being available, and secondly it would avoid having to pass the extra -D around.
Quoted 7 lines
I think it's relevant to have a consistent set of build tool options requirements for livepatch support, so that when enabled the support is consistent across builds. With this approach livepatch could be enabled in
Kconfig, but depending on the tools support the resulting binary might or might not support live patching of assembly code. Such behavior is IMO unhelpful from a user PoV, and can lead to surprises down the road.
I can see the desire to have LIVEPATCH grow such a dependency. Yet there is the bigger still open topic of the criteria towards what, if anything, to probe for in Kconfig, what, if anything, to probe for in Makefile, and which of the probing perhaps do in both places. I'm afraid my attempts to move us closer to a resolution (topic on summit, making proposals on list) have utterly failed. IOW I don't currently see how the existing disagreement there can be resolved, which will result in me to continue following the (traditional) Makefile approach unless I clearly view Kconfig superior in a particular case. I could perhaps be talked into following a "mixed Kconfig/Makefile model", along the lines of "x86:
convert CET tool chain feature checks to mixed Kconfig/Makefile model", albeit I'm sure you're aware there are issues to sort out there, which I see no value in putting time into as long as I can't expect things to make progress subsequently.
Dropping this patch, while an option, would seem undesirable to me, since even without Kconfig probing using new enough tool chains the splitting would yield reliable results, and provide - imo - an improvement over what we have right now.
Jan
Ping: [PATCH v5 6/8] PPC: switch entry point annotations to common model
In reply to Jan BeulichQuoted 4 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones.Signed-off-by Jan Beulich <[email protected]>
The other architectures have been at least partly switched; would be nice for PPC to follow suit. May I ask for an ack (or otherwise here), please?
Thanks, Jan
Re: [PATCH v5 4/8] Arm: annotate entry points with type and size
In reply to Jan BeulichQuoted 5 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.
Quoted 8 lines
Note that
ASM_INT()is switched toDATA(), notDATA_LOCAL(), as the only use site wants the symbol global anyway.Signed-off-by Jan Beulich <[email protected]>Reviewed-by Julien Grall <[email protected]>---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.
As this was meanwhile committed, I'd like to understand you preference for further conversion steps: I can certainly see to find time to make some actual progress here, but it might also be that you prefer to do so yourself. Please let me know.
Jan
Re: [PATCH v5 8/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichQuoted 25 lines · Jan Beulich
Quoted 24 lines · Roger Pau Monné
Quoted 9 lines · Jan Beulich
Leverage the new infrastructure in
xen/linkage.hto also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the timeFUNC()is invoked.Signed-off-by Jan Beulich <[email protected]>---
TBD: Since we use .subsection inUNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.Hm, I'm afraid I don't have much useful suggestions here.
Quoted 3 lines
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)).I don't have a strong opinion re those two options My preference however (see below for reasoning) would be to put this detection in
Kconfig.Quoted 2 lines
TBD: On top of Roger's respective patch (for livepatch), also respect
CONFIG_FUNCTION_ALIGNMENT.
Quoted 6 lines
Quoted 1 line
I think you can drop that, as the series is blocked.
Considering the series here has been pending for quite some time, too, I guess I'd like to keep it just in case that other functionality becomes unblocked or available by some other means, even if only to remind myself.
So as you have seen I've posted a new version of just the function alignment patch, that I expected wasn't controversial.
Quoted 22 lines
Quoted 14 lines
xen/Makefile AFLAGS += -D__ASSEMBLY__ · line 413
Quoted 8 lines
xen/Makefile +2
-0@@ -409,6 +409,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST)I guess you already know what I'm going to comment on. I think this would be clearer if it was a
Kconfigoption. For once because I think we should gate livapatch support on the option being available, and secondly it would avoid having to pass the extra -D around.Quoted 7 lines
I think it's relevant to have a consistent set of build tool options requirements for livepatch support, so that when enabled the support is consistent across builds. With this approach livepatch could be enabled in
Kconfig, but depending on the tools support the resulting binary might or might not support live patching of assembly code. Such behavior is IMO unhelpful from a user PoV, and can lead to surprises down the road.
Quoted 14 lines
I can see the desire to have LIVEPATCH grow such a dependency. Yet there is the bigger still open topic of the criteria towards what, if anything, to probe for in
Kconfig, what, if anything, to probe for inMakefile, and which of the probing perhaps do in both places. I'm afraid my attempts to move us closer to a resolution (topic on summit, making proposals on list) have utterly failed. IOW I don't currently see how the existing disagreement there can be resolved, which will result in me to continue following the (traditional)Makefileapproach unless I clearly viewKconfigsuperior in a particular case. I could perhaps be talked into following a "mixed Kconfig/Makefile model", along the lines of "x86:
convert CET tool chain feature checks to mixed Kconfig/Makefile model", albeit I'm sure you're aware there are issues to sort out there, which I see no value in putting time into as long as I can't expect things to make progress subsequently.
I think there are more subtle cases where it's indeed arguable that putting it in Kconfig or a Makefile makes no difference from a user experience PoV, hence in the context here I do believe it wants to be in Kconfig as LIVEPATCH can be make dependent on it.
Quoted 4 lines
Dropping this patch, while an option, would seem undesirable to me, since even without
Kconfigprobing using new enough tool chains the splitting would yield reliable results, and provide - imo - an improvement over what we have right now.
I could send a followup afterwards to arrange for the check to be in Kconfig, but it would feel a bit odd to me this is not done in the first place.
I don't want to block the patch because I think it's useful, so worst case I'm willing to give my Ack and provide an alternative Kconfig based patch afterwards.
Thanks, Roger.
Shawn Anastasio
Acked-byRe: Ping: [PATCH v5 6/8] PPC: switch entry point annotations to common model
In reply to Jan BeulichHi Jan,
Quoted 9 lines · Jan Beulich
Quoted 4 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones.Signed-off-by Jan Beulich <[email protected]>The other architectures have been at least partly switched; would be nice for PPC to follow suit. May I ask for an ack (or otherwise here), please?
Sorry for the delay.
Quoted 1 line
Thanks, Jan
Thanks,
Shawn
PATCH v6 7/7 (mostly) x86: add/convert entry point annotations
In reply to Jan Beulich1: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions 2: SVM: convert entry point annotations
3: VMX: convert entry point annotations
4: x86/ACPI: annotate assembly functions with type and size 5: x86/kexec: convert entry point annotations
6: x86: convert misc assembly function annotations
7: x86: move ENTRY(), GLOBAL(), and ALIGN
Jan
Re: [PATCH v6 0/7] (mostly) x86: add/convert entry point annotations
Quoted 7 lines · Jan Beulich
1: common: honor
CONFIG_CC_SPLIT_SECTIONSalso for assembly functions 2: SVM: convert entry point annotations
3: VMX: convert entry point annotations
4: x86/ACPI: annotate assembly functions with type and size 5: x86/kexec: convert entry point annotations
6: x86: convert misc assembly function annotations
7: x86: moveENTRY(),GLOBAL(), and ALIGN
Being the cover letter, the title was of course supposed to say 0/7.
Jan
PATCH v6 1/7 common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichLeverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). In fact Roger wants the detection to be in Kconfig, for LIVEPATCH to depend on it. Yet the whole underlying discussion there imo would first need settling (and therefore reviving).
TBD: On top of Roger's respective patch (for livepatch), also respect
CONFIG_FUNCTION_ALIGNMENT.
Note that we'd need to split DATA() in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
---
v6: Deal with x86'es entry_PF() and entry_int82() falling through to the
next "function". Re-base.
v5: Re-base over changes earlier in the series.
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).
Config.mk +1 -1
@@ -102,7 +102,7 @@ cc-option = $(shell if $(1) $(2:-Wno-%=- # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile +3 -0
@@ -409,6 +409,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assembler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/xen.lds.S +3 -0
@@ -157,6 +157,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -104,6 +104,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -104,6 +104,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/x86_64/compat/entry.S +3 -0
@@ -29,6 +29,9 @@ FUNC(entry_int82) mov %rsp, %rdi call do_entry_int82 +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp compat_test_all_events +#endif END(entry_int82) /* %rbx: struct vcpu */
xen/arch/x86/x86_64/entry.S +7 -1
@@ -723,6 +723,9 @@ END(common_interrupt) FUNC(entry_PF) ENDBR64 movl $X86_EXC_PF, 4(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_exception +#endif END(entry_PF) /* No special register assumptions. */ FUNC(handle_exception, 0)
@@ -1023,8 +1026,11 @@ FUNC(entry_NMI) ENDBR64 pushq $0 movl $X86_EXC_NMI, 4(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_ist_exception +#endif END(entry_NMI) - +/* No special register assumptions. */ FUNC(handle_ist_exception) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL
xen/arch/x86/xen.lds.S +6 -0
@@ -86,6 +86,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -214,6 +217,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -19,6 +19,14 @@ #define SYM_ALIGN(align...) .balign align +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -33,7 +41,14 @@SYM_ALIGN (align); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -47,6 +62,7 @@#endif #define FUNC(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align)) #define LABEL(name, align...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align))
@@ -54,6 +70,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) #define FUNC_LOCAL(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align)) #define LABEL_LOCAL(name, align...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align))
PATCH v6 2/7 SVM: convert entry point annotations
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
v6: New.
xen/arch/x86/hvm/svm/entry.S +3 -5
@@ -24,7 +24,7 @@ #include <asm/asm_defns.h> #include <asm/page.h> -ENTRY(svm_asm_do_resume) +FUNC(svm_asm_do_resume) GET_CURRENT(bx) .Lsvm_do_resume: call svm_intr_assist
@@ -132,7 +132,7 @@ __UNLIKELY_END(nsvm_hap) * to safely resolve any Spectre-v1 concerns in the above logic. */ stgi -GLOBAL(svm_stgi_label) +LABEL(svm_stgi_label, 0) call svm_vmexit_handler jmp .Lsvm_do_resume
@@ -140,6 +140,4 @@ GLOBAL(svm_stgi_label) sti call do_softirq jmp .Lsvm_do_resume - - .type svm_asm_do_resume, @function - .size svm_asm_do_resume, . - svm_asm_do_resume +END(svm_asm_do_resume)
PATCH v6 3/7 VMX: convert entry point annotations
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
v6: New.
xen/arch/x86/hvm/vmx/entry.S +3 -5
@@ -24,7 +24,7 @@ #define VMRESUME .byte 0x0f,0x01,0xc3 #define VMLAUNCH .byte 0x0f,0x01,0xc2 -ENTRY(vmx_asm_vmexit_handler) +FUNC(vmx_asm_vmexit_handler) SAVE_ALL mov %cr2,%rax
@@ -132,7 +132,7 @@ UNLIKELY_END(realmode) call vmx_vmentry_failure jmp .Lvmx_process_softirqs -ENTRY(vmx_asm_do_vmentry) +LABEL(vmx_asm_do_vmentry) GET_CURRENT(bx) jmp .Lvmx_do_vmentry
@@ -150,6 +150,4 @@ ENTRY(vmx_asm_do_vmentry) sti call do_softirq jmp .Lvmx_do_vmentry - - .type vmx_asm_vmexit_handler, @function - .size vmx_asm_vmexit_handler, . - vmx_asm_vmexit_handler +END(vmx_asm_vmexit_handler)
PATCH v6 4/7 x86/ACPI: annotate assembly functions with type and size
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
The .Lsuspend_err label is used in a cross-function manner here, but it's not clear to me what - if anything - to do about this.
---
v6: New.
xen/arch/x86/acpi/wakeup_prot.S +5 -4
@@ -7,7 +7,7 @@ .text .code64 -ENTRY(do_suspend_lowlevel) +FUNC(do_suspend_lowlevel) push %rbp push %rbx push %r12
@@ -32,6 +32,7 @@ ENTRY(do_suspend_lowlevel) /* It seems we didn't suspend. Get out of here. */ jmp .Lsuspend_err +END(do_suspend_lowlevel) /* * do_suspend_lowlevel() is arranged to behave as a regular function
@@ -43,7 +44,7 @@ ENTRY(do_suspend_lowlevel) * * Everything else, including the stack, needs restoring. */ -ENTRY(s3_resume) +FUNC(s3_resume) lgdt boot_gdtr(%rip) mov saved_cr0(%rip), %rax
@@ -132,6 +133,7 @@ ENTRY(s3_resume) pop %rbx pop %rbp ret +END(s3_resume) .data .align 16
@@ -142,5 +144,4 @@ saved_cr0: .quad 0 saved_ssp: .quad 0 #endif -GLOBAL(saved_magic) - .long 0x9abcdef0 +ASM_INT(saved_magic, 0x9abcdef0)
PATCH v6 5/7 x86/kexec: convert entry point annotations
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
Using the linker script like this feels fragile. Maybe it's better to suppress (#undef) CONFIG_CC_SPLIT_SECTIONS for this one file?
---
v6: New.
xen/arch/x86/x86_64/kexec_reloc.S +14 -23
@@ -21,10 +21,9 @@ #include <asm/machine_kexec.h> .section .text.kexec, "ax", @progbits - .align PAGE_SIZE .code64 -ENTRY(kexec_reloc) +FUNC(kexec_reloc, PAGE_SIZE) /* %rdi - code page maddr */ /* %rsi - page table maddr */ /* %rdx - indirection page maddr */
@@ -91,8 +90,9 @@ ENTRY(kexec_reloc) push $0x10 push %rax lretq +END(kexec_reloc) -relocate_pages: +FUNC_LOCAL(relocate_pages) /* %rdi - indirection page maddr */ pushq %rbx
@@ -138,10 +138,11 @@ relocate_pages: .L_done: popq %rbx ret +END(relocate_pages) .code32 -compatibility_mode: +FUNC_LOCAL(compatibility_mode) /* Setup some sane segments. */ movl $0x0008, %eax movl %eax, %ds
@@ -168,39 +169,29 @@ compatibility_mode: /* Call the image entry point. This should never return. */ call *%ebp ud2 +END(compatibility_mode) - .align 4 -compat_mode_gdt_desc: +DATA_LOCAL(compat_mode_gdt_desc, 4) .word .Lcompat_mode_gdt_end - compat_mode_gdt -1 .quad 0x0000000000000000 /* set in call_32_bit above */ +END(compat_mode_gdt_desc) - .type compat_mode_gdt_desc, @object - .size compat_mode_gdt_desc, . - compat_mode_gdt_desc - - .align 8 -compat_mode_gdt: +DATA_LOCAL(compat_mode_gdt, 8) .quad 0x0000000000000000 /* null */ .quad 0x00cf93000000ffff /* 0x0008 ring 0 data */ .quad 0x00cf9b000000ffff /* 0x0010 ring 0 code, compatibility */ .Lcompat_mode_gdt_end: +END(compat_mode_gdt) - .type compat_mode_gdt, @object - .size compat_mode_gdt, . - compat_mode_gdt - -compat_mode_idt: +DATA_LOCAL(compat_mode_idt) .word 0 /* limit */ .long 0 /* base */ - - .type compat_mode_idt, @object - .size compat_mode_idt, . - compat_mode_idt +END(compat_mode_idt) /* * 16 words of stack are more than enough. */ - .align 8 -reloc_stack: +DATA_LOCAL(reloc_stack, 8) .fill 16,8,0 .Lreloc_stack_base: - - .type reloc_stack, @object - .size reloc_stack, . - reloc_stack +END(reloc_stack)
xen/arch/x86/xen.lds.S +4 -1
@@ -92,7 +92,10 @@ SECTIONS . = ALIGN(PAGE_SIZE); _etextentry = .; - *(.text.kexec) /* Page aligned in the object file. */ + /* Page aligned in the object file. */ + *(.text.kexec.kexec_reloc) + *(.text.kexec.*) + *(.text.kexec) kexec_reloc_end = .; *(.text.cold)
PATCH v6 6/7 x86: convert misc assembly function annotations
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
v6: New.
xen/arch/x86/clear_page.S +3 -4
@@ -1,8 +1,9 @@ .file __FILE__ +#include <xen/linkage.h> #include <asm/page.h> -ENTRY(clear_page_sse2) +FUNC(clear_page_sse2) mov $PAGE_SIZE/32, %ecx xor %eax,%eax
@@ -16,6 +17,4 @@ ENTRY(clear_page_sse2) sfence ret - - .type clear_page_sse2, @function - .size clear_page_sse2, . - clear_page_sse2 +END(clear_page_sse2)
xen/arch/x86/copy_page.S +3 -4
@@ -1,5 +1,6 @@ .file __FILE__ +#include <xen/linkage.h> #include <asm/page.h> #define src_reg %rsi
@@ -10,7 +11,7 @@ #define tmp3_reg %r10 #define tmp4_reg %r11 -ENTRY(copy_page_sse2) +FUNC(copy_page_sse2) mov $PAGE_SIZE/(4*WORD_SIZE)-3, %ecx prefetchnta 2*4*WORD_SIZE(src_reg)
@@ -41,6 +42,4 @@ ENTRY(copy_page_sse2) sfence ret - - .type copy_page_sse2, @function - .size copy_page_sse2, . - copy_page_sse2 +END(copy_page_sse2)
xen/arch/x86/guest/xen/hypercall_page.S +2 -4
@@ -3,13 +3,11 @@ #include <public/xen.h> .section ".text.page_aligned", "ax", @progbits - .p2align PAGE_SHIFT -GLOBAL(hypercall_page) +DATA(hypercall_page, PAGE_SIZE) /* Poisoned with `ret` for safety before hypercalls are set up. */ .fill PAGE_SIZE, 1, 0xc3 - .type hypercall_page, STT_OBJECT - .size hypercall_page, PAGE_SIZE +END(hypercall_page) /* * Identify a specific hypercall in the hypercall page
xen/arch/x86/indirect-thunk.S +2 -4
@@ -35,15 +35,13 @@ .macro GEN_INDIRECT_THUNK reg:req .section .text.__x86_indirect_thunk_\reg, "ax", @progbits -ENTRY(__x86_indirect_thunk_\reg) +FUNC(__x86_indirect_thunk_\reg) ALTERNATIVE_2 __stringify(IND_THUNK_RETPOLINE \reg), \ __stringify(IND_THUNK_LFENCE \reg), X86_FEATURE_IND_THUNK_LFENCE, \ __stringify(IND_THUNK_JMP \reg), X86_FEATURE_IND_THUNK_JMP int3 /* Halt straight-line speculation */ - - .size __x86_indirect_thunk_\reg, . - __x86_indirect_thunk_\reg - .type __x86_indirect_thunk_\reg, @function +END(__x86_indirect_thunk_\reg) .endm /* Instantiate GEN_INDIRECT_THUNK for each register except %rsp. */
xen/arch/x86/pv/gpr_switch.S +4 -9
@@ -10,7 +10,7 @@ #include <asm/asm_defns.h> /* Load guest GPRs. Parameter in %rdi, clobbers all registers. */ -ENTRY(load_guest_gprs) +FUNC(load_guest_gprs) movq UREGS_rdx(%rdi), %rdx movq UREGS_rax(%rdi), %rax movq UREGS_rbx(%rdi), %rbx
@@ -27,13 +27,10 @@ ENTRY(load_guest_gprs) movq UREGS_rcx(%rdi), %rcx movq UREGS_rdi(%rdi), %rdi ret - - .size load_guest_gprs, . - load_guest_gprs - .type load_guest_gprs, STT_FUNC - +END(load_guest_gprs) /* Save guest GPRs. Parameter on the stack above the return address. */ -ENTRY(save_guest_gprs) +FUNC(save_guest_gprs) pushq %rdi movq 2*8(%rsp), %rdi movq %rax, UREGS_rax(%rdi)
@@ -52,6 +49,4 @@ ENTRY(save_guest_gprs) movq %rdx, UREGS_rdx(%rdi) movq %rcx, UREGS_rcx(%rdi) ret - - .size save_guest_gprs, . - save_guest_gprs - .type save_guest_gprs, STT_FUNC +END(save_guest_gprs)
xen/arch/x86/x86_64/entry.S +1 -1
@@ -599,7 +599,7 @@ domain_crash_page_fault_0x8: ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP movq %rsi,%rdi call show_page_walk -ENTRY(dom_crash_sync_extable) +LABEL(dom_crash_sync_extable, 0) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP # Get out of the guest-save area of the stack. GET_STACK_END(ax)
PATCH v6 7/7 x86: move ENTRY(), GLOBAL(), and ALIGN
In reply to Jan Beulich... to boot code, limiting their scope and thus allowing to drop respective #undef-s from the linker script.
---
An obvious alternative would be to convert boot code right away too, but I think this has lower priority for now.
---
v6: New.
xen/arch/x86/boot/head.S +9 -0
@@ -10,6 +10,15 @@ #include <asm/cpufeature.h> #include <public/elfnote.h> +#define ALIGN .align CODE_ALIGN, CODE_FILL +#define ENTRY(name) \ + ALIGN; \ + GLOBAL(name) +#define GLOBAL(name) \ + .globl name; \ + .hidden name; \ + name: + .section .text.header, "ax", @progbits .code32
xen/arch/x86/include/asm/config.h +0 -8
@@ -45,14 +45,6 @@#ifdef __ASSEMBLY__#define CODE_ALIGN 16#define CODE_FILL 0x90 -#define ALIGN .align CODE_ALIGN, CODE_FILL -#define ENTRY (name) \ - ALIGN; \ - GLOBAL(name) -#define GLOBAL (name) \ - .globl name; \ - .hidden name; \ - name:#endif #define NR_hypercalls 64
xen/arch/x86/x86_64/entry.S +1 -1
@@ -1199,7 +1199,7 @@ FUNC_LOCAL(autogen_stubs, 0) /* Automati .if vec >= FIRST_IRQ_VECTOR #endif - ALIGN + .align CODE_ALIGN, CODE_FILL 1: ENDBR64 pushq $0
xen/arch/x86/xen.lds.S +0 -2
@@ -5,8 +5,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> #include <asm/page.h> -#undef ENTRY -#undef ALIGN #ifdef EFI
Re: [PATCH v6 2/7] SVM: convert entry point annotations
In reply to Jan BeulichQuoted 3 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>
Re: [PATCH v6 3/7] VMX: convert entry point annotations
In reply to Jan BeulichQuoted 18 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>---
v6: New.xen/arch/x86/hvm/vmx/entry.S +1
-1@@ -24,7 +24,7 @@ #define VMRESUME .byte 0x0f,0x01,0xc3 #define VMLAUNCH .byte 0x0f,0x01,0xc2 -ENTRY(vmx_asm_vmexit_handler) +FUNC(vmx_asm_vmexit_handler) SAVE_ALL mov %cr2,%rax
xen/arch/x86/hvm/vmx/entry.S UNLIKELY_END(realmode) · line 135
Quoted 5 lines
xen/arch/x86/hvm/vmx/entry.S +1
-1@@ -132,7 +132,7 @@ UNLIKELY_END(realmode) call vmx_vmentry_failure jmp .Lvmx_process_softirqs -ENTRY(vmx_asm_do_vmentry) +LABEL(vmx_asm_do_vmentry)
This really is a function, not a label.
xen.git/xen$ git grep vmx_asm_do_vmentry arch/x86/hvm/vmx/entry.S:135:ENTRY(vmx_asm_do_vmentry) arch/x86/hvm/vmx/vmcs.c:1855:void noreturn vmx_asm_do_vmentry(void); arch/x86/hvm/vmx/vmcs.c:1929: reset_stack_and_jump(vmx_asm_do_vmentry);
It is giant mess, of two functions forming part of the same loop.
Considering that you declines to take CODE, I don't know what to suggest. The point of CODE, distinct to FUNC, was to identify the places where weird things were going on, and this absolutely counts.
~Andrew
Re: [PATCH v6 4/7] x86/ACPI: annotate assembly functions with type and size
In reply to Jan BeulichQuoted 6 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>---
The .Lsuspend_err label is used in a cross-function manner here, but it's not clear to me what - if anything - to do about this.
Well - again like VMX, this is special CODE.
It really is one function, do_suspend_lowlevel() - see how it's caller uses it, with a magic position in the middle that is joined by the S3 path.
s3_resume should be a CODE too, or whatever we call a not-LABEL.
~Andrew
Re: [PATCH v6 5/7] x86/kexec: convert entry point annotations
In reply to Jan BeulichQuoted 6 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>---
Using the linker script like this feels fragile. Maybe it's better to suppress (#undef)CONFIG_CC_SPLIT_SECTIONSfor this one file?
This is specific glue code, needing to fit in a single page. I'd prefer to explicitly state that SPLIT_SECTIONS is inapplciable, than to try to undo the effects in the linker script.
Everything else looks ok. I'll fix the preexiting errors after a rebase.
~Andrew
Re: [PATCH v6 6/7] x86: convert misc assembly function annotations
In reply to Jan Beulichxen/arch/x86/x86_64/entry.S domain_crash_page_fault_0x8: · line 605
Quoted 12 lines · Jan Beulich
xen/arch/x86/x86_64/entry.S +1
-1@@ -599,7 +599,7 @@ domain_crash_page_fault_0x8: ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP movq %rsi,%rdi call show_page_walk -ENTRY(dom_crash_sync_extable) +LABEL(dom_crash_sync_extable, 0) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP # Get out of the guest-save area of the stack. GET_STACK_END(ax)
This again is a function, and one even used across-TUs.
Furthermore, it's a (domain) fatal error path. It has the least excuse of all to not conform to a regular function-like layout.
Everything else looks fine. If you want to split this out into a separate patch to address its function-ness, then consider the remainder
Re: [PATCH v6 3/7] VMX: convert entry point annotations
In reply to Andrew CooperQuoted 32 lines · Andrew Cooper
Quoted 18 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>---
v6: New.xen/arch/x86/hvm/vmx/entry.S +1
-1@@ -24,7 +24,7 @@ #define VMRESUME .byte 0x0f,0x01,0xc3 #define VMLAUNCH .byte 0x0f,0x01,0xc2 -ENTRY(vmx_asm_vmexit_handler) +FUNC(vmx_asm_vmexit_handler) SAVE_ALL mov %cr2,%raxxen/arch/x86/hvm/vmx/entry.S UNLIKELY_END(realmode) · line 135
Quoted 5 lines
xen/arch/x86/hvm/vmx/entry.S +1
-1@@ -132,7 +132,7 @@ UNLIKELY_END(realmode) call vmx_vmentry_failure jmp .Lvmx_process_softirqs -ENTRY(vmx_asm_do_vmentry) +LABEL(vmx_asm_do_vmentry)This really is a function, not a label.
xen.git/xen$ git grep
vmx_asm_do_vmentryarch/x86/hvm/vmx/entry.S:135:ENTRY(vmx_asm_do_vmentry) arch/x86/hvm/vmx/vmcs.c:1855:void noreturnvmx_asm_do_vmentry(void); arch/x86/hvm/vmx/vmcs.c:1929:reset_stack_and_jump(vmx_asm_do_vmentry);
Quoted 5 lines
It is giant mess, of two functions forming part of the same loop.
Considering that you declines to take CODE, I don't know what to suggest. The point of CODE, distinct to FUNC, was to identify the places where weird things were going on, and this absolutely counts.
What's not clear to me: How would CODE() differ from both FUNC() and LABEL()? And if the symbol is to be a function, what's wrong with using FUNC() here as is? There's in particular no real need to have all FUNC()s paired with END()s, afaict.
Jan
Re: [PATCH v6 7/7] x86: move ENTRY(), GLOBAL(), and ALIGN
In reply to Jan BeulichQuoted 7 lines · Jan Beulich
... to boot code, limiting their scope and thus allowing to drop respective #undef-s from the linker script.
Signed-off-by Jan Beulich <[email protected]>---
An obvious alternative would be to convert boot code right away too, but I think this has lower priority for now.
It would be nice to take these out, and it doesn't look as if it's too much work to do, but I guess we can settle for getting them out of config.h
~Andrew
Re: [PATCH v6 3/7] VMX: convert entry point annotations
In reply to Jan BeulichQuoted 35 lines · Jan Beulich
Quoted 34 lines · Andrew Cooper
Quoted 18 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>---
v6: New.xen/arch/x86/hvm/vmx/entry.S +1
-1@@ -24,7 +24,7 @@ #define VMRESUME .byte 0x0f,0x01,0xc3 #define VMLAUNCH .byte 0x0f,0x01,0xc2 -ENTRY(vmx_asm_vmexit_handler) +FUNC(vmx_asm_vmexit_handler) SAVE_ALL mov %cr2,%raxxen/arch/x86/hvm/vmx/entry.S UNLIKELY_END(realmode) · line 135
Quoted 5 lines
xen/arch/x86/hvm/vmx/entry.S +1
-1@@ -132,7 +132,7 @@ UNLIKELY_END(realmode) call vmx_vmentry_failure jmp .Lvmx_process_softirqs -ENTRY(vmx_asm_do_vmentry) +LABEL(vmx_asm_do_vmentry)This really is a function, not a label.
xen.git/xen$ git grep
vmx_asm_do_vmentryarch/x86/hvm/vmx/entry.S:135:ENTRY(vmx_asm_do_vmentry) arch/x86/hvm/vmx/vmcs.c:1855:void noreturnvmx_asm_do_vmentry(void); arch/x86/hvm/vmx/vmcs.c:1929:reset_stack_and_jump(vmx_asm_do_vmentry);It is giant mess, of two functions forming part of the same loop.
Quoted 7 lines
Quoted 3 lines
Considering that you declines to take CODE, I don't know what to suggest. The point of CODE, distinct to FUNC, was to identify the places where weird things were going on, and this absolutely counts.
What's not clear to me: How would
CODE()differ from bothFUNC()andLABEL()? And if the symbol is to be a function, what's wrong with usingFUNC()here as is?
Well, I figured this one: FUNC() may switch sections following patch 1, so indeed we'd need something that is much like FUNC(), but without the (optional) section switch.
Jan
Re: [PATCH v5 4/8] Arm: annotate entry points with type and size
In reply to Jan BeulichHi Jan,
Quoted 15 lines · Jan Beulich
Quoted 5 lines · Jan Beulich
Use the generic framework in
xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones.Quoted 8 lines
Note that
ASM_INT()is switched toDATA(), notDATA_LOCAL(), as the only use site wants the symbol global anyway.Signed-off-by Jan Beulich <[email protected]>Reviewed-by Julien Grall <[email protected]>---
Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches.
Quoted 4 lines
As this was meanwhile committed, I'd like to understand you preference for further conversion steps: I can certainly see to find time to make some actual progress here, but it might also be that you prefer to do so yourself. Please let me know.
Sorry for the late reply. I will have a look.
Cheers,
Signature · 1 line
Julien Grall
v7 cover (mostly) x86+Arm32: add/convert entry point annotations
In reply to Jan Beulich01: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions 02: VMX: convert entry point annotations
03: x86/ACPI: annotate assembly functions with type and size 04: x86/kexec: convert entry point annotations
05: x86: convert dom_crash_sync_extable() annotation
06: x86: move ENTRY(), GLOBAL(), and ALIGN
07: Arm32: use new-style entry annotations for library code 08: Arm32: use new-style entry annotations for MMU code
09: Arm32: use new-style entry annotations for entry code 10: Arm32: use new-style entry annotations in head.S
11: Arm: purge ENTRY(), ENDPROC(), and ALIGN
Jan
PATCH v7 1/11 common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Leverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). In fact Roger wants the detection to be in Kconfig, for LIVEPATCH to depend on it. Yet the whole underlying discussion there imo would first need settling (and therefore reviving).
Note that we'd need to split DATA() in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
---
v7: Override SYM_PUSH_SECTION() in arch/x86/indirect-thunk.S. Re-base,
notably to deal with fallout from fba250ae604e ("xen/arm64: head:
Add missing code symbol annotations").
v6: Deal with x86'es entry_PF() and entry_int82() falling through to the
next "function". Re-base.
v5: Re-base over changes earlier in the series.
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).
Config.mk +1 -1
@@ -102,7 +102,7 @@ cc-option = $(shell if $(1) $(2:-Wno-%=- # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile +3 -0
@@ -412,6 +412,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assembler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/arm64/head.S +2 -2
@@ -90,7 +90,7 @@ * 4K-aligned address. */ -FUNC(start) +LABEL(start) /* * DO NOT MODIFY. Image header expected by Linux boot-loaders. */
@@ -224,7 +224,7 @@ section_table: .align 5 #endif /* CONFIG_ARM_EFI */ -FUNC_LOCAL(real_start) +LABEL_LOCAL(real_start) /* BSS should be zeroed when booting without EFI */ mov x26, #0 /* x26 := skip_zero_bss */
xen/arch/arm/xen.lds.S +3 -0
@@ -152,6 +152,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -99,6 +99,9 @@ SECTIONS DECL_SECTION(.init.text) { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -96,6 +96,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/indirect-thunk.S +4 -0
@@ -11,6 +11,10 @@ #include <asm/asm_defns.h> +/* Section placement is done explicitly here; override the respective macro. */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) + .macro IND_THUNK_RETPOLINE reg:req call 1f int3
xen/arch/x86/x86_64/compat/entry.S +3 -0
@@ -31,6 +31,9 @@ FUNC(entry_int82) mov %rsp, %rdi call do_entry_int82 +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp compat_test_all_events +#endif END(entry_int82) /* %rbx: struct vcpu */
xen/arch/x86/x86_64/entry.S +7 -1
@@ -771,6 +771,9 @@ END(common_interrupt) FUNC(entry_PF) ENDBR64 movb $X86_EXC_PF, EFRAME_entry_vector(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_exception +#endif END(entry_PF) /* No special register assumptions. */ FUNC(handle_exception, 0)
@@ -1084,8 +1087,11 @@ FUNC(entry_NMI) ENDBR64 pushq $0 movb $X86_EXC_NMI, EFRAME_entry_vector(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_ist_exception +#endif END(entry_NMI) - +/* No special register assumptions. */ FUNC(handle_ist_exception) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL
xen/arch/x86/xen.lds.S +6 -0
@@ -82,6 +82,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -201,6 +204,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -18,6 +18,14 @@ #define SYM_ALIGN(align...) .balign align +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -32,7 +40,14 @@SYM_ALIGN (align); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -47,6 +62,7 @@#endif #define FUNC(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align)) #define LABEL(name, align...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align))
@@ -54,6 +70,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) #define FUNC_LOCAL(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align)) #define LABEL_LOCAL(name, align...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align))
PATCH v7 2/11 VMX: convert entry point annotations
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
v6: New.
xen/arch/x86/hvm/vmx/entry.S +3 -5
@@ -24,7 +24,7 @@ #define VMRESUME .byte 0x0f,0x01,0xc3 #define VMLAUNCH .byte 0x0f,0x01,0xc2 -ENTRY(vmx_asm_vmexit_handler) +FUNC(vmx_asm_vmexit_handler) SAVE_ALL mov %cr2,%rax
@@ -187,7 +187,7 @@ UNLIKELY_END(realmode) call vmx_vmentry_failure jmp .Lvmx_process_softirqs -ENTRY(vmx_asm_do_vmentry) +LABEL(vmx_asm_do_vmentry) GET_CURRENT(bx) jmp .Lvmx_do_vmentry
@@ -205,6 +205,4 @@ ENTRY(vmx_asm_do_vmentry) sti call do_softirq jmp .Lvmx_do_vmentry - - .type vmx_asm_vmexit_handler, @function - .size vmx_asm_vmexit_handler, . - vmx_asm_vmexit_handler +END(vmx_asm_vmexit_handler)
PATCH v7 3/11 x86/ACPI: annotate assembly function/data with type and size
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
v7: Make do_suspend_lowlevel() a single function.
v6: New.
xen/arch/x86/acpi/wakeup_prot.S +4 -4
@@ -7,7 +7,7 @@ .text .code64 -ENTRY(do_suspend_lowlevel) +FUNC(do_suspend_lowlevel) push %rbp push %rbx push %r12
@@ -43,7 +43,7 @@ ENTRY(do_suspend_lowlevel) * * Everything else, including the stack, needs restoring. */ -ENTRY(s3_resume) +LABEL(s3_resume) lgdt boot_gdtr(%rip) mov saved_cr0(%rip), %rax
@@ -132,6 +132,7 @@ ENTRY(s3_resume) pop %rbx pop %rbp ret +END(do_suspend_lowlevel) .data .align 16
@@ -142,5 +143,4 @@ saved_cr0: .quad 0 saved_ssp: .quad 0 #endif -GLOBAL(saved_magic) - .long 0x9abcdef0 +ASM_INT(saved_magic, 0x9abcdef0)
PATCH v7 4/11 x86/kexec: convert entry point annotations
In reply to Jan BeulichUse the generic framework from xen/linkage.h.
---
v7: Use alternative approach, un-defining CONFIG_CC_SPLIT_SECTIONS.
v6: New.
xen/arch/x86/x86_64/kexec_reloc.S +17 -23
@@ -13,6 +13,9 @@ .file __FILE__ +/* All contents of .text.kexec wants to be kept together. */ +#undef CONFIG_CC_SPLIT_SECTIONS + #include <xen/kimage.h> #include <asm/asm_defns.h>
@@ -21,10 +24,9 @@ #include <asm/machine_kexec.h> .section .text.kexec, "ax", @progbits - .align PAGE_SIZE .code64 -ENTRY(kexec_reloc) +FUNC(kexec_reloc, PAGE_SIZE) /* %rdi - code page maddr */ /* %rsi - page table maddr */ /* %rdx - indirection page maddr */
@@ -91,8 +93,9 @@ ENTRY(kexec_reloc) push $0x10 push %rax lretq +END(kexec_reloc) -relocate_pages: +FUNC_LOCAL(relocate_pages) /* %rdi - indirection page maddr */ pushq %rbx
@@ -138,10 +141,11 @@ relocate_pages: .L_done: popq %rbx ret +END(relocate_pages) .code32 -compatibility_mode: +FUNC_LOCAL(compatibility_mode) /* Setup some sane segments. */ movl $0x0008, %eax movl %eax, %ds
@@ -168,39 +172,29 @@ compatibility_mode: /* Call the image entry point. This should never return. */ call *%ebp ud2 +END(compatibility_mode) - .align 4 -compat_mode_gdt_desc: +DATA_LOCAL(compat_mode_gdt_desc, 4) .word .Lcompat_mode_gdt_end - compat_mode_gdt -1 .quad 0x0000000000000000 /* set in call_32_bit above */ +END(compat_mode_gdt_desc) - .type compat_mode_gdt_desc, @object - .size compat_mode_gdt_desc, . - compat_mode_gdt_desc - - .align 8 -compat_mode_gdt: +DATA_LOCAL(compat_mode_gdt, 8) .quad 0x0000000000000000 /* null */ .quad 0x00cf93000000ffff /* 0x0008 ring 0 data */ .quad 0x00cf9b000000ffff /* 0x0010 ring 0 code, compatibility */ .Lcompat_mode_gdt_end: +END(compat_mode_gdt) - .type compat_mode_gdt, @object - .size compat_mode_gdt, . - compat_mode_gdt - -compat_mode_idt: +DATA_LOCAL(compat_mode_idt) .word 0 /* limit */ .long 0 /* base */ - - .type compat_mode_idt, @object - .size compat_mode_idt, . - compat_mode_idt +END(compat_mode_idt) /* * 16 words of stack are more than enough. */ - .align 8 -reloc_stack: +DATA_LOCAL(reloc_stack, 8) .fill 16,8,0 .Lreloc_stack_base: - - .type reloc_stack, @object - .size reloc_stack, . - reloc_stack +END(reloc_stack)
PATCH v7 5/11 x86: convert dom_crash_sync_extable() annotation
In reply to Jan Beulich... to that from the generic framework in xen/linkage.h.
---
v7: Split from larger patch.
xen/arch/x86/x86_64/entry.S +1 -1
@@ -624,7 +624,7 @@ domain_crash_page_fault_0x8: ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP movq %rsi,%rdi call show_page_walk -ENTRY(dom_crash_sync_extable) +LABEL(dom_crash_sync_extable, 0) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP # Get out of the guest-save area of the stack. GET_STACK_END(ax)
PATCH v7 6/11 x86: move ENTRY(), GLOBAL(), and ALIGN
In reply to Jan Beulich... to boot code, limiting their scope and thus allowing to drop respective #undef-s from the linker script.
---
An obvious alternative would be to convert boot code right away too, but I think this has lower priority for now.
---
v7: Re-base.
v6: New.
xen/arch/x86/boot/head.S +9 -0
@@ -10,6 +10,15 @@ #include <asm/cpufeature.h> #include <public/elfnote.h> +#define ALIGN .align CONFIG_FUNCTION_ALIGNMENT, CODE_FILL +#define ENTRY(name) \ + ALIGN; \ + GLOBAL(name) +#define GLOBAL(name) \ + .globl name; \ + .hidden name; \ + name: + .section .text.header, "ax", @progbits .code32
xen/arch/x86/include/asm/config.h +0 -8
@@ -42,14 +42,6 @@/* Linkage for x86 */ #ifdef __ASSEMBLY__#define CODE_FILL 0x90 -#define ALIGN .align CONFIG_FUNCTION_ALIGNMENT, CODE_FILL -#define ENTRY (name) \ - ALIGN; \ - GLOBAL(name) -#define GLOBAL (name) \ - .globl name; \ - .hidden name; \ - name:#endif #define NR_hypercalls 64
xen/arch/x86/x86_64/entry.S +1 -1
@@ -1260,7 +1260,7 @@ FUNC_LOCAL(autogen_stubs, 0) /* Automati .if vec >= FIRST_IRQ_VECTOR #endif - ALIGN + .align CONFIG_FUNCTION_ALIGNMENT, CODE_FILL 1: ENDBR64 pushq $0
xen/arch/x86/xen.lds.S +0 -2
@@ -5,8 +5,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> #include <asm/page.h> -#undef ENTRY -#undef ALIGN #ifdef EFI
PATCH v7 7/11 Arm32: use new-style entry annotations for library code
In reply to Jan BeulichNo functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) as well as __memzero lose their function-ness and size.
---
If the function-ness is important, some new construct would need inventing. Not setting size for the aliases may even be desirable, as I'm uncertain whether it is really legal in ELF that two entities overlap in space.
I fear I'm breaking __memzero(), as I don't understand the purpose of the ".word 0" next to where the FUNC_LOCAL() appears.
---
v7: New.
xen/arch/arm/arm32/lib/findbit.S +16 -16
@@ -20,7 +20,7 @@ * Purpose : Find a 'zero' bit * Prototype: int find_first_zero_bit(void *addr, unsigned int maxbit); */ -ENTRY(_find_first_zero_bit_le) +FUNC(_find_first_zero_bit_le) teq r1, #0 beq 3f mov r2, #0
@@ -35,13 +35,13 @@ ENTRY(_find_first_zero_bit_le) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_zero_bit_le) +END(_find_first_zero_bit_le) /* * Purpose : Find next 'zero' bit * Prototype: int find_next_zero_bit(void *addr, unsigned int maxbit, int offset) */ -ENTRY(_find_next_zero_bit_le) +FUNC(_find_next_zero_bit_le) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -55,13 +55,13 @@ ENTRY(_find_next_zero_bit_le) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_zero_bit_le) +END(_find_next_zero_bit_le) /* * Purpose : Find a 'one' bit * Prototype: int find_first_bit(const unsigned long *addr, unsigned int maxbit); */ -ENTRY(_find_first_bit_le) +FUNC(_find_first_bit_le) teq r1, #0 beq 3f mov r2, #0
@@ -76,13 +76,13 @@ ENTRY(_find_first_bit_le) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_bit_le) +END(_find_first_bit_le) /* * Purpose : Find next 'one' bit * Prototype: int find_next_zero_bit(void *addr, unsigned int maxbit, int offset) */ -ENTRY(_find_next_bit_le) +FUNC(_find_next_bit_le) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -95,11 +95,11 @@ ENTRY(_find_next_bit_le) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_bit_le) +END(_find_next_bit_le) #ifdef __ARMEB__ -ENTRY(_find_first_zero_bit_be) +FUNC(_find_first_zero_bit_be) teq r1, #0 beq 3f mov r2, #0
@@ -114,9 +114,9 @@ ENTRY(_find_first_zero_bit_be) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_zero_bit_be) +END(_find_first_zero_bit_be) -ENTRY(_find_next_zero_bit_be) +FUNC(_find_next_zero_bit_be) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -131,9 +131,9 @@ ENTRY(_find_next_zero_bit_be) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_zero_bit_be) +END(_find_next_zero_bit_be) -ENTRY(_find_first_bit_be) +FUNC(_find_first_bit_be) teq r1, #0 beq 3f mov r2, #0
@@ -148,9 +148,9 @@ ENTRY(_find_first_bit_be) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_bit_be) +END(_find_first_bit_be) -ENTRY(_find_next_bit_be) +FUNC(_find_next_bit_be) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -164,7 +164,7 @@ ENTRY(_find_next_bit_be) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_bit_be) +END(_find_next_bit_be) #endif
xen/arch/arm/arm32/lib/lib1funcs.S +20 -22
110 lines not on this page · raw message
xen/arch/arm/arm32/lib/lshrdi3.S +3 -4
@@ -34,8 +34,8 @@ along with this program; see the file CO #define ah r1 #endif -ENTRY(__lshrdi3) -ENTRY(__aeabi_llsr) +FUNC(__lshrdi3) +LABEL(__aeabi_llsr) subs r3, r2, #32 rsb ip, r2, #32
@@ -47,5 +47,4 @@ ENTRY(__aeabi_llsr) mov ah, ah, lsr r2 mov pc, lr -ENDPROC(__lshrdi3) -ENDPROC(__aeabi_llsr) +END(__lshrdi3)
xen/arch/arm/arm32/lib/memchr.S +2 -3
@@ -12,8 +12,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(memchr) +FUNC(memchr, 32) and r1, r1, #0xff 1: subs r2, r2, #1 bmi 2f
@@ -23,4 +22,4 @@ ENTRY(memchr) sub r0, r0, #1 2: movne r0, #0 mov pc, lr -ENDPROC(memchr) +END(memchr)
xen/arch/arm/arm32/lib/memcpy.S +2 -2
@@ -54,8 +54,8 @@ /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ -ENTRY(memcpy) +FUNC(memcpy) #include "copy_template.S" -ENDPROC(memcpy) +END(memcpy)
xen/arch/arm/arm32/lib/memmove.S +2 -2
@@ -24,7 +24,7 @@ * occurring in the opposite direction. */ -ENTRY(memmove) +FUNC(memmove) subs ip, r0, r1 cmphi r2, ip
@@ -194,4 +194,4 @@ ENTRY(memmove) 18: backward_copy_shift push=24 pull=8 -ENDPROC(memmove) +END(memmove)
xen/arch/arm/arm32/lib/memset.S +2 -3
@@ -12,9 +12,8 @@ #include "assembler.h" .text - .align 5 -ENTRY(memset) +FUNC(memset, 32) and r1, r1, #0xff ands r3, r0, #3 @ 1 unaligned? mov ip, r0 @ preserve r0 as return value
@@ -120,4 +119,4 @@ ENTRY(memset) strb r1, [ip], #1 @ 1 add r2, r2, r3 @ 1 (r2 = r2 - (4 - r3)) b 1b -ENDPROC(memset) +END(memset)
xen/arch/arm/arm32/lib/memzero.S +3 -3
@@ -10,7 +10,7 @@ #include "assembler.h" .text - .align 5 +FUNC_LOCAL(_memzero_, 32) .word 0 /* * Align the pointer in r0. r3 contains the number of bytes that we are
@@ -29,7 +29,7 @@ * memzero again. */ -ENTRY(__memzero) +LABEL(__memzero) mov r2, #0 @ 1 ands r3, r0, #3 @ 1 unaligned? bne 1b @ 1
@@ -121,4 +121,4 @@ ENTRY(__memzero) tst r1, #1 @ 1 a byte left over strneb r2, [r0], #1 @ 1 mov pc, lr @ 1 -ENDPROC(__memzero) +END(_memzero_)
xen/arch/arm/arm32/lib/strchr.S +2 -3
@@ -14,8 +14,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(strchr) +FUNC(strchr, 32) and r1, r1, #0xff 1: ldrb r2, [r0], #1 teq r2, r1
@@ -25,4 +24,4 @@ ENTRY(strchr) movne r0, #0 subeq r0, r0, #1 mov pc, lr -ENDPROC(strchr) +END(strchr)
xen/arch/arm/arm32/lib/strrchr.S +2 -3
@@ -12,8 +12,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(strrchr) +FUNC(strrchr, 32) and r1, r1, #0xff mov r3, #0 1: ldrb r2, [r0], #1
@@ -23,4 +22,4 @@ ENTRY(strrchr) bne 1b mov r0, r3 mov pc, lr -ENDPROC(strrchr) +END(strrchr)
PATCH v7 8/11 Arm32: use new-style entry annotations for MMU code
In reply to Jan BeulichLocally override SYM_PUSH_SECTION() to retain the intended section association.
---
v7: New.
xen/arch/arm/arm32/mmu/head.S +26 -18
@@ -160,6 +160,13 @@ .endm .section .text.idmap, "ax", %progbits +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * Rebuild the boot pagetable's first-level entries. The structure
@@ -174,7 +181,7 @@ * * Clobbers r0 - r5 */ -create_page_tables: +FUNC_LOCAL(create_page_tables) /* Prepare the page-tables for mapping Xen */ mov_w r0, XEN_VIRT_START
@@ -263,7 +270,7 @@ use_temporary_mapping: mov r12, #1 /* r12 := temporary mapping created */ mov pc, lr -ENDPROC(create_page_tables) +END(create_page_tables) /* * Turn on the Data Cache and the MMU. The function will return
@@ -276,7 +283,7 @@ ENDPROC(create_page_tables) * * Clobbers r0 - r5 */ -enable_mmu: +FUNC_LOCAL(enable_mmu) PRINT("- Turning on paging -\r\n") /*
@@ -346,7 +353,7 @@ enable_mmu: teq r12, #0 beq remove_identity_mapping b remove_temporary_mapping -ENDPROC(enable_mmu) +END(enable_mmu) /* * Switch to the runtime mapping. The logic depends on whether the
@@ -366,7 +373,7 @@ ENDPROC(enable_mmu) * * Clobbers r0 - r4 */ -switch_to_runtime_mapping: +FUNC_LOCAL(switch_to_runtime_mapping) /* * Jump to the runtime mapping if the virt and phys are not * clashing
@@ -411,7 +418,7 @@ ready_to_switch: PRINT_ID("- Jumping to runtime address -\r\n") mov pc, lr -ENDPROC(switch_to_runtime_mapping) +END(switch_to_runtime_mapping) /* * Enable mm (turn on the data cache and the MMU) for secondary CPUs.
@@ -428,7 +435,7 @@ ENDPROC(switch_to_runtime_mapping) * * Clobbers r0 - r6 */ -ENTRY(enable_secondary_cpu_mm) +FUNC(enable_secondary_cpu_mm) mov r6, lr bl create_page_tables
@@ -456,7 +463,7 @@ ENTRY(enable_secondary_cpu_mm) /* Return to the virtual address requested by the caller. */ mov pc, r6 -ENDPROC(enable_secondary_cpu_mm) +END(enable_secondary_cpu_mm) /* * Enable mm (turn on the data cache and the MMU) for the boot CPU.
@@ -474,7 +481,7 @@ ENDPROC(enable_secondary_cpu_mm) * * Clobbers r0 - r6 */ -ENTRY(enable_boot_cpu_mm) +FUNC(enable_boot_cpu_mm) mov r6, lr #ifdef CONFIG_EARLY_PRINTK
@@ -491,7 +498,7 @@ ENTRY(enable_boot_cpu_mm) /* Address in the runtime mapping to jump to after the MMU is enabled */ mov lr, r6 b enable_mmu -ENDPROC(enable_boot_cpu_mm) +END(enable_boot_cpu_mm) /* * Remove the 1:1 map from the page-tables. It is not easy to keep track
@@ -503,7 +510,7 @@ ENDPROC(enable_boot_cpu_mm) * * Clobbers r0 - r3 */ -remove_identity_mapping: +FUNC_LOCAL(remove_identity_mapping) PRINT("- Removing the identity mapping -\r\n") /* r2:r3 := invalid page-table entry */
@@ -518,14 +525,14 @@ remove_identity_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_identity_mapping) +END(remove_identity_mapping) /* * Remove the temporary mapping of Xen starting at TEMPORARY_XEN_VIRT_START. * * Clobbers r0 - r3 */ -remove_temporary_mapping: +FUNC_LOCAL(remove_temporary_mapping) PRINT("- Removing the temporary mapping -\r\n") /* r2:r3 := invalid page-table entry */
@@ -541,13 +548,14 @@ remove_temporary_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_temporary_mapping) +END(remove_temporary_mapping) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) /* * Switch TTBR
@@ -555,7 +563,7 @@ ENDPROC(fail) * * TODO: This code does not comply with break-before-make. */ -ENTRY(switch_ttbr) +FUNC(switch_ttbr) dsb /* Ensure the flushes happen before * continuing */ isb /* Ensure synchronization with previous
@@ -579,4 +587,4 @@ ENTRY(switch_ttbr) isb mov pc, lr -ENDPROC(switch_ttbr) +END(switch_ttbr)
PATCH v7 11/11 Arm: purge ENTRY(), ENDPROC(), and ALIGN
In reply to Jan BeulichThey're no longer used. This also makes it unnecessary to #undef two of them in the linker script.
---
v7: New.
xen/arch/arm/include/asm/config.h +0 -8
@@ -53,17 +53,9 @@/* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .balign CONFIG_FUNCTION_ALIGNMENT -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name:#define GLOBAL (name) \ .globl name; \ name: -#define ENDPROC (name) \ - .type name, %function; \ - END(name)#endif #include <xen/const.h>
xen/arch/arm/xen.lds.S +0 -2
@@ -6,8 +6,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> #include <asm/page.h> -#undef ENTRY -#undef ALIGN ENTRY(start)
Re: [PATCH v7 08/11] Arm32: use new-style entry annotations for MMU code
In reply to Jan BeulichQuoted 6 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>---
v7: New.
I'm sorry, I failed to Cc maintainers here.
Jan
Quoted 166 lines
xen/arch/arm/arm32/mmu/head.S +26
-18@@ -160,6 +160,13 @@ .endm .section .text.idmap, "ax", %progbits +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * Rebuild the boot pagetable's first-level entries. The structure@@ -174,7 +181,7 @@ * * Clobbers r0 - r5 */ -create_page_tables: +FUNC_LOCAL(create_page_tables) /* Prepare the page-tables for mapping Xen */ mov_w r0, XEN_VIRT_START@@ -263,7 +270,7 @@ use_temporary_mapping: mov r12, #1 /* r12 := temporary mapping created */ mov pc, lr -ENDPROC(create_page_tables) +END(create_page_tables) /* * Turn on the Data Cache and the MMU. The function will return@@ -276,7 +283,7 @@ ENDPROC(create_page_tables) * * Clobbers r0 - r5 */ -enable_mmu: +FUNC_LOCAL(enable_mmu) PRINT("- Turning on paging -\r\n") /*@@ -346,7 +353,7 @@ enable_mmu: teq r12, #0 beq remove_identity_mapping b remove_temporary_mapping -ENDPROC(enable_mmu) +END(enable_mmu) /* * Switch to the runtime mapping. The logic depends on whether the@@ -366,7 +373,7 @@ ENDPROC(enable_mmu) * * Clobbers r0 - r4 */ -switch_to_runtime_mapping: +FUNC_LOCAL(switch_to_runtime_mapping) /* * Jump to the runtime mapping if the virt and phys are not * clashing@@ -411,7 +418,7 @@ ready_to_switch: PRINT_ID("- Jumping to runtime address -\r\n") mov pc, lr -ENDPROC(switch_to_runtime_mapping) +END(switch_to_runtime_mapping) /* * Enable mm (turn on the data cache and the MMU) for secondary CPUs.@@ -428,7 +435,7 @@ ENDPROC(switch_to_runtime_mapping) * * Clobbers r0 - r6 */ -ENTRY(enable_secondary_cpu_mm) +FUNC(enable_secondary_cpu_mm) mov r6, lr bl create_page_tables@@ -456,7 +463,7 @@ ENTRY(enable_secondary_cpu_mm) /* Return to the virtual address requested by the caller. */ mov pc, r6 -ENDPROC(enable_secondary_cpu_mm) +END(enable_secondary_cpu_mm) /* * Enable mm (turn on the data cache and the MMU) for the boot CPU.@@ -474,7 +481,7 @@ ENDPROC(enable_secondary_cpu_mm) * * Clobbers r0 - r6 */ -ENTRY(enable_boot_cpu_mm) +FUNC(enable_boot_cpu_mm) mov r6, lr #ifdef CONFIG_EARLY_PRINTK@@ -491,7 +498,7 @@ ENTRY(enable_boot_cpu_mm) /* Address in the runtime mapping to jump to after the MMU is enabled */ mov lr, r6 b enable_mmu -ENDPROC(enable_boot_cpu_mm) +END(enable_boot_cpu_mm) /* * Remove the 1:1 map from the page-tables. It is not easy to keep track@@ -503,7 +510,7 @@ ENDPROC(enable_boot_cpu_mm) * * Clobbers r0 - r3 */ -remove_identity_mapping: +FUNC_LOCAL(remove_identity_mapping) PRINT("- Removing the identity mapping -\r\n") /* r2:r3 := invalid page-table entry */@@ -518,14 +525,14 @@ remove_identity_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_identity_mapping) +END(remove_identity_mapping) /* * Remove the temporary mapping of Xen starting at TEMPORARY_XEN_VIRT_START. * * Clobbers r0 - r3 */ -remove_temporary_mapping: +FUNC_LOCAL(remove_temporary_mapping) PRINT("- Removing the temporary mapping -\r\n") /* r2:r3 := invalid page-table entry */@@ -541,13 +548,14 @@ remove_temporary_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_temporary_mapping) +END(remove_temporary_mapping) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) /* * Switch TTBR@@ -555,7 +563,7 @@ ENDPROC(fail) * * TODO: This code does not comply with break-before-make. */ -ENTRY(switch_ttbr) +FUNC(switch_ttbr) dsb /* Ensure the flushes happen before * continuing */ isb /* Ensure synchronization with previous@@ -579,4 +587,4 @@ ENTRY(switch_ttbr) isb mov pc, lr -ENDPROC(switch_ttbr) +END(switch_ttbr)
PATCH v7 9/11 Arm32: use new-style entry annotations for entry code
In reply to Jan Beulich---
Should the GLOBAL()s also be replaced?
---
v7: New.
xen/arch/arm/arm32/entry.S +7 -5
@@ -31,7 +31,7 @@ * r4: Set to a non-zero value if a pending Abort exception took place. * Otherwise, it will be set to zero. */ -prepare_context_from_guest: +FUNC_LOCAL(prepare_context_from_guest) #ifdef CONFIG_ARM32_HARDEN_BRANCH_PREDICTOR /* * Restore vectors table to the default as it may have been
@@ -140,7 +140,7 @@ abort_guest_exit_end: skip_check: b enter_hypervisor_from_guest_preirq -ENDPROC(prepare_context_from_guest) +END(prepare_context_from_guest) /* * Macro to define a trap entry.
@@ -362,13 +362,13 @@ trap_irq: trap_fiq: vector fiq -return_from_trap: +LABEL_LOCAL(return_from_trap) /* * Restore the stack pointer from r11. It was saved on exception * entry (see __DEFINE_TRAP_ENTRY). */ mov sp, r11 -ENTRY(return_to_new_vcpu32) +LABEL(return_to_new_vcpu32) ldr r11, [sp, #UREGS_cpsr] and r11, #PSR_MODE_MASK cmp r11, #PSR_MODE_HYP
@@ -426,6 +426,7 @@ return_to_hypervisor: clrex eret sb +END(return_from_trap) /* * struct vcpu *__context_switch(struct vcpu *prev, struct vcpu *next)
@@ -435,12 +436,13 @@ return_to_hypervisor: * * Returns prev in r0 */ -ENTRY(__context_switch) +FUNC(__context_switch) add ip, r0, #VCPU_arch_saved_context stmia ip!, {r4 - sl, fp, sp, lr} /* Save register state */ add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ +END(__context_switch) /* * Local variables:
PATCH v7 10/11 Arm32: use new-style entry annotations in head.S
In reply to Jan BeulichLocally override SYM_PUSH_SECTION() to retain the intended section association.
---
v7: New.
xen/arch/arm/arm32/head.S +32 -23
@@ -48,13 +48,20 @@ .section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * This must be the very first address in the loaded image. * It should be linked at XEN_VIRT_START, and loaded at any * 4K-aligned address. */ -GLOBAL(start) +FUNC(start) /* * zImage magic header, see: * http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
@@ -104,9 +111,9 @@ primary_switched: mov r0, r8 /* r0 := paddr(FDT) */ mov_w r1, start_xen b launch -ENDPROC(start) +END(start) -GLOBAL(init_secondary) +FUNC(init_secondary) cpsid aif /* Disable all interrupts */ /* Find out where we are */
@@ -142,7 +149,7 @@ secondary_switched: /* Jump to C world */ mov_w r1, start_secondary b launch -ENDPROC(init_secondary) +END(init_secondary) /* * Check if the CPU supports virtualization extensions and has been booted
@@ -154,7 +161,7 @@ ENDPROC(init_secondary) * * Clobbers r0 - r3 */ -check_cpu_mode: +FUNC_LOCAL(check_cpu_mode) /* Check that this CPU has Hyp mode */ mrc CP32(r0, ID_PFR1) and r0, r0, #0xf000 /* Bits 12-15 define virt extensions */
@@ -174,14 +181,14 @@ check_cpu_mode: PRINT("- Xen must be entered in NS Hyp mode -\r\n") PRINT("- Please update the bootloader -\r\n") b fail -ENDPROC(check_cpu_mode) +END(check_cpu_mode) /* * Zero BSS * * Clobbers r0 - r3 */ -zero_bss: +FUNC_LOCAL(zero_bss) PRINT("- Zero BSS -\r\n") mov_w r0, __bss_start /* r0 := vaddr(__bss_start) */ mov_w r1, __bss_end /* r1 := vaddr(__bss_end) */
@@ -192,9 +199,9 @@ zero_bss: blo 1b mov pc, lr -ENDPROC(zero_bss) +END(zero_bss) -cpu_init: +FUNC_LOCAL(cpu_init) PRINT("- Setting up control registers -\r\n") mov r5, lr /* r5 := return address */
@@ -235,7 +242,7 @@ cpu_init_done: isb mov pc, r5 /* Return address is in r5 */ -ENDPROC(cpu_init) +END(cpu_init) /* * Setup the initial stack and jump to the C world
@@ -246,7 +253,7 @@ ENDPROC(cpu_init) * * Clobbers r3 */ -launch: +FUNC_LOCAL(launch) mov_w r3, init_data add r3, #INITINFO_stack /* Find the boot-time stack */ ldr sp, [r3]
@@ -255,13 +262,14 @@ launch: /* Jump to C world */ bx r1 -ENDPROC(launch) +END(launch) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) #ifdef CONFIG_EARLY_PRINTK /*
@@ -272,14 +280,14 @@ ENDPROC(fail) * * Clobbers r0 - r3 */ -init_uart: +FUNC_LOCAL(init_uart) mov_w r11, CONFIG_EARLY_UART_BASE_ADDRESS #ifdef CONFIG_EARLY_UART_INIT early_uart_init r11, r1, r2 #endif PRINT("- UART enabled -\r\n") mov pc, lr -ENDPROC(init_uart) +END(init_uart) /* * Print early debug messages.
@@ -288,14 +296,14 @@ ENDPROC(init_uart) * r11: Early UART base address * Clobbers r0-r1 */ -ENTRY(asm_puts) +FUNC(asm_puts) early_uart_ready r11, r1 ldrb r1, [r0], #1 /* Load next char */ teq r1, #0 /* Exit on nul */ moveq pc, lr early_uart_transmit r11, r1 b asm_puts -ENDPROC(asm_puts) +END(asm_puts) /* * Print a 32-bit number in hex.
@@ -304,7 +312,7 @@ ENDPROC(asm_puts) * r11: Early UART base address * Clobbers r0-r3 */ -ENTRY(asm_putn) +FUNC(asm_putn) adr_l r1, hex mov r3, #8 1:
@@ -316,18 +324,19 @@ ENTRY(asm_putn) subs r3, r3, #1 bne 1b mov pc, lr -ENDPROC(asm_putn) +END(asm_putn) RODATA_SECT(.rodata.idmap, hex, "0123456789abcdef") #endif /* CONFIG_EARLY_PRINTK */ /* This provides a C-API version of __lookup_processor_type */ -ENTRY(lookup_processor_type) +FUNC(lookup_processor_type) stmfd sp!, {r4, lr} bl __lookup_processor_type mov r0, r1 ldmfd sp!, {r4, pc} +END(lookup_processor_type) /* * Read processor ID register (CP#15, CR0), and Look up in the linker-built
@@ -338,7 +347,7 @@ ENTRY(lookup_processor_type) * r1: proc_info pointer * Clobbers r2-r4 */ -__lookup_processor_type: +FUNC_LOCAL(__lookup_processor_type) mrc CP32(r0, MIDR) /* r0 := our cpu id */ adr_l r1, __proc_info_start adr_l r2, __proc_info_end
@@ -354,7 +363,7 @@ __lookup_processor_type: mov r1, #0 2: mov pc, lr -ENDPROC(__lookup_processor_type) +END(__lookup_processor_type) /* * Local variables:
Re: [PATCH v7 03/11] x86/ACPI: annotate assembly function/data with type and size
In reply to Jan BeulichQuoted 3 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>
Quoted 33 lines
---
v7: Makedo_suspend_lowlevel()a single function.
v6: New.xen/arch/x86/acpi/wakeup_prot.S +3
-2@@ -7,7 +7,7 @@ .text .code64 -ENTRY(do_suspend_lowlevel) +FUNC(do_suspend_lowlevel) push %rbp push %rbx push %r12@@ -43,7 +43,7 @@ ENTRY(do_suspend_lowlevel) * * Everything else, including the stack, needs restoring. */ -ENTRY(s3_resume) +LABEL(s3_resume) lgdt boot_gdtr(%rip) mov saved_cr0(%rip), %rax@@ -132,6 +132,7 @@ ENTRY(s3_resume) pop %rbx pop %rbp ret +END(do_suspend_lowlevel) .data .align 16
xen/arch/x86/acpi/wakeup_prot.S saved_cr0: .quad 0 · line 144
Quoted 2 lines
xen/arch/x86/acpi/wakeup_prot.S +0
-0@@ -142,5 +143,4 @@ saved_cr0: .quad 0 saved_ssp: .quad 0 #endif
... we do need something for these 3 variables, or they want to move into a C file.
~Andrew
Re: [PATCH v7 02/11] VMX: convert entry point annotations
In reply to Jan BeulichQuoted 3 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>
Re: [PATCH v7 05/11] x86: convert dom_crash_sync_extable() annotation
In reply to Jan BeulichQuoted 3 lines · Jan Beulich
... to that from the generic framework in
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>
Re: [PATCH v7 04/11] x86/kexec: convert entry point annotations
In reply to Jan BeulichQuoted 3 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>
Re: [PATCH v7 03/11] x86/ACPI: annotate assembly function/data with type and size
In reply to Andrew CooperQuoted 6 lines · Andrew Cooper
Quoted 3 lines · Jan Beulich
Use the generic framework from
xen/linkage.h.Signed-off-by Jan Beulich <[email protected]>
Thanks.
Quoted 6 lines
Quoted 6 lines
xen/arch/x86/acpi/wakeup_prot.S +1
-0@@ -132,6 +132,7 @@ ENTRY(s3_resume) pop %rbx pop %rbp ret +END(do_suspend_lowlevel)
Quoted 8 lines
xen/arch/x86/acpi/wakeup_prot.S saved_cr0: .quad 0 · line 144
Quoted 5 lines
xen/arch/x86/acpi/wakeup_prot.S +0
-0.data .align 16@@ -142,5 +143,4 @@ saved_cr0: .quad 0 saved_ssp: .quad 0 #endif... we do need something for these 3 variables, or they want to move into a C file.
We have DATA_LOCAL(). Moving to a C file would be odd, as they're not used outside of this file (and hence aren't global).
Jan
Ping: [PATCH v7 00/11] (mostly) x86+Arm32: add/convert entry point annotations
In reply to Jan BeulichQuoted 11 lines · Jan Beulich
01: common: honor
CONFIG_CC_SPLIT_SECTIONSalso for assembly functions 02: VMX: convert entry point annotations
03: x86/ACPI: annotate assembly functions with type and size 04: x86/kexec: convert entry point annotations
05: x86: convertdom_crash_sync_extable()annotation
06: x86: moveENTRY(),GLOBAL(), and ALIGN
07: Arm32: use new-style entry annotations for library code 08: Arm32: use new-style entry annotations for MMU code
09: Arm32: use new-style entry annotations for entry code 10: Arm32: use new-style entry annotations inhead.S
11: Arm: purgeENTRY(),ENDPROC(), and ALIGN
Patches 2-6 went in. Arm maintainers - what about 7-11?
Jan
Re: [PATCH v7 07/11] Arm32: use new-style entry annotations for library code
In reply to Jan BeulichHi Jan,
Sorry for the late answer.
Quoted 10 lines · Jan Beulich
No functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) as well as
__memzerolose their function-ness and size.Signed-off-by Jan Beulich <[email protected]>---
If the function-ness is important, some new construct would need inventing. Not setting size for the aliases may even be desirable, as I'm uncertain whether it is really legal in ELF that two entities overlap in space.
I can't think of a reason where we would need the "function-ness".
Quoted 3 lines
I fear I'm breaking
__memzero(), as I don't understand the purpose of the ".word 0" next to where theFUNC_LOCAL()appears.
I am not entirely sure either. AFAIK, "0" is not a valid instruction.
This code was taken from Linux, the history doesn't give much clue because it seems the ".word 0" was added before Linux used git.
However, it looks like Linux replace __memzero with memset() 6 years ago on arm32. So maybe we should get rid of it? This would at least avoid worrying on the purpose of ".word 0".
The rest of the patch looks good to me.
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v7 09/11] Arm32: use new-style entry annotations for entry code
In reply to Jan BeulichHi Jan,
Quoted 3 lines · Jan Beulich
Signed-off-by Jan Beulich <[email protected]>---
Should the GLOBAL()s also be replaced?
What would you replace them with?
Quoted 24 lines
---
v7: New.xen/arch/arm/arm32/entry.S +2
-2@@ -31,7 +31,7 @@ * r4: Set to a non-zero value if a pending Abort exception took place. * Otherwise, it will be set to zero. */ -prepare_context_from_guest: +FUNC_LOCAL(prepare_context_from_guest) #ifdef CONFIG_ARM32_HARDEN_BRANCH_PREDICTOR /* * Restore vectors table to the default as it may have been@@ -140,7 +140,7 @@ abort_guest_exit_end: skip_check: b enter_hypervisor_from_guest_preirq -ENDPROC(prepare_context_from_guest) +END(prepare_context_from_guest) /* * Macro to define a trap entry.
xen/arch/arm/arm32/entry.S trap_irq: · line 365
Quoted 5 lines
xen/arch/arm/arm32/entry.S +1
-1@@ -362,13 +362,13 @@ trap_irq: trap_fiq: vector fiq -return_from_trap: +LABEL_LOCAL(return_from_trap)
OOI, why do we need to annotate return_from_trap?
xen/arch/arm/arm32/entry.S trap_irq: · line 371
Quoted 7 lines
xen/arch/arm/arm32/entry.S +1
-1/* * Restore the stack pointer from r11. It was saved on exception * entry (see __DEFINE_TRAP_ENTRY). */ mov sp, r11 -ENTRY(return_to_new_vcpu32) +LABEL(return_to_new_vcpu32)
I am a bit confused why this is a LABEL rather than a FUNC. But I wonder if either of them are corrrect? The code above is meant to fall into this one. So I think at least the alignment should be 0.
Quoted 17 lines
xen/arch/arm/arm32/entry.S +1
-1ldr r11, [sp, #UREGS_cpsr] and r11, #PSR_MODE_MASK cmp r11, #PSR_MODE_HYP@@ -426,6 +426,7 @@ return_to_hypervisor: clrex eret sb +END(return_from_trap) /* * struct vcpu *__context_switch(struct vcpu *prev, struct vcpu *next)@@ -435,12 +436,13 @@ return_to_hypervisor: * * Returns prev in r0 */ -ENTRY(__context_switch)
xen/arch/arm/arm32/entry.S return_to_hypervisor: · line 448
Quoted 10 lines
xen/arch/arm/arm32/entry.S +2
-0+FUNC(__context_switch) add ip, r0, #VCPU_arch_saved_context stmia ip!, {r4 - sl, fp, sp, lr} /* Save register state */ add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ +END(__context_switch) /* * Local variables:
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v7 10/11] Arm32: use new-style entry annotations in head.S
In reply to Jan BeulichHi Jan,
Quoted 10 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>---
v7: New.
xen/arch/arm/arm32/head.S line 57
Quoted 10 lines
xen/arch/arm/arm32/head.S +7
-0@@ -48,13 +48,20 @@ .section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr)
Are you suggesting the code in arch/*/head.S has a latent bug?
The rest lgtm to me pending the clarification.
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v7 11/11] Arm: purge ENTRY(), ENDPROC(), and ALIGN
In reply to Jan BeulichHi Jan,
Quoted 4 lines · Jan Beulich
They're no longer used. This also makes it unnecessary to #undef two of them in the linker script.
Signed-off-by Jan Beulich <[email protected]>
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v7 07/11] Arm32: use new-style entry annotations for library code
In reply to Julien GrallQuoted 9 lines · Julien Grall
Hi Jan,
Sorry for the late answer.
Quoted 4 lines · Jan Beulich
No functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) as well as
__memzerolose their function-ness and size.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Jan Beulich <[email protected]>---
If the function-ness is important, some new construct would need inventing. Not setting size for the aliases may even be desirable, as I'm uncertain whether it is really legal in ELF that two entities overlap in space.I can't think of a reason where we would need the "function-ness".
Good, thanks for confirming.
Quoted 7 lines
Quoted 2 lines
I fear I'm breaking
__memzero(), as I don't understand the purpose of the ".word 0" next to where theFUNC_LOCAL()appears.I am not entirely sure either. AFAIK, "0" is not a valid instruction.
This code was taken from Linux, the history doesn't give much clue because it seems the ".word 0" was added before Linux used git.
My vague guess is that this is a crude way of arranging for desired alignment of labels later in the function. That wouldn't require use of .word (could simply be a nop), yet what specifically is used there doesn't matter for the patch here.
Quoted 3 lines
However, it looks like Linux replace
__memzerowithmemset()6 years ago on arm32. So maybe we should get rid of it? This would at least avoid worrying on the purpose of ".word 0".
Certainly an option, yet may I remind you of your replies [1], [2] to a much older patch of mine, which I still have pending for the suggested removal never having happened? I fear the patch here may get stuck over this just like the other one did.
Jan
[1] https://lists.xen.org/archives/html/xen-devel/2022-08/msg01185.html
[2] https://lists.xen.org/archives/html/xen-devel/2022-08/msg01190.html
Re: [PATCH v7 09/11] Arm32: use new-style entry annotations for entry code
In reply to Julien GrallQuoted 6 lines · Julien Grall
Quoted 3 lines · Jan Beulich
Signed-off-by Jan Beulich <[email protected]>---
Should the GLOBAL()s also be replaced?What would you replace them with?
LABEL() or, perhaps better, DATA()/END() pairs.
Quoted 8 lines
xen/arch/arm/arm32/entry.S trap_irq: · line 365
Quoted 6 lines
xen/arch/arm/arm32/entry.S +1
-1@@ -362,13 +362,13 @@ trap_irq: trap_fiq: vector fiq -return_from_trap: +LABEL_LOCAL(return_from_trap)OOI, why do we need to annotate
return_from_trap?
We don't _need_ to; it's for consistency. Please advise whether you want me to drop that change (it's the only use of LABEL_LOCAL() throughout the series). But please be aware that then END(return_from_trap) also needs dropping (i.e. leaving the range uncovered as far as plain ELF metadata goes).
Quoted 11 lines
xen/arch/arm/arm32/entry.S trap_irq: · line 371
Quoted 7 lines
xen/arch/arm/arm32/entry.S +1
-1/* * Restore the stack pointer from r11. It was saved on exception * entry (see __DEFINE_TRAP_ENTRY). */ mov sp, r11 -ENTRY(return_to_new_vcpu32) +LABEL(return_to_new_vcpu32)I am a bit confused why this is a LABEL rather than a FUNC. But I wonder if either of them are corrrect? The code above is meant to fall into this one.
My take is that function (or object) ranges shouldn't overlap. That's an abstract reason. There's a practical reason, too: With "common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions" FUNC() will change sections when CC_SPLIT_SECTIONS=y (which LABEL() won't). Section changes clearly may not happen when fall-through is intended.
Quoted 1 line
So I think at least the alignment should be 0.
That would be a change compared to the prior use of ENTRY(). I can certainly do so, but without having sufficient context my goal was to leave existing alignment unaltered as far as possible (on the assumption that there's a reason for it).
Jan
Re: [PATCH v7 10/11] Arm32: use new-style entry annotations in head.S
In reply to Julien GrallQuoted 12 lines · Julien Grall
Quoted 11 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>---
v7: New.xen/arch/arm/arm32/head.S +0
-0@@ -48,13 +48,20 @@
Quoted 11 lines
xen/arch/arm/arm32/head.S line 57
Quoted 9 lines
xen/arch/arm/arm32/head.S +7
-0.section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr)Are you suggesting the code in
arch/*/head.Shas a latent bug?
I don't think I'd call this a "bug". Code which is sensitive to what precise section it lives in better is left unaffected by the per-function sections that CC_SPLIT_SECTIONS=y asks for. Which precise way this is arranged for is a separate question. You'll find a few more instances of this approach throughout the series.
Jan
Re: [PATCH v7 07/11] Arm32: use new-style entry annotations for library code
In reply to Jan BeulichHi,
Quoted 34 lines · Jan Beulich
Quoted 9 lines · Julien Grall
Hi Jan,
Sorry for the late answer.
Quoted 4 lines · Jan Beulich
No functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) as well as
__memzerolose their function-ness and size.Quoted 8 lines
Quoted 6 lines
Signed-off-by Jan Beulich <[email protected]>---
If the function-ness is important, some new construct would need inventing. Not setting size for the aliases may even be desirable, as I'm uncertain whether it is really legal in ELF that two entities overlap in space.I can't think of a reason where we would need the "function-ness".
Good, thanks for confirming.
Quoted 7 lines
Quoted 2 lines
I fear I'm breaking
__memzero(), as I don't understand the purpose of the ".word 0" next to where theFUNC_LOCAL()appears.I am not entirely sure either. AFAIK, "0" is not a valid instruction.
This code was taken from Linux, the history doesn't give much clue because it seems the ".word 0" was added before Linux used git.
My vague guess is that this is a crude way of arranging for desired alignment of labels later in the function. That wouldn't require use of .word (could simply be a nop), yet what specifically is used there doesn't matter for the patch here.
Quoted 8 lines
Quoted 3 lines
However, it looks like Linux replace
__memzerowithmemset()6 years ago on arm32. So maybe we should get rid of it? This would at least avoid worrying on the purpose of ".word 0".Certainly an option, yet may I remind you of your replies [1], [2] to a much older patch of mine, which I still have pending for the suggested removal never having happened? I fear the patch here may get stuck over this just like the other one did.
Here we go https://lore.kernel.org/xen-devel/[email protected]/
Cheers,
Signature · 1 line
Julien Grall
v8 cover (mostly) Arm32: add/convert entry point annotations
In reply to Jan BeulichBesides the (now) last patch only Arm32 adjustments are left in this series.
1: Arm32: use new-style entry annotations for library code 2: Arm32: use new-style entry annotations for MMU code
3: Arm32: use new-style entry annotations for entry code 4: Arm32: use new-style entry annotations in head.S
5: Arm: purge ENTRY(), ENDPROC(), and ALIGN
6: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Jan
PATCH v8 1/6 Arm32: use new-style entry annotations for library code
No functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) lose their function-ness and size.
---
If the function-ness was important (Julien says it likely isn't), some new construct would need inventing. Not setting size for the aliases may even be desirable, as I'm uncertain whether it is really legal in ELF that two entities overlap in space.
---
v8: Re-base.
v7: New.
xen/arch/arm/arm32/lib/findbit.S +16 -16
@@ -20,7 +20,7 @@ * Purpose : Find a 'zero' bit * Prototype: int find_first_zero_bit(void *addr, unsigned int maxbit); */ -ENTRY(_find_first_zero_bit_le) +FUNC(_find_first_zero_bit_le) teq r1, #0 beq 3f mov r2, #0
@@ -35,13 +35,13 @@ ENTRY(_find_first_zero_bit_le) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_zero_bit_le) +END(_find_first_zero_bit_le) /* * Purpose : Find next 'zero' bit * Prototype: int find_next_zero_bit(void *addr, unsigned int maxbit, int offset) */ -ENTRY(_find_next_zero_bit_le) +FUNC(_find_next_zero_bit_le) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -55,13 +55,13 @@ ENTRY(_find_next_zero_bit_le) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_zero_bit_le) +END(_find_next_zero_bit_le) /* * Purpose : Find a 'one' bit * Prototype: int find_first_bit(const unsigned long *addr, unsigned int maxbit); */ -ENTRY(_find_first_bit_le) +FUNC(_find_first_bit_le) teq r1, #0 beq 3f mov r2, #0
@@ -76,13 +76,13 @@ ENTRY(_find_first_bit_le) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_bit_le) +END(_find_first_bit_le) /* * Purpose : Find next 'one' bit * Prototype: int find_next_zero_bit(void *addr, unsigned int maxbit, int offset) */ -ENTRY(_find_next_bit_le) +FUNC(_find_next_bit_le) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -95,11 +95,11 @@ ENTRY(_find_next_bit_le) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_bit_le) +END(_find_next_bit_le) #ifdef __ARMEB__ -ENTRY(_find_first_zero_bit_be) +FUNC(_find_first_zero_bit_be) teq r1, #0 beq 3f mov r2, #0
@@ -114,9 +114,9 @@ ENTRY(_find_first_zero_bit_be) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_zero_bit_be) +END(_find_first_zero_bit_be) -ENTRY(_find_next_zero_bit_be) +FUNC(_find_next_zero_bit_be) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -131,9 +131,9 @@ ENTRY(_find_next_zero_bit_be) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_zero_bit_be) +END(_find_next_zero_bit_be) -ENTRY(_find_first_bit_be) +FUNC(_find_first_bit_be) teq r1, #0 beq 3f mov r2, #0
@@ -148,9 +148,9 @@ ENTRY(_find_first_bit_be) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_bit_be) +END(_find_first_bit_be) -ENTRY(_find_next_bit_be) +FUNC(_find_next_bit_be) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -164,7 +164,7 @@ ENTRY(_find_next_bit_be) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_bit_be) +END(_find_next_bit_be) #endif
xen/arch/arm/arm32/lib/lib1funcs.S +20 -22
110 lines not on this page · raw message
xen/arch/arm/arm32/lib/lshrdi3.S +3 -4
@@ -34,8 +34,8 @@ along with this program; see the file CO #define ah r1 #endif -ENTRY(__lshrdi3) -ENTRY(__aeabi_llsr) +FUNC(__lshrdi3) +LABEL(__aeabi_llsr) subs r3, r2, #32 rsb ip, r2, #32
@@ -47,5 +47,4 @@ ENTRY(__aeabi_llsr) mov ah, ah, lsr r2 mov pc, lr -ENDPROC(__lshrdi3) -ENDPROC(__aeabi_llsr) +END(__lshrdi3)
xen/arch/arm/arm32/lib/memchr.S +2 -3
@@ -12,8 +12,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(memchr) +FUNC(memchr, 32) and r1, r1, #0xff 1: subs r2, r2, #1 bmi 2f
@@ -23,4 +22,4 @@ ENTRY(memchr) sub r0, r0, #1 2: movne r0, #0 mov pc, lr -ENDPROC(memchr) +END(memchr)
xen/arch/arm/arm32/lib/memcpy.S +2 -2
@@ -54,8 +54,8 @@ /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ -ENTRY(memcpy) +FUNC(memcpy) #include "copy_template.S" -ENDPROC(memcpy) +END(memcpy)
xen/arch/arm/arm32/lib/memmove.S +2 -2
@@ -24,7 +24,7 @@ * occurring in the opposite direction. */ -ENTRY(memmove) +FUNC(memmove) subs ip, r0, r1 cmphi r2, ip
@@ -194,4 +194,4 @@ ENTRY(memmove) 18: backward_copy_shift push=24 pull=8 -ENDPROC(memmove) +END(memmove)
xen/arch/arm/arm32/lib/memset.S +2 -3
@@ -12,9 +12,8 @@ #include "assembler.h" .text - .align 5 -ENTRY(memset) +FUNC(memset, 32) and r1, r1, #0xff ands r3, r0, #3 @ 1 unaligned? mov ip, r0 @ preserve r0 as return value
@@ -120,4 +119,4 @@ ENTRY(memset) strb r1, [ip], #1 @ 1 add r2, r2, r3 @ 1 (r2 = r2 - (4 - r3)) b 1b -ENDPROC(memset) +END(memset)
xen/arch/arm/arm32/lib/strchr.S +2 -3
@@ -14,8 +14,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(strchr) +FUNC(strchr, 32) and r1, r1, #0xff 1: ldrb r2, [r0], #1 teq r2, r1
@@ -25,4 +24,4 @@ ENTRY(strchr) movne r0, #0 subeq r0, r0, #1 mov pc, lr -ENDPROC(strchr) +END(strchr)
xen/arch/arm/arm32/lib/strrchr.S +2 -3
@@ -12,8 +12,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(strrchr) +FUNC(strrchr, 32) and r1, r1, #0xff mov r3, #0 1: ldrb r2, [r0], #1
@@ -23,4 +22,4 @@ ENTRY(strrchr) bne 1b mov r0, r3 mov pc, lr -ENDPROC(strrchr) +END(strrchr)
PATCH v8 2/6 Arm32: use new-style entry annotations for MMU code
In reply to Jan BeulichLocally override SYM_PUSH_SECTION() to retain the intended section association.
---
v7: New.
xen/arch/arm/arm32/mmu/head.S +26 -18
@@ -160,6 +160,13 @@ .endm .section .text.idmap, "ax", %progbits +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * Rebuild the boot pagetable's first-level entries. The structure
@@ -174,7 +181,7 @@ * * Clobbers r0 - r5 */ -create_page_tables: +FUNC_LOCAL(create_page_tables) /* Prepare the page-tables for mapping Xen */ mov_w r0, XEN_VIRT_START
@@ -263,7 +270,7 @@ use_temporary_mapping: mov r12, #1 /* r12 := temporary mapping created */ mov pc, lr -ENDPROC(create_page_tables) +END(create_page_tables) /* * Turn on the Data Cache and the MMU. The function will return
@@ -276,7 +283,7 @@ ENDPROC(create_page_tables) * * Clobbers r0 - r5 */ -enable_mmu: +FUNC_LOCAL(enable_mmu) PRINT("- Turning on paging -\r\n") /*
@@ -346,7 +353,7 @@ enable_mmu: teq r12, #0 beq remove_identity_mapping b remove_temporary_mapping -ENDPROC(enable_mmu) +END(enable_mmu) /* * Switch to the runtime mapping. The logic depends on whether the
@@ -366,7 +373,7 @@ ENDPROC(enable_mmu) * * Clobbers r0 - r4 */ -switch_to_runtime_mapping: +FUNC_LOCAL(switch_to_runtime_mapping) /* * Jump to the runtime mapping if the virt and phys are not * clashing
@@ -411,7 +418,7 @@ ready_to_switch: PRINT_ID("- Jumping to runtime address -\r\n") mov pc, lr -ENDPROC(switch_to_runtime_mapping) +END(switch_to_runtime_mapping) /* * Enable mm (turn on the data cache and the MMU) for secondary CPUs.
@@ -428,7 +435,7 @@ ENDPROC(switch_to_runtime_mapping) * * Clobbers r0 - r6 */ -ENTRY(enable_secondary_cpu_mm) +FUNC(enable_secondary_cpu_mm) mov r6, lr bl create_page_tables
@@ -456,7 +463,7 @@ ENTRY(enable_secondary_cpu_mm) /* Return to the virtual address requested by the caller. */ mov pc, r6 -ENDPROC(enable_secondary_cpu_mm) +END(enable_secondary_cpu_mm) /* * Enable mm (turn on the data cache and the MMU) for the boot CPU.
@@ -474,7 +481,7 @@ ENDPROC(enable_secondary_cpu_mm) * * Clobbers r0 - r6 */ -ENTRY(enable_boot_cpu_mm) +FUNC(enable_boot_cpu_mm) mov r6, lr #ifdef CONFIG_EARLY_PRINTK
@@ -491,7 +498,7 @@ ENTRY(enable_boot_cpu_mm) /* Address in the runtime mapping to jump to after the MMU is enabled */ mov lr, r6 b enable_mmu -ENDPROC(enable_boot_cpu_mm) +END(enable_boot_cpu_mm) /* * Remove the 1:1 map from the page-tables. It is not easy to keep track
@@ -503,7 +510,7 @@ ENDPROC(enable_boot_cpu_mm) * * Clobbers r0 - r3 */ -remove_identity_mapping: +FUNC_LOCAL(remove_identity_mapping) PRINT("- Removing the identity mapping -\r\n") /* r2:r3 := invalid page-table entry */
@@ -518,14 +525,14 @@ remove_identity_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_identity_mapping) +END(remove_identity_mapping) /* * Remove the temporary mapping of Xen starting at TEMPORARY_XEN_VIRT_START. * * Clobbers r0 - r3 */ -remove_temporary_mapping: +FUNC_LOCAL(remove_temporary_mapping) PRINT("- Removing the temporary mapping -\r\n") /* r2:r3 := invalid page-table entry */
@@ -541,13 +548,14 @@ remove_temporary_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_temporary_mapping) +END(remove_temporary_mapping) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) /* * Switch TTBR
@@ -555,7 +563,7 @@ ENDPROC(fail) * * TODO: This code does not comply with break-before-make. */ -ENTRY(switch_ttbr) +FUNC(switch_ttbr) dsb /* Ensure the flushes happen before * continuing */ isb /* Ensure synchronization with previous
@@ -579,4 +587,4 @@ ENTRY(switch_ttbr) isb mov pc, lr -ENDPROC(switch_ttbr) +END(switch_ttbr)
PATCH v8 3/6 Arm32: use new-style entry annotations for entry code
In reply to Jan Beulich---
Should the GLOBAL()s also be replaced?
---
v7: New.
xen/arch/arm/arm32/entry.S +7 -5
@@ -31,7 +31,7 @@ * r4: Set to a non-zero value if a pending Abort exception took place. * Otherwise, it will be set to zero. */ -prepare_context_from_guest: +FUNC_LOCAL(prepare_context_from_guest) #ifdef CONFIG_ARM32_HARDEN_BRANCH_PREDICTOR /* * Restore vectors table to the default as it may have been
@@ -140,7 +140,7 @@ abort_guest_exit_end: skip_check: b enter_hypervisor_from_guest_preirq -ENDPROC(prepare_context_from_guest) +END(prepare_context_from_guest) /* * Macro to define a trap entry.
@@ -362,13 +362,13 @@ trap_irq: trap_fiq: vector fiq -return_from_trap: +LABEL_LOCAL(return_from_trap) /* * Restore the stack pointer from r11. It was saved on exception * entry (see __DEFINE_TRAP_ENTRY). */ mov sp, r11 -ENTRY(return_to_new_vcpu32) +LABEL(return_to_new_vcpu32) ldr r11, [sp, #UREGS_cpsr] and r11, #PSR_MODE_MASK cmp r11, #PSR_MODE_HYP
@@ -426,6 +426,7 @@ return_to_hypervisor: clrex eret sb +END(return_from_trap) /* * struct vcpu *__context_switch(struct vcpu *prev, struct vcpu *next)
@@ -435,12 +436,13 @@ return_to_hypervisor: * * Returns prev in r0 */ -ENTRY(__context_switch) +FUNC(__context_switch) add ip, r0, #VCPU_arch_saved_context stmia ip!, {r4 - sl, fp, sp, lr} /* Save register state */ add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ +END(__context_switch) /* * Local variables:
PATCH v8 4/6 Arm32: use new-style entry annotations in head.S
In reply to Jan BeulichLocally override SYM_PUSH_SECTION() to retain the intended section association.
---
v8: Re-base.
v7: New.
xen/arch/arm/arm32/head.S +32 -23
@@ -48,13 +48,20 @@ .section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * This must be the very first address in the loaded image. * It should be linked at XEN_VIRT_START, and loaded at any * 4K-aligned address. */ -GLOBAL(start) +FUNC(start) /* * zImage magic header, see: * http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
@@ -104,9 +111,9 @@ primary_switched: mov r0, r8 /* r0 := paddr(FDT) */ mov_w r1, start_xen b launch -ENDPROC(start) +END(start) -GLOBAL(init_secondary) +FUNC(init_secondary) cpsid aif /* Disable all interrupts */ /* Find out where we are */
@@ -142,7 +149,7 @@ secondary_switched: /* Jump to C world */ mov_w r1, start_secondary b launch -ENDPROC(init_secondary) +END(init_secondary) /* * Check if the CPU supports virtualization extensions and has been booted
@@ -154,7 +161,7 @@ ENDPROC(init_secondary) * * Clobbers r0 - r3 */ -check_cpu_mode: +FUNC_LOCAL(check_cpu_mode) /* Check that this CPU has Hyp mode */ mrc CP32(r0, ID_PFR1) and r0, r0, #0xf000 /* Bits 12-15 define virt extensions */
@@ -174,14 +181,14 @@ check_cpu_mode: PRINT("- Xen must be entered in NS Hyp mode -\r\n") PRINT("- Please update the bootloader -\r\n") b fail -ENDPROC(check_cpu_mode) +END(check_cpu_mode) /* * Zero BSS * * Clobbers r0 - r3 */ -zero_bss: +FUNC_LOCAL(zero_bss) PRINT("- Zero BSS -\r\n") mov_w r0, __bss_start /* r0 := vaddr(__bss_start) */ mov_w r1, __bss_end /* r1 := vaddr(__bss_end) */
@@ -195,9 +202,9 @@ zero_bss: skip_bss: mov pc, lr -ENDPROC(zero_bss) +END(zero_bss) -cpu_init: +FUNC_LOCAL(cpu_init) PRINT("- Setting up control registers -\r\n") mov r5, lr /* r5 := return address */
@@ -238,7 +245,7 @@ cpu_init_done: isb mov pc, r5 /* Return address is in r5 */ -ENDPROC(cpu_init) +END(cpu_init) /* * Setup the initial stack and jump to the C world
@@ -249,7 +256,7 @@ ENDPROC(cpu_init) * * Clobbers r3 */ -launch: +FUNC_LOCAL(launch) mov_w r3, init_data add r3, #INITINFO_stack /* Find the boot-time stack */ ldr sp, [r3]
@@ -258,13 +265,14 @@ launch: /* Jump to C world */ bx r1 -ENDPROC(launch) +END(launch) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) #ifdef CONFIG_EARLY_PRINTK /*
@@ -275,14 +283,14 @@ ENDPROC(fail) * * Clobbers r0 - r3 */ -init_uart: +FUNC_LOCAL(init_uart) mov_w r11, CONFIG_EARLY_UART_BASE_ADDRESS #ifdef CONFIG_EARLY_UART_INIT early_uart_init r11, r1, r2 #endif PRINT("- UART enabled -\r\n") mov pc, lr -ENDPROC(init_uart) +END(init_uart) /* * Print early debug messages.
@@ -291,14 +299,14 @@ ENDPROC(init_uart) * r11: Early UART base address * Clobbers r0-r1 */ -ENTRY(asm_puts) +FUNC(asm_puts) early_uart_ready r11, r1 ldrb r1, [r0], #1 /* Load next char */ teq r1, #0 /* Exit on nul */ moveq pc, lr early_uart_transmit r11, r1 b asm_puts -ENDPROC(asm_puts) +END(asm_puts) /* * Print a 32-bit number in hex.
@@ -307,7 +315,7 @@ ENDPROC(asm_puts) * r11: Early UART base address * Clobbers r0-r3 */ -ENTRY(asm_putn) +FUNC(asm_putn) adr_l r1, hex mov r3, #8 1:
@@ -319,18 +327,19 @@ ENTRY(asm_putn) subs r3, r3, #1 bne 1b mov pc, lr -ENDPROC(asm_putn) +END(asm_putn) RODATA_SECT(.rodata.idmap, hex, "0123456789abcdef") #endif /* CONFIG_EARLY_PRINTK */ /* This provides a C-API version of __lookup_processor_type */ -ENTRY(lookup_processor_type) +FUNC(lookup_processor_type) stmfd sp!, {r4, lr} bl __lookup_processor_type mov r0, r1 ldmfd sp!, {r4, pc} +END(lookup_processor_type) /* * Read processor ID register (CP#15, CR0), and Look up in the linker-built
@@ -341,7 +350,7 @@ ENTRY(lookup_processor_type) * r1: proc_info pointer * Clobbers r2-r4 */ -__lookup_processor_type: +FUNC_LOCAL(__lookup_processor_type) mrc CP32(r0, MIDR) /* r0 := our cpu id */ adr_l r1, __proc_info_start adr_l r2, __proc_info_end
@@ -357,7 +366,7 @@ __lookup_processor_type: mov r1, #0 2: mov pc, lr -ENDPROC(__lookup_processor_type) +END(__lookup_processor_type) /* * Local variables:
PATCH v8 5/6 Arm: purge ENTRY(), ENDPROC(), and ALIGN
In reply to Jan BeulichThey're no longer used. This also makes it unnecessary to #undef two of them in the linker script.
---
v7: New.
xen/arch/arm/include/asm/config.h +0 -8
@@ -53,17 +53,9 @@/* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .balign CONFIG_FUNCTION_ALIGNMENT -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name:#define GLOBAL (name) \ .globl name; \ name: -#define ENDPROC (name) \ - .type name, %function; \ - END(name)#endif #include <xen/const.h>
xen/arch/arm/xen.lds.S +0 -2
@@ -6,8 +6,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> #include <asm/page.h> -#undef ENTRY -#undef ALIGN ENTRY(start)
PATCH v8 6/6 common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichLeverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). In fact Roger wants the detection to be in Kconfig, for LIVEPATCH to depend on it. Yet the whole underlying discussion there imo would first need settling (and therefore reviving).
Note that we'd need to split DATA() in order to separate r/w, r/o, and BSS contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
An alternative to the "override" in arm64/head.S would be to use LABEL{,_LOCAL}() instead of FUNC{,_LOCAL}() there. Yet that would also lose the type information then. Question is whether the annotated ranges really are "functions" in whichever wide or narrow sense.
---
v7: Override SYM_PUSH_SECTION() in arch/x86/indirect-thunk.S. Re-base,
notably to deal with fallout from fba250ae604e ("xen/arm64: head:
Add missing code symbol annotations").
v6: Deal with x86'es entry_PF() and entry_int82() falling through to the
next "function". Re-base.
v5: Re-base over changes earlier in the series.
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).
Config.mk +1 -1
@@ -102,7 +102,7 @@ cc-option = $(shell if $(1) $(2:-Wno-%=- # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile +3 -0
@@ -415,6 +415,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assembler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/arm64/head.S +8 -0
@@ -28,6 +28,14 @@ #include <asm/arm64/efibind.h> #endif +/* + * Code here is, at least in part, ordering sensitive. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) + #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) #define __HEAD_FLAG_PHYS_BASE 1
xen/arch/arm/xen.lds.S +3 -0
@@ -140,6 +140,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -103,6 +103,9 @@ SECTIONS DECL_SECTION(.init.text) { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -98,6 +98,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/indirect-thunk.S +4 -0
@@ -11,6 +11,10 @@ #include <asm/asm_defns.h> +/* Section placement is done explicitly here; override the respective macro. */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) + .macro IND_THUNK_RETPOLINE reg:req call 1f int3
xen/arch/x86/x86_64/compat/entry.S +3 -0
@@ -31,6 +31,9 @@ FUNC(entry_int82) mov %rsp, %rdi call do_entry_int82 +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp compat_test_all_events +#endif END(entry_int82) /* %rbx: struct vcpu */
xen/arch/x86/x86_64/entry.S +7 -1
@@ -771,6 +771,9 @@ END(common_interrupt) FUNC(entry_PF) ENDBR64 movb $X86_EXC_PF, EFRAME_entry_vector(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_exception +#endif END(entry_PF) /* No special register assumptions. */ FUNC(handle_exception, 0)
@@ -1084,8 +1087,11 @@ FUNC(entry_NMI) ENDBR64 pushq $0 movb $X86_EXC_NMI, EFRAME_entry_vector(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_ist_exception +#endif END(entry_NMI) - +/* No special register assumptions. */ FUNC(handle_ist_exception) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL
xen/arch/x86/xen.lds.S +6 -0
@@ -83,6 +83,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -202,6 +205,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -18,6 +18,14 @@ #define SYM_ALIGN(align...) .balign align +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -32,7 +40,14 @@SYM_ALIGN (align); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -47,6 +62,7 @@#endif #define FUNC(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align)) #define LABEL(name, align...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align))
@@ -54,6 +70,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) #define FUNC_LOCAL(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align)) #define LABEL_LOCAL(name, align...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align))
Re: [PATCH v8 0/6] (mostly) Arm32: add/convert entry point annotations
In reply to Jan BeulichHi,
Quoted 11 lines · Jan Beulich
Besides the (now) last patch only Arm32 adjustments are left in this series.
1: Arm32: use new-style entry annotations for library code 2: Arm32: use new-style entry annotations for MMU code
3: Arm32: use new-style entry annotations for entry code 4: Arm32: use new-style entry annotations inhead.S
5: Arm: purgeENTRY(),ENDPROC(), and ALIGN
6: common: honorCONFIG_CC_SPLIT_SECTIONSalso for assembly functions
I’ve tested the serie on arm32 and arm64:
Quoted 3 lines
Jan
v8 cover (mostly) Arm32: add/convert entry point annotations
In reply to Jan Beulich(re-sending upon Julien's request)
Besides the (now) last patch only Arm32 adjustments are left in this series.
1: Arm32: use new-style entry annotations for library code 2: Arm32: use new-style entry annotations for MMU code
3: Arm32: use new-style entry annotations for entry code 4: Arm32: use new-style entry annotations in head.S
5: Arm: purge ENTRY(), ENDPROC(), and ALIGN
6: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
Jan
PATCH RESEND v8 1/6 Arm32: use new-style entry annotations for library code
No functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) lose their function-ness and size.
---
If the function-ness was important (Julien says it likely isn't), some new construct would need inventing. Not setting size for the aliases may even be desirable, as I'm uncertain whether it is really legal in ELF that two entities overlap in space.
---
v8: Re-base.
v7: New.
xen/arch/arm/arm32/lib/findbit.S +16 -16
@@ -20,7 +20,7 @@ * Purpose : Find a 'zero' bit * Prototype: int find_first_zero_bit(void *addr, unsigned int maxbit); */ -ENTRY(_find_first_zero_bit_le) +FUNC(_find_first_zero_bit_le) teq r1, #0 beq 3f mov r2, #0
@@ -35,13 +35,13 @@ ENTRY(_find_first_zero_bit_le) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_zero_bit_le) +END(_find_first_zero_bit_le) /* * Purpose : Find next 'zero' bit * Prototype: int find_next_zero_bit(void *addr, unsigned int maxbit, int offset) */ -ENTRY(_find_next_zero_bit_le) +FUNC(_find_next_zero_bit_le) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -55,13 +55,13 @@ ENTRY(_find_next_zero_bit_le) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_zero_bit_le) +END(_find_next_zero_bit_le) /* * Purpose : Find a 'one' bit * Prototype: int find_first_bit(const unsigned long *addr, unsigned int maxbit); */ -ENTRY(_find_first_bit_le) +FUNC(_find_first_bit_le) teq r1, #0 beq 3f mov r2, #0
@@ -76,13 +76,13 @@ ENTRY(_find_first_bit_le) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_bit_le) +END(_find_first_bit_le) /* * Purpose : Find next 'one' bit * Prototype: int find_next_zero_bit(void *addr, unsigned int maxbit, int offset) */ -ENTRY(_find_next_bit_le) +FUNC(_find_next_bit_le) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -95,11 +95,11 @@ ENTRY(_find_next_bit_le) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_bit_le) +END(_find_next_bit_le) #ifdef __ARMEB__ -ENTRY(_find_first_zero_bit_be) +FUNC(_find_first_zero_bit_be) teq r1, #0 beq 3f mov r2, #0
@@ -114,9 +114,9 @@ ENTRY(_find_first_zero_bit_be) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_zero_bit_be) +END(_find_first_zero_bit_be) -ENTRY(_find_next_zero_bit_be) +FUNC(_find_next_zero_bit_be) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -131,9 +131,9 @@ ENTRY(_find_next_zero_bit_be) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_zero_bit_be) +END(_find_next_zero_bit_be) -ENTRY(_find_first_bit_be) +FUNC(_find_first_bit_be) teq r1, #0 beq 3f mov r2, #0
@@ -148,9 +148,9 @@ ENTRY(_find_first_bit_be) blo 1b 3: mov r0, r1 @ no free bits mov pc, lr -ENDPROC(_find_first_bit_be) +END(_find_first_bit_be) -ENTRY(_find_next_bit_be) +FUNC(_find_next_bit_be) cmp r1, r2 bls 3b ands ip, r2, #7
@@ -164,7 +164,7 @@ ENTRY(_find_next_bit_be) orr r2, r2, #7 @ if zero, then no bits here add r2, r2, #1 @ align bit pointer b 2b @ loop for next bit -ENDPROC(_find_next_bit_be) +END(_find_next_bit_be) #endif
xen/arch/arm/arm32/lib/lib1funcs.S +20 -22
110 lines not on this page · raw message
xen/arch/arm/arm32/lib/lshrdi3.S +3 -4
@@ -34,8 +34,8 @@ along with this program; see the file CO #define ah r1 #endif -ENTRY(__lshrdi3) -ENTRY(__aeabi_llsr) +FUNC(__lshrdi3) +LABEL(__aeabi_llsr) subs r3, r2, #32 rsb ip, r2, #32
@@ -47,5 +47,4 @@ ENTRY(__aeabi_llsr) mov ah, ah, lsr r2 mov pc, lr -ENDPROC(__lshrdi3) -ENDPROC(__aeabi_llsr) +END(__lshrdi3)
xen/arch/arm/arm32/lib/memchr.S +2 -3
@@ -12,8 +12,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(memchr) +FUNC(memchr, 32) and r1, r1, #0xff 1: subs r2, r2, #1 bmi 2f
@@ -23,4 +22,4 @@ ENTRY(memchr) sub r0, r0, #1 2: movne r0, #0 mov pc, lr -ENDPROC(memchr) +END(memchr)
xen/arch/arm/arm32/lib/memcpy.S +2 -2
@@ -54,8 +54,8 @@ /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ -ENTRY(memcpy) +FUNC(memcpy) #include "copy_template.S" -ENDPROC(memcpy) +END(memcpy)
xen/arch/arm/arm32/lib/memmove.S +2 -2
@@ -24,7 +24,7 @@ * occurring in the opposite direction. */ -ENTRY(memmove) +FUNC(memmove) subs ip, r0, r1 cmphi r2, ip
@@ -194,4 +194,4 @@ ENTRY(memmove) 18: backward_copy_shift push=24 pull=8 -ENDPROC(memmove) +END(memmove)
xen/arch/arm/arm32/lib/memset.S +2 -3
@@ -12,9 +12,8 @@ #include "assembler.h" .text - .align 5 -ENTRY(memset) +FUNC(memset, 32) and r1, r1, #0xff ands r3, r0, #3 @ 1 unaligned? mov ip, r0 @ preserve r0 as return value
@@ -120,4 +119,4 @@ ENTRY(memset) strb r1, [ip], #1 @ 1 add r2, r2, r3 @ 1 (r2 = r2 - (4 - r3)) b 1b -ENDPROC(memset) +END(memset)
xen/arch/arm/arm32/lib/strchr.S +2 -3
@@ -14,8 +14,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(strchr) +FUNC(strchr, 32) and r1, r1, #0xff 1: ldrb r2, [r0], #1 teq r2, r1
@@ -25,4 +24,4 @@ ENTRY(strchr) movne r0, #0 subeq r0, r0, #1 mov pc, lr -ENDPROC(strchr) +END(strchr)
xen/arch/arm/arm32/lib/strrchr.S +2 -3
@@ -12,8 +12,7 @@ #include "assembler.h" .text - .align 5 -ENTRY(strrchr) +FUNC(strrchr, 32) and r1, r1, #0xff mov r3, #0 1: ldrb r2, [r0], #1
@@ -23,4 +22,4 @@ ENTRY(strrchr) bne 1b mov r0, r3 mov pc, lr -ENDPROC(strrchr) +END(strrchr)
PATCH RESEND v8 2/6 Arm32: use new-style entry annotations for MMU code
In reply to Jan BeulichLocally override SYM_PUSH_SECTION() to retain the intended section association.
---
v7: New.
xen/arch/arm/arm32/mmu/head.S +26 -18
@@ -160,6 +160,13 @@ .endm .section .text.idmap, "ax", %progbits +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * Rebuild the boot pagetable's first-level entries. The structure
@@ -174,7 +181,7 @@ * * Clobbers r0 - r5 */ -create_page_tables: +FUNC_LOCAL(create_page_tables) /* Prepare the page-tables for mapping Xen */ mov_w r0, XEN_VIRT_START
@@ -263,7 +270,7 @@ use_temporary_mapping: mov r12, #1 /* r12 := temporary mapping created */ mov pc, lr -ENDPROC(create_page_tables) +END(create_page_tables) /* * Turn on the Data Cache and the MMU. The function will return
@@ -276,7 +283,7 @@ ENDPROC(create_page_tables) * * Clobbers r0 - r5 */ -enable_mmu: +FUNC_LOCAL(enable_mmu) PRINT("- Turning on paging -\r\n") /*
@@ -346,7 +353,7 @@ enable_mmu: teq r12, #0 beq remove_identity_mapping b remove_temporary_mapping -ENDPROC(enable_mmu) +END(enable_mmu) /* * Switch to the runtime mapping. The logic depends on whether the
@@ -366,7 +373,7 @@ ENDPROC(enable_mmu) * * Clobbers r0 - r4 */ -switch_to_runtime_mapping: +FUNC_LOCAL(switch_to_runtime_mapping) /* * Jump to the runtime mapping if the virt and phys are not * clashing
@@ -411,7 +418,7 @@ ready_to_switch: PRINT_ID("- Jumping to runtime address -\r\n") mov pc, lr -ENDPROC(switch_to_runtime_mapping) +END(switch_to_runtime_mapping) /* * Enable mm (turn on the data cache and the MMU) for secondary CPUs.
@@ -428,7 +435,7 @@ ENDPROC(switch_to_runtime_mapping) * * Clobbers r0 - r6 */ -ENTRY(enable_secondary_cpu_mm) +FUNC(enable_secondary_cpu_mm) mov r6, lr bl create_page_tables
@@ -456,7 +463,7 @@ ENTRY(enable_secondary_cpu_mm) /* Return to the virtual address requested by the caller. */ mov pc, r6 -ENDPROC(enable_secondary_cpu_mm) +END(enable_secondary_cpu_mm) /* * Enable mm (turn on the data cache and the MMU) for the boot CPU.
@@ -474,7 +481,7 @@ ENDPROC(enable_secondary_cpu_mm) * * Clobbers r0 - r6 */ -ENTRY(enable_boot_cpu_mm) +FUNC(enable_boot_cpu_mm) mov r6, lr #ifdef CONFIG_EARLY_PRINTK
@@ -491,7 +498,7 @@ ENTRY(enable_boot_cpu_mm) /* Address in the runtime mapping to jump to after the MMU is enabled */ mov lr, r6 b enable_mmu -ENDPROC(enable_boot_cpu_mm) +END(enable_boot_cpu_mm) /* * Remove the 1:1 map from the page-tables. It is not easy to keep track
@@ -503,7 +510,7 @@ ENDPROC(enable_boot_cpu_mm) * * Clobbers r0 - r3 */ -remove_identity_mapping: +FUNC_LOCAL(remove_identity_mapping) PRINT("- Removing the identity mapping -\r\n") /* r2:r3 := invalid page-table entry */
@@ -518,14 +525,14 @@ remove_identity_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_identity_mapping) +END(remove_identity_mapping) /* * Remove the temporary mapping of Xen starting at TEMPORARY_XEN_VIRT_START. * * Clobbers r0 - r3 */ -remove_temporary_mapping: +FUNC_LOCAL(remove_temporary_mapping) PRINT("- Removing the temporary mapping -\r\n") /* r2:r3 := invalid page-table entry */
@@ -541,13 +548,14 @@ remove_temporary_mapping: flush_xen_tlb_local r0 mov pc, lr -ENDPROC(remove_temporary_mapping) +END(remove_temporary_mapping) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) /* * Switch TTBR
@@ -555,7 +563,7 @@ ENDPROC(fail) * * TODO: This code does not comply with break-before-make. */ -ENTRY(switch_ttbr) +FUNC(switch_ttbr) dsb /* Ensure the flushes happen before * continuing */ isb /* Ensure synchronization with previous
@@ -579,4 +587,4 @@ ENTRY(switch_ttbr) isb mov pc, lr -ENDPROC(switch_ttbr) +END(switch_ttbr)
PATCH RESEND v8 3/6 Arm32: use new-style entry annotations for entry code
In reply to Jan Beulich---
Should the GLOBAL()s also be replaced?
---
v7: New.
xen/arch/arm/arm32/entry.S +7 -5
@@ -31,7 +31,7 @@ * r4: Set to a non-zero value if a pending Abort exception took place. * Otherwise, it will be set to zero. */ -prepare_context_from_guest: +FUNC_LOCAL(prepare_context_from_guest) #ifdef CONFIG_ARM32_HARDEN_BRANCH_PREDICTOR /* * Restore vectors table to the default as it may have been
@@ -140,7 +140,7 @@ abort_guest_exit_end: skip_check: b enter_hypervisor_from_guest_preirq -ENDPROC(prepare_context_from_guest) +END(prepare_context_from_guest) /* * Macro to define a trap entry.
@@ -362,13 +362,13 @@ trap_irq: trap_fiq: vector fiq -return_from_trap: +LABEL_LOCAL(return_from_trap) /* * Restore the stack pointer from r11. It was saved on exception * entry (see __DEFINE_TRAP_ENTRY). */ mov sp, r11 -ENTRY(return_to_new_vcpu32) +LABEL(return_to_new_vcpu32) ldr r11, [sp, #UREGS_cpsr] and r11, #PSR_MODE_MASK cmp r11, #PSR_MODE_HYP
@@ -426,6 +426,7 @@ return_to_hypervisor: clrex eret sb +END(return_from_trap) /* * struct vcpu *__context_switch(struct vcpu *prev, struct vcpu *next)
@@ -435,12 +436,13 @@ return_to_hypervisor: * * Returns prev in r0 */ -ENTRY(__context_switch) +FUNC(__context_switch) add ip, r0, #VCPU_arch_saved_context stmia ip!, {r4 - sl, fp, sp, lr} /* Save register state */ add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ +END(__context_switch) /* * Local variables:
PATCH RESEND v8 4/6 Arm32: use new-style entry annotations in head.S
In reply to Jan BeulichLocally override SYM_PUSH_SECTION() to retain the intended section association.
---
v8: Re-base.
v7: New.
xen/arch/arm/arm32/head.S +32 -23
@@ -48,13 +48,20 @@ .section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) /* * This must be the very first address in the loaded image. * It should be linked at XEN_VIRT_START, and loaded at any * 4K-aligned address. */ -GLOBAL(start) +FUNC(start) /* * zImage magic header, see: * http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
@@ -104,9 +111,9 @@ primary_switched: mov r0, r8 /* r0 := paddr(FDT) */ mov_w r1, start_xen b launch -ENDPROC(start) +END(start) -GLOBAL(init_secondary) +FUNC(init_secondary) cpsid aif /* Disable all interrupts */ /* Find out where we are */
@@ -142,7 +149,7 @@ secondary_switched: /* Jump to C world */ mov_w r1, start_secondary b launch -ENDPROC(init_secondary) +END(init_secondary) /* * Check if the CPU supports virtualization extensions and has been booted
@@ -154,7 +161,7 @@ ENDPROC(init_secondary) * * Clobbers r0 - r3 */ -check_cpu_mode: +FUNC_LOCAL(check_cpu_mode) /* Check that this CPU has Hyp mode */ mrc CP32(r0, ID_PFR1) and r0, r0, #0xf000 /* Bits 12-15 define virt extensions */
@@ -174,14 +181,14 @@ check_cpu_mode: PRINT("- Xen must be entered in NS Hyp mode -\r\n") PRINT("- Please update the bootloader -\r\n") b fail -ENDPROC(check_cpu_mode) +END(check_cpu_mode) /* * Zero BSS * * Clobbers r0 - r3 */ -zero_bss: +FUNC_LOCAL(zero_bss) PRINT("- Zero BSS -\r\n") mov_w r0, __bss_start /* r0 := vaddr(__bss_start) */ mov_w r1, __bss_end /* r1 := vaddr(__bss_end) */
@@ -195,9 +202,9 @@ zero_bss: skip_bss: mov pc, lr -ENDPROC(zero_bss) +END(zero_bss) -cpu_init: +FUNC_LOCAL(cpu_init) PRINT("- Setting up control registers -\r\n") mov r5, lr /* r5 := return address */
@@ -238,7 +245,7 @@ cpu_init_done: isb mov pc, r5 /* Return address is in r5 */ -ENDPROC(cpu_init) +END(cpu_init) /* * Setup the initial stack and jump to the C world
@@ -249,7 +256,7 @@ ENDPROC(cpu_init) * * Clobbers r3 */ -launch: +FUNC_LOCAL(launch) mov_w r3, init_data add r3, #INITINFO_stack /* Find the boot-time stack */ ldr sp, [r3]
@@ -258,13 +265,14 @@ launch: /* Jump to C world */ bx r1 -ENDPROC(launch) +END(launch) /* Fail-stop */ -fail: PRINT("- Boot failed -\r\n") +FUNC_LOCAL(fail) + PRINT("- Boot failed -\r\n") 1: wfe b 1b -ENDPROC(fail) +END(fail) #ifdef CONFIG_EARLY_PRINTK /*
@@ -275,14 +283,14 @@ ENDPROC(fail) * * Clobbers r0 - r3 */ -init_uart: +FUNC_LOCAL(init_uart) mov_w r11, CONFIG_EARLY_UART_BASE_ADDRESS #ifdef CONFIG_EARLY_UART_INIT early_uart_init r11, r1, r2 #endif PRINT("- UART enabled -\r\n") mov pc, lr -ENDPROC(init_uart) +END(init_uart) /* * Print early debug messages.
@@ -291,14 +299,14 @@ ENDPROC(init_uart) * r11: Early UART base address * Clobbers r0-r1 */ -ENTRY(asm_puts) +FUNC(asm_puts) early_uart_ready r11, r1 ldrb r1, [r0], #1 /* Load next char */ teq r1, #0 /* Exit on nul */ moveq pc, lr early_uart_transmit r11, r1 b asm_puts -ENDPROC(asm_puts) +END(asm_puts) /* * Print a 32-bit number in hex.
@@ -307,7 +315,7 @@ ENDPROC(asm_puts) * r11: Early UART base address * Clobbers r0-r3 */ -ENTRY(asm_putn) +FUNC(asm_putn) adr_l r1, hex mov r3, #8 1:
@@ -319,18 +327,19 @@ ENTRY(asm_putn) subs r3, r3, #1 bne 1b mov pc, lr -ENDPROC(asm_putn) +END(asm_putn) RODATA_SECT(.rodata.idmap, hex, "0123456789abcdef") #endif /* CONFIG_EARLY_PRINTK */ /* This provides a C-API version of __lookup_processor_type */ -ENTRY(lookup_processor_type) +FUNC(lookup_processor_type) stmfd sp!, {r4, lr} bl __lookup_processor_type mov r0, r1 ldmfd sp!, {r4, pc} +END(lookup_processor_type) /* * Read processor ID register (CP#15, CR0), and Look up in the linker-built
@@ -341,7 +350,7 @@ ENTRY(lookup_processor_type) * r1: proc_info pointer * Clobbers r2-r4 */ -__lookup_processor_type: +FUNC_LOCAL(__lookup_processor_type) mrc CP32(r0, MIDR) /* r0 := our cpu id */ adr_l r1, __proc_info_start adr_l r2, __proc_info_end
@@ -357,7 +366,7 @@ __lookup_processor_type: mov r1, #0 2: mov pc, lr -ENDPROC(__lookup_processor_type) +END(__lookup_processor_type) /* * Local variables:
PATCH RESEND v8 6/6 common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichLeverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked.
---
TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.
TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). In fact Roger wants the detection to be in Kconfig, for LIVEPATCH to depend on it. Yet the whole underlying discussion there imo would first need settling (and therefore reviving).
Note that we'd need to split DATA() in order to separate r/w, r/o, and BSS contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
An alternative to the "override" in arm64/head.S would be to use LABEL{,_LOCAL}() instead of FUNC{,_LOCAL}() there. Yet that would also lose the type information then. Question is whether the annotated ranges really are "functions" in whichever wide or narrow sense.
---
v7: Override SYM_PUSH_SECTION() in arch/x86/indirect-thunk.S. Re-base,
notably to deal with fallout from fba250ae604e ("xen/arm64: head:
Add missing code symbol annotations").
v6: Deal with x86'es entry_PF() and entry_int82() falling through to the
next "function". Re-base.
v5: Re-base over changes earlier in the series.
v4: Re-base.
v2: Make detection properly fail on old gas (by adjusting
cc-option-add-closure).
Config.mk +1 -1
@@ -102,7 +102,7 @@ cc-option = $(shell if $(1) $(2:-Wno-%=- # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef
xen/Makefile +3 -0
@@ -415,6 +415,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack) +# Check to see whether the assembler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y)
xen/arch/arm/arm64/head.S +8 -0
@@ -28,6 +28,14 @@ #include <asm/arm64/efibind.h> #endif +/* + * Code here is, at least in part, ordering sensitive. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) + #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) #define __HEAD_FLAG_PHYS_BASE 1
xen/arch/arm/xen.lds.S +3 -0
@@ -140,6 +140,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement)
xen/arch/ppc/xen.lds.S +3 -0
@@ -103,6 +103,9 @@ SECTIONS DECL_SECTION(.init.text) { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/riscv/xen.lds.S +3 -0
@@ -98,6 +98,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text
xen/arch/x86/indirect-thunk.S +4 -0
@@ -11,6 +11,10 @@ #include <asm/asm_defns.h> +/* Section placement is done explicitly here; override the respective macro. */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr) + .macro IND_THUNK_RETPOLINE reg:req call 1f int3
xen/arch/x86/x86_64/compat/entry.S +3 -0
@@ -31,6 +31,9 @@ FUNC(entry_int82) mov %rsp, %rdi call do_entry_int82 +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp compat_test_all_events +#endif END(entry_int82) /* %rbx: struct vcpu */
xen/arch/x86/x86_64/entry.S +7 -1
@@ -771,6 +771,9 @@ END(common_interrupt) FUNC(entry_PF) ENDBR64 movb $X86_EXC_PF, EFRAME_entry_vector(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_exception +#endif END(entry_PF) /* No special register assumptions. */ FUNC(handle_exception, 0)
@@ -1084,8 +1087,11 @@ FUNC(entry_NMI) ENDBR64 pushq $0 movb $X86_EXC_NMI, EFRAME_entry_vector(%rsp) +#ifdef CONFIG_CC_SPLIT_SECTIONS + jmp handle_ist_exception +#endif END(entry_NMI) - +/* No special register assumptions. */ FUNC(handle_ist_exception) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL
xen/arch/x86/xen.lds.S +6 -0
@@ -85,6 +85,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .;
@@ -204,6 +207,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /*
xen/include/xen/linkage.h +18 -1
@@ -18,6 +18,14 @@ #define SYM_ALIGN(align...) .balign align +#if defined(HAVE_AS_SECTNAME_SUBST ) && defined(CONFIG_CC_SPLIT_SECTIONS ) +# define SYM_PUSH_SECTION (name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION (name, attr) +#endif +#define SYM_L_GLOBAL (name) .globl name; .hidden name#define SYM_L_WEAK (name) .weak name#define SYM_L_LOCAL (name)/* nothing */
@@ -32,7 +40,14 @@SYM_ALIGN (align); \ name: -#define END (name) .size name, . - name +#define END (name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif/* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in
@@ -47,6 +62,7 @@#endif #define FUNC(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(align)) #define LABEL(name, align...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(align))
@@ -54,6 +70,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## align), DATA_FILL) #define FUNC_LOCAL(name, align...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(align)) #define LABEL_LOCAL(name, align...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(align))
PATCH RESEND v8 5/6 Arm: purge ENTRY(), ENDPROC(), and ALIGN
In reply to Jan BeulichThey're no longer used. This also makes it unnecessary to #undef two of them in the linker script.
---
v7: New.
xen/arch/arm/include/asm/config.h +0 -8
@@ -53,17 +53,9 @@/* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .balign CONFIG_FUNCTION_ALIGNMENT -#define ENTRY (name) \ - .globl name; \ - ALIGN; \ - name:#define GLOBAL (name) \ .globl name; \ name: -#define ENDPROC (name) \ - .type name, %function; \ - END(name)#endif #include <xen/const.h>
xen/arch/arm/xen.lds.S +0 -2
@@ -6,8 +6,6 @@ #include <xen/lib.h> #include <xen/xen.lds.h> #include <asm/page.h> -#undef ENTRY -#undef ALIGN ENTRY(start)
Re: [PATCH v8 RESEND 1/6] Arm32: use new-style entry annotations for library code
In reply to Jan BeulichHi Jan,
Quoted 5 lines · Jan Beulich
No functional change, albeit all globals now become hidden, and aliasing symbols (__aeabi_{u,}idiv) lose their function-ness and size.
Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v8 RESEND 2/6] Arm32: use new-style entry annotations for MMU code
In reply to Jan BeulichHi Jan,
Quoted 11 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm---
v7: New.
xen/arch/arm/arm32/mmu/head.S line 169
Quoted 10 lines
xen/arch/arm/arm32/mmu/head.S +7
-0@@ -160,6 +160,13 @@ .endm .section .text.idmap, "ax", %progbits +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr)
AFAICT, SYM_PUSH_SECTION doesn't exist yet. It is introduced by patch #6. Should this be moved to the last patch?
The rest of the patch LGTM to me. So with this addressed:
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v8 RESEND 3/6] Arm32: use new-style entry annotations for entry code
In reply to Jan BeulichHi Jan,
Quoted 2 lines · Jan Beulich
Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm
Quoted 2 lines
---
Should the GLOBAL()s also be replaced?
I guess the goal is to use helper from xen/linkage.h. So I would say yes. It doesn't need to be done in this series though.
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v8 RESEND 4/6] Arm32: use new-style entry annotations in head.S
In reply to Jan BeulichHi Jan,
Quoted 12 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm---
v8: Re-base.
v7: New.
xen/arch/arm/arm32/head.S line 57
Quoted 10 lines
xen/arch/arm/arm32/head.S +7
-0@@ -48,13 +48,20 @@ .section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr)
Similar to patch #2, I think SYM_PUSH_SECTION doesn't yet exist.
With that fixed:
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v8 RESEND 4/6] Arm32: use new-style entry annotations in head.S
In reply to Jan BeulichHi Jan,
Quoted 12 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm---
v8: Re-base.
v7: New.
xen/arch/arm/arm32/head.S line 57
Quoted 10 lines
xen/arch/arm/arm32/head.S +7
-0@@ -48,13 +48,20 @@ .section .text.header, "ax", %progbits .arm +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr)
Same as patch #2 and #6.
With that addressed:
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v8 RESEND 6/6] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions
In reply to Jan BeulichHi Jan,
I am not very familiar with CC_SPLIT_SECTIONS. But I will try to answer the Arm questions.
Quoted 26 lines · Jan Beulich
Leverage the new infrastructure in
xen/linkage.hto also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the timeFUNC()is invoked.Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm---
TBD: Since we use .subsection inUNLIKELY_START(), a perhaps not really
wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code.TBD: Of course something with the same overall effect, but less
impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). In fact Roger wants the detection to be inKconfig, for LIVEPATCH to depend on it. Yet the whole underlying discussion there imo would first need settling (and therefore reviving).Note that we'd need to split
DATA()in order to separate r/w, r/o, and BSS contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is giveDATA()a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway.
Quoted 4 lines
An alternative to the "override" in
arm64/head.Swould be to use LABEL{,_LOCAL}() instead of FUNC{,_LOCAL}() there. Yet that would also lose the type information then. Question is whether the annotated ranges really are "functions" in whichever wide or narrow sense.
They are functions. So I would prefer if we keep FUNC{,_LOCAL} and do the override as proposed in this patch..
Also, I think you want to move some of the override from the previous patches to this patch.
Cheers,
Signature · 1 line
Julien Grall
Re: [PATCH v8 RESEND 2/6] Arm32: use new-style entry annotations for MMU code
In reply to Julien GrallQuoted 16 lines · Julien Grall
Hi Jan,
Quoted 13 lines · Jan Beulich
Locally override
SYM_PUSH_SECTION()to retain the intended section association.Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # arm---
v7: New.xen/arch/arm/arm32/mmu/head.S +0
-0@@ -160,6 +160,13 @@ .endm
Quoted 11 lines
xen/arch/arm/arm32/mmu/head.S line 169
Quoted 8 lines
xen/arch/arm/arm32/mmu/head.S +7
-0.section .text.idmap, "ax", %progbits +/* + * Code below wants to all live in the section established above. Annotations + * from xen/linkage.h therefore may not switch sections (honoring + * CONFIG_CC_SPLIT_SECTIONS). Override the respective macro. + */ +#undef SYM_PUSH_SECTION +#define SYM_PUSH_SECTION(name, attr)AFAICT,
SYM_PUSH_SECTIONdoesn't exist yet. It is introduced by patch #6. Should this be moved to the last patch?
Perhaps; I failed to notice this when I moved that patch last. I doesn't hurt to live right here, but I agree it's better to move it.
Quoted 3 lines
The rest of the patch LGTM to me. So with this addressed:
Acked-by Julien Grall <[email protected]>
Thanks.
Jan
Re: [PATCH v8 RESEND 3/6] Arm32: use new-style entry annotations for entry code
In reply to Julien GrallQuoted 5 lines · Julien Grall
Quoted 2 lines · Jan Beulich
Signed-off-by Jan Beulich <[email protected]>Tested-by Luca Fancellu <[email protected]> # armAcked-by Julien Grall <[email protected]>
Thanks.
Quoted 4 lines
Quoted 2 lines
---
Should the GLOBAL()s also be replaced?I guess the goal is to use helper from
xen/linkage.h.
Yes. Imo in the long run we shouldn't have more than one annotation scheme.
Jan
Quoted 5 lines
So I would say
yes. It doesn't need to be done in this series though.Cheers,