staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()
PATCH 1/1 staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()
Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by sparse
drivers/staging/lustre/lustre/lov/lov_object.c +1 -1
@@ -1335,7 +1335,7 @@ static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj,int rc =0 ;int cur_stripe;int stripe_count; -struct fiemap_state fs = {0 }; +struct fiemap_state fs = {NULL }; lsm =lov_lsm_addref (cl2lov (obj));if (!lsm)
Quoted 6 lines · Andrii Vladyka
Change 0 to NULL in
lov_object_fiemap()in order to fix warning produced by sparseSigned-off-by Andrii Vladyka <[email protected]>
Patches should be inline rather than in an attachment.
That said, the patch looks correct, so you can add:
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
PATCH 1/1 staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()
Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by sparse
---
drivers/staging/lustre/lustre/lov/lov_object.c +1 -1
@@ -1335,7 +1335,7 @@ static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj,int rc =0 ;int cur_stripe;int stripe_count; -struct fiemap_state fs = {0 }; +struct fiemap_state fs = {NULL }; lsm =lov_lsm_addref (cl2lov (obj));if (!lsm)
[email protected]
maintainerQuoted 12 lines · Andrii Vladyka
Change 0 to NULL in
lov_object_fiemap()in order to fix warning produced by sparseSigned-off-by Andrii Vladyka <[email protected]>Signed-off-by Andreas Dilger <[email protected]>---
drivers/staging/lustre/lustre/lov/lov_object.c +0
-0
drivers/staging/lustre/lustre/lov/lov_object.c static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj, · line 1340
Quoted 7 lines
drivers/staging/lustre/lustre/lov/lov_object.c +1
-1@@ -1335,7 +1335,7 @@ static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj,int rc =0 ;int cur_stripe;int stripe_count; -struct fiemap_state fs = {0 }; +struct fiemap_state fs = {NULL }; lsm =lov_lsm_addref (cl2lov (obj));if (!lsm)
Patch is corrupted, and can not apply, please fix up your email client and try it again.
greg k-h
PATCH 1/1 staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()
Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by sparse
drivers/staging/lustre/lustre/lov/lov_object.c +1 -1
@@ -1335,7 +1335,7 @@ static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj,int rc =0 ;int cur_stripe;int stripe_count; -struct fiemap_state fs = {0 }; +struct fiemap_state fs = {NULL }; lsm =lov_lsm_addref (cl2lov (obj));if (!lsm)
Quoted 8 lines · gregkh at linuxfoundation.org
Quoted 7 lines · Andrii Vladyka
Change 0 to NULL in
lov_object_fiemap()in order to fix warning produced by sparseSigned-off-by Andrii Vladyka <[email protected]>Signed-off-by Andreas Dilger <[email protected]>---
Quoted 15 lines
drivers/staging/lustre/lustre/lov/lov_object.c static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj, · line 1340
Quoted 12 lines
drivers/staging/lustre/lustre/lov/lov_object.c +1
-1@@ -1335,7 +1335,7 @@ static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj,int rc =0 ;int cur_stripe;int stripe_count; -struct fiemap_state fs = {0 }; +struct fiemap_state fs = {NULL }; lsm =lov_lsm_addref (cl2lov (obj));if (!lsm)Patch is corrupted, and can not apply, please fix up your email client and try it again.
It would be better to use {} to clear the struct
rather than any member initialization.