Skip to contentSkip to conversation

unmodified_drivers: __devinit was removed in linux-3.8

PATCH Superseded Olaf Hering 2 participants 5 messages Feb 11, 2013 – Feb 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unmodified_drivers: __devinit was removed in linux-3.8

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1360595055 -3600
# Node ID e80418f1f58bf36fe953af587cc0e6dbd52dffa7 # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8

unmodified_drivers/linux-2.6/platform-pci/platform-pci.h +5 -0
diff -r 2fdca30363f0 -r e80418f1f58b unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
@@ -24,6 +24,11 @@
 
 #include <linux/pci.h>
 
+#ifndef __devinit
+#define __devinit
+#define __devinitdata
+#endif
+
 unsigned long alloc_xen_mmio(unsigned long len);
 void platform_pci_resume(void);
#1 lore raw
Quoted 7 lines
Quoted 1 line
Quoted 1 line · Olaf Hering

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1360595055 -3600
# Node ID e80418f1f58bf36fe953af587cc0e6dbd52dffa7 # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8

I recognize the need for dealing with this, but ...

unmodified_drivers/linux-2.6/platform-pci/platform-pci.h

Quoted 6 lines

diff -r 2fdca30363f0 -r e80418f1f58b unmodified_drivers/linux-2.6/platform-pci/platform-pci.h

unmodified_drivers/linux-2.6/platform-pci/platform-pci.h +0 -0

... this is the wrong file. See compat-include/xen/platform-compat.h (including how it already deals with non-present __init).

Jan

Quoted 17 lines
unmodified_drivers/linux-2.6/platform-pci/platform-pci.h +5 -0
@@ -24,6 +24,11 @@
 
 #include <linux/pci.h>
 
+#ifndef __devinit
+#define __devinit
+#define __devinitdata
+#endif
+
 unsigned long alloc_xen_mmio(unsigned long len);
 void platform_pci_resume(void);
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#3 lore raw

PATCH v2 1/1 unmodified_drivers: __devinit was removed in linux-3.8

In reply to Olaf Hering

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1360663714 -3600
# Node ID 37bca0abac676afdece18363ba3170027378659c # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8

unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h +5 -0
diff -r 2fdca30363f0 -r 37bca0abac67 unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
@@ -171,4 +171,9 @@ typedef irqreturn_t (*irq_handler_t)(int
 #define synch_test_bit			sync_test_bit
 #endif
 
+#ifndef __devinit
+#define __devinit
+#define __devinitdata
 #endif
+
+#endif
#2 lore raw
In reply to Jan Beulich
Quoted 12 lines · Jan Beulich
Quoted 7 lines
Quoted 1 line
Quoted 1 line · Olaf Hering

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1360595055 -3600
# Node ID e80418f1f58bf36fe953af587cc0e6dbd52dffa7 # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8

I recognize the need for dealing with this, but ...

Quoted 2 lines
Quoted 7 lines

unmodified_drivers/linux-2.6/platform-pci/platform-pci.h

Quoted 4 lines

diff -r 2fdca30363f0 -r e80418f1f58b unmodified_drivers/linux-2.6/platform-pci/platform-pci.h

unmodified_drivers/linux-2.6/platform-pci/platform-pci.h +0 -0

... this is the wrong file. See compat-include/xen/platform-compat.h (including how it already deals with non-present __init).

Thanks, I sent v2 of this patch.

Olaf

#4 lore raw
In reply to Olaf Hering
Quoted 9 lines
Quoted 1 line
Quoted 1 line · Olaf Hering

# HG changeset patch
# User Olaf Hering <[email protected]>
# Date 1360663714 -3600
# Node ID 37bca0abac676afdece18363ba3170027378659c # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8

Committed, but it would have been nice if you had followed the advice I gave and thus saved me from having to edit the patch before checking in.

Jan