Skip to contentSkip to conversation

Add DMA engine driver for Freescale MPC85xx processors.

PATCH Dan Williams 3 participants 3 messages Jan 10, 2008 – Feb 7, 2008

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines · Zhang Wei

I think your patch is good. What should I do next?

Cheers!
Wei.

I do not think all the review comments have been addressed, for example my earlier comments about GFP_ATOMIC and spin_lock_irqsave [1]. We have two options to take this forward:

1/ Continue to carry this in the async-tx tree and get an Acked-by/Reviewed-by tag from Kumar.
2/ Move this to Kumar's tree, and coordinate our pull requests to have the async-tx updates hit first.

I prefer option 1, but I will defer to Kumar.

Thanks,
Dan

[1] http://marc.info/?l=linux-kernel&m=118936050531240&w=2

#1 lore raw

Hi, Dan,

Quoted 7 lines

-----Original Message-----
From: [email protected]

I do not think all the review comments have been addressed, for example my earlier comments about GFP_ATOMIC and spin_lock_irqsave [1]. We have two options to take this forward:

Thanks! Some comments need more study, I'll discuss them with you later.

Quoted 7 lines

1/ Continue to carry this in the async-tx tree and get an Acked-by/Reviewed-by tag from Kumar.
2/ Move this to Kumar's tree, and coordinate our pull requests to have the async-tx updates hit first.

I prefer option 1, but I will defer to Kumar.

I also prefer option 1. How about now?

Cheers!
Wei.

#2 lore raw
Quoted 11 lines · Zhang Wei

Hi, Dan,

Quoted 7 lines

-----Original Message-----
From: [email protected]

I do not think all the review comments have been addressed, for example my earlier comments about GFP_ATOMIC and spin_lock_irqsave [1]. We have two options to take this forward:

Thanks! Some comments need more study, I'll discuss them with you later.

Zhang and Dan,

What's the status on this patch? Will it make 2.6.25?

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale