Skip to contentSkip to conversation

Lenovo C940 speaker

PATCH Kailang 2 participants 2 messages Dec 23, 2020 Sound

lore
Share & tools
lore

Kailang

author
#0 lore raw

Hi Takashi,

C940 make i2s Amp(none Realtek) verb in BIOS verb table. It will enable internal speaker. This patch will solve it can't adjust speaker volume issue.

BR,
Kailang

From d6805ff00ee36544f151db406cb76cedc8f752dc Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Fri, 23 Oct 2020 14:46:47 +0800
Subject: [PATCH] ALSA: hda/realtek - Cannot adjust speaker's volume on Lenovo C940

Applying the alc298_fixup_speaker_volume function can fix the issue.

sound/pci/hda/patch_realtek.c +6 -0
index f2398721ac1e..bebdbc54eb46 100644
@@ -6277,6 +6277,7 @@ enum {
 	ALC256_FIXUP_INTEL_NUC8_RUGGED,
 	ALC255_FIXUP_XIAOMI_HEADSET_MIC,
 	ALC274_FIXUP_HP_MIC,
+	ALC298_FIXUP_LENOVO_SPK_VOLUME,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -7664,6 +7665,10 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		},
 	},
+	[ALC298_FIXUP_LENOVO_SPK_VOLUME] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc298_fixup_speaker_volume,
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7935,6 +7940,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x17aa, 0x3818, "Lenovo C940", ALC298_FIXUP_LENOVO_SPK_VOLUME),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
 	SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
#1 lore raw
Quoted 8 lines · Kailang

Hi Takashi,

C940 make i2s Amp(none Realtek) verb in BIOS verb table. It will enable internal speaker. This patch will solve it can't adjust speaker volume issue.

BR,
Kailang

Applied now with a slight modification to put at the next of the other speaker quirk for Dell and more clarifications in the description.

thanks,

Takashi