Skip to contentSkip to conversation

Issue with splice 32-bit compatability?

DISCUSSION Jens Axboe 2 participants 3 messages Feb 28, 2020 io_uring

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

Hey Pavel,

Since I yesterday found that weirdness with networking and using a separate flag for compat mode, I went to check everything else. Outside of all the syzbot reproducers not running in 32-bit mode, the only other error was splice:

splice: returned -29, expected 16384
basic splice-copy failed
test_splice failed -29 0
Test splice failed with ret 227

Can you take a look? I just edit test/Makefile and src/Makefile and add -m32 to the CFLAGS for testing.

Signature · 1 line
Jens Axboe
author maintainer
#1 lore raw
Quoted 7 lines · Jens Axboe

Hey Pavel,

Since I yesterday found that weirdness with networking and using a separate flag for compat mode, I went to check everything else. Outside of all the syzbot reproducers not running in 32-bit mode, the only other error was splice:

Quoted 7 lines

splice: returned -29, expected 16384
basic splice-copy failed
test_splice failed -29 0
Test splice failed with ret 227

Can you take a look? I just edit test/Makefile and src/Makefile and add -m32 to the CFLAGS for testing.

It's in the liburing prep, fixed it:

https://git.kernel.dk/cgit/liburing/commit/?id=566180209fc4d9e3ee8852315a4411ee0c3d5510

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 13 lines · Jens Axboe
Quoted 12 lines · Jens Axboe

Hey Pavel,

Since I yesterday found that weirdness with networking and using a separate flag for compat mode, I went to check everything else. Outside of all the syzbot reproducers not running in 32-bit mode, the only other error was splice:

splice: returned -29, expected 16384
basic splice-copy failed
test_splice failed -29 0
Test splice failed with ret 227

Quoted 6 lines
Quoted 2 lines

Can you take a look? I just edit test/Makefile and src/Makefile and add -m32 to the CFLAGS for testing.

It's in the liburing prep, fixed it:

https://git.kernel.dk/cgit/liburing/commit/?id=566180209fc4d9e3ee8852315a4411ee0c3d5510

A subtle one, great you found it!

Signature · 1 line
Pavel Begunkov