tools/gdbsx: drop stray recursion into tools/include/
PATCH 1/1 tools/gdbsx: drop stray recursion into tools/include/
Doing so isn't appropriate here - this gets done very early in the build process. If the directory is mean to to be buildable on its own, different arrangements would be needed.
The issue has become more pronounced by 47654a0d7320 ("tools/include:
fix (drop) dependencies of when to populate xen/"), but was there before afaict.
tools/debugger/gdbsx/xg/Makefile +1 -4
@@ -12,7 +12,7 @@ CFLAGS += $(CFLAGS_xeninclude) all: build .PHONY: build -build: xen-headers xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile +build: xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile # build: mk-symlinks xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile # build: mk-symlinks xg_all.a
@@ -21,9 +21,6 @@ xg_all.a: $(XG_OBJS) Makefile $(XG_HDRS) # $(LD) -b elf32-i386 $(LDFLAGS) -r -o $@ $^ # $(CC) -m32 -c -o $@ $^ -xen-headers: - $(MAKE) -C ../../../include - # xg_main.o: xg_main.c Makefile $(XG_HDRS) #$(CC) -c $(CFLAGS) -o $@ $<
Jan Beulich writes ("[PATCH] tools/gdbsx: drop stray recursion into tools/include/"):
Quoted 9 lines
Doing so isn't appropriate here - this gets done very early in the build process. If the directory is mean to to be buildable on its own, different arrangements would be needed.
The issue has become more pronounced by
47654a0d7320("tools/include:
fix (drop) dependencies of when to populate xen/"), but was there before afaict.Signed-off-by Jan Beulich <[email protected]>
Quoted 5 lines · Ian Jackson
Jan Beulich writes ("[PATCH]
tools/gdbsx: drop stray recursion intotools/include/"):Quoted 4 lines
Doing so isn't appropriate here - this gets done very early in the build process. If the directory is mean to to be buildable on its own, different arrangements would be needed.
Quoted 7 lines
Quoted 5 lines
The issue has become more pronounced by
47654a0d7320("tools/include:
fix (drop) dependencies of when to populate xen/"), but was there before afaict.Signed-off-by Jan Beulich <[email protected]>Reviewed-by Ian Jackson <[email protected]>
I tried to applied this one but git didn't like it.
Jan, feel free to apply it yourself.
Wei.
Quoted 10 lines · Wei Liu
Quoted 9 lines · Ian Jackson
Jan Beulich writes ("[PATCH]
tools/gdbsx: drop stray recursion intotools/include/"):Quoted 8 lines
Doing so isn't appropriate here - this gets done very early in the build process. If the directory is mean to to be buildable on its own, different arrangements would be needed.
The issue has become more pronounced by
47654a0d7320("tools/include:
fix (drop) dependencies of when to populate xen/"), but was there before afaict.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Jan Beulich <[email protected]>Reviewed-by Ian Jackson <[email protected]>I tried to applied this one but git didn't like it.
Jan, feel free to apply it yourself.
This is already applied. Sorry for the noise.
Wei.