Skip to contentSkip to conversation

io_uring: allow direct descriptors for connect

PATCH In review Jens Axboe 1 participant 2 messages Apr 12, 2022

Subsystems (2)
lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: allow direct descriptors for connect

Looks like an oversight that this is currently disabled, but I guess it didn't matter before we had direct descriptor support for socket.

---

fs/io_uring.c +1 -2
index 17b4dc9f130f..b83134906a3a 100644
@@ -5982,8 +5982,7 @@ static int io_connect_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 
 	if (unlikely(req->ctx->flags & IORING_SETUP_IOPOLL))
 		return -EINVAL;
-	if (sqe->ioprio || sqe->len || sqe->buf_index || sqe->rw_flags ||
-	    sqe->splice_fd_in)
+	if (sqe->ioprio || sqe->len || sqe->buf_index || sqe->rw_flags)
 		return -EINVAL;
 
 	conn->addr = u64_to_user_ptr(READ_ONCE(sqe->addr));
Signature · 1 line
Jens Axboe
author maintainer
#1 lore raw
Quoted 2 lines · Jens Axboe

Looks like an oversight that this is currently disabled, but I guess it didn't matter before we had direct descriptor support for socket.

Disregard, obviously a bug in my test program!

Signature · 1 line
Jens Axboe