Adding jh7100 SoC to defconfig
cover Adding jh7100 SoC to defconfig
Would like to have comments for adding jh7100 SoC to defconfig.
To make the upstream friendly, try to add as minimum as possible in arch/riscv/configs/defconfig required for beaglev-beta against the upstream defconfig. I might have added too much configs.
Then the distro vendors could use:
make defconfig beablev-fedora.config
or
make defconfig beablev-debian.config
while distro vendors keeping beablev-fedora.config and beablev-debian.config in their own repositories to make one binary kernel which boots for all riscv boards.
Probably, it is not good practice to add a different defconfig file under arch/riscv/configs/ when each new riscv board comes out.
Akira Tsukamoto (1):
config: Enable jh7100 SoC
arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)
Signature · 1 line
2.17.1
PATCH 1/1 config: Enable jh7100 SoC
--- arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)
arch/riscv/configs/defconfig +105 -0
@@ -138,3 +138,108 @@ CONFIG_DEBUG_BLOCK_EXT_DEVT=y CONFIG_MEMTEST=y # CONFIG_SYSFS_SYSCALL is not set CONFIG_EFI=y +CONFIG_FB_STARFIVE=y +CONFIG_FB_STARFIVE_HDMI_ADV7513=y +CONFIG_FB_STARFIVE_HDMI_TDA998X=y +CONFIG_FB_STARFIVE_SEEED5INCH=y +CONFIG_FB_STARFIVE_VIDEO=y +CONFIG_HW_RANDOM_STARFIVE_VIC=y +CONFIG_SOC_STARFIVE_VIC7100=y +CONFIG_FPGA_GMAC_FLUSH_DDR=y +CONFIG_MMC_DW_FLUSH_DDR=y +CONFIG_USB_CDNS3_HOST_FLUSH_DMA=y +CONFIG_SOC_STARFIVE_VIC7100_I2C_GPIO=y +CONFIG_VIDEO_STARFIVE_VIN=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_IMX219=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_OV5640=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_SC2235=y +CONFIG_RCU_CPU_STALL_TIMEOUT=60 +CONFIG_LOG_CPU_MAX_BUF_SHIFT=15 +CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT=12 +CONFIG_PM=y +CONFIG_PM_CLK=y +CONFIG_EFI_BOOTLOADER_CONTROL=y +CONFIG_BLK_PM=y +CONFIG_IOSCHED_BFQ=y +CONFIG_KSM=y +CONFIG_CMA=y +CONFIG_CMA_AREAS=7 +CONFIG_REGMAP_I2C=y +CONFIG_REGMAP_IRQ=y +CONFIG_MTD_OF_PARTS=y +CONFIG_MTD_BLKDEVS=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_PARTITIONED_MASTER=y +CONFIG_MTD_MAP_BANK_WIDTH_1=y +CONFIG_MTD_MAP_BANK_WIDTH_2=y +CONFIG_MTD_MAP_BANK_WIDTH_4=y +CONFIG_MTD_CFI_I1=y +CONFIG_MTD_CFI_I2=y +CONFIG_MTD_SPI_NOR=y +CONFIG_MTD_SPI_NOR_SWP_DISABLE_ON_VOLATILE=y +CONFIG_BLK_DEV_NBD=y +CONFIG_INPUT_LEDS=y +CONFIG_INPUT_EVDEV=y +CONFIG_SERIAL_8250_DMA=y +CONFIG_SERIAL_8250_DWLIB=y +CONFIG_SERIAL_8250_DW=y +CONFIG_HW_RANDOM_VIRTIO=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_MUX=y +CONFIG_I2C_DESIGNWARE_CORE=y +CONFIG_I2C_DESIGNWARE_PLATFORM=y +CONFIG_SPI_MEM=y +CONFIG_SPI_CADENCE_QUADSPI=y +CONFIG_SPI_DESIGNWARE=y +CONFIG_SPI_DW_DMA=y +CONFIG_SPI_DW_MMIO=y +CONFIG_SPI_SPIDEV=y +CONFIG_GPIO_SYSFS=y +CONFIG_GPIO_STARFIVE_VIC=y +CONFIG_GPIO_TPS65086=y +CONFIG_POWER_RESET_TPS65086=y +CONFIG_MFD_TPS65086=y +CONFIG_USB_HID=y +CONFIG_USB_CDNS_SUPPORT=y +CONFIG_USB_CDNS_HOST=y +CONFIG_USB_CDNS3=y +CONFIG_USB_CDNS3_HOST=y +CONFIG_USB_ROLE_SWITCH=y +CONFIG_SDIO_UART=y +CONFIG_MMC_DW=y +CONFIG_MMC_DW_PLTFM=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=y +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y +CONFIG_RTC_DRV_EFI=y +CONFIG_DMADEVICES=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_VIRTUAL_CHANNELS=y +CONFIG_DMA_OF=y +CONFIG_DW_AXI_DMAC=y +CONFIG_DW_AXI_DMAC_STARFIVE=y +CONFIG_COMMON_CLK_SI544=y +CONFIG_COMMON_CLK_PWM=y +CONFIG_SIFIVE_L2=y +CONFIG_SIFIVE_L2_FLUSH=y +CONFIG_SIFIVE_L2_FLUSH_START=0x80000000 +CONFIG_SIFIVE_L2_FLUSH_SIZE=0x800000000 +CONFIG_SIFIVE_L2_IRQ_DISABLE=y +CONFIG_PWM=y +CONFIG_PWM_SYSFS=y +CONFIG_PWM_SIFIVE_PTC=y +CONFIG_RESET_CONTROLLER=y +CONFIG_PROC_KCORE=y +CONFIG_EFIVAR_FS=y +CONFIG_ZLIB_DEFLATE=y +CONFIG_DMA_CMA=y +CONFIG_CMA_SIZE_MBYTES=640 +CONFIG_CMA_SIZE_SEL_MBYTES=y +CONFIG_CMA_ALIGNMENT=8 +CONFIG_NET_VENDOR_STMICRO=y +CONFIG_STMMAC_ETH=y +CONFIG_STMMAC_PLATFORM=y +CONFIG_DWMAC_GENERIC=y +CONFIG_MICREL_PHY=y
Signature · 1 line
2.17.1
Re: [PATCH 1/1] config: Enable jh7100 SoC
Hi Akira,
On Wed, 23 Jun 2021 21:46:54 +0900
Akira Tsukamoto <[email protected]> wrote:
It's better to add some descriptions here.
Quoted 10 lines
Signed-off-by Akira Tsukamoto <[email protected]>--- arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)arch/riscv/configs/defconfig +0
-0
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 146
Quoted 9 lines
arch/riscv/configs/defconfig +6
-0@@ -138,3 +138,108 @@ CONFIG_DEBUG_BLOCK_EXT_DEVT=y CONFIG_MEMTEST=y # CONFIG_SYSFS_SYSCALL is not set CONFIG_EFI=y +CONFIG_FB_STARFIVE=y +CONFIG_FB_STARFIVE_HDMI_ADV7513=y +CONFIG_FB_STARFIVE_HDMI_TDA998X=y +CONFIG_FB_STARFIVE_SEEED5INCH=y +CONFIG_FB_STARFIVE_VIDEO=y +CONFIG_HW_RANDOM_STARFIVE_VIC=y
I'm not sure which tree is this patch based. These config options are not defined. I also see undefined options below. For example, SOC_STARFIVE_VIC7100 SOC_STARFIVE_VIC7100_I2C_GPIO and so on
Quoted 99 lines
arch/riscv/configs/defconfig +99
-0+CONFIG_SOC_STARFIVE_VIC7100=y +CONFIG_FPGA_GMAC_FLUSH_DDR=y +CONFIG_MMC_DW_FLUSH_DDR=y +CONFIG_USB_CDNS3_HOST_FLUSH_DMA=y +CONFIG_SOC_STARFIVE_VIC7100_I2C_GPIO=y +CONFIG_VIDEO_STARFIVE_VIN=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_IMX219=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_OV5640=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_SC2235=y +CONFIG_RCU_CPU_STALL_TIMEOUT=60 +CONFIG_LOG_CPU_MAX_BUF_SHIFT=15 +CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT=12 +CONFIG_PM=y +CONFIG_PM_CLK=y +CONFIG_EFI_BOOTLOADER_CONTROL=y +CONFIG_BLK_PM=y +CONFIG_IOSCHED_BFQ=y +CONFIG_KSM=y +CONFIG_CMA=y +CONFIG_CMA_AREAS=7 +CONFIG_REGMAP_I2C=y +CONFIG_REGMAP_IRQ=y +CONFIG_MTD_OF_PARTS=y +CONFIG_MTD_BLKDEVS=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_PARTITIONED_MASTER=y +CONFIG_MTD_MAP_BANK_WIDTH_1=y +CONFIG_MTD_MAP_BANK_WIDTH_2=y +CONFIG_MTD_MAP_BANK_WIDTH_4=y +CONFIG_MTD_CFI_I1=y +CONFIG_MTD_CFI_I2=y +CONFIG_MTD_SPI_NOR=y +CONFIG_MTD_SPI_NOR_SWP_DISABLE_ON_VOLATILE=y +CONFIG_BLK_DEV_NBD=y +CONFIG_INPUT_LEDS=y +CONFIG_INPUT_EVDEV=y +CONFIG_SERIAL_8250_DMA=y +CONFIG_SERIAL_8250_DWLIB=y +CONFIG_SERIAL_8250_DW=y +CONFIG_HW_RANDOM_VIRTIO=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_MUX=y +CONFIG_I2C_DESIGNWARE_CORE=y +CONFIG_I2C_DESIGNWARE_PLATFORM=y +CONFIG_SPI_MEM=y +CONFIG_SPI_CADENCE_QUADSPI=y +CONFIG_SPI_DESIGNWARE=y +CONFIG_SPI_DW_DMA=y +CONFIG_SPI_DW_MMIO=y +CONFIG_SPI_SPIDEV=y +CONFIG_GPIO_SYSFS=y +CONFIG_GPIO_STARFIVE_VIC=y +CONFIG_GPIO_TPS65086=y +CONFIG_POWER_RESET_TPS65086=y +CONFIG_MFD_TPS65086=y +CONFIG_USB_HID=y +CONFIG_USB_CDNS_SUPPORT=y +CONFIG_USB_CDNS_HOST=y +CONFIG_USB_CDNS3=y +CONFIG_USB_CDNS3_HOST=y +CONFIG_USB_ROLE_SWITCH=y +CONFIG_SDIO_UART=y +CONFIG_MMC_DW=y +CONFIG_MMC_DW_PLTFM=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=y +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y +CONFIG_RTC_DRV_EFI=y +CONFIG_DMADEVICES=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_VIRTUAL_CHANNELS=y +CONFIG_DMA_OF=y +CONFIG_DW_AXI_DMAC=y +CONFIG_DW_AXI_DMAC_STARFIVE=y +CONFIG_COMMON_CLK_SI544=y +CONFIG_COMMON_CLK_PWM=y +CONFIG_SIFIVE_L2=y +CONFIG_SIFIVE_L2_FLUSH=y +CONFIG_SIFIVE_L2_FLUSH_START=0x80000000 +CONFIG_SIFIVE_L2_FLUSH_SIZE=0x800000000 +CONFIG_SIFIVE_L2_IRQ_DISABLE=y +CONFIG_PWM=y +CONFIG_PWM_SYSFS=y +CONFIG_PWM_SIFIVE_PTC=y +CONFIG_RESET_CONTROLLER=y +CONFIG_PROC_KCORE=y +CONFIG_EFIVAR_FS=y +CONFIG_ZLIB_DEFLATE=y +CONFIG_DMA_CMA=y +CONFIG_CMA_SIZE_MBYTES=640 +CONFIG_CMA_SIZE_SEL_MBYTES=y +CONFIG_CMA_ALIGNMENT=8 +CONFIG_NET_VENDOR_STMICRO=y +CONFIG_STMMAC_ETH=y +CONFIG_STMMAC_PLATFORM=y +CONFIG_DWMAC_GENERIC=y +CONFIG_MICREL_PHY=y
Quoted 2 lines · Akira Tsukamoto
Would like to have comments for adding jh7100 SoC to defconfig.
Thanks for preparing this defconfig.
Let's refer to the SoC as StarFive JH7100 SoC [1] which is used in the BeagleV Starlight JH7100 board [2].
Quoted 2 lines
To make the upstream friendly, try to add as minimum as possible in
arch/riscv/configs/defconfigrequired for beaglev-beta against the
Please use "BeagleV Starlight JH7100" instead of beaglev-beta.
Quoted 10 lines
upstream defconfig. I might have added too much configs.
Then the distro vendors could use:
make defconfig beablev-fedora.config
or
make defconfig beablev-debian.configwhile distro vendors keeping beablev-fedora.config and beablev-debian.config in their own repositories to make one binary kernel which boots for all riscv boards.
Note about naming, BeagleV refers to any RISC-V board produced by BeagleBoard.org and likely in the future will include other SoC families.
Quoted 3 lines
Probably, it is not good practice to add a different defconfig file under
arch/riscv/configs/when each new riscv board comes out.
We currently have:
defconfig
nommu_k210_defconfig
nommu_k210_sdcard_defconfig
nommu_virt_defconfig
rv32_defconfig
It seems like 'defconfig' supports the SiFive Unleashed board which makes sense as it was the only board for a longtime:
$ git grep -i sifive defconfig:CONFIG_SOC_SIFIVE=y defconfig:CONFIG_SPI_SIFIVE=y defconfig:CONFIG_GPIO_SIFIVE=y
I suppose the kconfig options needed for BeagleV Starlight JH7100 could be added to 'defconfig' as long as there were no incompatibilities. I assume the k210 versions were added because that is a rather odd SoC that has a non-supported MMU and thus runs in m-mode.
Thanks,
Drew
[1] https://github.com/starfive-tech/beaglev_doc/
[2] https://github.com/beagleboard/beaglev-starlight
Re: [PATCH 1/1] config: Enable jh7100 SoC
In reply to Akira Tsukamotoarch/riscv/configs/defconfig
Quoted 7 lines · Akira Tsukamoto
Signed-off-by Akira Tsukamoto <[email protected]>--- arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)arch/riscv/configs/defconfig +0
-0
Thanks for submitting this so we can review and discuss.
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 145
Quoted 12 lines
index
1f2be234b11c..e07d26d2743c100644arch/riscv/configs/defconfig +5
-0@@ -138,3 +138,108 @@ CONFIG_DEBUG_BLOCK_EXT_DEVT=y CONFIG_MEMTEST=y # CONFIG_SYSFS_SYSCALL is not set CONFIG_EFI=y +CONFIG_FB_STARFIVE=y +CONFIG_FB_STARFIVE_HDMI_ADV7513=y +CONFIG_FB_STARFIVE_HDMI_TDA998X=y +CONFIG_FB_STARFIVE_SEEED5INCH=y +CONFIG_FB_STARFIVE_VIDEO=y
These should be dropped as they are vendor drivers that will never be upstream as fbdev is deprecated [1]. StarFive is working on DRM driver but that is a couple months away from being ready.
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 147
Quoted 2 lines
arch/riscv/configs/defconfig +2
-0+CONFIG_HW_RANDOM_STARFIVE_VIC=y +CONFIG_SOC_STARFIVE_VIC7100=y
Before this gets merged upstream, we need to switch over to using JH7100 instead of VIC.
For those not familiar, VIC was the StarFive internal project name but the product is named JH7100 [2].
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 151
Quoted 4 lines
arch/riscv/configs/defconfig +4
-0+CONFIG_FPGA_GMAC_FLUSH_DDR=y +CONFIG_MMC_DW_FLUSH_DDR=y +CONFIG_USB_CDNS3_HOST_FLUSH_DMA=y +CONFIG_SOC_STARFIVE_VIC7100_I2C_GPIO=y
This config is being used in as a vendor hack in i2c_dw_configure_gpio() drivers/i2c/busses/i2c-designware-master.c [3].
It's possible we may be able to eliminate this once I have completed gpio and pinctrl drivers. Either way, this option will never be used in an upstream kernel.
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 155
Quoted 4 lines
arch/riscv/configs/defconfig +4
-0+CONFIG_VIDEO_STARFIVE_VIN=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_IMX219=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_OV5640=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_SC2235=y
These should be dropped as they are vendor drivers that do not use V4L2 and are not upstreamable [4]. StarFive is working on proper V4L2 drivers but that is a couple months away from being ready.
Quoted 33 lines
arch/riscv/configs/defconfig +33
-0+CONFIG_RCU_CPU_STALL_TIMEOUT=60 +CONFIG_LOG_CPU_MAX_BUF_SHIFT=15 +CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT=12 +CONFIG_PM=y +CONFIG_PM_CLK=y +CONFIG_EFI_BOOTLOADER_CONTROL=y +CONFIG_BLK_PM=y +CONFIG_IOSCHED_BFQ=y +CONFIG_KSM=y +CONFIG_CMA=y +CONFIG_CMA_AREAS=7 +CONFIG_REGMAP_I2C=y +CONFIG_REGMAP_IRQ=y +CONFIG_MTD_OF_PARTS=y +CONFIG_MTD_BLKDEVS=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_PARTITIONED_MASTER=y +CONFIG_MTD_MAP_BANK_WIDTH_1=y +CONFIG_MTD_MAP_BANK_WIDTH_2=y +CONFIG_MTD_MAP_BANK_WIDTH_4=y +CONFIG_MTD_CFI_I1=y +CONFIG_MTD_CFI_I2=y +CONFIG_MTD_SPI_NOR=y +CONFIG_MTD_SPI_NOR_SWP_DISABLE_ON_VOLATILE=y +CONFIG_BLK_DEV_NBD=y +CONFIG_INPUT_LEDS=y +CONFIG_INPUT_EVDEV=y +CONFIG_SERIAL_8250_DMA=y +CONFIG_SERIAL_8250_DWLIB=y +CONFIG_SERIAL_8250_DW=y +CONFIG_HW_RANDOM_VIRTIO=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_MUX=y
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 198
Quoted 10 lines
arch/riscv/configs/defconfig +10
-0+CONFIG_I2C_DESIGNWARE_CORE=y +CONFIG_I2C_DESIGNWARE_PLATFORM=y +CONFIG_SPI_MEM=y +CONFIG_SPI_CADENCE_QUADSPI=y +CONFIG_SPI_DESIGNWARE=y +CONFIG_SPI_DW_DMA=y +CONFIG_SPI_DW_MMIO=y +CONFIG_SPI_SPIDEV=y +CONFIG_GPIO_SYSFS=y +CONFIG_GPIO_STARFIVE_VIC=y
I am working on upstreamable version of the GPIO driver and will submit RFC soon. This will be called CONFIG_GPIO_STARFIVE_JH7100.
Quoted 51 lines
arch/riscv/configs/defconfig +47
-0+CONFIG_GPIO_TPS65086=y +CONFIG_POWER_RESET_TPS65086=y +CONFIG_MFD_TPS65086=y +CONFIG_USB_HID=y +CONFIG_USB_CDNS_SUPPORT=y +CONFIG_USB_CDNS_HOST=y +CONFIG_USB_CDNS3=y +CONFIG_USB_CDNS3_HOST=y +CONFIG_USB_ROLE_SWITCH=y +CONFIG_SDIO_UART=y +CONFIG_MMC_DW=y +CONFIG_MMC_DW_PLTFM=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=y +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y +CONFIG_RTC_DRV_EFI=y +CONFIG_DMADEVICES=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_VIRTUAL_CHANNELS=y +CONFIG_DMA_OF=y +CONFIG_DW_AXI_DMAC=y +CONFIG_DW_AXI_DMAC_STARFIVE=y +CONFIG_COMMON_CLK_SI544=y +CONFIG_COMMON_CLK_PWM=y +CONFIG_SIFIVE_L2=y +CONFIG_SIFIVE_L2_FLUSH=y +CONFIG_SIFIVE_L2_FLUSH_START=0x80000000 +CONFIG_SIFIVE_L2_FLUSH_SIZE=0x800000000 +CONFIG_SIFIVE_L2_IRQ_DISABLE=y +CONFIG_PWM=y +CONFIG_PWM_SYSFS=y +CONFIG_PWM_SIFIVE_PTC=y +CONFIG_RESET_CONTROLLER=y +CONFIG_PROC_KCORE=y +CONFIG_EFIVAR_FS=y +CONFIG_ZLIB_DEFLATE=y +CONFIG_DMA_CMA=y +CONFIG_CMA_SIZE_MBYTES=640 +CONFIG_CMA_SIZE_SEL_MBYTES=y +CONFIG_CMA_ALIGNMENT=8 +CONFIG_NET_VENDOR_STMICRO=y +CONFIG_STMMAC_ETH=y +CONFIG_STMMAC_PLATFORM=y +CONFIG_DWMAC_GENERIC=y +CONFIG_MICREL_PHY=ySignature · 1 line
2.17.1
Thanks,
Drew
[1] https://github.com/starfive-tech/linux/tree/beaglev/drivers/video/fbdev/starfive
[2] https://github.com/starfive-tech/beaglev_doc/
[3] https://github.com/starfive-tech/linux/blob/beaglev/drivers/i2c/busses/i2c-designware-master.c#L170
[4] https://github.com/starfive-tech/linux/tree/beaglev/drivers/media/platform/starfive
Re: [PATCH 1/1] config: Enable jh7100 SoC
In reply to Jisheng ZhangQuoted 6 lines · Jisheng Zhang
Hi Akira,
On Wed, 23 Jun 2021 21:46:54 +0900
Akira Tsukamoto <[email protected]> wrote:It's better to add some descriptions here.
Thanks, I will add it when the RFC is over and ready to spin the patch.
Akira
Quoted 126 lines
Quoted 11 lines
Signed-off-by Akira Tsukamoto <[email protected]>--- arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)arch/riscv/configs/defconfig +0
-0arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 146
Quoted 9 lines
arch/riscv/configs/defconfig +6
-0@@ -138,3 +138,108 @@ CONFIG_DEBUG_BLOCK_EXT_DEVT=y CONFIG_MEMTEST=y # CONFIG_SYSFS_SYSCALL is not set CONFIG_EFI=y +CONFIG_FB_STARFIVE=y +CONFIG_FB_STARFIVE_HDMI_ADV7513=y +CONFIG_FB_STARFIVE_HDMI_TDA998X=y +CONFIG_FB_STARFIVE_SEEED5INCH=y +CONFIG_FB_STARFIVE_VIDEO=y +CONFIG_HW_RANDOM_STARFIVE_VIC=yI'm not sure which tree is this patch based. These config options are not defined. I also see undefined options below. For example,
SOC_STARFIVE_VIC7100SOC_STARFIVE_VIC7100_I2C_GPIOand so onQuoted 99 lines
arch/riscv/configs/defconfig +99
-0+CONFIG_SOC_STARFIVE_VIC7100=y +CONFIG_FPGA_GMAC_FLUSH_DDR=y +CONFIG_MMC_DW_FLUSH_DDR=y +CONFIG_USB_CDNS3_HOST_FLUSH_DMA=y +CONFIG_SOC_STARFIVE_VIC7100_I2C_GPIO=y +CONFIG_VIDEO_STARFIVE_VIN=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_IMX219=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_OV5640=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_SC2235=y +CONFIG_RCU_CPU_STALL_TIMEOUT=60 +CONFIG_LOG_CPU_MAX_BUF_SHIFT=15 +CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT=12 +CONFIG_PM=y +CONFIG_PM_CLK=y +CONFIG_EFI_BOOTLOADER_CONTROL=y +CONFIG_BLK_PM=y +CONFIG_IOSCHED_BFQ=y +CONFIG_KSM=y +CONFIG_CMA=y +CONFIG_CMA_AREAS=7 +CONFIG_REGMAP_I2C=y +CONFIG_REGMAP_IRQ=y +CONFIG_MTD_OF_PARTS=y +CONFIG_MTD_BLKDEVS=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_PARTITIONED_MASTER=y +CONFIG_MTD_MAP_BANK_WIDTH_1=y +CONFIG_MTD_MAP_BANK_WIDTH_2=y +CONFIG_MTD_MAP_BANK_WIDTH_4=y +CONFIG_MTD_CFI_I1=y +CONFIG_MTD_CFI_I2=y +CONFIG_MTD_SPI_NOR=y +CONFIG_MTD_SPI_NOR_SWP_DISABLE_ON_VOLATILE=y +CONFIG_BLK_DEV_NBD=y +CONFIG_INPUT_LEDS=y +CONFIG_INPUT_EVDEV=y +CONFIG_SERIAL_8250_DMA=y +CONFIG_SERIAL_8250_DWLIB=y +CONFIG_SERIAL_8250_DW=y +CONFIG_HW_RANDOM_VIRTIO=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_MUX=y +CONFIG_I2C_DESIGNWARE_CORE=y +CONFIG_I2C_DESIGNWARE_PLATFORM=y +CONFIG_SPI_MEM=y +CONFIG_SPI_CADENCE_QUADSPI=y +CONFIG_SPI_DESIGNWARE=y +CONFIG_SPI_DW_DMA=y +CONFIG_SPI_DW_MMIO=y +CONFIG_SPI_SPIDEV=y +CONFIG_GPIO_SYSFS=y +CONFIG_GPIO_STARFIVE_VIC=y +CONFIG_GPIO_TPS65086=y +CONFIG_POWER_RESET_TPS65086=y +CONFIG_MFD_TPS65086=y +CONFIG_USB_HID=y +CONFIG_USB_CDNS_SUPPORT=y +CONFIG_USB_CDNS_HOST=y +CONFIG_USB_CDNS3=y +CONFIG_USB_CDNS3_HOST=y +CONFIG_USB_ROLE_SWITCH=y +CONFIG_SDIO_UART=y +CONFIG_MMC_DW=y +CONFIG_MMC_DW_PLTFM=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=y +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y +CONFIG_RTC_DRV_EFI=y +CONFIG_DMADEVICES=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_VIRTUAL_CHANNELS=y +CONFIG_DMA_OF=y +CONFIG_DW_AXI_DMAC=y +CONFIG_DW_AXI_DMAC_STARFIVE=y +CONFIG_COMMON_CLK_SI544=y +CONFIG_COMMON_CLK_PWM=y +CONFIG_SIFIVE_L2=y +CONFIG_SIFIVE_L2_FLUSH=y +CONFIG_SIFIVE_L2_FLUSH_START=0x80000000 +CONFIG_SIFIVE_L2_FLUSH_SIZE=0x800000000 +CONFIG_SIFIVE_L2_IRQ_DISABLE=y +CONFIG_PWM=y +CONFIG_PWM_SYSFS=y +CONFIG_PWM_SIFIVE_PTC=y +CONFIG_RESET_CONTROLLER=y +CONFIG_PROC_KCORE=y +CONFIG_EFIVAR_FS=y +CONFIG_ZLIB_DEFLATE=y +CONFIG_DMA_CMA=y +CONFIG_CMA_SIZE_MBYTES=640 +CONFIG_CMA_SIZE_SEL_MBYTES=y +CONFIG_CMA_ALIGNMENT=8 +CONFIG_NET_VENDOR_STMICRO=y +CONFIG_STMMAC_ETH=y +CONFIG_STMMAC_PLATFORM=y +CONFIG_DWMAC_GENERIC=y +CONFIG_MICREL_PHY=y
Quoted 21 lines · Drew Fustini
Quoted 2 lines · Akira Tsukamoto
Would like to have comments for adding jh7100 SoC to defconfig.
Thanks for preparing this defconfig.
Let's refer to the SoC as StarFive JH7100 SoC [1] which is used in the BeagleV Starlight JH7100 board [2].
Quoted 2 lines
To make the upstream friendly, try to add as minimum as possible in
arch/riscv/configs/defconfigrequired for beaglev-beta against thePlease use "BeagleV Starlight JH7100" instead of beaglev-beta.
Quoted 7 lines
upstream defconfig. I might have added too much configs.
Then the distro vendors could use:
make defconfig beablev-fedora.config
or
make defconfig beablev-debian.config
Quoted 7 lines
Quoted 3 lines
while distro vendors keeping beablev-fedora.config and beablev-debian.config in their own repositories to make one binary kernel which boots for all riscv boards.
Note about naming, BeagleV refers to any RISC-V board produced by BeagleBoard.org and likely in the future will include other SoC families.
No problem, I will rename them all to "StarFive JH7100 SoC" and "BeagleV Starlight JH7100 board".
Quoted 21 lines
Quoted 4 lines
Probably, it is not good practice to add a different defconfig file under
arch/riscv/configs/when each new riscv board comes out.We currently have:
defconfig
nommu_k210_defconfig
nommu_k210_sdcard_defconfig
nommu_virt_defconfig
rv32_defconfigIt seems like 'defconfig' supports the SiFive Unleashed board which makes sense as it was the only board for a longtime:
$ git grep -i sifive defconfig:CONFIG_SOC_SIFIVE=y defconfig:CONFIG_SPI_SIFIVE=y defconfig:CONFIG_GPIO_SIFIVE=y
Quoted 4 lines
I suppose the kconfig options needed for BeagleV Starlight JH7100 could be added to 'defconfig' as long as there were no incompatibilities. I assume the k210 versions were added because that is a rather odd SoC that has a non-supported MMU and thus runs in m-mode.
By adding configs for BeagleV Starlight JH7100 booting fine on the current defconfig which were SiFive Unleashed. Would like to have comments from the users of Unleashed when this patch starts to settle down.
Akira
Quoted 7 lines
Thanks,
Drew[1] https://github.com/starfive-tech/beaglev_doc/
[2] https://github.com/beagleboard/beaglev-starlight
Re: [PATCH 1/1] config: Enable jh7100 SoC
In reply to Drew FustiniQuoted 11 lines · Drew Fustini
arch/riscv/configs/defconfig
Quoted 7 lines · Akira Tsukamoto
Signed-off-by Akira Tsukamoto <[email protected]>--- arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)arch/riscv/configs/defconfig +0
-0Thanks for submitting this so we can review and discuss.
Quoted 16 lines
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 145
Quoted 12 lines
index
1f2be234b11c..e07d26d2743c100644arch/riscv/configs/defconfig +5
-0@@ -138,3 +138,108 @@ CONFIG_DEBUG_BLOCK_EXT_DEVT=y CONFIG_MEMTEST=y # CONFIG_SYSFS_SYSCALL is not set CONFIG_EFI=y +CONFIG_FB_STARFIVE=y +CONFIG_FB_STARFIVE_HDMI_ADV7513=y +CONFIG_FB_STARFIVE_HDMI_TDA998X=y +CONFIG_FB_STARFIVE_SEEED5INCH=y +CONFIG_FB_STARFIVE_VIDEO=yThese should be dropped as they are vendor drivers that will never be upstream as fbdev is deprecated [1]. StarFive is working on DRM driver but that is a couple months away from being ready.
I will remove fbdev. And enable DRM driver only when them become ready.
Quoted 9 lines
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 147
Quoted 3 lines
arch/riscv/configs/defconfig +2
-0+CONFIG_HW_RANDOM_STARFIVE_VIC=y +CONFIG_SOC_STARFIVE_VIC7100=yBefore this gets merged upstream, we need to switch over to using JH7100 instead of VIC.
For those not familiar, VIC was the StarFive internal project name but the product is named JH7100 [2].
I will wait to enable the configs above until the patches rename them and become upstream ready.
Quoted 9 lines
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 151
Quoted 5 lines
arch/riscv/configs/defconfig +4
-0+CONFIG_FPGA_GMAC_FLUSH_DDR=y +CONFIG_MMC_DW_FLUSH_DDR=y +CONFIG_USB_CDNS3_HOST_FLUSH_DMA=y +CONFIG_SOC_STARFIVE_VIC7100_I2C_GPIO=yThis config is being used in as a vendor hack in
i2c_dw_configure_gpio()drivers/i2c/busses/i2c-designware-master.c[3].
Quoted 3 lines
It's possible we may be able to eliminate this once I have completed gpio and pinctrl drivers. Either way, this option will never be used in an upstream kernel.
Sure, I will remove them and try it since I think your drivers were in the Esmil branch.
Quoted 9 lines
arch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 155
Quoted 5 lines
arch/riscv/configs/defconfig +4
-0+CONFIG_VIDEO_STARFIVE_VIN=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_IMX219=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_OV5640=y +CONFIG_VIDEO_STARFIVE_VIN_SENSOR_SC2235=yThese should be dropped as they are vendor drivers that do not use V4L2 and are not upstreamable [4]. StarFive is working on proper V4L2 drivers but that is a couple months away from being ready.
Thanks, I will also wait for the v4l2 being ready.
Akira
Quoted 108 lines
Quoted 34 lines
arch/riscv/configs/defconfig +33
-0+CONFIG_RCU_CPU_STALL_TIMEOUT=60 +CONFIG_LOG_CPU_MAX_BUF_SHIFT=15 +CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT=12 +CONFIG_PM=y +CONFIG_PM_CLK=y +CONFIG_EFI_BOOTLOADER_CONTROL=y +CONFIG_BLK_PM=y +CONFIG_IOSCHED_BFQ=y +CONFIG_KSM=y +CONFIG_CMA=y +CONFIG_CMA_AREAS=7 +CONFIG_REGMAP_I2C=y +CONFIG_REGMAP_IRQ=y +CONFIG_MTD_OF_PARTS=y +CONFIG_MTD_BLKDEVS=y +CONFIG_MTD_BLOCK=y +CONFIG_MTD_PARTITIONED_MASTER=y +CONFIG_MTD_MAP_BANK_WIDTH_1=y +CONFIG_MTD_MAP_BANK_WIDTH_2=y +CONFIG_MTD_MAP_BANK_WIDTH_4=y +CONFIG_MTD_CFI_I1=y +CONFIG_MTD_CFI_I2=y +CONFIG_MTD_SPI_NOR=y +CONFIG_MTD_SPI_NOR_SWP_DISABLE_ON_VOLATILE=y +CONFIG_BLK_DEV_NBD=y +CONFIG_INPUT_LEDS=y +CONFIG_INPUT_EVDEV=y +CONFIG_SERIAL_8250_DMA=y +CONFIG_SERIAL_8250_DWLIB=y +CONFIG_SERIAL_8250_DW=y +CONFIG_HW_RANDOM_VIRTIO=y +CONFIG_I2C_CHARDEV=y +CONFIG_I2C_MUX=yarch/riscv/configs/defconfig CONFIG_DEBUG_BLOCK_EXT_DEVT=y · line 198
Quoted 10 lines
arch/riscv/configs/defconfig +10
-0+CONFIG_I2C_DESIGNWARE_CORE=y +CONFIG_I2C_DESIGNWARE_PLATFORM=y +CONFIG_SPI_MEM=y +CONFIG_SPI_CADENCE_QUADSPI=y +CONFIG_SPI_DESIGNWARE=y +CONFIG_SPI_DW_DMA=y +CONFIG_SPI_DW_MMIO=y +CONFIG_SPI_SPIDEV=y +CONFIG_GPIO_SYSFS=y +CONFIG_GPIO_STARFIVE_VIC=yI am working on upstreamable version of the GPIO driver and will submit RFC soon. This will be called
CONFIG_GPIO_STARFIVE_JH7100.Quoted 51 lines
arch/riscv/configs/defconfig +47
-0+CONFIG_GPIO_TPS65086=y +CONFIG_POWER_RESET_TPS65086=y +CONFIG_MFD_TPS65086=y +CONFIG_USB_HID=y +CONFIG_USB_CDNS_SUPPORT=y +CONFIG_USB_CDNS_HOST=y +CONFIG_USB_CDNS3=y +CONFIG_USB_CDNS3_HOST=y +CONFIG_USB_ROLE_SWITCH=y +CONFIG_SDIO_UART=y +CONFIG_MMC_DW=y +CONFIG_MMC_DW_PLTFM=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=y +CONFIG_LEDS_GPIO=y +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_HEARTBEAT=y +CONFIG_RTC_DRV_EFI=y +CONFIG_DMADEVICES=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_VIRTUAL_CHANNELS=y +CONFIG_DMA_OF=y +CONFIG_DW_AXI_DMAC=y +CONFIG_DW_AXI_DMAC_STARFIVE=y +CONFIG_COMMON_CLK_SI544=y +CONFIG_COMMON_CLK_PWM=y +CONFIG_SIFIVE_L2=y +CONFIG_SIFIVE_L2_FLUSH=y +CONFIG_SIFIVE_L2_FLUSH_START=0x80000000 +CONFIG_SIFIVE_L2_FLUSH_SIZE=0x800000000 +CONFIG_SIFIVE_L2_IRQ_DISABLE=y +CONFIG_PWM=y +CONFIG_PWM_SYSFS=y +CONFIG_PWM_SIFIVE_PTC=y +CONFIG_RESET_CONTROLLER=y +CONFIG_PROC_KCORE=y +CONFIG_EFIVAR_FS=y +CONFIG_ZLIB_DEFLATE=y +CONFIG_DMA_CMA=y +CONFIG_CMA_SIZE_MBYTES=640 +CONFIG_CMA_SIZE_SEL_MBYTES=y +CONFIG_CMA_ALIGNMENT=8 +CONFIG_NET_VENDOR_STMICRO=y +CONFIG_STMMAC_ETH=y +CONFIG_STMMAC_PLATFORM=y +CONFIG_DWMAC_GENERIC=y +CONFIG_MICREL_PHY=ySignature · 1 line
2.17.1Thanks,
Drew[1] https://github.com/starfive-tech/linux/tree/beaglev/drivers/video/fbdev/starfive
[2] https://github.com/starfive-tech/beaglev_doc/
[3] https://github.com/starfive-tech/linux/blob/beaglev/drivers/i2c/busses/i2c-designware-master.c#L170
[4] https://github.com/starfive-tech/linux/tree/beaglev/drivers/media/platform/starfive