Skip to contentSkip to conversation

io_uring: correct size of overflow CQE calculation

PATCH In review Jens Axboe 2 participants 2 messages Sep 10, 2025 io_uring

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: correct size of overflow CQE calculation

If a 32b CQE is required, don't double the size of the overflow struct, just add the size of the io_uring_cqe addition that is needed. This avoids allocating too much memory, as the io_overflow_cqe size includes the list member required to queue them too.

Fixes e26dca67fde1 ("io_uring: add support for IORING_SETUP_CQE_MIXED")

---

io_uring/io_uring.c +1 -1
index 6d62f10416eb..1bfa124565f7 100644
@@ -756,7 +756,7 @@ static struct io_overflow_cqe *io_alloc_ocqe(struct io_ring_ctx *ctx,
 
 	if (cqe->flags & IORING_CQE_F_32 || ctx->flags & IORING_SETUP_CQE32) {
 		is_cqe32 = true;
-		ocq_size <<= 1;
+		ocq_size += sizeof(struct io_uring_cqe);
 	}
 
 	ocqe = kzalloc(ocq_size, gfp | __GFP_ACCOUNT);
Signature · 1 line
Jens Axboe
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jens Axboe

If a 32b CQE is required, don't double the size of the overflow struct, just add the size of the io_uring_cqe addition that is needed. This avoids allocating too much memory, as the io_overflow_cqe size includes the list member required to queue them too.

Fixes e26dca67fde1 ("io_uring: add support for IORING_SETUP_CQE_MIXED")