Skip to contentSkip to conversation

include/generated/environment.h included incorrectly

BUG Sean Anderson 2 participants 2 messages Feb 25, 2022 – Mar 12, 2022

lore
Share & tools
lore
#0 lore raw

Hi Simon,

include/generated/environment.h is still included if it exists, even if

CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board

which uses this config (such as sandbox), and then build a board which

does not. You should see the following error:

In file included from env/common.c:32:

include/env_default.h:113:3: error: #error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"

113 | # error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"

      |   ^~~~~

--Sean

#1 lore raw

Hi Sean,

Quoted 16 lines · Sean Anderson

Hi Simon,

include/generated/environment.h is still included if it exists, even if

CONFIG_USE_DEFAULT_ENV_FILE is not set. To reproduce this, build a board

which uses this config (such as sandbox), and then build a board which

does not. You should see the following error:

Quoted 8 lines

In file included from env/common.c:32:

include/env_default.h:113:3: error: #error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"

113 | # error "Your board uses a text-file environment, so must not define CONFIG_EXTRA_ENV_SETTINGS"

       |   ^~~~~

I created https://source.denx.de/u-boot/u-boot/-/issues/9

Regards,
Simon