bug in cpu/ppc4xx/start.S

hi,

what's the preferred method for reporting u-boot bugs? enter them into the bug database on sourceforge.net, or post them to the mailing list, or email the designated custodian?

the reason I ask is that I just discovered a bug in the OCM initialization code for the PPC405EZ

at line 786, the mtdcr instruction specifies the wrong register, it should say "r4" not "r3"

this:

         addis   r3,0,0x0800             /* OCM Data Parity Disable - 1 Wait State */
         mtdcr   ocmdsisdpc,r4

should be changed to this:

         addis   r3,0,0x0800             /* OCM Data Parity Disable - 1 Wait State */
         mtdcr   ocmdsisdpc,r3

bruce

Hi Bruce,

AFAIK, the bug database on sourceforge isn't used. If you know how to fix something, send a properly-formatted patch to this list, probably CC'ing the custodian to get his/her attention.

regards,
Ben

Yes, please send a patch to the list (and CC to me). In this case not necessary anymore, since I already intergrated your fix into a update that will be pushed soon to the official repository.

Thanks for spotting.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================