Skip to contentSkip to conversation

leds: class: If no default trigger is given, make hw_control trigger the default trigger

PATCH Applied Heiner Kallweit 2 participants 2 messages Dec 22, 2023 – Jan 11, 2024 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: class: If no default trigger is given, make hw_control trigger the default trigger

If a hw_control_trigger is defined, it's usually desirable to make it the default trigger. Therefore make it the default trigger, except the driver explicitly set a default trigger.

---
 drivers/leds/led-class.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/leds/led-class.c +6 -0
index ba1be15cf..24fcff682 100644
@@ -552,6 +552,12 @@ int led_classdev_register_ext(struct device *parent,
 	led_init_core(led_cdev);
 
 #ifdef CONFIG_LEDS_TRIGGERS
+	/*
+	 * If no default trigger was given and hw_control_trigger is set,
+	 * make it the default trigger.
+	 */
+	if (!led_cdev->default_trigger && led_cdev->hw_control_trigger)
+		led_cdev->default_trigger = led_cdev->hw_control_trigger;
 	led_trigger_set_default(led_cdev);
 #endif
 
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

Re: (subset) [PATCH] leds: class: If no default trigger is given, make hw_control trigger the default trigger

Quoted 5 lines · Heiner Kallweit

If a hw_control_trigger is defined, it's usually desirable to make it the default trigger. Therefore make it the default trigger, except the driver explicitly set a default trigger.

Applied, thanks!

[1/1] leds: class: If no default trigger is given, make hw_control trigger the default trigger

      commit: 2ee8444431cfa2324a695f964348124b5c4ca3d4

--
Lee Jones [李琼斯]