Skip to contentSkip to conversation

pci_lost_interrupt still needed?

DISCUSSION Heiner Kallweit 2 participants 4 messages Jul 28, 2020 PCI

lore
Share & tools
lore
#0 lore raw

Seems that pci_lost_interrupt() has no user. Do we still need this function? Same applies for related enum pci_lost_interrupt_reason.

#1 lore raw
Quoted 2 lines · Heiner Kallweit

Seems that pci_lost_interrupt() has no user. Do we still need this function? Same applies for related enum pci_lost_interrupt_reason.

If there's no user, remove it. Bonus points if you look up the removal of the last use.

#2 lore raw
Quoted 7 lines · Bjorn Helgaas
Quoted 2 lines · Heiner Kallweit

Seems that pci_lost_interrupt() has no user. Do we still need this function? Same applies for related enum pci_lost_interrupt_reason.

If there's no user, remove it. Bonus points if you look up the removal of the last use.

It was introduced in 2.6.27, and apparently there never has been a single user. So I'll submit a patch to remove it.

#3 lore raw
Quoted 10 lines · Heiner Kallweit
Quoted 7 lines · Bjorn Helgaas
Quoted 2 lines · Heiner Kallweit

Seems that pci_lost_interrupt() has no user. Do we still need this function? Same applies for related enum pci_lost_interrupt_reason.

If there's no user, remove it. Bonus points if you look up the removal of the last use.

It was introduced in 2.6.27, and apparently there never has been a single user. So I'll submit a patch to remove it.

Strange. Please include the commit that added it and cc: the author.