Agpgart for 845G
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hello
Quoted 3 lines
Patch for Intel 845G agpgart support
diff'd against which version of the kernel ?
Review
Quoted 6 lines
(quoted diff) +6
-0+ { PCI_DEVICE_ID_INTEL_845_G_0, + PCI_VENDOR_ID_INTEL, + INTEL_I845_G, + "Intel", + "i845G", + intel_830mp_setup },
Are you sure that 830mp and 845g have exactly the same addresses to write/read to ? BTW, I can't find any datasheet for 845g on Intel's website ... do you have any at hand ?
Review
Quoted 9 lines
(quoted diff) +9
-0+ if (i810_dev == NULL) { + /* + * We probably have a I830MP chipset + * with an external graphics + * card. It will be initialized later + */ + agp_bridge.type = INTEL_I845_G; + break; + }
Are you sure about the comment :-)) ?
a+
Nicolas.
PS: CC any answer to me, I am not on the list...
Signature · 2 lines
Nicolas Aspert Signal Processing Institute (ITS) Swiss Federal Institute of Technology (EPFL)
Hi Nicolas!
Quoted 10 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ { PCI_DEVICE_ID_INTEL_845_G_0, + PCI_VENDOR_ID_INTEL, + INTEL_I845_G, + "Intel", + "i845G", + intel_830mp_setup },Are you sure that 830mp and 845g have exactly the same addresses to write/read to ? BTW, I can't find any datasheet for 845g on Intel's website ... do you have any at hand ?
The 845g chipset is the little brother of 830mp - it's memory allocation didn't change a bit, so above setup is actually correct.
Quoted 11 lines
Review
Quoted 9 lines
(quoted diff) +9
-0+ if (i810_dev == NULL) { + /* + * We probably have a I830MP chipset + * with an external graphics + * card. It will be initialized later + */ + agp_bridge.type = INTEL_I845_G; + break; + }Are you sure about the comment :-)) ?
Smells like cut & paste to me (;
Signature · 16 lines
Regards Abraham "Intelligence without character is a dangerous thing." -- G. Steinem __________________________________________________________ Abraham vd Merwe - 2d3D, Inc. Device Driver Development, Outsourcing, Embedded Systems Cell: +27 82 565 4451 Snailmail: Tel: +27 21 761 7549 Block C, Aintree Park Fax: +27 21 761 7648 Doncaster Road Email: [email protected] Kenilworth, 7700 Http: http://www.2d3d.com South Africa