: linux-2.5.44uc1 (MMU-less support)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Sam Ravnborg <[email protected]>:
Quoted 12 lines
+arch/$(ARCH)/kernel/asm-offsets.s:
include/asminclude/linux/version.h\
+include/config/MARKER
+
+include/asm-$(ARCH)/asm-offsets.h.tmp: arch/$(ARCH)/kernel/asm-offsets.s
+ @$(generate-asm-offsets.h) < $< > $@
+
+include/asm-$(ARCH)/asm-offsets.h: include/asm-$(ARCH)/asm-offsets.h.tmp
+ @echo -n ' Generating $@'
+ @$(update-if-changed)Combine it like this instead:
Quoted 8 lines
include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \ include/asm include/linux/version.h \ include/config/MARKER @echo -n ' Generating $@' @$(generate-asm-offsets.h) < $< > $@ @$(update-if-changed)Thats more readable, and follow te normal way of doing it.
It may be more readable, but I don't think you can say it's the `normal way of doing it,' at least in linux -- almost all the arch Makefiles have code pretty much identical to Greg's (presumably all derived from a single original source).
Perhaps they should all be changed.
-Miles
[the threading info on this msg is wrong because MARC's `Download message
RAW' option doesn't provide the message headers; quite annoying, that...]
Signature · 1 line
"1971 pickup truck; will trade for guns"
Quoted 6 lines · Miles Bader
It may be more readable, but I don't think you can say it's the `normal way of doing it,' at least in linux -- almost all the arch Makefiles have code pretty much identical to Greg's (presumably all derived from a single original source).
Perhaps they should all be changed.
Well, most arch Makefiles could use some cleaning up - also with respect to te construct above. My point was that there is no need to list prerequisites as several rules when they can be combined as one. And the fact that a temporary is generated could well be hidden. By the way I made a mistake, it should be:
include/asm-$(ARCH)/asm-offsets.h: arch/$(ARCH)/kernel/asm-offsets.s \
include/asm include/linux/version.h \
include/config/MARKER
@echo -n ' Generating $@'
@$(generate-asm-offsets.h) < $< > [email protected]
@$(update-if-changed)
SamQuoted 3 lines · Sam Ravnborg
Well, most arch Makefiles could use some cleaning up - also with respect to the construct above. My point was that there is no need to list prerequisites as several rules when they can be combined as one.
Well, sure. I'm just trying to say that this shouldn't be considered a problem with Greg's patch. Since he's aiming for inclusion, I think a bit of conservatism is a good thing... :-)
-Miles
Signature · 2 lines
P.S. All information contained in the above letter is false,
for reasons of military security.