Skip to contentSkip to conversation

PS2 mouse changes for 2.6

DISCUSSION walt 2 participants 2 messages Dec 30, 2003 2 messages not in the archive Input drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

walt

author
#2 lore raw
Quoted 7 lines · Dmitry Torokhov
Quoted 2 lines · walt

I see no deprecation warnings when starting the kernel with psmouse_noext, which I was expecting to see.

It is emitted with KERN_WARNING severity and is not necessary seen on the console. Check your dmesg.

No warnings in dmesg on two different machines booted with psmouse_noext.

I am NOT complaining -- my mouse works better today than yesterday :0)

Is there anything I can do to help with this problem (?)

#3 lore raw
Quoted 8 lines · walt
Quoted 6 lines · Dmitry Torokhov
Quoted 2 lines · walt

I see no deprecation warnings when starting the kernel with psmouse_noext, which I was expecting to see.

It is emitted with KERN_WARNING severity and is not necessary seen on the console. Check your dmesg.

Quoted 6 lines

No warnings in dmesg on two different machines booted with psmouse_noext.

I am NOT complaining -- my mouse works better today than yesterday :0)

Is there anything I can do to help with this problem (?)

OK, when I switched the parameter processing to the new technique I missed the fact that it requires specifying prefix (module name + '.') when the module is compiled directly into the kernel. Therefore in the lastest -bk you have to pass "psmouse.psmouse_noext=1" to the kernel for it to be. recognized.

Since we already have an unique prefix (psmouse) for all parameters and changing parameter names at this time is not desirable (IMHO) I propose the patch below to restore the old behavior.

Dmitry

===================================================================

[email protected], 2003-12-29 22:53:14-05:00, [email protected]
Input: Suppress prefix generation for psmouse parameter names
regardless of whether psmouse is built as a module or compiled into the kernel image

 psmouse-base.c |    9 +++++++++
 1 files changed, 9 insertions(+)

===================================================================

drivers/input/mouse/psmouse-base.c +9 -0
diff -Nru a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
@@ -22,6 +22,15 @@
 #include "synaptics.h"
 #include "logips2pp.h"
 
+/*
+ * Reset module param prefix regardless of whether we build psmouse as
+ * a module or directly into kernel, otherwise for build-in case
+ * parameters will have to be specified as psmouse.psmouse_proto which
+ * is unsightly
+ */
+#undef MODULE_PARAM_PREFIX
+#define MODULE_PARAM_PREFIX /* empty */
+
 MODULE_AUTHOR("Vojtech Pavlik <[email protected]>");
 MODULE_DESCRIPTION("PS/2 mouse driver");
 MODULE_LICENSE("GPL");