aoe: add documentation for udev users
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 7 lines · Ed L Cashin
(quoted diff) +7
-0+if test -z "$conf"; then + conf="`find /etc -type f -name udev.conf 2> /dev/null`" +fi +if test -z "$conf" || test ! -r $conf; then + echo "$me Error: could not find readable udev.conf in /etc" 1>&2 + exit 1 +fi
This will fail and print
---
bash: test: etc/udev.conf: binary operator expected
---
if there is more than one udev.conf.
Fix: Always put quotes around variables.
Quoted 16 lines · Bodo Eggert
Review
Quoted 7 lines · Ed L Cashin
(quoted diff) +7
-0+if test -z "$conf"; then + conf="`find /etc -type f -name udev.conf 2> /dev/null`" +fi +if test -z "$conf" || test ! -r $conf; then + echo "$me Error: could not find readable udev.conf in /etc" 1>&2 + exit 1 +fiThis will fail and print
---
bash: test:etc/udev.conf: binary operator expected
---
if there is more than one udev.conf.
Quoted 1 line
Fix: Always put quotes around variables.
Thanks. With the changes below, it still will complain if it finds more than one udev.conf, but only if /etc/udev/udev.conf doesn't exist.
Quote all shell variables, and use /etc/udev/udev.conf if available.
Documentation/aoe/udev-install.sh +9 -5
@@ -8,11 +8,15 @@ me="`basename $0`" # (or environment can specify where to find udev.conf) # if test -z "$conf"; then - conf="`find /etc -type f -name udev.conf 2> /dev/null`" -fi -if test -z "$conf" || test ! -r $conf; then - echo "$me Error: could not find readable udev.conf in /etc" 1>&2 - exit 1 + if test -r /etc/udev/udev.conf; then + conf=/etc/udev/udev.conf + else + conf="`find /etc -type f -name udev.conf 2> /dev/null`" + if test -z "$conf" || test ! -r "$conf"; then + echo "$me Error: no udev.conf found" 1>&2 + exit 1 + fi + fi fi # find the directory where udev rules are stored, often
Signature · 2 lines
-- Ed L Cashin <[email protected]>
Greg KH
AppliedQuoted 20 lines · Ed L Cashin
Quoted 16 lines · Bodo Eggert
Review
Quoted 7 lines · Ed L Cashin
(quoted diff) +7
-0+if?test?-z?"$conf";?then +????????conf="`find?/etc?-type?f?-name?udev.conf?2>?/dev/null`" +fi +if?test?-z?"$conf"?||?test?!?-r?$conf;?then +????????echo?"$me?Error:?could?not?find?readable?udev.conf?in?/etc"?1>&2 +????????exit?1 +fiThis will fail and print
---
bash: test:etc/udev.conf: binary operator expected
---
if there is more than one udev.conf.Quoted 1 line
Fix: Always put quotes around variables.
Quoted 8 lines
Thanks. With the changes below, it still will complain if it finds more than one udev.conf, but only if
/etc/udev/udev.confdoesn't exist.Quote all shell variables, and use
/etc/udev/udev.confif available.Signed-off-by Ed L. Cashin <[email protected]>
Applied, thanks.
greg k-h