Skip to contentSkip to conversation

megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

PATCH Bodo Eggert 1 participant 1 message Mar 9, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Sreenivas
Quoted 6 lines
Quoted 2 lines

. And since this is compile time
system-wide property, I kept it as driver global.

that step I don't understand... why is it a global *VARIABLE* if it's compile time system-wide property...

I see your point! Are you saying I should use if(sizeof(dma_addr_t)==8) instead of the shortcut if(is_dma64)? Are you thinking of "const" modifier? Please advice.

If using a static const variable produces about the same code a macro does, the variable is OK. Otherwise you'll have to use a #define in order to avoid including dead code.