Skip to contentSkip to conversation

two probable security holes

DISCUSSION Sam Varshavchik 1 participant 1 message Sep 25, 2001 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 34 lines · David S. Miller

From: Ken Ashcraft <[email protected]>
Date: Tue, 18 Sep 2001 14:29:57 -0700 (PDT)

Watch ifr.ifr_name.

Hi Ken, I believe there is some bug in your new checker algorithms for this case.

                   struct ifreq ifr;
                   int err;
   Start--->
                   if (copy_from_user(&ifr, (void *)arg, sizeof(ifr)))
                           return -EFAULT;
                   ifr.ifr_name[IFNAMSIZ-1] = '\0'; 

ifreq copied safely to kernel space, ifr.ifr_name[] is inside the struct and NOT a user pointer.

                   err = tun_set_iff(file, &ifr); 

Pass address of kernel ifreq.

                   if (*ifr->ifr_name)
                           name = ifr->ifr_name;
   
                   if ((err = dev_alloc_name(&tun->dev, name)) < 0)
                           goto failed; 

Perfectly fine still, name always points to kernel memory.

int dev_alloc_name(struct net_device *dev, const char *name) {
...

Quoted 5 lines
           for (i = 0; i < 100; i++) {

Error--->
sprintf(buf,name,i);

Still fine, as stated "name" is pointing to kernel memory.

Ummm... Is it possible for name to be, oh, something like

"foo%s%s%s%s%s"?

In that case, what would that sprintf do?

Quoted 2 lines

Perhaps your code is being confused by "ifreq->if_name" being an array.

Signature · 1 line
Sam