MIPS: Add basic support for ptrace single step
Subsystems (2)
PATCH RESEND v2 1/1 MIPS: Add basic support for ptrace single step
From: Tiezhu Yang <[email protected]>
In the current code, arch_has_single_step() is not defined on MIPS, that means MIPS does not support instruction single-step for user mode.
Delve is a debugger for the Go programming language, the ptrace syscall PtraceSingleStep() failed [1] on MIPS and then the single step function can not work well, we can see that PtraceSingleStep() definition returns ptrace(PTRACE_SINGLESTEP) [2].
So it is necessary to support ptrace single step on MIPS.
At the beginning, we try to use the Debug Single Step exception on the Loongson 3A4000 platform, but it has no effect when set CP0_DEBUG SSt bit, this is because CP0_DEBUG NoSSt bit is 1 which indicates no single-step feature available [3], so this way which is dependent on the hardware is almost impossible.
With further research, we find out there exists a common way used with break instruction in arch/alpha/kernel/ptrace.c, it is workable.
For the above analysis, define arch_has_single_step(), add the common function user_enable_single_step() and user_disable_single_step(), set flag TIF_SINGLESTEP for child process, use break instruction to set breakpoint.
We can use the following testcase to test it:tools/testing/selftests/breakpoints/step_after_suspend_test.c
$ make -C tools/testing/selftests TARGETS=breakpoints $ cd tools/testing/selftests/breakpoints
Without this patch:
$ ./step_after_suspend_test -n TAP version 13 1..4 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 1 # SKIP CPU 0 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 2 # SKIP CPU 1 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 3 # SKIP CPU 2 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 4 # SKIP CPU 3 # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:4 error:0
With this patch:
$ ./step_after_suspend_test -n TAP version 13 1..4 ok 1 CPU 0 ok 2 CPU 1 ok 3 CPU 2 ok 4 CPU 3 # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
[1] https://github.com/go-delve/delve/blob/master/pkg/proc/native/threads_linux.go#L50
[2] https://github.com/go-delve/delve/blob/master/vendor/golang.org/x/sys/unix/syscall_linux.go#L1573
[3] http://www.t-es-t.hu/download/mips/md00047f.pdf
---
RESEND due to send to mail list failed, sorry for that.
v2: make union mips_instruction mips_insn = { 0 };
to fix uninitialized build warning used with clang reported by kernel test robot.
arch/mips/include/asm/ptrace.h | 2 + arch/mips/include/asm/thread_info.h | 5 ++ arch/mips/kernel/ptrace.c | 108 ++++++++++++++++++++++++++++++++++++ arch/mips/kernel/signal.c | 2 +- 4 files changed, 116 insertions(+), 1 deletion(-)
arch/mips/include/asm/ptrace.h +2 -0
@@ -186,4 +186,6 @@ static inline void user_stack_pointer_set(struct pt_regs *regs, regs->regs[29] = val; } +#define arch_has_single_step () (1) +#endif /* _ASM_PTRACE_H */
arch/mips/include/asm/thread_info.h +5 -0
@@ -35,6 +35,10 @@ struct thread_info {*/ struct pt_regs *regs;long syscall;/* syscall number */ + +int bpt_nsaved; +unsigned long bpt_addr[1 ];/* breakpoint handling */ +unsigned int bpt_insn[1 ]; };/*
@@ -117,6 +121,7 @@ static inline struct thread_info *current_thread_info(void)#define TIF_UPROBE 6/* breakpointed or singlestepping */ #define TIF_NOTIFY_SIGNAL 7/* signal notifications exist */ #define TIF_RESTORE_SIGMASK 9/* restore signal mask in do_signal() */ +#define TIF_SINGLESTEP 10/* restore singlestep on return to user mode */ #define TIF_USEDFPU 16/* FPU was used by this task this quantum (SMP) */ #define TIF_MEMDIE 18/* is terminating due to OOM killer */ #define TIF_NOHZ 19/* in adaptive nohz mode */
arch/mips/kernel/ptrace.c +108 -0
130 lines not on this page · raw message
arch/mips/kernel/signal.c +1 -1
@@ -849,7 +849,7 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs) ret = abi->setup_frame (vdso + abi->vdso->off_sigreturn, ksig, regs, oldset); -signal_setup_done (ret, ksig,0 ); +signal_setup_done (ret, ksig,test_thread_flag (TIF_SINGLESTEP )); }static void do_signal (struct pt_regs *regs)
Signature · 1 line
1.8.3.1
Quoted 74 lines · Tiezhu Yang
From: Tiezhu Yang <[email protected]>
In the current code,
arch_has_single_step()is not defined on MIPS, that means MIPS does not support instruction single-step for user mode.Delve is a debugger for the Go programming language, the ptrace syscall
PtraceSingleStep()failed [1] on MIPS and then the single step function can not work well, we can see thatPtraceSingleStep()definition returnsptrace(PTRACE_SINGLESTEP)[2].So it is necessary to support ptrace single step on MIPS.
At the beginning, we try to use the Debug Single Step exception on the Loongson 3A4000 platform, but it has no effect when set
CP0_DEBUGSSt bit, this is becauseCP0_DEBUGNoSSt bit is 1 which indicates no single-step feature available [3], so this way which is dependent on the hardware is almost impossible.With further research, we find out there exists a common way used with break instruction in
arch/alpha/kernel/ptrace.c, it is workable.For the above analysis, define
arch_has_single_step(), add the common functionuser_enable_single_step()anduser_disable_single_step(), set flagTIF_SINGLESTEPfor child process, use break instruction to set breakpoint.We can use the following testcase to test it:
tools/testing/selftests/breakpoints/step_after_suspend_test.c$ make -C tools/testing/selftests TARGETS=breakpoints $ cd tools/testing/selftests/breakpointsWithout this patch:
$ ./step_after_suspend_test -n TAP version 13 1..4 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 1 # SKIP CPU 0 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 2 # SKIP CPU 1 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 3 # SKIP CPU 2 # ptrace(PTRACE_SINGLESTEP) not supported on this architecture: Input/output error ok 4 # SKIP CPU 3 # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:4 error:0With this patch:
$ ./step_after_suspend_test -n TAP version 13 1..4 ok 1 CPU 0 ok 2 CPU 1 ok 3 CPU 2 ok 4 CPU 3 # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0[1] https://github.com/go-delve/delve/blob/master/pkg/proc/native/threads_linux.go#L50
[2] https://github.com/go-delve/delve/blob/master/vendor/golang.org/x/sys/unix/syscall_linux.go#L1573
[3] http://www.t-es-t.hu/download/mips/md00047f.pdfReported-by Guoqi Chen <[email protected]>Signed-off-by Xingxing Su <[email protected]>Signed-off-by Tiezhu Yang <[email protected]>Reported-by kernel test robot <[email protected]>---
RESEND due to send to mail list failed, sorry for that.
v2: make union
mips_instructionmips_insn= { 0 };
to fix uninitialized build warning used with clang reported by kernel test robot.
Quoted 5 lines
arch/mips/include/asm/ptrace.h | 2 + arch/mips/include/asm/thread_info.h | 5 ++ arch/mips/kernel/ptrace.c | 108 ++++++++++++++++++++++++++++++++++++ arch/mips/kernel/signal.c | 2 +- 4 files changed, 116 insertions(+), 1 deletion(-)
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]