Skip to contentSkip to conversation

KVM: s390: add function process_gib_alert_list()

PATCH Michael Mueller 1 participant 1 message Nov 6, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Pierre Morel
Quoted 10 lines
Quoted 9 lines
Quoted 4 lines

+������� /* wake-up a vcpu of the kvm this gisa belongs to */ +������� kvm = container_of(gisa, struct sie_page2, gisa)->kvm; +������� __floating_irq_kick(kvm, KVM_S390_INT_IO(1, 0, 0, 0));

Do we really need to insert a floating interrupt? Wouldn't a simple kvm_s390_vcpu_wakeup() after choosing the vcpu be enough?

Quoted 5 lines
Quoted 2 lines

We need to find a suitable vcpu before calling kvm_s390_vcpu_wakeup(). That is exactly what __floating_irq_kick() does for us, right?

Yes right, it is just an optimization, we have two unnecessary tests, one for interrupt type and another for GISA availability.

I will factor out a function __find_vcpu_for_irq()

Quoted 9 lines
Quoted 9 lines

It is *not* inserting a floating interruption.

Quoted 5 lines
Quoted 5 lines

+��� }
+
+��� if (gisa_to_nullify)
+������� nullify_gisa(gisa_to_nullify);