Skip to contentSkip to conversation

kbuild: check the minimum compiler version in Kconfig

DISCUSSION Florian Fainelli 3 participants 7 messages Nov 16, 2022

lore
Share & tools
lore
#0 lore raw

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2 -I/local/users/fainelli/buildroot-llvm/output/arm64/host/include -DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib -Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib" ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

  UPD     scripts/kconfig/mconf-cfg
  HOSTCC  scripts/kconfig/mconf.o
  HOSTCC  scripts/kconfig/lxdialog/checklist.o
  HOSTCC  scripts/kconfig/lxdialog/inputbox.o
  HOSTCC  scripts/kconfig/lxdialog/menubox.o
  HOSTCC  scripts/kconfig/lxdialog/textbox.o
  HOSTCC  scripts/kconfig/lxdialog/util.o
  HOSTCC  scripts/kconfig/lxdialog/yesno.o
  HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

It is not clear to me how to best address that, short of not specifying LLVM=1 on the kernel *config targets, but IMHO there is still an actual issue where we do not check the compiler that we would want to check.

Thanks!

Signature · 1 line
Florian
#1 lore raw
Quoted 39 lines · Florian Fainelli

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2

(quoted diff) +0 -3
-I/local/users/fainelli/buildroot-llvm/output/arm64/host/include
-DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib
-Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib"

ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

   UPD     scripts/kconfig/mconf-cfg
   HOSTCC  scripts/kconfig/mconf.o
   HOSTCC  scripts/kconfig/lxdialog/checklist.o
   HOSTCC  scripts/kconfig/lxdialog/inputbox.o
   HOSTCC  scripts/kconfig/lxdialog/menubox.o
   HOSTCC  scripts/kconfig/lxdialog/textbox.o
   HOSTCC  scripts/kconfig/lxdialog/util.o
   HOSTCC  scripts/kconfig/lxdialog/yesno.o
   HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Quoted 3 lines

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

LLVM=1 will use clang as found by your $PATH. Where did you express to make what the "cross compiler clang version" is? (And why do you set HOSTCC three times)

Quoted 8 lines

It is not clear to me how to best address that, short of not specifying LLVM=1 on the kernel *config targets, but IMHO there is still an actual issue where we do not check the compiler that we would want to check.

Thanks!
--
Florian

Signature · 2 lines
Thanks,
~Nick Desaulniers
#2 lore raw
Quoted 40 lines · Nick Desaulniers
Quoted 39 lines · Florian Fainelli

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2

(quoted diff) +0 -3
-I/local/users/fainelli/buildroot-llvm/output/arm64/host/include
-DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib
-Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib"

ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

    UPD     scripts/kconfig/mconf-cfg
    HOSTCC  scripts/kconfig/mconf.o
    HOSTCC  scripts/kconfig/lxdialog/checklist.o
    HOSTCC  scripts/kconfig/lxdialog/inputbox.o
    HOSTCC  scripts/kconfig/lxdialog/menubox.o
    HOSTCC  scripts/kconfig/lxdialog/textbox.o
    HOSTCC  scripts/kconfig/lxdialog/util.o
    HOSTCC  scripts/kconfig/lxdialog/yesno.o
    HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Quoted 7 lines
Quoted 3 lines

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

LLVM=1 will use clang as found by your $PATH. Where did you express to make what the "cross compiler clang version" is? (And why do you set HOSTCC three times)

We are setting CROSS_COMPILE to express the cross compiler clang prefix to use.

Setting HOSTCC three times is done by buildroot, it does it through make flags, and then variables passed to make etc. clearly we could change that, but that's out of scope is not it?

Signature · 1 line
Florian
#3 lore raw
Quoted 50 lines · Florian Fainelli
Quoted 40 lines · Nick Desaulniers
Quoted 39 lines · Florian Fainelli

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2

(quoted diff) +0 -3
-I/local/users/fainelli/buildroot-llvm/output/arm64/host/include
-DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib
-Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib"

ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

    UPD     scripts/kconfig/mconf-cfg
    HOSTCC  scripts/kconfig/mconf.o
    HOSTCC  scripts/kconfig/lxdialog/checklist.o
    HOSTCC  scripts/kconfig/lxdialog/inputbox.o
    HOSTCC  scripts/kconfig/lxdialog/menubox.o
    HOSTCC  scripts/kconfig/lxdialog/textbox.o
    HOSTCC  scripts/kconfig/lxdialog/util.o
    HOSTCC  scripts/kconfig/lxdialog/yesno.o
    HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Quoted 7 lines
Quoted 3 lines

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

LLVM=1 will use clang as found by your $PATH. Where did you express to make what the "cross compiler clang version" is? (And why do you set HOSTCC three times)

Quoted 2 lines

We are setting CROSS_COMPILE to express the cross compiler clang prefix to use.

Can you try setting CLANG_PREFIX rather than CROSS_COMPILE (to the same value)?

CLANG_PREFIX=/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-

Quoted 7 lines

Setting HOSTCC three times is done by buildroot, it does it through make flags, and then variables passed to make etc. clearly we could change that, but that's out of scope is not it?
--
Florian

--
Thanks,
~Nick Desaulniers

#4 lore raw
Quoted 52 lines · Nick Desaulniers
Quoted 50 lines · Florian Fainelli
Quoted 47 lines · Nick Desaulniers
Quoted 39 lines · Florian Fainelli

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2

(quoted diff) +0 -3
-I/local/users/fainelli/buildroot-llvm/output/arm64/host/include
-DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib
-Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib"

ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

    UPD     scripts/kconfig/mconf-cfg
    HOSTCC  scripts/kconfig/mconf.o
    HOSTCC  scripts/kconfig/lxdialog/checklist.o
    HOSTCC  scripts/kconfig/lxdialog/inputbox.o
    HOSTCC  scripts/kconfig/lxdialog/menubox.o
    HOSTCC  scripts/kconfig/lxdialog/textbox.o
    HOSTCC  scripts/kconfig/lxdialog/util.o
    HOSTCC  scripts/kconfig/lxdialog/yesno.o
    HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Quoted 3 lines

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

LLVM=1 will use clang as found by your $PATH. Where did you express to make what the "cross compiler clang version" is? (And why do you set HOSTCC three times)

Quoted 6 lines
Quoted 2 lines

We are setting CROSS_COMPILE to express the cross compiler clang prefix to use.

Can you try setting CLANG_PREFIX rather than CROSS_COMPILE (to the same value)?

CLANG_PREFIX=/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-

sorry, I meant LLVM_PREFIX

Quoted 14 lines
Quoted 9 lines

Setting HOSTCC three times is done by buildroot, it does it through make flags, and then variables passed to make etc. clearly we could change that, but that's out of scope is not it?
--
Florian

--
Thanks,
~Nick Desaulniers

Signature · 2 lines
Thanks,
~Nick Desaulniers
#5 lore raw
Quoted 54 lines · Nick Desaulniers
Quoted 52 lines · Nick Desaulniers
Quoted 50 lines · Florian Fainelli
Quoted 47 lines · Nick Desaulniers
Quoted 39 lines · Florian Fainelli

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2

(quoted diff) +0 -3
-I/local/users/fainelli/buildroot-llvm/output/arm64/host/include
-DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib
-Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib"

ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

     UPD     scripts/kconfig/mconf-cfg
     HOSTCC  scripts/kconfig/mconf.o
     HOSTCC  scripts/kconfig/lxdialog/checklist.o
     HOSTCC  scripts/kconfig/lxdialog/inputbox.o
     HOSTCC  scripts/kconfig/lxdialog/menubox.o
     HOSTCC  scripts/kconfig/lxdialog/textbox.o
     HOSTCC  scripts/kconfig/lxdialog/util.o
     HOSTCC  scripts/kconfig/lxdialog/yesno.o
     HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Quoted 3 lines

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

LLVM=1 will use clang as found by your $PATH. Where did you express to make what the "cross compiler clang version" is? (And why do you set HOSTCC three times)

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

We are setting CROSS_COMPILE to express the cross compiler clang prefix to use.

Can you try setting CLANG_PREFIX rather than CROSS_COMPILE (to the same value)?

CLANG_PREFIX=/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-

sorry, I meant LLVM_PREFIX

Same results unfortunately.

Signature · 1 line
Florian
#6 lore raw
Quoted 58 lines · Florian Fainelli
Quoted 57 lines · Nick Desaulniers
Quoted 55 lines · Nick Desaulniers
Quoted 52 lines · Florian Fainelli
Quoted 40 lines · Nick Desaulniers
Quoted 39 lines · Florian Fainelli

Hi Masahiro, Nick,

The compiler version check performed with aec6c60a01d3a3170242d6a99372a388e1136dc6 ("kbuild: check the minimum compiler version in Kconfig") can be defeated and prevent running the *config targets if specifying LLVM=1 on the command line, in that way:

BR_BINARIES_DIR=/local/users/fainelli/buildroot-llvm/output/arm64/images LLVM=1 LLVM_IAS=1 PKG_CONFIG_PATH="" /usr/bin/make -j49 -C /local/users/fainelli/buildroot-llvm/output/arm64/build/linux-custom HOSTCC="/usr/bin/gcc" HOSTCC="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/ccache /usr/bin/gcc -O2

(quoted diff) +0 -3
-I/local/users/fainelli/buildroot-llvm/output/arm64/host/include
-DNDEBUG -L/local/users/fainelli/buildroot-llvm/output/arm64/host/lib
-Wl,-rpath,/local/users/fainelli/buildroot-llvm/output/arm64/host/lib"

ARCH=arm64 INSTALL_MOD_PATH=/local/users/fainelli/buildroot-llvm/output/arm64/target CROSS_COMPILE="/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-" WERROR=0 DEPMOD=/local/users/fainelli/buildroot-llvm/output/arm64/host/sbin/depmod INSTALL_MOD_STRIP=1 HOSTCC="/usr/bin/gcc" menuconfig

     UPD     scripts/kconfig/mconf-cfg
     HOSTCC  scripts/kconfig/mconf.o
     HOSTCC  scripts/kconfig/lxdialog/checklist.o
     HOSTCC  scripts/kconfig/lxdialog/inputbox.o
     HOSTCC  scripts/kconfig/lxdialog/menubox.o
     HOSTCC  scripts/kconfig/lxdialog/textbox.o
     HOSTCC  scripts/kconfig/lxdialog/util.o
     HOSTCC  scripts/kconfig/lxdialog/yesno.o
     HOSTLD  scripts/kconfig/mconf

***
*** Compiler is too old.
*** Your Clang version: 10.0.0
*** Minimum Clang version: 10.0.1
***
scripts/Kconfig.include:44: Sorry, this compiler is not supported.

Quoted 7 lines
Quoted 3 lines

Here, the compiler check is actually checking the host compiler clang version installed on my Ubuntu 20.04 system, as opposed to the cross compiler clang version that is being used.

LLVM=1 will use clang as found by your $PATH. Where did you express to make what the "cross compiler clang version" is? (And why do you set HOSTCC three times)

We are setting CROSS_COMPILE to express the cross compiler clang prefix to use.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Can you try setting CLANG_PREFIX rather than CROSS_COMPILE (to the same value)?

CLANG_PREFIX=/local/users/fainelli/buildroot-llvm/output/arm64/host/bin/aarch64-linux-

sorry, I meant LLVM_PREFIX

Same results unfortunately.

What kernel version is this?

If you are not using PATH to control which binaries are being used, you can use

    $ make LLVM=.../

to use .../clang, .../ld.lld, etc (the trailing slash is critical for this), which will behave similar to CROSS_COMPILE for GCC. When building with LLVM, CROSS_COMPILE only controls the target triple and it is unnecessary when using all LLVM tools. That LLVM behavior is relatively new, see commit e9c281928c24 ("kbuild: Make $(LLVM) more flexible").

Cheers,
Nathan