mmc-utils: Add softreset command for issuing CMD0
PATCH 1/1 mmc-utils: Add softreset command for issuing CMD0
CMD0 may be used to see if the hardware can handle a UHS card that completed the voltage switch. If a UHS card has problems coming back up after CMD0 your hardware may not support a hard reset properly.
--- mmc.c | 5 +++++ mmc.h | 3 +++ mmc_cmds.c | 30 ++++++++++++++++++++++++++++++ mmc_cmds.h | 1 + 4 files changed, 39 insertions(+)
mmc.c +5 -0
@@ -245,6 +245,11 @@ static struct Command commands[] = { "be 1.", NULL }, + { do_soft_reset,-1 , +"softreset" ,"<device>\n" +"Issues a CMD0 softreset, e.g. for testing if hardware reset for UHS works\n\n" , +NULL + }, { 0, 0, 0, 0 } };
mmc.h +3 -0
@@ -21,6 +21,7 @@#include <linux/mmc/ioctl.h> /* From kernel linux/mmc/mmc.h */ +#define MMC_GO_IDLE_STATE 0/* bc */ #define MMC_SWITCH 6/* ac [31:0] See below R1b */ #define MMC_SEND_EXT_CSD 8/* adtc R1 */ #define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */
@@ -226,6 +227,7 @@/* From kernel linux/mmc/core.h */ +#define MMC_RSP_NONE 0/* no response */ #define MMC_RSP_PRESENT (1 << 0)#define MMC_RSP_136 (1 << 1)/* 136 bit response */ #define MMC_RSP_CRC (1 << 2)/* expect valid crc */
@@ -234,6 +236,7 @@#define MMC_CMD_AC (0 << 5)#define MMC_CMD_ADTC (1 << 5) +#define MMC_CMD_BC (2 << 5)#define MMC_RSP_SPI_S1 (1 << 7)/* one status byte */ #define MMC_RSP_SPI_BUSY (1 << 10)/* card may send busy */
mmc_cmds.c +30 -0
@@ -3039,3 +3039,33 @@ out:close (dev_fd);return ret; } + +int do_soft_reset (int nargs,char **argv) +{ +int fd; +char *device; +struct mmc_ioc_cmd idata; + +if (nargs !=2 ) { +fprintf (stderr,"Usage: mmc status softreset </path/to/mmcblkX>\n" ); +exit (1 ); + } + + device = argv[1 ]; + + fd =open (device,O_RDWR ); +if (fd <0 ) { +perror ("open" ); +exit (1 ); + } + +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_GO_IDLE_STATE ; + idata.flags =MMC_RSP_NONE |MMC_CMD_BC ; + +/* No need to check for error, it is expected */ +ioctl (fd,MMC_IOC_CMD , &idata); +close (fd); + +return 0 ; +}
mmc_cmds.h +1 -0
@@ -47,3 +47,4 @@ int do_read_cid(int argc, char **argv);int do_read_csd (int argc,char **argv);int do_erase (int nargs,char **argv);int do_general_cmd_read (int nargs,char **argv); +int do_soft_reset (int nargs,char **argv);
Signature · 5 lines
2.36.1 Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782
Hi,
Quoted 5 lines
CMD0 may be used to see if the hardware can handle a UHS card that completed the voltage switch. If a UHS card has problems coming back up after CMD0 your hardware may not support a hard reset properly.
I think it's a useful addition, not just for that reason.
Specifically to test hw-reset support, I think you should use the GO_PRE_IDLE_STATE option.
Quoted 76 lines
Signed-off-by Christian Loehle <[email protected]>--- mmc.c | 5 +++++ mmc.h | 3 +++ mmc_cmds.c | 30 ++++++++++++++++++++++++++++++ mmc_cmds.h | 1 + 4 files changed, 39 insertions(+)mmc.c +5
-0@@ -245,6 +245,11 @@ static struct Command commands[] = { "be 1.", NULL }, + { do_soft_reset,-1 , +"softreset" ,"<device>\n" +"Issues a CMD0 softreset, e.g. for testing if hardware reset for UHS works\n\n", +NULL + }, { 0, 0, 0, 0 } };mmc.h +3
-0@@ -21,6 +21,7 @@#include <linux/mmc/ioctl.h> /* From kernel linux/mmc/mmc.h */ +#define MMC_GO_IDLE_STATE 0/* bc */ #define MMC_SWITCH 6/* ac [31:0] See below R1b */ #define MMC_SEND_EXT_CSD 8/* adtc R1 */ #define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */ @@ -226,6 +227,7 @@/* From kernel linux/mmc/core.h */ +#define MMC_RSP_NONE 0/* no response */ #define MMC_RSP_PRESENT (1 << 0)#define MMC_RSP_136 (1 << 1)/* 136 bit response */ #define MMC_RSP_CRC (1 << 2)/* expect valid crc */ @@ -234,6 +236,7 @@#define MMC_CMD_AC (0 << 5)#define MMC_CMD_ADTC (1 << 5) +#define MMC_CMD_BC (2 << 5)#define MMC_RSP_SPI_S1 (1 << 7)/* one status byte */ #define MMC_RSP_SPI_BUSY (1 << 10)/* card may send busy */ mmc_cmds.c +9
-0@@ -3039,3 +3039,33 @@ out:close (dev_fd);return ret; } + +int do_soft_reset (int nargs,char **argv) +{ +int fd; +char *device; +struct mmc_ioc_cmd idata; + +if (nargs !=2 ) { + fprintf(stderr, "Usage: mmc status softreset</path/to/mmcblkX>\n");
mmc_cmds.c +4
-0+exit (1 ); + } + + device = argv[1 ];
mmc_cmds.c out: · line 3064
Quoted 10 lines
mmc_cmds.c +10
-0+ + fd =open (device,O_RDWR ); +if (fd <0 ) { +perror ("open" ); +exit (1 ); + } + +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_GO_IDLE_STATE ; + idata.flags =MMC_RSP_NONE |MMC_CMD_BC ;
How about adding all 3 flavors of soft-reset: GO_IDLE_STATE, GO_PRE_IDLE_STATE, and BOOT_INITIATION. There can be 3 different command, that calls the same __soft_reset helper, or whatever. What do you think?
Thanks,
Avri
Quoted 22 lines
mmc_cmds.c +7
-0+ +/* No need to check for error, it is expected */ +ioctl (fd,MMC_IOC_CMD , &idata); +close (fd); + +return 0 ; +}mmc_cmds.h +1
-1@@ -47,3 +47,4 @@ int do_read_cid(int argc, char **argv);int do_read_csd (int argc,char **argv);int do_erase (int nargs,char **argv);int do_general_cmd_read (int nargs,char **argv); +int do_soft_reset (int nargs,char **argv); --2.36.1
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782
Quoted 6 lines
Quoted 4 lines
CMD0 may be used to see if the hardware can handle a UHS card that completed the voltage switch. If a UHS card has problems coming back up after CMD0 your hardware may not support a hard reset properly.
I think it's a useful addition, not just for that reason.
Specifically to test hw-reset support, I think you should use theGO_PRE_IDLE_STATEoption.
Makes sense to add both, I can do that.
Quoted 8 lines
mmc_cmds.c out: · line 3064
Quoted 5 lines
mmc_cmds.c +4
-0+ +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_GO_IDLE_STATE ; + idata.flags =MMC_RSP_NONE |MMC_CMD_BC ;How about adding all 3 flavors of soft-reset:
GO_IDLE_STATE,GO_PRE_IDLE_STATE, andBOOT_INITIATION. There can be 3 different command, that calls the same__soft_resethelper, or whatever. What do you think?
I'm fine with GO_IDLE_STATE and GO_PRE_IDLE_STATE, but BOOT_INITATION Im not sure about, what purpose would it serve?
If the intention is to be able to get the boot operation done with multi_cmd of GO_PRE_IDLE_STATE and BOOT_INITATION and return the data then that would at least be some more testing effort before I resend. I have only done the boot operations completely in the driver so far.
Furthermore I think many (most?) host controllers (or our drivers) seem to have issues with the transfer size I'd expect of a normal boot operation (i.e 4-32MB).
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782
Quoted 15 lines
Quoted 6 lines
Quoted 4 lines
CMD0 may be used to see if the hardware can handle a UHS card that completed the voltage switch. If a UHS card has problems coming back up after CMD0 your hardware may not support a hard reset properly.
I think it's a useful addition, not just for that reason. Specifically to test hw-reset support, I think you should use the
GO_PRE_IDLE_STATEoption.Makes sense to add both, I can do that.
Quoted 5 lines
Quoted 5 lines
mmc_cmds.c +4
-0+ +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_GO_IDLE_STATE ; + idata.flags =MMC_RSP_NONE |MMC_CMD_BC ;
Quoted 8 lines
Quoted 1 line
How about adding all 3 flavors of soft-reset:
GO_IDLE_STATE,
GO_PRE_IDLE_STATE, andBOOT_INITIATION.Quoted 1 line
There can be 3 different command, that calls the same
__soft_resethelper,or whatever.
Quoted 1 line
What do you think?
I'm fine with
GO_IDLE_STATEandGO_PRE_IDLE_STATE, butBOOT_INITATIONIm not sure about, what purpose would it serve?
We can move with these 2 to start with.
Quoted 7 lines
If the intention is to be able to get the boot operation done with
multi_cmdofGO_PRE_IDLE_STATEandBOOT_INITATIONand return the data then that would at least be some more testing effort before I resend.
I have only done the boot operations completely in the driver so far. Furthermore I think many (most?) host controllers (or our drivers) seem to have issues with the transfer size I'd expect of a normal boot operation (i.e 4- 32MB).
You can add it later (or not) when you find the time.
Thanks,
Avri
Quoted 4 lines
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director:
Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782