nfstest_posix failed with 6.7 kernel (resend)
Subsystems (3)
[email protected]
reviewer(resend with correct Jorge Mora address)
The 'open' tests of nfstest_posix failed with 6.7 kernel with these errors:
FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
The problem can be reproduced with both client and server running 6.7 kernel.
Bisecting points to commit 43b450632676:43b450632676: open: return EINVAL for O_DIRECTORY | O_CREAT
This commit was introduced in 6.4-rc1 and back ported to LTS kernels. I'm not sure if the fix for this should be in the fs or in nfstest_posix. The commit 43b450632676 makes sense to me. No one should expect open(2) to create the directory so the error returned should be EINVAL instead of EEXIST as nfstest_posix expects.
-Dai
Quoted 6 lines · On Mon, Jan 15, 2024 at 01:05:37PM -0800, [email protected] wrote:
(resend with correct Jorge Mora address)
The 'open' tests of
nfstest_posixfailed with 6.7 kernel with these errors:FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
it might be helpful if you either included a source code snippet of "nfstest_posix" or a link to where we can see what it's doing. or an strace of the failing call.
[email protected]
reviewerQuoted 11 lines · Matthew Wilcox
Quoted 6 lines · On Mon, Jan 15, 2024 at 01:05:37PM -0800, [email protected] wrote:
(resend with correct Jorge Mora address)
The 'open' tests of
nfstest_posixfailed with 6.7 kernel with these errors:FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)it might be helpful if you either included a source code snippet of "
nfstest_posix" or a link to where we can see what it's doing. or an strace of the failing call.
This is the link to source code of nfstest:
http://wiki.linux-nfs.org/wiki/index.php/NFStest#Download To reproduce the problem run the test as follow: nfstest_posix --server /nfs_server/ --export=//home/nfs_share/ --notty --createlog --nfsversion=4.1 --tmpdir=/var/tmp/nfstestlogs --verbose all --runtest open -Dai
Christian Brauner
maintainerQuoted 10 lines · On Mon, Jan 15, 2024 at 01:05:37PM -0800, [email protected] wrote:
(resend with correct Jorge Mora address)
The 'open' tests of
nfstest_posixfailed with 6.7 kernel with these errors:FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)The problem can be reproduced with both client and server running 6.7 kernel.
Quoted 8 lines
Bisecting points to commit
43b450632676:43b450632676: open: return EINVAL forO_DIRECTORY|O_CREATThis commit was introduced in 6.4-rc1 and back ported to LTS kernels. I'm not sure if the fix for this should be in the fs or in
nfstest_posix. The commit43b450632676makes sense to me. No one should expect open(2) to create the directory so the error returned should be EINVAL instead of EEXIST asnfstest_posixexpects.
Please change the test. The EINVAL fix for open is a really important fix to the general vfs api.
Christian
[email protected]
reviewerQuoted 14 lines · Christian Brauner
Quoted 13 lines · On Mon, Jan 15, 2024 at 01:05:37PM -0800, [email protected] wrote:
(resend with correct Jorge Mora address)
The 'open' tests of
nfstest_posixfailed with 6.7 kernel with these errors:FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)The problem can be reproduced with both client and server running 6.7 kernel.
Bisecting points to commit
43b450632676:43b450632676: open: return EINVAL forO_DIRECTORY|O_CREAT
Quoted 7 lines
Quoted 5 lines
This commit was introduced in 6.4-rc1 and back ported to LTS kernels. I'm not sure if the fix for this should be in the fs or in
nfstest_posix. The commit43b450632676makes sense to me. No one should expect open(2) to create the directory so the error returned should be EINVAL instead of EEXIST asnfstest_posixexpects.Please change the test. The EINVAL fix for open is a really important fix to the general vfs api.
Jorge, can you help fixing the nfstest_posix to work with commit 43b450632676?
Thanks,
-Dai
Quoted 2 lines
Christian