Skip to contentSkip to conversation

2 patches for dvb-apps gnutv

PATCH In review Andrea 2 participants 3 messages Jul 16, 2008 – Jul 19, 2008 Media (V4L/DVB)

lore
Share & tools
lore

Andrea

author
#0 lore raw

PATCH 1/1 2 patches for dvb-apps gnutv

Hi,

I would like to repost 2 patches for gnutv, part of dvb-apps.

http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html

They both try to make gnutv more robust when the system/destination file system are temporary slow.

1) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027176.html
Once the dvb ringbuffer overflows, it is pointless to stop gnutv. I think it should continue and get the rest of the signal.
What has been lost has been lost, let's not loose the future stream

2) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html
Allow to set a bigger (than default = 2MB) dvb ringbuffer to cope with temporary bottlenecks.

Is anybody interested in reviewing them?

Andrea

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#1 lore raw

Am Mittwoch 16 Juli 2008 22:28:33 schrieb Andrea:

Quoted 14 lines

Hi,

I would like to repost 2 patches for gnutv, part of dvb-apps.

http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html

They both try to make gnutv more robust when the system/destination file system are temporary slow.

1) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027176.html
Once the dvb ringbuffer overflows, it is pointless to stop gnutv. I think it should continue and get the rest of the signal.
What has been lost has been lost, let's not loose the future stream

Quoted 5 lines

2) http://www.linuxtv.org/pipermail/linux-dvb/2008-July/027177.html
Allow to set a bigger (than default = 2MB) dvb ringbuffer to cope with temporary bottlenecks.

Is anybody interested in reviewing them?

Guess no.

But I'll rework the first patch a bit (the sequence of revents <--> errno check is already bogus) and commit them. And I really suggest you to use an application like dvbstream which does its own buffering (at least I hope so ;) - because it has never happened to me yet that the ringbuffer overflowed (and it shouldn't with sane applications).

Quoted 1 line

Andrea

Christoph

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

author
#2 lore raw
Quoted 6 lines · Christoph Pfister

Am Mittwoch 16 Juli 2008 22:28:33 schrieb Andrea:

But I'll rework the first patch a bit (the sequence of revents <--> errno check is already bogus) and commit them. And I really suggest you to use an application like dvbstream which does its own buffering (at least I hope so ;) - because it has never happened to me yet that the ringbuffer

I've read the code of dvbstream and it does not use an other buffer, it writes immediately to the output file, the same as gnutv.

Quoted 2 lines

overflowed (and it shouldn't with sane applications).

It can happen to me when the output file is on a NAS via wireless network. gnutv is very easy to use, lightweight, command line and saves subtitles too.

Quoted 2 lines

Christoph

Cheers

Andrea

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb