Skip to contentSkip to conversation

Checking out signed tags fails

EGIT Jonas Flodén 3 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

When trying to check-out a signed tag I get the following Error:
Unable to switch branches

Reason:
Mapping commit: refs/tags/v1.3.1.1

And in details:
Object XXX is not a commit.

The object ID shown is actually the id for the tag object and not the tagged commit.

This was tested with the latest master. It seemed commit 1f460e2 (Tests and fixes for dereferencing tags in Repository.resolve(), 2008-09-12) would fix it, but it didn't.

Thanks,

Jonas

#1 lore raw
Quoted 9 lines · Jonas Flodén

When trying to check-out a signed tag I get the following Error:
Unable to switch branches

Reason:
Mapping commit: refs/tags/v1.3.1.1

And in details:
Object XXX is not a commit.

Quoted 6 lines

The object ID shown is actually the id for the tag object and not the tagged commit.

This was tested with the latest master. It seemed commit 1f460e2 (Tests and fixes for dereferencing tags in Repository.resolve(), 2008-09-12) would fix it, but it didn't.

The fixes are only for the code path where reference expressions needs to be resolved. From what I understand, the problem you have encountered is due to resolve() falling back to using resolveSimple() which doesn't dereference any tags. Perhaps EGit could postfix ^{} or ^{commit} to the tag name before calling mapCommit(), or whatever it uses?

Signature · 1 line
Jonas Fonseca
#2 lore raw
Quoted 17 lines · Jonas Fonseca
Quoted 9 lines · Jonas Flodén

When trying to check-out a signed tag I get the following Error:
Unable to switch branches

Reason:
Mapping commit: refs/tags/v1.3.1.1

And in details:
Object XXX is not a commit.

Quoted 6 lines

The object ID shown is actually the id for the tag object and not the tagged commit.

This was tested with the latest master. It seemed commit 1f460e2 (Tests and fixes for dereferencing tags in Repository.resolve(), 2008-09-12) would fix it, but it didn't.

Quoted 6 lines

The fixes are only for the code path where reference expressions needs to be resolved. From what I understand, the problem you have encountered is due to resolve() falling back to using resolveSimple() which doesn't dereference any tags. Perhaps EGit could postfix ^{} or ^{commit} to the tag name before calling mapCommit(), or whatever it uses?

Yea, a ^{} is missing somwhere... this is now in the issue tracker. I'm behind and probably won't look at it more this week, but its probably a simple thing in the checkout UI.

Signature · 1 line
Shawn.