Skip to contentSkip to conversation

Change in openvpn[master]: GHA: Make sure renovate notifies us about AWS LC releases

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Apr 2, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1743591174000.I3434c35da75ede90a1b479b152142142ecc2fd40@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/932?usp=email

to review the following change.

Change subject: GHA: Make sure renovate notifies us about AWS LC releases
......................................................................

GHA: Make sure renovate notifies us about AWS LC releases

Change-Id I3434c35da75ede90a1b479b152142142ecc2fd40

---
M .github/workflows/build.yaml

1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/32/932/1

.github/workflows/build.yaml +1 -0
index 5e8e15d..2df495c 100644
@@ -469,6 +469,7 @@
         uses: actions/[email protected]... # v4.2.2
         with:
           path: aws-lc
+          # versioning=semver-coerced
           repository: aws/aws-lc
           ref: v1.42.0
       - uses: lukka/[email protected]... # v3.31.6

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/932?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3434c35da75ede90a1b479b152142142ecc2fd40
Gerrit-Change-Number: 932
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/932?usp=email )

Change subject: GHA: Make sure renovate notifies us about AWS LC releases
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
magic comments... has no effect on building or code

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/932?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3434c35da75ede90a1b479b152142142ecc2fd40
Gerrit-Change-Number: 932
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Wed, 02 Apr 2025 15:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 GHA: Make sure renovate notifies us about AWS LC releases

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Change-Id I3434c35da75ede90a1b479b152142142ecc2fd40

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/932
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

.github/workflows/build.yaml +1 -0
index 5e8e15d..2df495c 100644
@@ -469,6 +469,7 @@
         uses: actions/[email protected]... # v4.2.2
         with:
           path: aws-lc
+          # versioning=semver-coerced
           repository: aws/aws-lc
           ref: v1.42.0
       - uses: lukka/[email protected]... # v3.31.6
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: GHA: Make sure renovate notifies us about AWS LC releases

This only does magic comments - so there is not much to test (GHA is not upset if I push this, but besides this, I just believe it does what it's supposed to do).

Your patch has been applied to the master branch.

commit b75849ba36433331227ff66430ea06423fab8148

Author: Frank Lichtenheld
Date:   Wed Apr 2 17:36:55 2025 +0200
     GHA: Make sure renovate notifies us about AWS LC releases

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg31328.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/932?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: GHA: Make sure renovate notifies us about AWS LC releases
......................................................................

GHA: Make sure renovate notifies us about AWS LC releases

Change-Id I3434c35da75ede90a1b479b152142142ecc2fd40

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31328.html

---
M .github/workflows/build.yaml

1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/32/932/2

.github/workflows/build.yaml +1 -0
index 5e8e15d..2df495c 100644
@@ -469,6 +469,7 @@
         uses: actions/[email protected]... # v4.2.2
         with:
           path: aws-lc
+          # versioning=semver-coerced
           repository: aws/aws-lc
           ref: v1.42.0
       - uses: lukka/[email protected]... # v3.31.6

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/932?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3434c35da75ede90a1b479b152142142ecc2fd40
Gerrit-Change-Number: 932
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/932?usp=email )

Change subject: GHA: Make sure renovate notifies us about AWS LC releases
......................................................................

GHA: Make sure renovate notifies us about AWS LC releases

Change-Id I3434c35da75ede90a1b479b152142142ecc2fd40

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31328.html

---
M .github/workflows/build.yaml

1 file changed, 1 insertion(+), 0 deletions(-)
.github/workflows/build.yaml +1 -0
index 5e8e15d..2df495c 100644
@@ -469,6 +469,7 @@
         uses: actions/[email protected]... # v4.2.2
         with:
           path: aws-lc
+          # versioning=semver-coerced
           repository: aws/aws-lc
           ref: v1.42.0
       - uses: lukka/[email protected]... # v3.31.6

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/932?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3434c35da75ede90a1b479b152142142ecc2fd40
Gerrit-Change-Number: 932
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged