Skip to contentSkip to conversation

Change in openvpn[master]: Add clang-format reformat commit to .git-blame-ignore-revs

Openvpn-devel In review flichtenheld (Code Review) 2 participants 7 messages Aug 5, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1754396906000.I729ee240e107a629ada5fab6b2ed2399e864cbd0@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email

to review the following change.

Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................

Add clang-format reformat commit to .git-blame-ignore-revs

Change-Id I729ee240e107a629ada5fab6b2ed2399e864cbd0

---
M .git-blame-ignore-revs

1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1130/1

.git-blame-ignore-revs +3 -0
index 1fafaac..757d9ad 100644
@@ -48,3 +48,6 @@
 
 # Reformat for sp_after_comma=add
 e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to reexamine a change. Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email

to look at the new patch set (#2).

Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................

Add clang-format reformat commit to .git-blame-ignore-revs

Change-Id I729ee240e107a629ada5fab6b2ed2399e864cbd0

---
M .git-blame-ignore-revs

1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1130/2

.git-blame-ignore-revs +5 -0
index 1fafaac..290e4c3 100644
@@ -48,3 +48,8 @@
 
 # Reformat for sp_after_comma=add
 e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701
+# Switching to ColumnLimit 0 for clang-format
+21f7d6e1ad65b1f7db673bc98764dc7325858e0b

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newpatchset

#3 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email )

Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................

Patch Set 2: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Tue, 05 Aug 2025 15:04:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#4 lore raw

PATCH v2 1/1 Add clang-format reformat commit to .git-blame-ignore-revs

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Change-Id I729ee240e107a629ada5fab6b2ed2399e864cbd0

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1130
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

.git-blame-ignore-revs +5 -0
index 1fafaac..290e4c3 100644
@@ -48,3 +48,8 @@
 
 # Reformat for sp_after_comma=add
 e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701
+# Switching to ColumnLimit 0 for clang-format
+21f7d6e1ad65b1f7db673bc98764dc7325858e0b
#5 lore raw

[Openvpn-devel] [PATCH applied] Re: Add clang-format reformat commit to .git-blame-ignore-revs

Not much to test here, except point "git blame" at your favourite piece of source code, and see the original commits, not the "everything changed by clang-format" changes :-) - it's actually not *that* bad this time, compared to the first Great Reformat, but still, quite distracting.

Your patch has been applied to the master branch.

commit 2cc23415889f5d1b1a6d1837332e8c64eeacbb31

Author: Frank Lichtenheld
Date:   Tue Aug 5 17:04:57 2025 +0200
     Add clang-format reformat commit to .git-blame-ignore-revs

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg32528.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#6 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................

Add clang-format reformat commit to .git-blame-ignore-revs

Change-Id I729ee240e107a629ada5fab6b2ed2399e864cbd0

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32528.html

---
M .git-blame-ignore-revs

1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1130/3

.git-blame-ignore-revs +5 -0
index 1fafaac..290e4c3 100644
@@ -48,3 +48,8 @@
 
 # Reformat for sp_after_comma=add
 e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701
+# Switching to ColumnLimit 0 for clang-format
+21f7d6e1ad65b1f7db673bc98764dc7325858e0b

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#7 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email )

Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................

Add clang-format reformat commit to .git-blame-ignore-revs

Change-Id I729ee240e107a629ada5fab6b2ed2399e864cbd0

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32528.html

---
M .git-blame-ignore-revs

1 file changed, 5 insertions(+), 0 deletions(-)
.git-blame-ignore-revs +5 -0
index 1fafaac..290e4c3 100644
@@ -48,3 +48,8 @@
 
 # Reformat for sp_after_comma=add
 e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701
+# Switching to ColumnLimit 0 for clang-format
+21f7d6e1ad65b1f7db673bc98764dc7325858e0b

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged