Skip to contentSkip to conversation

Disable/Enable Flat I²C Commands

PATCH New Jens Scharsig 4 participants 13 messages Jan 29, 2009 – Jan 30, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Since CONFIG_I2C_CMD_TREE are defined, the old flat i2c commands are still present.
This patch disables the old flat command by default, if CONFIG_I2C_CMD_TREE is defined.
The new option CONFIG_I2C_CMD_FLAT makes it possible to use the flat commands in addition of tree commands.

---

README +3 -0
index 86c1304..3ad6d34 100644
@@ -1306,6 +1306,9 @@ The following options need to be configured:
 		older 'imm', 'imd', 'iprobe' etc. commands are considered
 		deprecated and may disappear in the future.
 
+		CONFIG_I2C_CMD_FLAT enable the old flat i2c commands like
+		'imm', 'imd', 'iprobe' etc. if CONFIG_I2C_CMD_TREE is defined.
+
 		CONFIG_HARD_I2C selects a hardware I2C controller.
 
 		CONFIG_SOFT_I2C configures u-boot to use a software (aka
common/cmd_i2c.c +2 -0
index 16439ac..5fec13c 100644
@@ -1324,6 +1324,7 @@ U_BOOT_CMD(
 #endif
 );
 #endif /* CONFIG_I2C_CMD_TREE */
+#if (defined(CONFIG_I2C_CMD_FLAT) || !defined(CONFIG_I2C_CMD_TREE))
 U_BOOT_CMD(
 	imd,	4,	1,	do_i2c_md,		\
 	"i2c memory display",				\
@@ -1369,6 +1370,7 @@ U_BOOT_CMD(
 	"chip address[.0, .1, .2] [# of objects]\n"
 	"    - loop, reading a set of addresses\n"
 );
+#endif /* CONFIG_I2C_CMD_FLAT/TREE */
 
 #if defined(CONFIG_CMD_SDRAM)
 U_BOOT_CMD(
#1 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Quoted 8 lines · Jens Scharsig

Since CONFIG_I2C_CMD_TREE are defined, the old flat i2c commands are still present.
This patch disables the old flat command by default, if CONFIG_I2C_CMD_TREE is defined.
The new option CONFIG_I2C_CMD_FLAT makes it possible to use the flat commands in addition of tree commands.

Controversial, maybe, but why not just get rid of the flat commands? When I introduced the tree probably a couple of years ago, we said it would deprecate the flat commands and that they'd go away in a couple of releases.
<snip>

regards,
Ben

#2 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Quoted 9 lines · Ben Warren
Quoted 8 lines · Jens Scharsig

Since CONFIG_I2C_CMD_TREE are defined, the old flat i2c commands are still present.
This patch disables the old flat command by default, if CONFIG_I2C_CMD_TREE is defined.
The new option CONFIG_I2C_CMD_FLAT makes it possible to use the flat commands in addition of tree commands.

Quoted 5 lines

Controversial, maybe, but why not just get rid of the flat commands? When I introduced the tree probably a couple of years ago, we said it would deprecate the flat commands and that they'd go away in a couple of releases.
<snip>

We discussed this a few months ago as well and came to the same conclusion as Ben.

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/47755
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/48429

Best,
Peter

#11 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

In reply to Jens Scharsig

Dear Jens Scharsig,

Quoted 6 lines · In message <[email protected]> you wrote:

Since CONFIG_I2C_CMD_TREE are defined, the old flat i2c commands are still present.
This patch disables the old flat command by default, if CONFIG_I2C_CMD_TREE is defined.
The new option CONFIG_I2C_CMD_FLAT makes it possible to use the flat commands in addition of tree commands.

I don't like that this changes the behavious of many boards without having the go form the board maintainers, actually without even noticing them in advance.

Please either add the needed CONFIG_I2C_CMD_FLAT to all affected boards so the current behaviour remains the same, or make it such that it gets activated only for new boards.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"In Christianity neither morality nor religion come into contact with
reality at any point."                          - Friedrich Nietzsche
#3 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

In reply to Ben Warren

Dear Ben Warren,

Quoted 5 lines · In message <[email protected]> you wrote:

Controversial, maybe, but why not just get rid of the flat commands? When I introduced the tree probably a couple of years ago, we said it would deprecate the flat commands and that they'd go away in a couple of releases.

We should at least announce such a feature removal, and declare a deadline in public.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A great many people think they are thinking when they are merely re-
arranging their prejudices."                          - William James
#4 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Quoted 10 lines · Wolfgang Denk

Dear Ben Warren,

Quoted 5 lines · In message <[email protected]> you wrote:

Controversial, maybe, but why not just get rid of the flat commands? When I introduced the tree probably a couple of years ago, we said it would deprecate the flat commands and that they'd go away in a couple of releases.

Quoted 8 lines

We should at least announce such a feature removal, and declare a deadline in public.

Best regards,

Wolfgang Denk

From README:

CONFIG_I2C_CMD_TREE is a recommended option that places all I2C commands under a single 'i2c' root command. The older 'imm', 'imd', 'iprobe' etc. commands are considered deprecated and may disappear in the future.

I guess this isn't explicit enough. Let's say it gets removed in the release after v2009.03.

regards,
Ben

#5 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Dear Ben Warren,

Quoted 11 lines · In message <[email protected]> you wrote:

From README:

CONFIG_I2C_CMD_TREE is a recommended option that places all I2C commands under a single 'i2c' root command. The older 'imm', 'imd', 'iprobe' etc. commands are considered deprecated and may disappear in the future.

I guess this isn't explicit enough. Let's say it gets removed in the release after v2009.03.

Indeed. We should add it to doc/feature_removal.txt and the wiki page.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe is all a spin-off of the Big Bang.
#6 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Hi Wolfgang,

Quoted 12 lines · Wolfgang Denk

Dear Ben Warren,

Quoted 9 lines · In message <[email protected]> you wrote:

From README:

CONFIG_I2C_CMD_TREE is a recommended option that places all I2C commands under a single 'i2c' root command. The older 'imm', 'imd', 'iprobe' etc. commands are considered deprecated and may disappear in the future.

Quoted 4 lines
Quoted 2 lines

I guess this isn't explicit enough. Let's say it gets removed in the release after v2009.03.

Indeed. We should add it to doc/feature_removal.txt and the wiki page.

Its actually already on the wiki page.

http://www.denx.de/wiki/U-Boot/TaskFeatureRemovalSchedule

I submitted the following patch to add it a new doc/feature-removal-schedule.txt with a similar timeframe:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/48429

It seems like it would be a good idea to add the doc/feature_removal.txt. Did the above mentioned patch slip through the cracks or do you prefer to only use the wiki for feature removals?

Best,
Peter

#10 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

In reply to Wolfgang Denk
Quoted 12 lines · Wolfgang Denk

Dear Ben Warren,

Quoted 8 lines · In message <[email protected]> you wrote:

From README:

CONFIG_I2C_CMD_TREE is a recommended option that places all I2C commands under a single 'i2c' root command. The older 'imm', 'imd', 'iprobe' etc. commands are considered deprecated and may disappear in the future.

Quoted 7 lines
Quoted 3 lines

I guess this isn't explicit enough. Let's say it gets removed in the release after v2009.03.

Indeed. We should add it to doc/feature_removal.txt and the wiki page.

OK. I'l make it so.

Quoted 5 lines

Best regards,

Wolfgang Denk

#7 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

In reply to Peter Tyser
Quoted 26 lines · Peter Tyser

Hi Wolfgang,

Quoted 12 lines · Wolfgang Denk

Dear Ben Warren,

Quoted 8 lines · In message <[email protected]> you wrote:

From README:

CONFIG_I2C_CMD_TREE is a recommended option that places all I2C commands under a single 'i2c' root command. The older 'imm', 'imd', 'iprobe' etc. commands are considered deprecated and may disappear in the future.

Quoted 5 lines
Quoted 3 lines

I guess this isn't explicit enough. Let's say it gets removed in the release after v2009.03.

Indeed. We should add it to doc/feature_removal.txt and the wiki page.

Its actually already on the wiki page.

http://www.denx.de/wiki/U-Boot/TaskFeatureRemovalSchedule

Quoted 10 lines

I submitted the following patch to add it a new doc/feature-removal-schedule.txt with a similar timeframe:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/48429

It seems like it would be a good idea to add the doc/feature_removal.txt. Did the above mentioned patch slip through the cracks or do you prefer to only use the wiki for feature removals?

This is perfect. The patches without an obvious custodian sometimes take a bit longer to find a home, I guess. Anway, full ACK from me.

Quoted 4 lines

Best,
Peter

regards,
Ben

#8 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

In reply to Peter Tyser

Dear Peter Tyser,

Quoted 2 lines · In message <[email protected]> you wrote:

Its actually already on the wiki page.

Ah, good. Sometimes I'm better than I think myself ;-)

Quoted 4 lines

I submitted the following patch to add it a new doc/feature-removal-schedule.txt with a similar timeframe:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/48429

Hm...

Quoted 3 lines

It seems like it would be a good idea to add the doc/feature_removal.txt. Did the above mentioned patch slip through the cracks or do you prefer to only use the wiki for feature removals?

Must have slipped through. Can you please repost so have it here in current context?nks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you think the problem is bad now, just wait until we've solved it.
                                                        Epstein's Law
#9 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

Quoted 13 lines · Wolfgang Denk

Dear Peter Tyser,

Quoted 2 lines · In message <[email protected]> you wrote:

Its actually already on the wiki page.

Ah, good. Sometimes I'm better than I think myself ;-)

Quoted 4 lines

I submitted the following patch to add it a new doc/feature-removal-schedule.txt with a similar timeframe:

http://article.gmane.org/gmane.comp.boot-loaders.u-boot/48429

Quoted 8 lines

Hm...

Quoted 3 lines

It seems like it would be a good idea to add the doc/feature_removal.txt. Did the above mentioned patch slip through the cracks or do you prefer to only use the wiki for feature removals?

Must have slipped through. Can you please repost so have it here in current context?nks.

Sure, will do shortly. I'll add the autoscr and legacy NAND deprecation/removal while I'm at it.

Best,
Peter

#12 lore raw

PATCH 1/1 Disable/Enable Flat I²C Commands

In reply to Wolfgang Denk

Dear Wolfgang Denk,

Quoted 3 lines

Please either add the needed CONFIG_I2C_CMD_FLAT to all affected boards so the current behaviour remains the same, or make it such that it gets activated only for new boards.

i will invert the logic of the patch and post it as version 2. The new patch disables flat commands if CONFIG_I2C_CMD_NO_FLAT defined.

Best regards,

Jens Scharsig