Skip to contentSkip to conversation

fix argument -C on cyclictest

PATCH In review trem 4 participants 4 messages Apr 19, 2009 – Apr 20, 2009

lore
Share & tools
lore

trem

author
#0 lore raw

PATCH 1/1 fix argument -C on cyclictest

The argument -C isn't used in cyclictest, only --context is recognized.

---

src/cyclictest/cyclictest.c +1 -1
index f878217..e67d0d3 100644
@@ -777,7 +777,7 @@ static void process_options (int argc, char *argv[])
                       {"help", no_argument, NULL, '?'},
                       {NULL, 0, NULL, 0}
               };
-               int c = getopt_long (argc, argv, "a::b:Bc:d:fh:i:Il:nNo:p:Pmqrst::vD:",
+               int c = getopt_long (argc, argv, "a::b:Bc:Cd:fh:i:Il:nNo:p:Pmqrst::vD:",
                       long_options, &option_index);
               if (c == -1)
                       break;
#1 lore raw

Hi,

Quoted 9 lines · trem

The argument -C isn't used in cyclictest, only --context is recognized.

---

src/cyclictest/cyclictest.c +0 -0
index f878217..e67d0d3 100644

src/cyclictest/cyclictest.c static void process_options (int argc, char *argv[]) · line 781

Quoted 6 lines
src/cyclictest/cyclictest.c +1 -1
@@ -777,7 +777,7 @@ static void process_options (int argc, char *argv[])
                       {"help", no_argument, NULL, '?'},
                       {NULL, 0, NULL, 0}
               };
-               int c = getopt_long (argc, argv, "a::b:Bc:d:fh:i:Il:nNo:p:Pmqrst::vD:",
+               int c = getopt_long (argc, argv, "a::b:Bc:Cd:fh:i:Il:nNo:p:Pmqrst::vD:",
                       long_options, &option_index);

After the commit log I would have expected that you remove C from the options list. I would suggest something like "make cyclictest accept -C as documented. This is the same as --context".

BTW, I just noticed that both -C and --context don't appear in the man page.

Best regards
Uwe

Signature · 6 lines
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw

Hi Uwe Kleine-Konig

I already submited same issues. for example, --context and --event. Is your patch proposal is different?

Refer to http://marc.info/?l=linux-rt-users&m=123919858213957&w=2 webpage.

Regards,
GeunSik Lim.

2009/4/20 Uwe Kleine-König <[email protected]>:

Quoted 36 lines

Hi,

Quoted 9 lines · trem

The argument -C isn't used in cyclictest, only --context is recognized.

---

src/cyclictest/cyclictest.c +0 -0
index f878217..e67d0d3 100644

src/cyclictest/cyclictest.c static void process_options (int argc, char *argv[]) · line 781

Quoted 6 lines
src/cyclictest/cyclictest.c +1 -1
@@ -777,7 +777,7 @@ static void process_options (int argc, char *argv[])
                        {"help", no_argument, NULL, '?'},
                        {NULL, 0, NULL, 0}
                };
-               int c = getopt_long (argc, argv, "a::b:Bc:d:fh:i:Il:nNo:p:Pmqrst::vD:",
+               int c = getopt_long (argc, argv, "a::b:Bc:Cd:fh:i:Il:nNo:p:Pmqrst::vD:",
                        long_options, &option_index);

After the commit log I would have expected that you remove C from the options list.  I would suggest something like "make cyclictest accept -C as documented.  This is the same as --context".

BTW, I just noticed that both -C and --context don't appear in the man page.

Best regards
Uwe

--
Pengutronix e.K.                              | Uwe Kleine-König            | Industrial Linux Solutions                    | http://www.pengutronix.de/  | --
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Signature · 11 lines
Regards,
GeunSik Lim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 12 lines · On Mon, 20 Apr 2009 23:14:27 +0900 GeunSik Lim <[email protected]> wrote:

Hi Uwe Kleine-Konig

I already submited same issues. for example, --context and --event. Is your patch proposal is different?

Refer to http://marc.info/?l=linux-rt-users&m=123919858213957&w=2 webpage.

Regards,
GeunSik Lim.

Thanks for the reminder; I just pushed rt-tests-0.36, which has the
- -C/-E patch and an updated man page for those two options (although anyone that wants to submit a better description is more than welcome to do so :)).

Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)

iEYEARECAAYFAknsyhIACgkQHyuj/+TTEp0kcwCfXk55nKOUY/9wTOEXcJpG4/AF Ey0AoM6L2JpnVQmfm0X65PkXDf0DvYbZ
=X9mT
-----END PGP SIGNATURE-----