Skip to contentSkip to conversation

PATCH add rgb555 for at91

U-Boot Giulio Benetti 2 participants 6 messages Jun 18, 2009 – Jun 23, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Signed-off-by giulio.benetti at micronovasrl.com
common/lcd.c 2009-06-18 12:45:15.000000000 +0200 renamed from common/lcd.c 2009-06-14 21:30:39.000000000 +0200 +5 -1
diff -urpN b/common/lcd.c a/common/lcd.c
@@ -1,4 +1,4 @@
-/*
+/*OC
  * Common LCD routines for supported CPUs
  *
  * (C) Copyright 2001-2002
@@ -575,6 +575,10 @@ void bitmap_plot (int x, int y)
                        lut_entry = ((colreg & 0x000F) << 11) |
                                    ((colreg & 0x00F0) <<  2) |
                                    ((colreg & 0x0F00) >>  7);
+#elif defined (CONFIG_ATMEL_LCD_RGB555)
+                       lut_entry = ((colreg & 0x000F) << 1) |
+                                   ((colreg & 0x00F0) <<  2) |
+                                   ((colreg & 0x0F00) <<  3);
 #else /* CONFIG_ATMEL_LCD_RGB565 */
                        lut_entry = ((colreg & 0x000F) << 1) |
                                    ((colreg & 0x00F0) << 3) |
drivers/video/atmel_lcdfb.c 2009-06-18 12:45:15.000000000 +0200 renamed from drivers/video/atmel_lcdfb.c 2009-06-14 21:30:39.000000000 +0200 +3 -0
diff -urpN b/drivers/video/atmel_lcdfb.c a/drivers/video/atmel_lcdfb.c
@@ -57,6 +57,9 @@ void lcd_setcolreg(ushort regno, ushort
 #if defined(CONFIG_ATMEL_LCD_BGR555)
        lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
                    (red >> 3) | ((green & 0xf8) << 2) | ((blue & 0xf8) << 7));
+#elif defined(CONFIG_ATMEL_LCD_RGB555)
+       lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
+                   (blue >> 3) | ((green & 0xf8) << 2) | ((red & 0xf8) << 7));
 #else
        lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
                    (blue >> 3) | ((green & 0xfc) << 3) | ((red & 0xf8) << 8));
Signature · 3 lines
Giulio Benetti
R&D
Micronova srl
#1 lore raw

Hi Giulio,

Quoted 1 line
Signed-off-by giulio.benetti at micronovasrl.com

Can you please provide a somewhat more descriptive description? It may be obvious for you what this does (or what new features can now be used), but it isn't for me.

Quoted 25 lines

diff -urpN b/common/lcd.c a/common/lcd.c

common/lcd.c 2009-06-18 12:45:15.000000000 +0200 renamed from common/lcd.c 2009-06-14 21:30:39.000000000 +0200 +5 -1
@@ -1,4 +1,4 @@
-/*
+/*OC
  * Common LCD routines for supported CPUs
  *
  * (C) Copyright 2001-2002
@@ -575,6 +575,10 @@ void bitmap_plot (int x, int y)
                        lut_entry = ((colreg & 0x000F) << 11) |
                                    ((colreg & 0x00F0) <<  2) |
                                    ((colreg & 0x0F00) >>  7);
+#elif defined (CONFIG_ATMEL_LCD_RGB555)
+                       lut_entry = ((colreg & 0x000F) << 1) |
+                                   ((colreg & 0x00F0) <<  2) |
+                                   ((colreg & 0x0F00) <<  3);
 #else /* CONFIG_ATMEL_LCD_RGB565 */
                        lut_entry = ((colreg & 0x000F) << 1) |
                                    ((colreg & 0x00F0) << 3) |

diff -urpN b/drivers/video/atmel_lcdfb.c a/drivers/video/atmel_lcdfb.c

drivers/video/atmel_lcdfb.c 2009-06-18 12:45:15.000000000 +0200 void lcd_setcolreg(ushort regno, ushort · line 57

Quoted 1 line
drivers/video/atmel_lcdfb.c 2009-06-18 12:45:15.000000000 +0200 renamed from drivers/video/atmel_lcdfb.c 2009-06-14 21:30:39.000000000 +0200 +0 -0
@@ -57,6 +57,9 @@ void lcd_setcolreg(ushort regno, ushort
 #if defined(CONFIG_ATMEL_LCD_BGR555)
                                ^^^

I know this line is not touched by you, but is BGR correct?

drivers/video/atmel_lcdfb.c 2009-06-18 12:45:15.000000000 +0200 void lcd_setcolreg(ushort regno, ushort · line 65

Quoted 8 lines
drivers/video/atmel_lcdfb.c 2009-06-18 12:45:15.000000000 +0200 renamed from drivers/video/atmel_lcdfb.c 2009-06-14 21:30:39.000000000 +0200 +3 -0
        lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
                    (red >> 3) | ((green & 0xf8) << 2) | ((blue & 0xf8) << 7));
+#elif defined(CONFIG_ATMEL_LCD_RGB555)
+       lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
+                   (blue >> 3) | ((green & 0xf8) << 2) | ((red & 0xf8) << 7));
 #else
        lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
                    (blue >> 3) | ((green & 0xfc) << 3) | ((red & 0xf8) << 8));

Cheers
Detlev

Signature · 6 lines
To you I'm an atheist; to God, I'm the Loyal Opposition.
                                        -- Woody Allen
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
Quoted 50 lines · Detlev Zundel

Hi Giulio,

Quoted 1 line
Signed-off-by giulio.benetti at micronovasrl.com

Can you please provide a somewhat more descriptive description? It may be obvious for you what this does (or what new features can now be used), but it isn't for me.

Quoted 21 lines

diff -urpN b/common/lcd.c a/common/lcd.c

common/lcd.c 2009-06-18 12:45:15.000000000 +0200 renamed from common/lcd.c 2009-06-14 21:30:39.000000000 +0200 +5 -1
@@ -1,4 +1,4 @@
-/*
+/*OC
  * Common LCD routines for supported CPUs
  *
  * (C) Copyright 2001-2002
@@ -575,6 +575,10 @@ void bitmap_plot (int x, int y)
                        lut_entry = ((colreg & 0x000F) << 11) |
                                    ((colreg & 0x00F0) <<  2) |
                                    ((colreg & 0x0F00) >>  7);
+#elif defined (CONFIG_ATMEL_LCD_RGB555)
+                       lut_entry = ((colreg & 0x000F) << 1) |
+                                   ((colreg & 0x00F0) <<  2) |
+                                   ((colreg & 0x0F00) <<  3);
 #else /* CONFIG_ATMEL_LCD_RGB565 */
                        lut_entry = ((colreg & 0x000F) << 1) |
                                    ((colreg & 0x00F0) << 3) |
Quoted 6 lines

diff -urpN b/drivers/video/atmel_lcdfb.c a/drivers/video/atmel_lcdfb.c
--- b/drivers/video/atmel_lcdfb.c 2009-06-14 21:30:39.000000000
+0200
+++ a/drivers/video/atmel_lcdfb.c 2009-06-18 12:45:15.000000000
+0200 @@ -57,6 +57,9 @@ void lcd_setcolreg(ushort regno, ushort
#if defined(CONFIG_ATMEL_LCD_BGR555)

                                ^^^

I know this line is not touched by you, but is BGR correct?

Quoted 11 lines
        lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
                    (red >> 3) | ((green & 0xf8) << 2) | ((blue & 0xf8)
                    << 7));
common/lcd.c 2009-06-18 12:45:15.000000000 +0200 renamed from common/lcd.c 2009-06-14 21:30:39.000000000 +0200 +3 -0
+#elif defined(CONFIG_ATMEL_LCD_RGB555)
+       lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
+                   (blue >> 3) | ((green & 0xf8) << 2) | ((red & 0xf8)

<< 7));

 #else
        lcdc_writel(panel_info.mmio, ATMEL_LCDC_LUT(regno),
                    (blue >> 3) | ((green & 0xfc) << 3) | ((red & 0xf8)
                    << 8));
Quoted 3 lines

Cheers
Detlev

You're right, sorry.
This patch add support for Rgb 555 bits following a precise hardware wiring that should be more correct respect the at91sam9263ek.
I mean
LCD2 - LCD7 are RED0 - RED4,
LCD10 - LCD15 are GREEN0 - GREEN4,
LCD18 - LCD23 are BLUE0 - BLUE4

Regarding "LCD_BGR555", it is correct only because at91sam9263ek was wired swapped between red and blue. It should be in that way but I'm not sure. Anyway I think the wiring should be done better before, instead of create a new "standard". Fortunately with software you can change more than something, but not everything.

Signature · 3 lines
Giulio Benetti
R&D
Micronova srl
#3 lore raw

Hi Giulio,

Quoted 9 lines
Quoted 7 lines · Detlev Zundel

Hi Giulio,

Quoted 1 line
Signed-off-by giulio.benetti at micronovasrl.com

Can you please provide a somewhat more descriptive description? It may be obvious for you what this does (or what new features can now be used), but it isn't for me.

[...]

Quoted 7 lines

You're right, sorry.
This patch add support for Rgb 555 bits following a precise hardware wiring that should be more correct respect the at91sam9263ek.
I mean
LCD2 - LCD7 are RED0 - RED4,
LCD10 - LCD15 are GREEN0 - GREEN4,
LCD18 - LCD23 are BLUE0 - BLUE4

Hm, I still don't get what your patch does. Is this the wiring which is actually used on the at91sam9263ek? If so, then why does your patch not add this symbol in include/configs/at91sam9263ek.h? In there I see the said CONFIG_ATMEL_LCD_BGR555. That symbol is also defined for the at91cap9adk, at91sam9261ek and pm9263.h. So what I would really like to know - is the interpretation of CONFIG_ATMEL_LCD_BGR555 correct in U-Boot and only the at91sam9263ek is wired up differently? Or should rather the interpretation of CONFIG_ATMEL_LCD_BGR555 be fixed?

Quoted 5 lines

Regarding "LCD_BGR555", it is correct only because at91sam9263ek was wired swapped between red and blue. It should be in that way but I'm not sure. Anyway I think the wiring should be done better before, instead of create a new "standard". Fortunately with software you can change more than something, but not everything.

Ah, so this means that the at91sam9263ek is special compared to the other boards listed above and should be treated differently, right? Well in this case, your patch certainly needs to change include/configs/at91sam9263ek.h.

Cheers
Detlev

Signature · 8 lines
Peace of mind isn't at all superficial to technical work.  It's the
whole thing.   That which  produces it is good work  and that which
destroys it is bad work.
                                        -- Robert M. Pirsig
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#4 lore raw

Hi Detlev,

RGB555 is a wiring with blue and red swapped, nothing more. Maybe I've made too much confusion before.
And in the at91 eks there's nothing to change, because they're wired as BGR555.

Best regards

Signature · 3 lines
Giulio Benetti
R&D
Micronova srl
#5 lore raw

Hi Giulio,

Quoted 4 lines

RGB555 is a wiring with blue and red swapped, nothing more. Maybe I've made too much confusion before.
And in the at91 eks there's nothing to change, because they're wired as BGR555.

Ok, in this case, postpone your patch until a board is in mainline which needs this support ;)

Cheers
Detlev

Signature · 7 lines
Man sei weder unzufrieden mit sich selbst - denn das waere Kleinmut - noch
selbstzufrieden - denn das waere Dummheit.
                                    --- Baltasar Gracian
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de