Pass nr_wake2 to futex_wake_op
PATCH 1/1 Pass nr_wake2 to futex_wake_op
The fourth argument of sys_futex is ignored when op == FUTEX_WAKE_OP, but futex_wake_op expects it as its nr_wake2 parameter.
The only user of this operation in glibc is always passing 1, so this bug had no consequences so far.
Signed-off-by Andreas Schwab <[email protected]>
--- kernel/futex.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/futex.c +3 -1
@@ -2061,8 +2061,10 @@ asmlinkage long sys_futex(u32 __user *ua }/* * requeue parameter in 'utime' if cmd == FUTEX_REQUEUE. +* number of waiters to wake in 'utime' if cmd == FUTEX_WAKE_OP. */ -if (cmd ==FUTEX_REQUEUE || cmd ==FUTEX_CMP_REQUEUE ) +if (cmd ==FUTEX_REQUEUE || cmd ==FUTEX_CMP_REQUEUE || + cmd ==FUTEX_WAKE_OP ) val2 = (u32 ) (unsigned long ) utime;return do_futex (uaddr, op, val, tp, uaddr2, val2, val3);
Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."