Skip to contentSkip to conversation

imx: sys_proto: Fixing function imx6_is_bmode_from_gpr9()

PATCH New Christoph Niedermaier 2 participants 2 messages Nov 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx: sys_proto: Fixing function imx6_is_bmode_from_gpr9()

From: Stefano Babic <[email protected]>
Sent: Tuesday 5th November 2019 17:26

Quoted 16 lines · Anatolij Gustschin
Quoted 15 lines

Hi Stefano, Christoph,

On Tue, 5 Nov 2019 16:57:18 +0100
Stefano Babic sbabic at denx.de wrote:
...

Quoted 9 lines

Review

Quoted 6 lines
(quoted diff) +1 -1
-static inline u8 imx6_is_bmode_from_gpr9(void)
+static inline u32 imx6_is_bmode_from_gpr9(void)
 {
 	return readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE;
 }

This is correct but it rather conflicts with another patch I already applied. Could you rebase and repost ? Thanks !

Quoted 9 lines
Quoted 1 line

This function was removed by Claudius (see commit ID e01c8cfe5769)

Yes, but this check just one bit.

Quoted 1 line

since there are no users any more.

Oh yes, you're right !

Quoted 1 line

No need to rebase/repost.

OK, the commit from Claudius solves my problem and my patch is therefore outdated.
It's funny that the useless function has been around for more than two years and now we're both trying to fix it at almost the same time ;-)

Regards,
Christoph

#1 lore raw

PATCH 1/1 imx: sys_proto: Fixing function imx6_is_bmode_from_gpr9()

Quoted 24 lines · Christoph Niedermaier

From: Stefano Babic <[email protected]>
Sent: Tuesday 5th November 2019 17:26

Quoted 20 lines · Anatolij Gustschin
Quoted 15 lines

Hi Stefano, Christoph,

On Tue, 5 Nov 2019 16:57:18 +0100
Stefano Babic sbabic at denx.de wrote:
...

Quoted 9 lines

Review

Quoted 6 lines
(quoted diff) +1 -1
-static inline u8 imx6_is_bmode_from_gpr9(void)
+static inline u32 imx6_is_bmode_from_gpr9(void)
 {
 	return readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE;
 }

This is correct but it rather conflicts with another patch I already applied. Could you rebase and repost ? Thanks !

Quoted 1 line

This function was removed by Claudius (see commit ID e01c8cfe5769)

Yes, but this check just one bit.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

since there are no users any more.

Oh yes, you're right !

Quoted 1 line

No need to rebase/repost.

OK, the commit from Claudius solves my problem and my patch is therefore outdated.
It's funny that the useless function has been around for more than two years and now we're both trying to fix it at almost the same time ;-)

It is a common path: nothing for years or all together. It happens many times ;-)

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================