Skip to contentSkip to conversation

I/O macros redefined, inconsistent across m68k machdep headers

DISCUSSION Thorsten Glaser 4 participants 7 messages May 11, 2013 – Jun 9, 2013

lore
Share & tools
lore
#0 lore raw

Hi!

I *really* dislike seeing messages like this while compiling, that’s why I’m sending them there. I had a look at both files, but there’s a lot of ifdeffery going on, and I don’t know which of the macro resolutions, if any, is supposedly correct.

CC [M] drivers/parport/parport_pc.o
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/ parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
"insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
"outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is the location of the previous definition
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/ parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
"insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
"outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the location of the previous definition

This is from building the amiga flavour (first of six!) of the Debian unstable Linux kernel source package. We’ll have the new kernels in roughly 1½-2 weeks, if everything works ☺

bye,
//mirabilos

#1 lore raw

Thorsten,

Quoted 5 lines

I *really* dislike seeing messages like this while compiling, that’s why I’m sending them there. I had a look at both files, but there’s a lot of ifdeffery going on, and I don’t know which of the macro resolutions, if any, is supposedly correct.

I'm responsible for part of the ifdef'ery in io_mm.h - as far as I can see, Q40 only needs this hack for the parport, all other ISA accesses should be mapped to isa_insl()/isa_outsl() with address translation applied correctly in all cases regarding of whether or not this is a multiarch kernel.

I'm certain there is a reason for turning the word macros into byte ones (Q40 needs delays between accesses, maybe that's it. Or the parport chip is 8 bit only). So this most likely needs to stay.

A cleaner way to do this would be to prefix the #defines with

#ifdef isa_insl
#undef isa_insl
#undef isa_outsl
#endif

(untested)

or just #undef anyway, since we can be fairly certain the previous #defines have been made.

Quoted 15 lines

CC [M] drivers/parport/parport_pc.o
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: "insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: "outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is the location of the previous definition In file included from /tmp/buildd/linux-3.8.12/drivers/parport/
parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning: "insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning: "outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the location of the previous definition

Quoted 4 lines

This is from building the amiga flavour (first of six!) of the Debian unstable Linux kernel source package. We’ll have the new kernels in roughly 1½-2 weeks, if everything works ☺

What kernel versions are these?

Cheers,

Michael

Quoted 8 lines

bye,
//mirabilos

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

Michael Schmitz dixit:

Quoted 1 line

or just #undef anyway, since we can be fairly certain the previous #defines

An #undef is always safe even if none has been made.

Quoted 3 lines

What kernel versions are these?

Quoted 1 line

/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the

                     ^^^^^^

As usual, when building Debian packages, I’m using whatever the Debian Linux kernel team has uploaded to unstable.

(As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

bye,
//mirabilos

Signature · 4 lines
Sorry,  I’m annoyed today and you came by as an Arch user. These are the
perfect victims for any crime against humanity, like  systemd,  feminism
or social democracy.
		-- Christoph Lohmann on [email protected]
#3 lore raw

Hi Thorsten,

Quoted 3 lines
Quoted 1 line

or just #undef anyway, since we can be fairly certain the previous #defines

An #undef is always safe even if none has been made.

Right - it's just for readability really.

Quoted 4 lines
Quoted 3 lines

What kernel versions are these?

Quoted 1 line

/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the

                     ^^^^^^

Missed that, obviously.

Quoted 4 lines

As usual, when building Debian packages, I’m using whatever the Debian Linux kernel team has uploaded to unstable.

(As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

They are in m68k-queue on 3.9 so might to into 3.10. No idea whether they are automatically backported to 3.8.10.

Cheers,

Michael

Quoted 7 lines

bye,
//mirabilos
--
Sorry, I’m annoyed today and you came by as an Arch user. These are the perfect victims for any crime against humanity, like systemd, feminism or social democracy.
-- Christoph Lohmann on [email protected]

Quoted 23 lines · Thorsten Glaser

Michael Schmitz dixit:

Quoted 1 line

or just #undef anyway, since we can be fairly certain the previous #defines

An #undef is always safe even if none has been made.

Quoted 3 lines

What kernel versions are these?

Quoted 1 line

/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the

                     ^^^^^^

As usual, when building Debian packages, I’m using whatever the Debian Linux kernel team has uploaded to unstable.

(As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

bye,
//mirabilos
--
Sorry, I’m annoyed today and you came by as an Arch user. These are the perfect victims for any crime against humanity, like systemd, feminism or social democracy.
-- Christoph Lohmann on [email protected]

#4 lore raw

Michael Schmitz dixit:

Quoted 3 lines
Quoted 1 line

(As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

They are in m68k-queue on 3.9 so might to into 3.10. No idea whether

Ah okay. ISTR Geert saying you had to submit them?

Quoted 1 line

they are automatically backported to 3.8.10.

Oh sorry, that was a typo, I meant 3.10 of course. Nothing is backported automatically.

bye,
//mirabilos

Signature · 4 lines
Sorry,  I’m annoyed today and you came by as an Arch user. These are the
perfect victims for any crime against humanity, like  systemd,  feminism
or social democracy.
		-- Christoph Lohmann on [email protected]
#5 lore raw

Hi Thorsten,

Quoted 3 lines
Quoted 1 line

They are in m68k-queue on 3.9 so might to into 3.10. No idea whether

Ah okay. ISTR Geert saying you had to submit them?

Correct - will do when I find a free moment. I need to tread a wee bit carefully after being shot down in flames last time.

Quoted 4 lines
Quoted 1 line

they are automatically backported to 3.8.10.

Oh sorry, that was a typo, I meant 3.10 of course. Nothing is backported automatically.

Should be going into 3.10 vanilla if no objections are raised. The rest has already been merged (except for the interrupt stuff, which people may have shrugged off a a joke).

Cheers,

Michael

Quoted 20 lines · Thorsten Glaser

Michael Schmitz dixit:

Quoted 3 lines
Quoted 1 line

(As a side note: will your Atari NIC drivers be in 3.8.10 vanilla?)

They are in m68k-queue on 3.9 so might to into 3.10. No idea whether

Ah okay. ISTR Geert saying you had to submit them?

Quoted 1 line

they are automatically backported to 3.8.10.

Oh sorry, that was a typo, I meant 3.10 of course. Nothing is backported automatically.

bye,
//mirabilos
--
Sorry, I’m annoyed today and you came by as an Arch user. These are the perfect victims for any crime against humanity, like systemd, feminism or social democracy.
-- Christoph Lohmann on [email protected]

#6 lore raw
In reply to Thorsten Glaser
Quoted 23 lines · Thorsten Glaser

CC [M] drivers/parport/parport_pc.o
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/ parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
"insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
"outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0: note: this is the location of the previous definition
In file included from /tmp/buildd/linux-3.8.12/drivers/parport/ parport_pc.c:67:0:
/tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:14:0: warning:
"insl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:280:0: note: this is the location of the previous definition /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/parport.h:15:0: warning:
"outsl" redefined [enabled by default] /tmp/buildd/linux-3.8.12/arch/m68k/include/asm/io_mm.h:283:0:this is the location of the previous definition

Quoted 2 lines

This is from building the amiga flavour (first of six!) of the Debian unstable Linux kernel source package. We’ll have the new kernels in

I only have this warning in builds that enable as much as possible (e.g. allmodconfig).

PARPORT_PC depends on (!M68K || ISA).
ISA depends on Q40 || AMIGA_PCMCIA.

However, I have CONFIG_PARPORT_PC=n in amiga_defconfig and multi_defconfig, and CONFIG_PARPORT=n in q40_defconfig. Hence I don't see it elsewhere.

As we don't have support for bridgeboards on Amiga, we probably don't need CONFIG_PARPORT_PC on Amiga. Unless someone is using it with a PCMCIA parallel port adapter?

Probably CONFIG_PARPORT and CONFIG_PARPORT_PC should be enabled in q40_defconfig (and thus multi_defconfig) though, to accommodate ISA multi-I/O boards.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds