Skip to contentSkip to conversation

Missing get_cycles() has effect on quality of entropy

DISCUSSION Thorsten Glaser 1 participant 1 message Sep 9, 2013

lore
Share & tools
lore
#0 lore raw

Hi!

https://lists.openwrt.org/pipermail/openwrt-devel/2013-September/021318.html
affects several architectures – m68k among them.

Some arches have comments like “only used by the scheduler”. This may have been once true, but a quick “git grep -w get_cycles” shows much more use throughout the Linux kernel.

The random thing is scary already, but…
mm/slub.c: p += 64 + (get_cycles() & 0xff) * sizeof(void *);
… there are several cases like this, where an always-zero get_cycles() result severely impacts operation of the code.

So I ask whether it’s possible to fill this code with life, for at least a subset of all architectures?

bye,
//mirabilos