2.4.0-test11 (pre1, final) OOPS during boot/modprobe

2.4.0-test11-pre1 seems to have broken something.
I have no problems with test10, but test11-pre1 gives three oops messages during boot. test11-final gives the exact same OOPS messages...

Of the three, only the first one decodes to anything useful:

Unable to handle kernel paging request at virtual address c86bd1e0 
 printing eip: 
c4890060 
*pde = 00000000 
Oops: 0000 
CPU:    0 
EIP:    0010:[nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-12192/80] 
EFLAGS: 00010a82 
eax: c4890050   ebx: c3fcb400   ecx: c489101c   edx: ffffffff 
esi: c4891160   edi: c4891160   ebp: c48912d4   esp: c36fbee8 
ds: 0018   es: 0018   ss: 0018 
Process modprobe (pid: 201, stackpage=c36fb000) 
Stack: c01b74fc c3fcb400 c489101c c3fcb400 00000000 c01b7554 c4891160 c3fcb400  
       c4890000 c489098c 00000001 c4890996 c4891160 c0117d2d c36fa000 08065490  
       08061760 bfffe164 00000001 c488d000 c488d000 c36fbf60 0000004c c48912c0  
Call Trace: [pci_announce_device+44/64] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-8164/80] [pci_register_driver+68/92] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-7840/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-12288/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-9844/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-9834/80]  
       [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-7840/80] [sys_init_module+1409/1568] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-24576/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-24576/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-7488/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-24576/80] [nfsd:__insmod_nfsd_O/lib/modules/2.4.0-test11/kernel/fs/nfsd/nfs+-12192/80] [system_call+51/64]  
Code: 12 89 c4 c1 e2 03 89 44 24 18 89 54 24 1c 40 8b 8a c8 0f 89  

The addresses are different, but the stack trace is identical, between test-11(pre1) and test11(final).

I think the oops's each correspond to a modprobe.

Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/egcs-2.91.66/specs gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Which modutils? And if it is not 2.3.21, upgrade.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Steven probably wants to apply this patch to test11:

@@ -480,7 +480,9 @@
 
 	/* Ok, that's about all the sanity we can stomach; copy the rest.  */
 
-	if (copy_from_user(mod+1, mod_user+1, mod->size-sizeof(*mod))) {
+	if (copy_from_user((char *)mod+mod_user_size,
+			   (char *)mod_user+mod_user_size,
+			   mod->size-mod_user_size)) {
 		error = -EFAULT;
 		goto err3;
 	}

_____

  |_____| ------------------------------------------------- ---+---+-
  |   |         Russell King        [email protected]      --- ---
  | | | | http://www.arm.linux.org.uk/personal/aboutme.html   /  /  |
  | +-+-+                                                     --- -+-
  /   |               THE developer of ARM Linux              |+| /|\
 /  | | |                                                     ---  |
    +-+-+ -------------------------------------------------  /\\\  |

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Upgrading to modutils 2.3.21 is easier and everybody should do that anyway to fix the local root exploits.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

How about we apply both that patch and this one?

diff -u linux/Documentation/Changes.old linux/Documentation/Changes
@@ -52,7 +52,7 @@
 o  Gnu make               3.77                    # make --version
 o  binutils               2.9.1.0.25              # ld -v
 o  util-linux             2.10o                   # kbdrate -v
-o  modutils               2.3.18                  # insmod -V
+o  modutils               2.3.21                  # insmod -V
 o  e2fsprogs              1.19                    # tune2fs --version
 o  pcmcia-cs              3.1.21                  # cardmgr -V
 o  PPP                    2.4.0                   # pppd --version

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/

Both already sent to Linus and Alan Cox.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/