Skip to contentSkip to conversation

megaraid: Use the proper type to hold the irq number.

PATCH New Eric W. Biederman 1 participant 1 message Aug 7, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 megaraid: Use the proper type to hold the irq number.

When testing on a Unisys machine it was discovered that the megaraid driver would not initialize as it was requesting irq 162 instead of irq 1442 it was assigned. The problem was the irq number had been truncated by being stored in an unsigned char.

This patches fixes that problem and the driver now appears to work.

The ioctl interface appears fundamentally broken as it exports the irq number to user space in an unsigned char.

---
 drivers/scsi/megaraid/mega_common.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/megaraid/mega_common.h +1 -1
index 8cd0bd1..b50e27e 100644
@@ -175,7 +175,7 @@ typedef struct {
 	uint8_t			max_lun;
 
 	uint32_t		unique_id;
-	uint8_t			irq;
+	int			irq;
 	uint8_t			ito;
 	caddr_t			ibuf;
 	dma_addr_t		ibuf_dma_h;
Signature · 1 line
1.4.2.rc3.g7e18e