Skip to contentSkip to conversation

x86_64 kexec: Remove experimental mark of kexec

PATCH New Eric W. Biederman 3 participants 9 messages Sep 6, 2006 – Sep 8, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86_64 kexec: Remove experimental mark of kexec

kexec has been marked experimental for a year now and all of the serious kernel side problems have been worked through. So it is time (if not past time) to remove the experimental mark.

---
 arch/x86_64/Kconfig |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/x86_64/Kconfig +1 -2
index 756fa38..1adba0f 100644
@@ -481,8 +481,7 @@ config X86_MCE_AMD
 	   the DRAM Error Threshold.
 
 config KEXEC
-	bool "kexec system call (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
+	bool "kexec system call"
 	help
 	  kexec is a system call that implements the ability to shutdown your
 	  current kernel, and to start another kernel.  It is like a reboot
Signature · 1 line
1.4.2.rc3.g7e18e-dirty
#1 lore raw

PATCH 1/1 x86_64 kexec: Remove experimental mark of kexec

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

---

This time with a Signed-off-by line.

 arch/x86_64/Kconfig |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
arch/x86_64/Kconfig +1 -2
index 756fa38..1adba0f 100644
@@ -481,8 +481,7 @@ config X86_MCE_AMD
 	   the DRAM Error Threshold.
 
 config KEXEC
-	bool "kexec system call (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
+	bool "kexec system call"
 	help
 	  kexec is a system call that implements the ability to shutdown your
 	  current kernel, and to start another kernel.  It is like a reboot
Signature · 1 line
1.4.2.rc3.g7e18e-dirty
#2 lore raw
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

But applied for now.

-Andi

#3 lore raw
Quoted 10 lines · Andi Kleen
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

That is a reasonable viewpoint. Although by that a lot more of the kernel deserves to be marked experimental.

On the perverse side of the sentiment taking off experimental may increase our number of testers and get the bugs fixed faster :)

Quoted 1 line

But applied for now.

Thanks.

Eric

#4 lore raw
Quoted 13 lines · Eric W. Biederman
Quoted 10 lines · Andi Kleen
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

Quoted 5 lines

That is a reasonable viewpoint. Although by that a lot more of the kernel deserves to be marked experimental.

On the perverse side of the sentiment taking off experimental may increase our number of testers and get the bugs fixed faster :)

I take it that for using kexec to boot a kdump kernel and then rebooting the primary kernel that there are a few drivers in the dumping kernel that wouldn't work but they aren't likely to be used. Ie: it's "just" a hardware initialization issue on kernels booted with kexec.

-piet

Quoted 11 lines
Quoted 2 lines

But applied for now.

Thanks.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 4 lines
Piet Delaney                                    Phone: (408) 200-5256
Blue Lane Technologies                          Fax:   (408) 200-5299
10450 Bubb Rd.
Cupertino, Ca. 95014                            Email: [email protected]
#5 lore raw
Quoted 17 lines · Piet Delaney
Quoted 16 lines · Eric W. Biederman
Quoted 10 lines · Andi Kleen
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

That is a reasonable viewpoint. Although by that a lot more of the kernel deserves to be marked experimental.

Quoted 8 lines
Quoted 2 lines

On the perverse side of the sentiment taking off experimental may increase our number of testers and get the bugs fixed faster :)

I take it that for using kexec to boot a kdump kernel and then rebooting the primary kernel that there are a few drivers in the dumping kernel that wouldn't work but they aren't likely to be used. Ie: it's "just" a hardware initialization issue on kernels booted with kexec.

Yes. The only place you are likely to observe the driver initialization problems are kernels booted with kexec. But there are other rare scenarios that can yield challenging boot driver
initialization scenarios. I know soft booting from windows used
to be one of them.

As for the kdump kernel usually you won't load (or build in) any drivers you don't intend to use. If the drivers actually get loaded even if you aren't using them you could have problems.

Eric

#6 lore raw
Quoted 34 lines · Eric W. Biederman
Quoted 17 lines · Piet Delaney
Quoted 16 lines · Eric W. Biederman
Quoted 10 lines · Andi Kleen
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

That is a reasonable viewpoint. Although by that a lot more of the kernel deserves to be marked experimental.

Quoted 8 lines
Quoted 2 lines

On the perverse side of the sentiment taking off experimental may increase our number of testers and get the bugs fixed faster :)

I take it that for using kexec to boot a kdump kernel and then rebooting the primary kernel that there are a few drivers in the dumping kernel that wouldn't work but they aren't likely to be used. Ie: it's "just" a hardware initialization issue on kernels booted with kexec.

Yes. The only place you are likely to observe the driver initialization problems are kernels booted with kexec. But there are other rare scenarios that can yield challenging boot driver
initialization scenarios. I know soft booting from windows used
to be one of them.

Quoted 3 lines

As for the kdump kernel usually you won't load (or build in) any drivers you don't intend to use. If the drivers actually get loaded even if you aren't using them you could have problems.

Thanks for the tip, I'll make sure my dumping kernel only has drivers necessary to make the kernel core file configured.

-piet

Quoted 2 lines

Eric

Signature · 4 lines
Piet Delaney                                    Phone: (408) 200-5256
Blue Lane Technologies                          Fax:   (408) 200-5299
10450 Bubb Rd.
Cupertino, Ca. 95014                            Email: [email protected]
#7 lore raw
In reply to Andi Kleen
Quoted 10 lines · Andi Kleen
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

What drivers does kexec break?

-piet

Quoted 9 lines

But applied for now.

(quoted diff) +0 -2
-Andi
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 4 lines
Piet Delaney                                    Phone: (408) 200-5256
Blue Lane Technologies                          Fax:   (408) 200-5299
10450 Bubb Rd.
Cupertino, Ca. 95014                            Email: [email protected]
#8 lore raw
Quoted 8 lines · Piet Delaney
Quoted 7 lines · Andi Kleen
Quoted 5 lines · Eric W. Biederman

kexec has been marked experimental for a year now and all of the serious problems have been worked through. So it is time (if not past time) to remove the experimental mark.

Quoted 5 lines
Quoted 3 lines

Hmm, I personally have some doubts it is really not experimental (not because of the kexec code itself, but because of all the other drivers that still break)

What drivers does kexec break?

Kexec doesn't break any drivers. kexec exposes bugs in driver initialization handling, when drivers on not robust.

The normal kexec case should be quite simple to handle and because we cleanup just like a reboot, the difference is that we don't ask the BIOS to reset us first.

The kexec on panic case is painful, because drivers in the original kernel are not stopped or shutdown, and so the secondary kernel gets to initialize drivers from an essentially random state.

Eric