iwlwifi: remove EXPORT_SYMBOL for static symbol
Subsystems (3)
It does not make sense to apply EXPORT_SYMBOL to a static symbol. Fixes this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error: __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
---
This obsoletes 6269b731560d69c5eaa929909891edec39496d71, which was misattributed as a compiler bug.
--- drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/wireless/iwlwifi/iwl3945-base.c +0 -1
@@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct rxq->bd =NULL ; rxq->rb_stts =NULL ; } -EXPORT_SYMBOL (iwl3945_rx_queue_free);/* Convert linear signal-to-noise ratio into dB */
Signature · 7 lines
Andreas Schwab, [email protected] GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Johannes Berg
maintainerQuoted 10 lines · Andreas Schwab
It does not make sense to apply
EXPORT_SYMBOLto a static symbol. Fixes this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:__ksymtab_iwl3945_rx_queue_resetcauses a section type conflictSigned-off-by Andreas Schwab <[email protected]>---
This obsoletes6269b731560d69c5eaa929909891edec39496d71, which was misattributed as a compiler bug.
At least in my tree the function isn't static...(yet I still got the compiler error)?
johannes
Quoted 7 lines · Johannes Berg
Quoted 6 lines · Andreas Schwab
It does not make sense to apply
EXPORT_SYMBOLto a static symbol. Fixes this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:__ksymtab_iwl3945_rx_queue_resetcauses a section type conflict
Quoted 7 lines
Quoted 4 lines
Signed-off-by Andreas Schwab <[email protected]>---
This obsoletes6269b731560d69c5eaa929909891edec39496d71, which was misattributed as a compiler bug.At least in my tree the function isn't static...(yet I still got the compiler error)?
The static function is iwl3945_rx_queue_free.
Andreas.
Signature · 3 lines
Andreas Schwab, [email protected] GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Johannes Berg
maintainerQuoted 7 lines · Andreas Schwab
Quoted 5 lines
Quoted 2 lines
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:__ksymtab_iwl3945_rx_queue_resetcauses a section type conflictAt least in my tree the function isn't static...(yet I still got the compiler error)?
The static function is
iwl3945_rx_queue_free.
Oh. I have to admit to not looking that far, thanks.
johannes
reinette chatre
Acked-byQuoted 20 lines · Andreas Schwab
It does not make sense to apply
EXPORT_SYMBOLto a static symbol. Fixes this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:__ksymtab_iwl3945_rx_queue_resetcauses a section type conflictSigned-off-by Andreas Schwab <[email protected]>---
This obsoletes6269b731560d69c5eaa929909891edec39496d71, which wasFrom which repo is this commit id?
misattributed as a compiler bug.
--- drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/wireless/iwlwifi/iwl3945-base.c static void iwl3945_rx_queue_free(struct · line 1750
Quoted 7 lines
drivers/net/wireless/iwlwifi/iwl3945-base.c +0
-1@@ -1745,7 +1745,6 @@ static void iwl3945_rx_queue_free(struct rxq->bd =NULL ; rxq->rb_stts =NULL ; } -EXPORT_SYMBOL (iwl3945_rx_queue_free);/* Convert linear signal-to-noise ratio into dB */
Thank you
Reinette
reinette chatre
Quoted 11 lines · <[email protected]> writes:
Quoted 10 lines · Andreas Schwab
It does not make sense to apply
EXPORT_SYMBOLto a static symbol. Fixes this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:__ksymtab_iwl3945_rx_queue_resetcauses a section type conflictSigned-off-by Andreas Schwab <[email protected]>---
This obsoletes6269b731560d69c5eaa929909891edec39496d71, which wasFrom which repo is this commit id?
That's from davem/net-2.6 or linville/wireless-2.6.git
Andreas.
Signature · 3 lines
Andreas Schwab, [email protected] GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Andreas,
Quoted 10 lines · Andreas Schwab
reinette chatre
Quoted 6 lines · <[email protected]> writes:
Quoted 5 lines · Andreas Schwab
It does not make sense to apply
EXPORT_SYMBOLto a static symbol. Fixes this build error:
drivers/net/wireless/iwlwifi/iwl3945-base.c:1697: error:__ksymtab_iwl3945_rx_queue_resetcauses a section type conflict
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Signed-off-by Andreas Schwab <[email protected]>---
This obsoletes6269b731560d69c5eaa929909891edec39496d71, which wasFrom which repo is this commit id?
That's from davem/net-2.6 or linville/wireless-2.6.git
Thanks. Even though this patch obsoletes 6269b731560d69c5eaa929909891edec39496d71 it still makes sense to have that patch in the repo as it removes another unnecessary EXPORT_SYMBOL. I would thus prefer that both patches are included.
Reinette
reinette chatre
Quoted 4 lines · <[email protected]> writes:
Thanks. Even though this patch obsoletes
6269b731560d69c5eaa929909891edec39496d71it still makes sense to have that patch in the repo as it removes another unnecessaryEXPORT_SYMBOL. I would thus prefer that both patches are included.
I agree.
Andreas.
Signature · 3 lines
Andreas Schwab, [email protected] GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."