Skip to contentSkip to conversation

Don't cut off last character of commit descriptions.

PATCH In review Nikolaj Schumacher 3 participants 3 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't cut off last character of commit descriptions.

Quoted 1 line

From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001

From: Nikolaj Schumacher <[email protected]>
Date: Mon, 30 Jun 2008 12:06:01 +0200
Subject: [PATCH] Don't cut off last character of commit descriptions.

---
 contrib/emacs/git-blame.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
contrib/emacs/git-blame.el +1 -1
index 9f92cd2..4fa70c5 100644
@@ -381,7 +381,7 @@ See also function `git-blame-mode'."
                   "log" "-1"
 		  (concat "--pretty=" git-blame-log-oneline-format)
                   hash)
-    (buffer-substring (point-min) (1- (point-max)))))
+    (buffer-substring (point-min) (point-max))))
 
 (defvar git-blame-last-identification nil)
 (make-variable-buffer-local 'git-blame-last-identification)
Signature · 1 line
1.5.5.3
#1 lore raw
Quoted 14 lines · Nikolaj Schumacher

From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
From: Nikolaj Schumacher <[email protected]>
Date: Mon, 30 Jun 2008 12:06:01 +0200
Subject: [PATCH] Don't cut off last character of commit descriptions.

---
 contrib/emacs/git-blame.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
contrib/emacs/git-blame.el +0 -0
index 9f92cd2..4fa70c5 100644

contrib/emacs/git-blame.el See also function `git-blame-mode'." · line 387

Quoted 8 lines
contrib/emacs/git-blame.el +1 -1
@@ -381,7 +381,7 @@ See also function `git-blame-mode'."
                   "log" "-1"
 		  (concat "--pretty=" git-blame-log-oneline-format)
                   hash)
-    (buffer-substring (point-min) (1- (point-max)))))
+    (buffer-substring (point-min) (point-max))))
 
 (defvar git-blame-last-identification nil)
 (make-variable-buffer-local 'git-blame-last-identification)

Yes, this should have been part of 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when, who and what in the minibuffer. that changed from using --pretty=oneline to --pretty=format:... without terminating newline.

Signature · 1 line
David Kågedal
#2 lore raw
Quoted 22 lines · David Kågedal
Quoted 20 lines · Nikolaj Schumacher

From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
From: Nikolaj Schumacher <[email protected]>
Date: Mon, 30 Jun 2008 12:06:01 +0200
Subject: [PATCH] Don't cut off last character of commit descriptions.

---
 contrib/emacs/git-blame.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
contrib/emacs/git-blame.el +1 -1
index 9f92cd2..4fa70c5 100644
@@ -381,7 +381,7 @@ See also function `git-blame-mode'."
                   "log" "-1"
 		  (concat "--pretty=" git-blame-log-oneline-format)
                   hash)
-    (buffer-substring (point-min) (1- (point-max)))))
+    (buffer-substring (point-min) (point-max))))
 
Quoted 7 lines

contrib/emacs/git-blame.el See also function `git-blame-mode'." · line 387

Quoted 2 lines
contrib/emacs/git-blame.el +0 -0
 (defvar git-blame-last-identification nil)
 (make-variable-buffer-local 'git-blame-last-identification)

Yes, this should have been part of 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when, who and what in the minibuffer. that changed from using --pretty=oneline to --pretty=format:... without terminating newline.

Sorry, I realize I haven't applied the patch from Nikolaj. Should I take this as an Ack?